mirror of
https://github.com/infiniflow/ragflow.git
synced 2026-07-29 12:09:31 +08:00
feat(agent): ship the Go agent canvas port — eino interrupt/resume + Redis check-pointing (#16035)
Replaces the Python agent canvas runtime with a Go implementation that runs inside `cmd/server_main`. The canvas compiles into an eino Workflow that pauses on wait-for-user via native Interrupt/Resume (no sentinel flag) and resumes from a Redis-backed CheckPointStore. All 21 Python agent components and ~35 tools are ported with functional parity. Sandbox providers now read their JSON config from the admin-panel system_settings table with env fallback. 234 files / +35,413 / -6,111. All Go files are gofmt-clean (CI gate added); drops the v2 DSL E2E step and the gap-analysis plan (both redundant after the port ships). ## Type of change - [x] Refactoring - [x] New feature - [x] Bug fix 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
@@ -92,3 +92,181 @@ func TestCodeExec_Info(t *testing.T) {
|
||||
t.Errorf("Desc = %q, want to mention Python", info.Desc)
|
||||
}
|
||||
}
|
||||
|
||||
// TestCodeExec_ResultExtractsArtifacts pins the artifact
|
||||
// collection: SandboxResponse.Metadata["artifacts"] must be
|
||||
// surfaced as `_ARTIFACTS` in the tool's JSON envelope so the
|
||||
// Message
|
||||
// component's artifact markdown formatter can render them.
|
||||
func TestCodeExec_ResultExtractsArtifacts(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
resp := &SandboxResponse{
|
||||
Returned: "ok",
|
||||
ExitCode: 0,
|
||||
Metadata: map[string]any{
|
||||
"artifacts": []any{
|
||||
map[string]any{"name": "chart.png", "url": "minio://b/chart.png"},
|
||||
map[string]any{"name": "data.csv", "url": "minio://b/data.csv"},
|
||||
},
|
||||
},
|
||||
}
|
||||
out, err := codeExecResultJSON(resp)
|
||||
if err != nil {
|
||||
t.Fatalf("codeExecResultJSON: %v", err)
|
||||
}
|
||||
var got codeExecResult
|
||||
if jerr := json.Unmarshal([]byte(out), &got); jerr != nil {
|
||||
t.Fatalf("output not valid JSON: %v (raw=%s)", jerr, out)
|
||||
}
|
||||
if len(got.Artifacts) != 2 {
|
||||
t.Fatalf("Artifacts len = %d, want 2", len(got.Artifacts))
|
||||
}
|
||||
if got.Artifacts[0]["name"] != "chart.png" {
|
||||
t.Errorf("Artifacts[0][name] = %v, want chart.png", got.Artifacts[0]["name"])
|
||||
}
|
||||
}
|
||||
|
||||
// TestCodeExec_ResultDropsBadArtifactShape ensures the extractor
|
||||
// silently drops entries that aren't map[string]any rather than
|
||||
// aborting the run.
|
||||
func TestCodeExec_ResultDropsBadArtifactShape(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
resp := &SandboxResponse{
|
||||
Returned: "ok",
|
||||
Metadata: map[string]any{
|
||||
"artifacts": []any{
|
||||
"just a string", // bad shape
|
||||
map[string]any{"name": "ok.png"}, // good
|
||||
42, // bad shape
|
||||
},
|
||||
},
|
||||
}
|
||||
out, err := codeExecResultJSON(resp)
|
||||
if err != nil {
|
||||
t.Fatalf("codeExecResultJSON: %v", err)
|
||||
}
|
||||
var got codeExecResult
|
||||
if jerr := json.Unmarshal([]byte(out), &got); jerr != nil {
|
||||
t.Fatalf("output not valid JSON: %v", jerr)
|
||||
}
|
||||
if len(got.Artifacts) != 1 {
|
||||
t.Errorf("Artifacts len = %d, want 1 (bad shapes dropped)", len(got.Artifacts))
|
||||
}
|
||||
if got.Artifacts[0]["name"] != "ok.png" {
|
||||
t.Errorf("Artifacts[0][name] = %v, want ok.png", got.Artifacts[0]["name"])
|
||||
}
|
||||
}
|
||||
|
||||
// TestCodeExec_ResultExtractsAttachments pins the attachments
|
||||
// (rendered to downstream Message markdown) path. Distinct from
|
||||
// artifacts so renderers can route them differently.
|
||||
func TestCodeExec_ResultExtractsAttachments(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
resp := &SandboxResponse{
|
||||
Returned: "ok",
|
||||
Metadata: map[string]any{
|
||||
"attachments": []any{
|
||||
map[string]any{"name": "report.pdf", "url": "minio://b/report.pdf"},
|
||||
},
|
||||
},
|
||||
}
|
||||
out, err := codeExecResultJSON(resp)
|
||||
if err != nil {
|
||||
t.Fatalf("codeExecResultJSON: %v", err)
|
||||
}
|
||||
var got codeExecResult
|
||||
if jerr := json.Unmarshal([]byte(out), &got); jerr != nil {
|
||||
t.Fatalf("output not valid JSON: %v", jerr)
|
||||
}
|
||||
if len(got.Attachments) != 1 {
|
||||
t.Fatalf("Attachments len = %d, want 1", len(got.Attachments))
|
||||
}
|
||||
}
|
||||
|
||||
// TestCodeExec_ResultSurfacesActualType pins the actual_type
|
||||
// surface used by Message component to render the right Markdown
|
||||
// formatting (Number → <code>, Object → JSON dump, etc.).
|
||||
func TestCodeExec_ResultSurfacesActualType(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
resp := &SandboxResponse{
|
||||
Returned: `{"x": 1}`,
|
||||
StructuredResult: map[string]any{"actual_type": "Object"},
|
||||
}
|
||||
out, err := codeExecResultJSON(resp)
|
||||
if err != nil {
|
||||
t.Fatalf("codeExecResultJSON: %v", err)
|
||||
}
|
||||
var got codeExecResult
|
||||
if jerr := json.Unmarshal([]byte(out), &got); jerr != nil {
|
||||
t.Fatalf("output not valid JSON: %v", jerr)
|
||||
}
|
||||
if got.ActualType != "Object" {
|
||||
t.Errorf("ActualType = %q, want Object", got.ActualType)
|
||||
}
|
||||
if got.Content != `{"x": 1}` {
|
||||
t.Errorf("Content = %q, want %q", got.Content, `{"x": 1}`)
|
||||
}
|
||||
}
|
||||
|
||||
// TestCodeExec_PassesTimeoutToSandbox verifies the new
|
||||
// `timeout` arg flows into the SandboxRequest.Timeout field so
|
||||
// the model can dial per-script budgets. Note: this test
|
||||
// mutates the global sandbox client; it must NOT run in
|
||||
// parallel with the other CodeExec tests that depend on the
|
||||
// default (loud-fail) stub.
|
||||
func TestCodeExec_PassesTimeoutToSandbox(t *testing.T) {
|
||||
var captured SandboxRequest
|
||||
prev := GetSandboxClient()
|
||||
SetSandboxClient(stubSandbox(func(_ context.Context, req SandboxRequest) (*SandboxResponse, error) {
|
||||
captured = req
|
||||
return &SandboxResponse{Returned: "ok", ExitCode: 0}, nil
|
||||
}))
|
||||
t.Cleanup(func() { SetSandboxClient(prev) })
|
||||
|
||||
c := NewCodeExecTool()
|
||||
_, err := c.InvokableRun(context.Background(),
|
||||
`{"language":"python","code":"def main(): return {}","timeout":42}`)
|
||||
if err != nil {
|
||||
t.Fatalf("InvokableRun: %v", err)
|
||||
}
|
||||
if captured.Timeout != 42 {
|
||||
t.Errorf("SandboxRequest.Timeout = %d, want 42", captured.Timeout)
|
||||
}
|
||||
}
|
||||
|
||||
// TestCodeExec_PassesArgumentsToSandbox verifies the `arguments`
|
||||
// arg (Python `**kwargs` to main()) is propagated. Like the
|
||||
// timeout test, this mutates the global sandbox client and must
|
||||
// not run in parallel with sibling CodeExec tests.
|
||||
func TestCodeExec_PassesArgumentsToSandbox(t *testing.T) {
|
||||
var captured SandboxRequest
|
||||
prev := GetSandboxClient()
|
||||
SetSandboxClient(stubSandbox(func(_ context.Context, req SandboxRequest) (*SandboxResponse, error) {
|
||||
captured = req
|
||||
return &SandboxResponse{Returned: "ok", ExitCode: 0}, nil
|
||||
}))
|
||||
t.Cleanup(func() { SetSandboxClient(prev) })
|
||||
|
||||
c := NewCodeExecTool()
|
||||
_, err := c.InvokableRun(context.Background(),
|
||||
`{"language":"python","code":"def main(**kw): return kw","arguments":{"x":1,"y":"z"}}`)
|
||||
if err != nil {
|
||||
t.Fatalf("InvokableRun: %v", err)
|
||||
}
|
||||
if captured.Arguments["x"].(float64) != 1 || captured.Arguments["y"].(string) != "z" {
|
||||
t.Errorf("Arguments = %v, want {x:1, y:z}", captured.Arguments)
|
||||
}
|
||||
}
|
||||
|
||||
// stubSandbox adapts a function literal to the SandboxClient
|
||||
// interface so the timeout / arguments tests can capture the
|
||||
// request without depending on the default stub.
|
||||
type stubSandbox func(ctx context.Context, req SandboxRequest) (*SandboxResponse, error)
|
||||
|
||||
func (s stubSandbox) ExecuteCode(ctx context.Context, req SandboxRequest) (*SandboxResponse, error) {
|
||||
return s(ctx, req)
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user