From e2e70cea9204705bf58e3cb80e9460e086151680 Mon Sep 17 00:00:00 2001
From: balibabu <cike8899@users.noreply.github.com>
Date: Fri, 7 Aug 2026 14:55:18 +0800
Subject: [PATCH] Fix: Clicking the confirm button on the WikiCommitModal does
 not validate the form. (#17981)

---
 .../pages/dataset/compilation/hooks/use-commit-artifact.ts  | 6 +-----
 .../dataset/compilation/hooks/use-wiki-detail-content.ts    | 4 ++--
 web/src/pages/dataset/compilation/wiki-detail-content.tsx   | 4 ++--
 3 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/web/src/pages/dataset/compilation/hooks/use-commit-artifact.ts b/web/src/pages/dataset/compilation/hooks/use-commit-artifact.ts
index 4a72559120..4fc719a36b 100644
--- a/web/src/pages/dataset/compilation/hooks/use-commit-artifact.ts
+++ b/web/src/pages/dataset/compilation/hooks/use-commit-artifact.ts
@@ -44,10 +44,6 @@ export function useCommitArtifact({
     setIsOpen(true);
   }, [form]);
 
-  const close = useCallback(() => {
-    setIsOpen(false);
-  }, []);
-
   const handleConfirm = useCallback(
     async (values: CommitFormValues) => {
       if (!pageType || !slug) return;
@@ -72,7 +68,7 @@ export function useCommitArtifact({
   return {
     isOpen,
     open,
-    close,
+    setIsOpen,
     form,
     handleConfirm,
     isUpdating,
diff --git a/web/src/pages/dataset/compilation/hooks/use-wiki-detail-content.ts b/web/src/pages/dataset/compilation/hooks/use-wiki-detail-content.ts
index ce9368840c..154e2940a0 100644
--- a/web/src/pages/dataset/compilation/hooks/use-wiki-detail-content.ts
+++ b/web/src/pages/dataset/compilation/hooks/use-wiki-detail-content.ts
@@ -160,7 +160,7 @@ export function useWikiDetailContent({
     }
   }, [handleMarkAsSaved, isVersionView, onSelectVersion]);
 
-  const { isOpen, open, close, form, handleConfirm, isUpdating } =
+  const { isOpen, open, setIsOpen, form, handleConfirm, isUpdating } =
     useCommitArtifact({
       editedContent,
       pageType: currentEntry?.pageType ?? selectedArtifact?.page_type ?? '',
@@ -207,7 +207,7 @@ export function useWikiDetailContent({
     referenceDocuments,
     isOpen,
     open,
-    close,
+    setIsOpen,
     form,
     handleConfirm,
     isUpdating,
diff --git a/web/src/pages/dataset/compilation/wiki-detail-content.tsx b/web/src/pages/dataset/compilation/wiki-detail-content.tsx
index a0b35d55d5..00e12f760f 100644
--- a/web/src/pages/dataset/compilation/wiki-detail-content.tsx
+++ b/web/src/pages/dataset/compilation/wiki-detail-content.tsx
@@ -38,7 +38,7 @@ export function WikiDetailContent({
     isDirty,
     isOpen,
     open,
-    close,
+    setIsOpen,
     form,
     handleConfirm,
     isUpdating,
@@ -95,7 +95,7 @@ export function WikiDetailContent({
 
           <WikiCommitModal
             open={isOpen}
-            onOpenChange={close}
+            onOpenChange={setIsOpen}
             form={form}
             onConfirm={handleConfirm}
             loading={isUpdating}