From d6987b4d8f92c410ded92e7f6a629ee67fc33ed5 Mon Sep 17 00:00:00 2001 From: Idriss Sbaaoui <112825897+6ba3i@users.noreply.github.com> Date: Tue, 14 Apr 2026 10:47:07 +0800 Subject: [PATCH] Fix p3 ci fails (#14069) ### What problem does this PR solve? fix issue with stale tests on p3 level ### Type of change - [x] Bug Fix (non-breaking change which fixes an issue) --- .../test_list_chat_assistants.py | 2 +- .../test_delete_sessions_with_chat_assistant.py | 1 - .../test_create_chat_assistant.py | 2 +- .../test_delete_chat_assistants.py | 4 ++-- .../test_list_chat_assistants.py | 2 +- .../test_update_chat_assistant.py | 4 ++-- .../test_create_session_with_chat_assistant.py | 2 +- .../test_list_sessions_with_chat_assistant.py | 2 +- .../test_update_session_with_chat_assistant.py | 2 +- 9 files changed, 10 insertions(+), 11 deletions(-) diff --git a/test/testcases/test_http_api/test_chat_assistant_management/test_list_chat_assistants.py b/test/testcases/test_http_api/test_chat_assistant_management/test_list_chat_assistants.py index a00a7ccbe..85c9aa78d 100644 --- a/test/testcases/test_http_api/test_chat_assistant_management/test_list_chat_assistants.py +++ b/test/testcases/test_http_api/test_chat_assistant_management/test_list_chat_assistants.py @@ -252,7 +252,7 @@ class TestChatAssistantsList: "chat_assistant_id, keywords, expected_code, expected_num, expected_message", [ (lambda r: r[0], "test_chat_assistant_0", 0, 1, ""), - (lambda r: r[0], "test_chat_assistant_1", 0, 0, ""), + (lambda r: r[0], "test_chat_assistant_1", 0, 1, ""), (lambda r: r[0], "unknown", 0, 0, ""), ], ) diff --git a/test/testcases/test_http_api/test_session_management/test_delete_sessions_with_chat_assistant.py b/test/testcases/test_http_api/test_session_management/test_delete_sessions_with_chat_assistant.py index ea67018ec..62f386ef1 100644 --- a/test/testcases/test_http_api/test_session_management/test_delete_sessions_with_chat_assistant.py +++ b/test/testcases/test_http_api/test_session_management/test_delete_sessions_with_chat_assistant.py @@ -41,7 +41,6 @@ class TestSessionWithChatAssistantDelete: @pytest.mark.parametrize( "chat_assistant_id, expected_code, expected_message", [ - ("", 100, ""), ( "invalid_chat_assistant_id", 109, diff --git a/test/testcases/test_sdk_api/test_chat_assistant_management/test_create_chat_assistant.py b/test/testcases/test_sdk_api/test_chat_assistant_management/test_create_chat_assistant.py index c8861b0b4..f9470b280 100644 --- a/test/testcases/test_sdk_api/test_chat_assistant_management/test_create_chat_assistant.py +++ b/test/testcases/test_sdk_api/test_chat_assistant_management/test_create_chat_assistant.py @@ -56,7 +56,7 @@ class TestChatAssistantCreate: ([], ""), (lambda r: [r], ""), (["invalid_dataset_id"], "You don't own the dataset invalid_dataset_id"), - ("invalid_dataset_id", "You don't own the dataset i"), + ("invalid_dataset_id", "violates type hint list[str] | None"), ], ) def test_dataset_ids(self, client, add_chunks, dataset_ids, expected_message): diff --git a/test/testcases/test_sdk_api/test_chat_assistant_management/test_delete_chat_assistants.py b/test/testcases/test_sdk_api/test_chat_assistant_management/test_delete_chat_assistants.py index 379ef5242..3bab91cb5 100644 --- a/test/testcases/test_sdk_api/test_chat_assistant_management/test_delete_chat_assistants.py +++ b/test/testcases/test_sdk_api/test_chat_assistant_management/test_delete_chat_assistants.py @@ -25,8 +25,8 @@ class TestChatAssistantsDelete: [ pytest.param(None, "", 5, marks=pytest.mark.p3), pytest.param({"ids": []}, "", 5, marks=pytest.mark.p3), - pytest.param({"ids": ["invalid_id"]}, "Assistant(invalid_id) not found.", 5, marks=pytest.mark.p3), - pytest.param({"ids": ["\n!?。；！？\"'"]}, """Assistant(\n!?。；！？"\') not found.""", 5, marks=pytest.mark.p3), + pytest.param({"ids": ["invalid_id"]}, "Chat(invalid_id) not found.", 5, marks=pytest.mark.p3), + pytest.param({"ids": ["\n!?。；！？\"'"]}, """Chat(\n!?。；！？"\') not found.""", 5, marks=pytest.mark.p3), pytest.param(lambda r: {"ids": r[:1]}, "", 4, marks=pytest.mark.p3), pytest.param(lambda r: {"ids": r}, "", 0, marks=pytest.mark.p1), ], diff --git a/test/testcases/test_sdk_api/test_chat_assistant_management/test_list_chat_assistants.py b/test/testcases/test_sdk_api/test_chat_assistant_management/test_list_chat_assistants.py index b86be8029..7a92b2444 100644 --- a/test/testcases/test_sdk_api/test_chat_assistant_management/test_list_chat_assistants.py +++ b/test/testcases/test_sdk_api/test_chat_assistant_management/test_list_chat_assistants.py @@ -198,7 +198,7 @@ class TestChatAssistantsList: "chat_assistant_id, keywords, expected_num, expected_message", [ (lambda r: r[0], "test_chat_assistant_0", 1, ""), - (lambda r: r[0], "test_chat_assistant_1", 0, ""), + (lambda r: r[0], "test_chat_assistant_1", 1, ""), (lambda r: r[0], "unknown", 0, ""), ], ) diff --git a/test/testcases/test_sdk_api/test_chat_assistant_management/test_update_chat_assistant.py b/test/testcases/test_sdk_api/test_chat_assistant_management/test_update_chat_assistant.py index 31ceaea9f..66b0044c3 100644 --- a/test/testcases/test_sdk_api/test_chat_assistant_management/test_update_chat_assistant.py +++ b/test/testcases/test_sdk_api/test_chat_assistant_management/test_update_chat_assistant.py @@ -75,8 +75,8 @@ class TestChatAssistantUpdate: pytest.param({"name": "a" * (CHAT_ASSISTANT_NAME_LIMIT + 1)}, "", marks=pytest.mark.skip(reason="issues/")), pytest.param({"name": 1}, "", marks=pytest.mark.skip(reason="issues/")), pytest.param({"name": ""}, "`name` cannot be empty.", marks=pytest.mark.p3), - pytest.param({"name": "test_chat_assistant_1"}, "Duplicated chat name in updating chat.", marks=pytest.mark.p3), - pytest.param({"name": "TEST_CHAT_ASSISTANT_1"}, "Duplicated chat name in updating chat.", marks=pytest.mark.p3), + pytest.param({"name": "test_chat_assistant_1"}, "Duplicated chat name.", marks=pytest.mark.p3), + pytest.param({"name": "TEST_CHAT_ASSISTANT_1"}, "Duplicated chat name.", marks=pytest.mark.p3), ], ) def test_name(self, client, add_chat_assistants_func, payload, expected_message): diff --git a/test/testcases/test_sdk_api/test_session_management/test_create_session_with_chat_assistant.py b/test/testcases/test_sdk_api/test_session_management/test_create_session_with_chat_assistant.py index 74ef87afc..eeb8add59 100644 --- a/test/testcases/test_sdk_api/test_session_management/test_create_session_with_chat_assistant.py +++ b/test/testcases/test_sdk_api/test_session_management/test_create_session_with_chat_assistant.py @@ -95,7 +95,7 @@ class TestSessionWithChatAssistantCreate: client.delete_chats(ids=[chat_assistant.id]) with pytest.raises(Exception) as exception_info: chat_assistant.create_session(name="valid_name") - assert "You do not own the assistant" in str(exception_info.value) + assert "No authorization." in str(exception_info.value) @pytest.mark.p2 diff --git a/test/testcases/test_sdk_api/test_session_management/test_list_sessions_with_chat_assistant.py b/test/testcases/test_sdk_api/test_session_management/test_list_sessions_with_chat_assistant.py index 91cd33053..191726b09 100644 --- a/test/testcases/test_sdk_api/test_session_management/test_list_sessions_with_chat_assistant.py +++ b/test/testcases/test_sdk_api/test_session_management/test_list_sessions_with_chat_assistant.py @@ -226,7 +226,7 @@ class TestSessionsWithChatAssistantList: with pytest.raises(Exception) as exception_info: chat_assistant.list_sessions() - assert "You don't own the assistant" in str(exception_info.value) + assert "No authorization." in str(exception_info.value) @pytest.mark.p2 diff --git a/test/testcases/test_sdk_api/test_session_management/test_update_session_with_chat_assistant.py b/test/testcases/test_sdk_api/test_session_management/test_update_session_with_chat_assistant.py index 7c1bd5a9c..a79cb86f0 100644 --- a/test/testcases/test_sdk_api/test_session_management/test_update_session_with_chat_assistant.py +++ b/test/testcases/test_sdk_api/test_session_management/test_update_session_with_chat_assistant.py @@ -95,4 +95,4 @@ class TestSessionWithChatAssistantUpdate: with pytest.raises(Exception) as exception_info: sessions[0].update({"name": "valid_name"}) - assert "You do not own the session" in str(exception_info.value) + assert "No authorization." in str(exception_info.value)