feat: add Go MCP server update API (#15261)

## What

#15240
implementation for PUT /api/v1/mcp/servers/:mcp_id

## Changes

- Adds the Go implementation for `PUT /api/v1/mcp/servers/:mcp_id`.
- Wires MCP service and handler into the Go server/router for the update
route.
- Preserves Python-style behavior for ownership checks, partial update
fields, MCP type/name/URL validation, `headers`/`variables`
normalization, and tool metadata scrubbing.
This commit is contained in:
Alexander Laurent
2026-06-01 21:58:44 -10:00
committed by GitHub
parent 2819d0ea24
commit a98889cd76
8 changed files with 313 additions and 3 deletions

View File

@@ -21,10 +21,12 @@ import (
"net/http"
"strconv"
"strings"
"time"
"github.com/gin-gonic/gin"
"ragflow/internal/common"
"ragflow/internal/entity"
"ragflow/internal/service"
)
@@ -32,6 +34,7 @@ const (
defaultMCPServerPage = 0
defaultMCPServerPageSize = 0
maxMCPServerPageSize = 100
mcpServerDateFormat = "2006-01-02T15:04:05"
)
// MCPHandler handles MCP server requests.
@@ -39,6 +42,21 @@ type MCPHandler struct {
mcpService *service.MCPService
}
type mcpServerResponse struct {
ID string `json:"id"`
Name string `json:"name"`
TenantID string `json:"tenant_id"`
URL string `json:"url"`
ServerType string `json:"server_type"`
Description *string `json:"description"`
Variables map[string]interface{} `json:"variables"`
Headers map[string]interface{} `json:"headers"`
CreateTime *int64 `json:"create_time"`
CreateDate string `json:"create_date"`
UpdateTime *int64 `json:"update_time"`
UpdateDate string `json:"update_date"`
}
// NewMCPHandler creates an MCP handler.
func NewMCPHandler(mcpService *service.MCPService) *MCPHandler {
return &MCPHandler{
@@ -118,6 +136,34 @@ func (h *MCPHandler) ListMCPServers(c *gin.Context) {
})
}
// UpdateMCPServer updates an MCP server for the current user.
func (h *MCPHandler) UpdateMCPServer(c *gin.Context) {
user, errorCode, errorMessage := GetUser(c)
if errorCode != common.CodeSuccess {
jsonError(c, errorCode, errorMessage)
return
}
mcpID := c.Param("mcp_id")
var req service.UpdateMCPServerRequest
if err := c.ShouldBindJSON(&req); err != nil {
jsonError(c, common.CodeDataError, err.Error())
return
}
result, code, err := h.mcpService.UpdateMCPServer(user.ID, mcpID, req)
if err != nil {
jsonError(c, code, err.Error())
return
}
c.JSON(http.StatusOK, gin.H{
"code": common.CodeSuccess,
"message": "success",
"data": newMCPServerResponse(result),
})
}
// DeleteMCPServer deletes an MCP server for the current user.
func (h *MCPHandler) DeleteMCPServer(c *gin.Context) {
user, errorCode, errorMessage := GetUser(c)
@@ -139,6 +185,34 @@ func (h *MCPHandler) DeleteMCPServer(c *gin.Context) {
})
}
func newMCPServerResponse(server *entity.MCPServer) *mcpServerResponse {
if server == nil {
return nil
}
return &mcpServerResponse{
ID: server.ID,
Name: server.Name,
TenantID: server.TenantID,
URL: server.URL,
ServerType: server.ServerType,
Description: server.Description,
Variables: map[string]interface{}(server.Variables),
Headers: map[string]interface{}(server.Headers),
CreateTime: server.CreateTime,
CreateDate: formatMCPServerDate(server.CreateDate),
UpdateTime: server.UpdateTime,
UpdateDate: formatMCPServerDate(server.UpdateDate),
}
}
func formatMCPServerDate(date *time.Time) string {
if date == nil {
return ""
}
return date.Format(mcpServerDateFormat)
}
func parseMCPServerPage(value string) (int, error) {
if value == "" {
return defaultMCPServerPage, nil

View File

@@ -0,0 +1,71 @@
//
// Copyright 2026 The InfiniFlow Authors. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//
package handler
import (
"bytes"
"encoding/json"
"testing"
"time"
"ragflow/internal/entity"
)
func TestNewMCPServerResponsePreservesNullDescriptionAndFormatsDates(t *testing.T) {
createTime := int64(1779949820000)
updateTime := int64(1779953420000)
location := time.FixedZone("UTC+8", 8*60*60)
createDate := time.Date(2026, 5, 28, 10, 30, 20, 0, location)
updateDate := time.Date(2026, 5, 28, 11, 30, 20, 0, location)
response := newMCPServerResponse(&entity.MCPServer{
ID: "mcp-id",
Name: "server",
TenantID: "tenant-id",
URL: "https://example.com/mcp",
ServerType: "sse",
Variables: entity.JSONMap{"tools": map[string]interface{}{}},
Headers: entity.JSONMap{"Authorization": "Bearer token"},
BaseModel: entity.BaseModel{
CreateTime: &createTime,
CreateDate: &createDate,
UpdateTime: &updateTime,
UpdateDate: &updateDate,
},
})
if response.Description != nil {
t.Fatalf("description = %q, want nil", *response.Description)
}
if response.CreateDate != "2026-05-28T10:30:20" {
t.Fatalf("create_date = %q, want date without timezone", response.CreateDate)
}
if response.UpdateDate != "2026-05-28T11:30:20" {
t.Fatalf("update_date = %q, want date without timezone", response.UpdateDate)
}
payload, err := json.Marshal(response)
if err != nil {
t.Fatalf("marshal response: %v", err)
}
if !bytes.Contains(payload, []byte(`"description":null`)) {
t.Fatalf("payload %s does not preserve description:null", payload)
}
if bytes.Contains(payload, []byte(`+08:00`)) {
t.Fatalf("payload %s includes timezone in date fields", payload)
}
}