zlei6/ragflow
1
0
Fork 0
mirror of https://github.com/infiniflow/ragflow.git synced 2026-08-12 11:43:39 +08:00
Code Issues Packages Projects Releases Wiki Activity

Test: release Go-proxy RESTful contract tests verified passing in Go mode (#17468)

Browse Source 
### Summary

Aligns Go and Python error codes/messages so both backends honor the
same RESTful API contract, removing implementation-specific error leaks
(MySQL errors, `ValueError`, `AttributeError`, Gin validator format) in
favor of clean business error codes.

**Chat list** — invalid `orderby` now returns code 101 (was: raw Python
`AttributeError` code 100); invalid `page`/`page_size` values fall back
to defaults (was: raw `ValueError`/`ProgrammingError` code 100).

**Dataset create/update/delete** — adds UUID validation (101),
extra-field rejection (101), duplicate-id detection (101), content-type
/ JSON-syntax / object-shape checks (101), and "lacks permission" for
nonexistent datasets (IDOR). Create auto-deduplicates dataset names.
Pagerank updates tolerate a missing ES index. List response includes
`parser_config` and `pagerank`.

**Session list/update** — adds filtering, sorting, and pagination
support. Empty payloads are valid no-ops. Authorization errors map to
code 109.

**Chunk list** — doc object uses Python key names (`chunk_count`,
`dataset_id`, `chunk_method`, run text status). Add validates list
element types.

**Document update** — adds `chunk_method` alias, pydantic-style Field
error messages, metadata index auto-create with refresh, and "These
documents do not belong to dataset" messages. List validates
`metadata_condition` and reports ownership errors for unmatched name/id
filters.

**Search completion** — `kb_ids` ownership failure returns code 102
instead of 109.

Released 31 contract tests from `GO_ONLY_SKIPS` (all verified passing on
both Go and Python backends with real LLM keys).
This commit is contained in:
euvre
2026-07-30 19:58:49 +08:00
committed by GitHub
parent 75ac8cec2e
commit 8fc20dd9ca
53 changed files with 1138 additions and 426 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
test/testcases/restful_api/test_chats.py
View File

@@ -365,15 +365,15 @@ def test_chat_list_page_and_page_size_contract(rest_client, clear_chats):
("page two", {"page": 2, "page_size": 2}, 0, lambda total: min(max(total - 2, 0), 2), ""),
("page three", {"page": 3, "page_size": 2}, 0, lambda total: min(max(total - 4, 0), 2), ""),
("page string", {"page": "3", "page_size": 2}, 0, lambda total: min(max(total - 4, 0), 2), ""),
("page negative", {"page": -1, "page_size": 2}, 100, None, "ProgrammingError(1064"),
("page alpha", {"page": "a", "page_size": 2}, 100, None, "ValueError(\"invalid literal for int() with base 10: 'a'\")"),
("page negative", {"page": -1, "page_size": 2}, 0, lambda total: total, ""),
("page alpha", {"page": "a", "page_size": 2}, 0, lambda total: total, ""),
("page_size none", {"page_size": None}, 0, lambda total: total, ""),
("page_size zero", {"page_size": 0}, 0, lambda total: total, ""),
("page_size one", {"page_size": 1}, 0, lambda total: total, ""),
("page_size six", {"page_size": 6}, 0, lambda total: total, ""),
("page_size string", {"page_size": "1"}, 0, lambda total: total, ""),
("page_size negative", {"page_size": -1}, 0, lambda total: total, ""),
("page_size alpha", {"page_size": "a"}, 100, None, "ValueError(\"invalid literal for int() with base 10: 'a'\")"),
("page_size alpha", {"page_size": "a"}, 0, lambda total: total, ""),
]
for scenario_name, params, expected_code, expected_count_fn, expected_message in cases:
@@ -403,7 +403,7 @@ def test_chat_list_sorting_contract(rest_client, clear_chats):
("orderby create", {"orderby": "create_time"}, 0, descending_names, ""),
("orderby update", {"orderby": "update_time"}, 0, descending_names, ""),
("orderby name ascending", {"orderby": "name", "desc": "False"}, 0, ascending_names, ""),
("orderby unknown", {"orderby": "unknown"}, 100, None, "AttributeError(\"type object 'Dialog' has no attribute 'unknown'\")"),
("orderby unknown", {"orderby": "unknown"}, 101, None, "invalid orderby field"),
("desc none", {"desc": None}, 0, descending_names, ""),
("desc true", {"desc": "true"}, 0, descending_names, ""),
("desc True", {"desc": "True"}, 0, descending_names, ""),