mirror of
https://github.com/infiniflow/ragflow.git
synced 2026-08-02 05:47:31 +08:00
Test: release Go-proxy RESTful contract tests verified passing in Go mode (#17468)
### Summary Aligns Go and Python error codes/messages so both backends honor the same RESTful API contract, removing implementation-specific error leaks (MySQL errors, `ValueError`, `AttributeError`, Gin validator format) in favor of clean business error codes. **Chat list** — invalid `orderby` now returns code 101 (was: raw Python `AttributeError` code 100); invalid `page`/`page_size` values fall back to defaults (was: raw `ValueError`/`ProgrammingError` code 100). **Dataset create/update/delete** — adds UUID validation (101), extra-field rejection (101), duplicate-id detection (101), content-type / JSON-syntax / object-shape checks (101), and "lacks permission" for nonexistent datasets (IDOR). Create auto-deduplicates dataset names. Pagerank updates tolerate a missing ES index. List response includes `parser_config` and `pagerank`. **Session list/update** — adds filtering, sorting, and pagination support. Empty payloads are valid no-ops. Authorization errors map to code 109. **Chunk list** — doc object uses Python key names (`chunk_count`, `dataset_id`, `chunk_method`, run text status). Add validates list element types. **Document update** — adds `chunk_method` alias, pydantic-style Field error messages, metadata index auto-create with refresh, and "These documents do not belong to dataset" messages. List validates `metadata_condition` and reports ownership errors for unmatched name/id filters. **Search completion** — `kb_ids` ownership failure returns code 102 instead of 109. Released 31 contract tests from `GO_ONLY_SKIPS` (all verified passing on both Go and Python backends with real LLM keys).
This commit is contained in:
@@ -49,18 +49,20 @@ func TestBetaAuthMiddleware_MissingHeader(t *testing.T) {
|
||||
if rec.Code != http.StatusOK {
|
||||
t.Errorf("status = %d, want %d", rec.Code, http.StatusOK)
|
||||
}
|
||||
// jsonError writes 200 with a CodeUnauthorized body. Confirm the
|
||||
// body shape matches the wire contract used by the rest of the
|
||||
// bot handlers by decoding the JSON envelope and asserting the
|
||||
// code field rather than just checking for a non-empty body.
|
||||
// Beta endpoints follow Python's login_required(auth_types=AUTH_BETA):
|
||||
// auth failures are business errors (code 102), not HTTP 401.
|
||||
var resp struct {
|
||||
Code common.ErrorCode `json:"code"`
|
||||
Code common.ErrorCode `json:"code"`
|
||||
Message string `json:"message"`
|
||||
}
|
||||
if err := json.Unmarshal(rec.Body.Bytes(), &resp); err != nil {
|
||||
t.Fatalf("unmarshal response: %v; body = %s", err, rec.Body.String())
|
||||
}
|
||||
if resp.Code != common.CodeUnauthorized {
|
||||
if resp.Code != common.CodeDataError {
|
||||
t.Errorf("code = %d, want %d; body = %s",
|
||||
resp.Code, common.CodeUnauthorized, rec.Body.String())
|
||||
resp.Code, common.CodeDataError, rec.Body.String())
|
||||
}
|
||||
if resp.Message != "Authorization is not valid!" {
|
||||
t.Errorf("message = %q; body = %s", resp.Message, rec.Body.String())
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user