mirror of
https://github.com/infiniflow/ragflow.git
synced 2026-08-08 08:28:02 +08:00
Fix: add document delete permission check (#14472)
### What problem does this PR solve? add document delete permission check ### Type of change - [x] Bug Fix (non-breaking change which fixes an issue)
This commit is contained in:
@@ -132,7 +132,7 @@ class TestDocumentsDeletion:
|
||||
|
||||
res = delete_documents(HttpApiAuth, dataset_id, {"ids": document_ids})
|
||||
assert res["code"] == 102
|
||||
assert "Document not found" in res["message"]
|
||||
assert "or Document not found" in res["message"]
|
||||
|
||||
@pytest.mark.p2
|
||||
def test_duplicate_deletion(self, HttpApiAuth, add_documents_func):
|
||||
@@ -145,6 +145,24 @@ class TestDocumentsDeletion:
|
||||
assert len(res["data"]["docs"]) == 3
|
||||
assert res["data"]["total"] == 3
|
||||
|
||||
@pytest.mark.p2
|
||||
def test_cross_dataset_deletion_is_blocked(self, HttpApiAuth, add_dataset, add_documents_func, tmp_path):
|
||||
dataset_id, _document_ids = add_documents_func
|
||||
other_dataset_id = add_dataset
|
||||
other_document_id = bulk_upload_documents(HttpApiAuth, other_dataset_id, 1, tmp_path)[0]
|
||||
|
||||
res = delete_documents(HttpApiAuth, dataset_id, {"ids": [other_document_id]})
|
||||
assert res["code"] == 102
|
||||
assert f"These documents do not belong to dataset {dataset_id}" in res["message"]
|
||||
|
||||
res = list_documents(HttpApiAuth, dataset_id)
|
||||
assert len(res["data"]["docs"]) == 3
|
||||
assert res["data"]["total"] == 3
|
||||
|
||||
res = list_documents(HttpApiAuth, other_dataset_id)
|
||||
assert len(res["data"]["docs"]) == 1
|
||||
assert res["data"]["total"] == 1
|
||||
|
||||
|
||||
@pytest.mark.p3
|
||||
def test_concurrent_deletion(HttpApiAuth, add_dataset, tmp_path):
|
||||
|
||||
@@ -78,7 +78,7 @@ class TestDocumentsDeletion:
|
||||
for doc_id in document_ids:
|
||||
res = delete_document(WebApiAuth, kb_id, {"ids": [doc_id]})
|
||||
assert res["code"] == 102, res
|
||||
assert res["message"] == "Document not found!", res
|
||||
assert "Document not found" in res["message"], res
|
||||
|
||||
@pytest.mark.p2
|
||||
def test_delete_all(self, WebApiAuth, add_documents_func):
|
||||
|
||||
Reference in New Issue
Block a user