2024-01-15 08:46:22 +08:00
|
|
|
#
|
2025-03-26 19:33:14 +08:00
|
|
|
# Copyright 2025 The InfiniFlow Authors. All Rights Reserved.
|
2024-01-15 08:46:22 +08:00
|
|
|
#
|
|
|
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
|
# you may not use this file except in compliance with the License.
|
|
|
|
|
# You may obtain a copy of the License at
|
|
|
|
|
#
|
|
|
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
|
#
|
|
|
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
|
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
|
# See the License for the specific language governing permissions and
|
|
|
|
|
# limitations under the License.
|
|
|
|
|
#
|
2025-03-26 19:33:14 +08:00
|
|
|
import asyncio
|
|
|
|
|
import json
|
|
|
|
|
import logging
|
|
|
|
|
import os
|
2025-03-22 23:07:03 +08:00
|
|
|
import random
|
2025-07-30 19:41:09 +08:00
|
|
|
import re
|
2025-03-26 19:33:14 +08:00
|
|
|
import time
|
2023-12-25 19:05:59 +08:00
|
|
|
from abc import ABC
|
2025-06-11 17:20:12 +08:00
|
|
|
from copy import deepcopy
|
2025-06-03 14:18:40 +08:00
|
|
|
from urllib.parse import urljoin
|
2025-03-26 19:33:14 +08:00
|
|
|
|
2025-06-12 12:31:10 +08:00
|
|
|
import json_repair
|
2026-06-05 09:45:44 +08:00
|
|
|
from json.decoder import JSONDecodeError
|
2025-08-12 10:59:20 +08:00
|
|
|
import litellm
|
2024-02-27 14:57:34 +08:00
|
|
|
import openai
|
2025-12-01 14:24:06 +08:00
|
|
|
from openai import AsyncOpenAI, OpenAI
|
2026-05-15 08:40:53 +02:00
|
|
|
from enum import StrEnum
|
2025-03-26 19:33:14 +08:00
|
|
|
|
feat: Add Astraflow provider support (global + China endpoints) (#14270)
## Add Astraflow Provider Support
This PR integrates [Astraflow](https://astraflow.ucloud.cn/) (by UCloud
/ 优刻得) as a new AI model provider in RAGFlow, with support for both
global and China endpoints.
### About Astraflow
Astraflow is an OpenAI-compatible AI model aggregation platform
supporting 200+ models from major providers including DeepSeek, Qwen,
GPT, Claude, Gemini, Llama, Mistral, and more.
| Variant | Factory Name | Endpoint | Env Var |
|---------|-------------|----------|---------|
| Global | `Astraflow` | `https://api-us-ca.umodelverse.ai/v1` |
`ASTRAFLOW_API_KEY` |
| China | `Astraflow-CN` | `https://api.modelverse.cn/v1` |
`ASTRAFLOW_CN_API_KEY` |
- **API key signup**: https://astraflow.ucloud.cn/
---
### Files Changed
| File | Change |
|------|--------|
| `rag/llm/__init__.py` | Register `Astraflow` and `Astraflow-CN` in
`SupportedLiteLLMProvider` enum, `FACTORY_DEFAULT_BASE_URL`, and
`LITELLM_PROVIDER_PREFIX` |
| `rag/llm/chat_model.py` | Add `AstraflowChat` and `AstraflowCNChat`
(OpenAI-compatible `Base` subclass) |
| `rag/llm/embedding_model.py` | Add `AstraflowEmbed` and
`AstraflowCNEmbed` (subclasses of `OpenAIEmbed`) |
| `rag/llm/rerank_model.py` | Add `AstraflowRerank` and
`AstraflowCNRerank` (subclasses of `OpenAI_APIRerank`) |
| `rag/llm/cv_model.py` | Add `AstraflowCV` and `AstraflowCNCV`
(subclasses of `GptV4`) |
| `rag/llm/tts_model.py` | Add `AstraflowTTS` and `AstraflowCNTTS`
(subclasses of `OpenAITTS`) |
| `rag/llm/sequence2txt_model.py` | Add `AstraflowSeq2txt` and
`AstraflowCNSeq2txt` (subclasses of `GPTSeq2txt`) |
| `conf/llm_factories.json` | Register `Astraflow` and `Astraflow-CN`
factories with a curated list of popular models |
---
### Supported Model Types
- ✅ **Chat / LLM** — DeepSeek-V3/R1, Qwen3, GPT-4o/4.1, Claude 3.5/3.7,
Gemini 2.0/2.5 Flash, Llama 3.3/4, Mistral, and 200+ more
- ✅ **Text Embedding** — text-embedding-3-small/large
- ✅ **Image / Vision (IMAGE2TEXT)** — GPT-4o, GPT-4.1, Claude, Gemini,
Llama-4, etc.
- ✅ **Text Re-Rank**
- ✅ **TTS** — tts-1
- ✅ **Speech-to-Text (SPEECH2TEXT)** — whisper-1
### Implementation Notes
- Uses the `openai/` LiteLLM prefix — consistent with other
OpenAI-compatible aggregation platforms (SILICONFLOW, DeerAPI, CometAPI,
OpenRouter, n1n, Avian, etc.)
- `Astraflow` (global, rank 250) and `Astraflow-CN` (China, rank 249)
are separate factory entries, allowing users to choose the optimal
endpoint based on their region.
- All model classes cleanly subclass existing base classes (`Base`,
`OpenAIEmbed`, `OpenAI_APIRerank`, `GptV4`, `OpenAITTS`, `GPTSeq2txt`)
with no custom logic needed — the provider is fully OpenAI-compatible.
---------
Co-authored-by: user <user@xzaaaMacBook-Air.local>
2026-04-22 15:38:34 +08:00
|
|
|
from common.misc_utils import thread_pool_exec
|
2025-12-01 12:17:43 +08:00
|
|
|
from common.token_utils import num_tokens_from_string, total_token_count_from_response
|
2025-08-12 10:59:20 +08:00
|
|
|
from rag.llm import FACTORY_DEFAULT_BASE_URL, LITELLM_PROVIDER_PREFIX, SupportedLiteLLMProvider
|
Feat: @tool decorator for chat-model tool registration (#15047)
## Summary
- Adds a lightweight `@tool` decorator and `FunctionToolSession` adapter
in `rag/llm/tool_decorator.py` that let callers register plain Python
functions as LLM tools without hand-writing OpenAI function schemas or
building an MCP-style session.
- Refactors `Base.bind_tools` and `LiteLLMBase.bind_tools` in
`rag/llm/chat_model.py` to accept either the new decorator form
`bind_tools(tools=[fn1, fn2])` or the existing `(toolcall_session,
tools_schemas)` form, so existing agent/dialog call-sites in
`agent/component/agent_with_tools.py`, `api/db/services/llm_service.py`,
and `api/db/services/dialog_service.py` are unaffected.
- Adds 8 unit tests in `test/unit_test/rag/llm/test_tool_decorator.py`
covering schema shape, required/optional inference, sync + async
dispatch, and bad-input rejection.
## Usage
```python
from rag.llm.tool_decorator import tool
@tool
def get_weather(city: str) -> str:
"""Get current weather for a city.
:param city: City name to look up.
"""
return f"{city}: 21 C, partly cloudy"
chat_mdl.bind_tools(tools=[get_weather])
ans, tk = await chat_mdl.async_chat_with_tools(system, history)
```
The decorator introspects `inspect.signature` + type hints + the
docstring (`:param name:` style) and attaches an OpenAI-format
`openai_schema` to the callable. `FunctionToolSession` duck-types the
existing `ToolCallSession` protocol, dispatching async callables
directly and sync ones through `thread_pool_exec` so the event loop is
never blocked.
## Design notes
- `tool_decorator.py` deliberately does **not** live inside
`rag/llm/__init__.py` to avoid forcing every consumer through the heavy
provider auto-discovery loop and to sidestep a circular import
(`__init__.py` imports `chat_model`, which would otherwise need symbols
from `__init__.py`).
- `FunctionToolSession` is duck-typed against
`common.mcp_tool_call_conn.ToolCallSession` rather than explicitly
inheriting from it, so importing the decorator doesn't pull the MCP
client SDK into the import graph.
- Docstring parsing is intentionally minimal (`:param name:` only) to
keep this dependency-free; Google/NumPy styles can be added later via
`docstring_parser` if needed.
## Test plan
- [x] `python -m pytest test/unit_test/rag/llm/test_tool_decorator.py
-v` — 8 passed
- [x] `python -m pytest test/unit_test/rag/llm/
--ignore=test/unit_test/rag/llm/test_perplexity_embed.py` — 11 passed
(the ignored test has a pre-existing `numpy` import that's unrelated)
- [ ] Reviewer: smoke-test the new path end-to-end with a live model via
`chat_mdl.bind_tools(tools=[my_fn])` to confirm the OpenAI-format
schemas pass through unchanged
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---------
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-21 14:07:00 +08:00
|
|
|
from rag.llm.tool_decorator import FunctionToolSession, is_tool
|
2024-12-05 13:28:42 +08:00
|
|
|
from rag.nlp import is_chinese, is_english
|
2025-03-22 23:07:03 +08:00
|
|
|
|
feat: Add Astraflow provider support (global + China endpoints) (#14270)
## Add Astraflow Provider Support
This PR integrates [Astraflow](https://astraflow.ucloud.cn/) (by UCloud
/ 优刻得) as a new AI model provider in RAGFlow, with support for both
global and China endpoints.
### About Astraflow
Astraflow is an OpenAI-compatible AI model aggregation platform
supporting 200+ models from major providers including DeepSeek, Qwen,
GPT, Claude, Gemini, Llama, Mistral, and more.
| Variant | Factory Name | Endpoint | Env Var |
|---------|-------------|----------|---------|
| Global | `Astraflow` | `https://api-us-ca.umodelverse.ai/v1` |
`ASTRAFLOW_API_KEY` |
| China | `Astraflow-CN` | `https://api.modelverse.cn/v1` |
`ASTRAFLOW_CN_API_KEY` |
- **API key signup**: https://astraflow.ucloud.cn/
---
### Files Changed
| File | Change |
|------|--------|
| `rag/llm/__init__.py` | Register `Astraflow` and `Astraflow-CN` in
`SupportedLiteLLMProvider` enum, `FACTORY_DEFAULT_BASE_URL`, and
`LITELLM_PROVIDER_PREFIX` |
| `rag/llm/chat_model.py` | Add `AstraflowChat` and `AstraflowCNChat`
(OpenAI-compatible `Base` subclass) |
| `rag/llm/embedding_model.py` | Add `AstraflowEmbed` and
`AstraflowCNEmbed` (subclasses of `OpenAIEmbed`) |
| `rag/llm/rerank_model.py` | Add `AstraflowRerank` and
`AstraflowCNRerank` (subclasses of `OpenAI_APIRerank`) |
| `rag/llm/cv_model.py` | Add `AstraflowCV` and `AstraflowCNCV`
(subclasses of `GptV4`) |
| `rag/llm/tts_model.py` | Add `AstraflowTTS` and `AstraflowCNTTS`
(subclasses of `OpenAITTS`) |
| `rag/llm/sequence2txt_model.py` | Add `AstraflowSeq2txt` and
`AstraflowCNSeq2txt` (subclasses of `GPTSeq2txt`) |
| `conf/llm_factories.json` | Register `Astraflow` and `Astraflow-CN`
factories with a curated list of popular models |
---
### Supported Model Types
- ✅ **Chat / LLM** — DeepSeek-V3/R1, Qwen3, GPT-4o/4.1, Claude 3.5/3.7,
Gemini 2.0/2.5 Flash, Llama 3.3/4, Mistral, and 200+ more
- ✅ **Text Embedding** — text-embedding-3-small/large
- ✅ **Image / Vision (IMAGE2TEXT)** — GPT-4o, GPT-4.1, Claude, Gemini,
Llama-4, etc.
- ✅ **Text Re-Rank**
- ✅ **TTS** — tts-1
- ✅ **Speech-to-Text (SPEECH2TEXT)** — whisper-1
### Implementation Notes
- Uses the `openai/` LiteLLM prefix — consistent with other
OpenAI-compatible aggregation platforms (SILICONFLOW, DeerAPI, CometAPI,
OpenRouter, n1n, Avian, etc.)
- `Astraflow` (global, rank 250) and `Astraflow-CN` (China, rank 249)
are separate factory entries, allowing users to choose the optimal
endpoint based on their region.
- All model classes cleanly subclass existing base classes (`Base`,
`OpenAIEmbed`, `OpenAI_APIRerank`, `GptV4`, `OpenAITTS`, `GPTSeq2txt`)
with no custom logic needed — the provider is fully OpenAI-compatible.
---------
Co-authored-by: user <user@xzaaaMacBook-Air.local>
2026-04-22 15:38:34 +08:00
|
|
|
|
2025-07-30 19:41:09 +08:00
|
|
|
class LLMErrorCode(StrEnum):
|
|
|
|
|
ERROR_RATE_LIMIT = "RATE_LIMIT_EXCEEDED"
|
|
|
|
|
ERROR_AUTHENTICATION = "AUTH_ERROR"
|
|
|
|
|
ERROR_INVALID_REQUEST = "INVALID_REQUEST"
|
|
|
|
|
ERROR_SERVER = "SERVER_ERROR"
|
|
|
|
|
ERROR_TIMEOUT = "TIMEOUT"
|
|
|
|
|
ERROR_CONNECTION = "CONNECTION_ERROR"
|
|
|
|
|
ERROR_MODEL = "MODEL_ERROR"
|
|
|
|
|
ERROR_MAX_ROUNDS = "ERROR_MAX_ROUNDS"
|
|
|
|
|
ERROR_CONTENT_FILTER = "CONTENT_FILTERED"
|
|
|
|
|
ERROR_QUOTA = "QUOTA_EXCEEDED"
|
|
|
|
|
ERROR_MAX_RETRIES = "MAX_RETRIES_EXCEEDED"
|
|
|
|
|
ERROR_GENERIC = "GENERIC_ERROR"
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
class ReActMode(StrEnum):
|
|
|
|
|
FUNCTION_CALL = "function_call"
|
|
|
|
|
REACT = "react"
|
2023-12-28 13:50:13 +08:00
|
|
|
|
2025-08-12 10:59:20 +08:00
|
|
|
|
2025-07-30 19:41:09 +08:00
|
|
|
ERROR_PREFIX = "**ERROR**"
|
2025-03-12 19:40:54 +08:00
|
|
|
LENGTH_NOTIFICATION_CN = "······\n由于大模型的上下文窗口大小限制,回答已经被大模型截断。"
|
2025-03-13 14:43:24 +08:00
|
|
|
LENGTH_NOTIFICATION_EN = "...\nThe answer is truncated by your chosen LLM due to its limitation on context length."
|
2024-09-27 13:17:25 +08:00
|
|
|
|
fix(llm): strip non-generation keys from gen_conf for LiteLLM providers (#15427) (#15432)
### What problem does this PR solve?
Fixes #15427.
All LiteLLM-routed chats fail with:
- Anthropic: `litellm.BadRequestError: AnthropicException -
{"type":"invalid_request_error","message":"model_type: Extra inputs are
not permitted"}`
- OpenAI: `litellm.BadRequestError: OpenAIException - Unknown parameter:
'model_type'`
This is a regression from v0.25.4.
#### Root cause
A chat assistant's `llm_setting` is forwarded to the model as
`gen_conf`. `llm_setting` can legitimately carry RAGFlow-internal
metadata such as `model_type` (the chat REST APIs in
`api/apps/restful_apis/` read it back out of `llm_setting`), so that key
ends up inside `gen_conf`.
`Base._clean_conf` (OpenAI-compatible providers) already **whitelists**
the keys it forwards, so direct-OpenAI providers were unaffected.
`LiteLLMBase._clean_conf` only dropped `max_tokens` and passed
everything else straight through to `litellm.acompletion`, which
forwarded `model_type` to the upstream provider — and Anthropic / OpenAI
reject it. Because both Claude and GPT route through LiteLLM, every chat
broke.
#### Fix
- Extract the allowed-key set into a shared `ALLOWED_GEN_CONF_KEYS`
constant and reuse it in `Base._clean_conf`.
- Apply the same whitelist in `LiteLLMBase._clean_conf`, plus the
LiteLLM-specific reasoning params (`thinking`, `reasoning_effort`,
`extra_body`) that the model-family policies inject for reasoning
models.
This covers all four LiteLLM completion paths (`async_chat`,
`async_chat_streamly`, `async_chat_with_tools`,
`async_chat_streamly_with_tools`), since they all route through
`_clean_conf`.
#### Tests
Adds `test/unit_test/rag/llm/test_clean_conf_whitelist.py` covering both
backends: `model_type` (and other stray keys) are dropped, genuine
generation params and `thinking` survive, `max_tokens` is removed, and
the whitelist invariants hold.
### Type of change
- [x] Bug Fix (non-breaking change which fixes an issue)
- [x] Added test cases
2026-06-02 05:04:11 +03:00
|
|
|
# Generation parameters that are safe to forward to the underlying completion
|
|
|
|
|
# call. `gen_conf` originates from a chat assistant's `llm_setting`, which can
|
|
|
|
|
# also carry RAGFlow-internal metadata (e.g. `model_type`). Anything outside
|
|
|
|
|
# this set is dropped so providers don't reject the request with errors like
|
|
|
|
|
# "Extra inputs are not permitted" / "Unknown parameter: 'model_type'" (#15427).
|
|
|
|
|
ALLOWED_GEN_CONF_KEYS = frozenset(
|
|
|
|
|
{
|
|
|
|
|
"temperature",
|
|
|
|
|
"max_completion_tokens",
|
|
|
|
|
"top_p",
|
|
|
|
|
"stream",
|
|
|
|
|
"stream_options",
|
|
|
|
|
"stop",
|
|
|
|
|
"n",
|
|
|
|
|
"presence_penalty",
|
|
|
|
|
"frequency_penalty",
|
|
|
|
|
"functions",
|
|
|
|
|
"function_call",
|
|
|
|
|
"logit_bias",
|
|
|
|
|
"user",
|
|
|
|
|
"response_format",
|
|
|
|
|
"seed",
|
|
|
|
|
"tools",
|
|
|
|
|
"tool_choice",
|
|
|
|
|
"logprobs",
|
|
|
|
|
"top_logprobs",
|
|
|
|
|
"extra_headers",
|
|
|
|
|
}
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
# LiteLLM additionally understands reasoning-control parameters that the
|
|
|
|
|
# model-family policies may inject into `gen_conf` (e.g. `thinking` for
|
|
|
|
|
# Anthropic / Kimi reasoning models, `reasoning_effort` for OpenAI o-series).
|
|
|
|
|
LITELLM_ALLOWED_GEN_CONF_KEYS = ALLOWED_GEN_CONF_KEYS | frozenset(
|
|
|
|
|
{
|
|
|
|
|
"thinking",
|
|
|
|
|
"reasoning_effort",
|
|
|
|
|
"extra_body",
|
|
|
|
|
}
|
|
|
|
|
)
|
|
|
|
|
|
2025-01-22 19:43:14 +08:00
|
|
|
|
2026-03-18 17:28:20 +08:00
|
|
|
def _apply_model_family_policies(
|
|
|
|
|
model_name: str,
|
|
|
|
|
*,
|
|
|
|
|
backend: str,
|
|
|
|
|
provider: SupportedLiteLLMProvider | str | None = None,
|
|
|
|
|
gen_conf: dict | None = None,
|
|
|
|
|
request_kwargs: dict | None = None,
|
|
|
|
|
):
|
|
|
|
|
model_name_lower = (model_name or "").lower()
|
|
|
|
|
sanitized_gen_conf = deepcopy(gen_conf) if gen_conf else {}
|
|
|
|
|
sanitized_kwargs = dict(request_kwargs) if request_kwargs else {}
|
|
|
|
|
|
|
|
|
|
# Qwen3 family disables thinking by extra_body on non-stream chat requests.
|
|
|
|
|
if "qwen3" in model_name_lower:
|
|
|
|
|
sanitized_kwargs["extra_body"] = {"enable_thinking": False}
|
|
|
|
|
|
|
|
|
|
if backend == "base":
|
|
|
|
|
return sanitized_gen_conf, sanitized_kwargs
|
|
|
|
|
|
|
|
|
|
if backend == "litellm":
|
|
|
|
|
if provider in {SupportedLiteLLMProvider.OpenAI, SupportedLiteLLMProvider.Azure_OpenAI} and "gpt-5" in model_name_lower:
|
|
|
|
|
for key in ("temperature", "top_p", "logprobs", "top_logprobs"):
|
|
|
|
|
sanitized_gen_conf.pop(key, None)
|
|
|
|
|
sanitized_kwargs.pop(key, None)
|
2026-06-02 17:29:18 +08:00
|
|
|
elif provider == SupportedLiteLLMProvider.Anthropic and model_name_lower in {"claude-opus-4-7", "claude-opus-4-8"}:
|
|
|
|
|
for key in ("temperature", "top_p", "top_k"):
|
|
|
|
|
sanitized_gen_conf.pop(key, None)
|
|
|
|
|
sanitized_kwargs.pop(key, None)
|
2026-03-18 17:28:20 +08:00
|
|
|
|
|
|
|
|
if provider == SupportedLiteLLMProvider.HunYuan:
|
|
|
|
|
for key in ("presence_penalty", "frequency_penalty"):
|
|
|
|
|
sanitized_gen_conf.pop(key, None)
|
2026-05-29 19:28:29 +08:00
|
|
|
elif "kimi-k2.5" in model_name_lower or "kimi-k2.6" in model_name_lower:
|
2026-03-18 17:28:20 +08:00
|
|
|
reasoning = sanitized_gen_conf.pop("reasoning", None)
|
|
|
|
|
thinking = {"type": "enabled"}
|
|
|
|
|
if reasoning is not None:
|
|
|
|
|
thinking = {"type": "enabled"} if reasoning else {"type": "disabled"}
|
|
|
|
|
elif not isinstance(thinking, dict) or thinking.get("type") not in {"enabled", "disabled"}:
|
|
|
|
|
thinking = {"type": "disabled"}
|
|
|
|
|
sanitized_gen_conf["thinking"] = thinking
|
|
|
|
|
|
|
|
|
|
thinking_enabled = thinking.get("type") == "enabled"
|
|
|
|
|
sanitized_gen_conf["temperature"] = 1.0 if thinking_enabled else 0.6
|
|
|
|
|
sanitized_gen_conf["top_p"] = 0.95
|
|
|
|
|
sanitized_gen_conf["n"] = 1
|
|
|
|
|
sanitized_gen_conf["presence_penalty"] = 0.0
|
|
|
|
|
sanitized_gen_conf["frequency_penalty"] = 0.0
|
|
|
|
|
|
|
|
|
|
return sanitized_gen_conf, sanitized_kwargs
|
|
|
|
|
|
|
|
|
|
return sanitized_gen_conf, sanitized_kwargs
|
|
|
|
|
|
|
|
|
|
|
2023-12-25 19:05:59 +08:00
|
|
|
class Base(ABC):
|
2025-06-11 17:20:12 +08:00
|
|
|
def __init__(self, key, model_name, base_url, **kwargs):
|
2025-12-01 12:17:43 +08:00
|
|
|
timeout = int(os.environ.get("LLM_TIMEOUT_SECONDS", 600))
|
2024-10-21 12:11:08 +08:00
|
|
|
self.client = OpenAI(api_key=key, base_url=base_url, timeout=timeout)
|
2025-12-01 14:24:06 +08:00
|
|
|
self.async_client = AsyncOpenAI(api_key=key, base_url=base_url, timeout=timeout)
|
2024-01-22 19:51:38 +08:00
|
|
|
self.model_name = model_name
|
2025-03-22 23:07:03 +08:00
|
|
|
# Configure retry parameters
|
2025-06-11 17:20:12 +08:00
|
|
|
self.max_retries = kwargs.get("max_retries", int(os.environ.get("LLM_MAX_RETRIES", 5)))
|
|
|
|
|
self.base_delay = kwargs.get("retry_interval", float(os.environ.get("LLM_BASE_DELAY", 2.0)))
|
2025-06-12 12:31:10 +08:00
|
|
|
self.max_rounds = kwargs.get("max_rounds", 5)
|
2025-04-08 16:09:03 +08:00
|
|
|
self.is_tools = False
|
2025-06-23 17:45:35 +08:00
|
|
|
self.tools = []
|
|
|
|
|
self.toolcall_sessions = {}
|
2025-03-22 23:07:03 +08:00
|
|
|
|
2025-06-12 12:31:10 +08:00
|
|
|
def _get_delay(self):
|
2025-07-30 19:41:09 +08:00
|
|
|
return self.base_delay * random.uniform(10, 150)
|
2025-03-26 19:33:14 +08:00
|
|
|
|
2025-03-22 23:07:03 +08:00
|
|
|
def _classify_error(self, error):
|
|
|
|
|
error_str = str(error).lower()
|
2025-03-26 19:33:14 +08:00
|
|
|
|
2025-07-30 19:41:09 +08:00
|
|
|
keywords_mapping = [
|
|
|
|
|
(["quota", "capacity", "credit", "billing", "balance", "欠费"], LLMErrorCode.ERROR_QUOTA),
|
|
|
|
|
(["rate limit", "429", "tpm limit", "too many requests", "requests per minute"], LLMErrorCode.ERROR_RATE_LIMIT),
|
|
|
|
|
(["auth", "key", "apikey", "401", "forbidden", "permission"], LLMErrorCode.ERROR_AUTHENTICATION),
|
|
|
|
|
(["invalid", "bad request", "400", "format", "malformed", "parameter"], LLMErrorCode.ERROR_INVALID_REQUEST),
|
|
|
|
|
(["server", "503", "502", "504", "500", "unavailable"], LLMErrorCode.ERROR_SERVER),
|
|
|
|
|
(["timeout", "timed out"], LLMErrorCode.ERROR_TIMEOUT),
|
|
|
|
|
(["connect", "network", "unreachable", "dns"], LLMErrorCode.ERROR_CONNECTION),
|
|
|
|
|
(["filter", "content", "policy", "blocked", "safety", "inappropriate"], LLMErrorCode.ERROR_CONTENT_FILTER),
|
|
|
|
|
(["model", "not found", "does not exist", "not available"], LLMErrorCode.ERROR_MODEL),
|
|
|
|
|
(["max rounds"], LLMErrorCode.ERROR_MODEL),
|
|
|
|
|
]
|
|
|
|
|
for words, code in keywords_mapping:
|
|
|
|
|
if re.search("({})".format("|".join(words)), error_str):
|
|
|
|
|
return code
|
|
|
|
|
|
|
|
|
|
return LLMErrorCode.ERROR_GENERIC
|
2023-12-25 19:05:59 +08:00
|
|
|
|
2025-06-11 17:20:12 +08:00
|
|
|
def _clean_conf(self, gen_conf):
|
2026-03-18 17:28:20 +08:00
|
|
|
gen_conf, _ = _apply_model_family_policies(
|
|
|
|
|
self.model_name,
|
|
|
|
|
backend="base",
|
|
|
|
|
gen_conf=gen_conf,
|
|
|
|
|
)
|
2026-01-27 17:04:53 +08:00
|
|
|
|
2025-06-11 17:20:12 +08:00
|
|
|
if "max_tokens" in gen_conf:
|
|
|
|
|
del gen_conf["max_tokens"]
|
2025-08-22 19:33:09 +08:00
|
|
|
|
fix(llm): strip non-generation keys from gen_conf for LiteLLM providers (#15427) (#15432)
### What problem does this PR solve?
Fixes #15427.
All LiteLLM-routed chats fail with:
- Anthropic: `litellm.BadRequestError: AnthropicException -
{"type":"invalid_request_error","message":"model_type: Extra inputs are
not permitted"}`
- OpenAI: `litellm.BadRequestError: OpenAIException - Unknown parameter:
'model_type'`
This is a regression from v0.25.4.
#### Root cause
A chat assistant's `llm_setting` is forwarded to the model as
`gen_conf`. `llm_setting` can legitimately carry RAGFlow-internal
metadata such as `model_type` (the chat REST APIs in
`api/apps/restful_apis/` read it back out of `llm_setting`), so that key
ends up inside `gen_conf`.
`Base._clean_conf` (OpenAI-compatible providers) already **whitelists**
the keys it forwards, so direct-OpenAI providers were unaffected.
`LiteLLMBase._clean_conf` only dropped `max_tokens` and passed
everything else straight through to `litellm.acompletion`, which
forwarded `model_type` to the upstream provider — and Anthropic / OpenAI
reject it. Because both Claude and GPT route through LiteLLM, every chat
broke.
#### Fix
- Extract the allowed-key set into a shared `ALLOWED_GEN_CONF_KEYS`
constant and reuse it in `Base._clean_conf`.
- Apply the same whitelist in `LiteLLMBase._clean_conf`, plus the
LiteLLM-specific reasoning params (`thinking`, `reasoning_effort`,
`extra_body`) that the model-family policies inject for reasoning
models.
This covers all four LiteLLM completion paths (`async_chat`,
`async_chat_streamly`, `async_chat_with_tools`,
`async_chat_streamly_with_tools`), since they all route through
`_clean_conf`.
#### Tests
Adds `test/unit_test/rag/llm/test_clean_conf_whitelist.py` covering both
backends: `model_type` (and other stray keys) are dropped, genuine
generation params and `thinking` survive, `max_tokens` is removed, and
the whitelist invariants hold.
### Type of change
- [x] Bug Fix (non-breaking change which fixes an issue)
- [x] Added test cases
2026-06-02 05:04:11 +03:00
|
|
|
gen_conf = {k: v for k, v in gen_conf.items() if k in ALLOWED_GEN_CONF_KEYS}
|
2025-06-11 17:20:12 +08:00
|
|
|
return gen_conf
|
|
|
|
|
|
2025-12-08 09:43:03 +08:00
|
|
|
async def _async_chat_streamly(self, history, gen_conf, **kwargs):
|
2025-12-01 14:24:06 +08:00
|
|
|
logging.info("[HISTORY STREAMLY]" + json.dumps(history, ensure_ascii=False, indent=4))
|
|
|
|
|
reasoning_start = False
|
|
|
|
|
|
|
|
|
|
request_kwargs = {"model": self.model_name, "messages": history, "stream": True, **gen_conf}
|
|
|
|
|
stop = kwargs.get("stop")
|
|
|
|
|
if stop:
|
|
|
|
|
request_kwargs["stop"] = stop
|
|
|
|
|
|
|
|
|
|
response = await self.async_client.chat.completions.create(**request_kwargs)
|
|
|
|
|
async for resp in response:
|
|
|
|
|
if not resp.choices:
|
|
|
|
|
continue
|
|
|
|
|
if not resp.choices[0].delta.content:
|
|
|
|
|
resp.choices[0].delta.content = ""
|
2026-03-10 21:13:14 +08:00
|
|
|
_reasoning = getattr(resp.choices[0].delta, "reasoning_content", None) or getattr(resp.choices[0].delta, "reasoning", None)
|
|
|
|
|
if kwargs.get("with_reasoning", True) and _reasoning:
|
2025-12-01 14:24:06 +08:00
|
|
|
ans = ""
|
|
|
|
|
if not reasoning_start:
|
|
|
|
|
reasoning_start = True
|
|
|
|
|
ans = "<think>"
|
2026-03-10 21:13:14 +08:00
|
|
|
ans += _reasoning + "</think>"
|
2025-12-01 14:24:06 +08:00
|
|
|
else:
|
|
|
|
|
reasoning_start = False
|
|
|
|
|
ans = resp.choices[0].delta.content
|
|
|
|
|
tol = total_token_count_from_response(resp)
|
|
|
|
|
if not tol:
|
|
|
|
|
tol = num_tokens_from_string(resp.choices[0].delta.content)
|
|
|
|
|
|
|
|
|
|
finish_reason = resp.choices[0].finish_reason if hasattr(resp.choices[0], "finish_reason") else ""
|
|
|
|
|
if finish_reason == "length":
|
|
|
|
|
if is_chinese(ans):
|
|
|
|
|
ans += LENGTH_NOTIFICATION_CN
|
|
|
|
|
else:
|
|
|
|
|
ans += LENGTH_NOTIFICATION_EN
|
|
|
|
|
yield ans, tol
|
|
|
|
|
|
fix(llm): replace mutable default `gen_conf={}` with None + defensive copy (#14566)
### What
19 methods across `rag/llm/chat_model.py` and `rag/llm/cv_model.py`
declare `gen_conf={}` (or `gen_conf: dict = {}`) as a parameter default
and then mutate `gen_conf` in place — typically `del
gen_conf["max_tokens"]`, `gen_conf["penalty_score"] = ...`, or
`gen_conf.pop(...)` as part of provider-specific normalization.
### The two bugs in this pattern
**1. Mutable default argument (Python footgun).** Python evaluates
default values **once** at function-definition time, so the single `{}`
dict is *shared* across every caller that doesn't pass `gen_conf`. The
first such call's mutations leak into the default seen by every
subsequent call.
```python
# Before
def chat_streamly(self, system, history, gen_conf={}, **kwargs):
if "max_tokens" in gen_conf:
del gen_conf["max_tokens"] # mutates the SHARED default dict
...
```
After call N with `max_tokens` set, call N+1 that omits `gen_conf` no
longer sees `max_tokens` — even though the caller never touched it.
**2. Caller-dict pollution.** When the caller *does* pass a `gen_conf`
dict, the same in-place mutations modify the caller's dict. A reused
`gen_conf` (very common for chat-loop callers that build the config once
and pass it on every turn) silently loses `max_tokens`,
`presence_penalty`, etc. after the first round.
### The fix
In every affected method:
- Change `gen_conf={}` (or `gen_conf: dict = {}`) → `gen_conf=None`.
- Add `gen_conf = dict(gen_conf or {})` as the first statement of the
body so all subsequent mutations operate on a fresh local copy.
```python
# After
def chat_streamly(self, system, history, gen_conf=None, **kwargs):
gen_conf = dict(gen_conf or {})
if "max_tokens" in gen_conf:
del gen_conf["max_tokens"] # local copy — safe
...
```
This is byte-for-byte identical provider-side behavior for callers that
already pass a fresh `gen_conf` per call. The new `dict(...)` copy is
O(small constant) per call.
### Files changed
- `rag/llm/chat_model.py` — 17 methods
- `rag/llm/cv_model.py` — 2 methods
### Tests
Adds `test/unit_test/rag/llm/test_gen_conf_no_mutable_default.py` — an
`ast`-based regression guard that walks both modules and asserts no
parameter named `gen_conf` ever has a mutable literal (`{}` or `[]`) as
its default. The test caught **five additional `gen_conf: dict = {}`
sites** that an initial `gen_conf={}` text grep had missed (annotated
parameters with whitespace), and would fail again if the pattern is ever
reintroduced.
```
$ pytest test/unit_test/rag/llm/test_gen_conf_no_mutable_default.py -v
============================== 3 passed in 0.04s ===============================
```
`ruff check` passes on all touched files.
### Notes
- This PR is intentionally focused on **just** the `gen_conf` default +
copy fix. There's a related (but separate) `history.insert(0, ...)`
pattern in the same files that mutates the caller's history list in 12
places — left for a follow-up so this PR stays mechanical and easy to
review.
### Latest revision (`700bb54a7`) — addresses CodeRabbit review
- Type annotation: `gen_conf: dict = None` → `gen_conf: dict | None =
None` (5 occurrences in `chat_model.py`). The old annotation was a
static-checker mismatch since `None` isn't a `dict`.
- Regression test: the AST check accessed `default.keys` directly.
`ast.List` has no `.keys` attribute — a future `gen_conf=[]` would crash
with `AttributeError` instead of being caught. Use `getattr` for both
`.keys` (Dict) and `.elts` (List). Manually verified the updated check
correctly catches both `gen_conf={}` and `gen_conf=[]` while ignoring
`gen_conf=None` and non-empty literals.
---------
Co-authored-by: Ricardo <ricardo@example.com>
2026-05-09 13:11:44 +08:00
|
|
|
async def async_chat_streamly(self, system, history, gen_conf: dict | None = None, **kwargs):
|
|
|
|
|
gen_conf = dict(gen_conf or {})
|
2025-12-01 14:24:06 +08:00
|
|
|
if system and history and history[0].get("role") != "system":
|
|
|
|
|
history.insert(0, {"role": "system", "content": system})
|
|
|
|
|
gen_conf = self._clean_conf(gen_conf)
|
|
|
|
|
ans = ""
|
|
|
|
|
total_tokens = 0
|
2025-12-08 09:43:03 +08:00
|
|
|
|
|
|
|
|
for attempt in range(self.max_retries + 1):
|
|
|
|
|
try:
|
|
|
|
|
async for delta_ans, tol in self._async_chat_streamly(history, gen_conf, **kwargs):
|
|
|
|
|
ans = delta_ans
|
|
|
|
|
total_tokens += tol
|
|
|
|
|
yield ans
|
2025-12-09 17:14:30 +08:00
|
|
|
|
|
|
|
|
yield total_tokens
|
|
|
|
|
return
|
2025-12-08 09:43:03 +08:00
|
|
|
except Exception as e:
|
|
|
|
|
e = await self._exceptions_async(e, attempt)
|
|
|
|
|
if e:
|
2025-12-13 11:32:46 +08:00
|
|
|
yield e
|
2025-12-08 09:43:03 +08:00
|
|
|
yield total_tokens
|
|
|
|
|
return
|
2025-12-01 14:24:06 +08:00
|
|
|
|
2025-06-12 12:31:10 +08:00
|
|
|
def _length_stop(self, ans):
|
|
|
|
|
if is_chinese([ans]):
|
|
|
|
|
return ans + LENGTH_NOTIFICATION_CN
|
|
|
|
|
return ans + LENGTH_NOTIFICATION_EN
|
|
|
|
|
|
2025-09-23 06:19:28 +02:00
|
|
|
@property
|
|
|
|
|
def _retryable_errors(self) -> set[str]:
|
|
|
|
|
return {
|
|
|
|
|
LLMErrorCode.ERROR_RATE_LIMIT,
|
|
|
|
|
LLMErrorCode.ERROR_SERVER,
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
def _should_retry(self, error_code: str) -> bool:
|
|
|
|
|
return error_code in self._retryable_errors
|
|
|
|
|
|
|
|
|
|
def _exceptions(self, e, attempt) -> str | None:
|
2025-07-16 13:47:38 +08:00
|
|
|
logging.exception("OpenAI chat_with_tools")
|
2025-06-12 12:31:10 +08:00
|
|
|
# Classify the error
|
|
|
|
|
error_code = self._classify_error(e)
|
2025-07-30 19:41:09 +08:00
|
|
|
if attempt == self.max_retries:
|
|
|
|
|
error_code = LLMErrorCode.ERROR_MAX_RETRIES
|
2025-06-12 12:31:10 +08:00
|
|
|
|
2025-09-23 06:19:28 +02:00
|
|
|
if self._should_retry(error_code):
|
|
|
|
|
delay = self._get_delay()
|
|
|
|
|
logging.warning(f"Error: {error_code}. Retrying in {delay:.2f} seconds... (Attempt {attempt + 1}/{self.max_retries})")
|
|
|
|
|
time.sleep(delay)
|
|
|
|
|
return None
|
2025-06-12 12:31:10 +08:00
|
|
|
|
2025-12-01 14:24:06 +08:00
|
|
|
msg = f"{ERROR_PREFIX}: {error_code} - {str(e)}"
|
|
|
|
|
logging.error(f"sync base giving up: {msg}")
|
|
|
|
|
return msg
|
|
|
|
|
|
2025-12-08 09:43:03 +08:00
|
|
|
async def _exceptions_async(self, e, attempt):
|
2025-12-01 14:24:06 +08:00
|
|
|
logging.exception("OpenAI async completion")
|
|
|
|
|
error_code = self._classify_error(e)
|
|
|
|
|
if attempt == self.max_retries:
|
|
|
|
|
error_code = LLMErrorCode.ERROR_MAX_RETRIES
|
|
|
|
|
|
|
|
|
|
if self._should_retry(error_code):
|
|
|
|
|
delay = self._get_delay()
|
|
|
|
|
logging.warning(f"Error: {error_code}. Retrying in {delay:.2f} seconds... (Attempt {attempt + 1}/{self.max_retries})")
|
|
|
|
|
await asyncio.sleep(delay)
|
|
|
|
|
return None
|
|
|
|
|
|
|
|
|
|
msg = f"{ERROR_PREFIX}: {error_code} - {str(e)}"
|
|
|
|
|
logging.error(f"async base giving up: {msg}")
|
|
|
|
|
return msg
|
2025-07-30 19:41:09 +08:00
|
|
|
|
2025-06-27 19:28:41 +08:00
|
|
|
def _verbose_tool_use(self, name, args, res):
|
2025-08-12 10:59:20 +08:00
|
|
|
return "<tool_call>" + json.dumps({"name": name, "args": args, "result": res}, ensure_ascii=False, indent=2) + "</tool_call>"
|
2025-06-27 19:28:41 +08:00
|
|
|
|
|
|
|
|
def _append_history(self, hist, tool_call, tool_res):
|
|
|
|
|
hist.append(
|
|
|
|
|
{
|
|
|
|
|
"role": "assistant",
|
|
|
|
|
"tool_calls": [
|
|
|
|
|
{
|
Fix AttributeError when appending non-streaming tool calls to chat history in Agentic Agent (#14456)
### What problem does this PR solve?
Fix #14340
## Problem Description
When using an **Agentic Agent** (not Workflow) with one or more
Retrieval tools (e.g., Dataset Retrieval + Memory Retrieval), the agent
silently returns an empty response (`agent_response: ""`) after hanging
for several minutes. The server logs show:
```
AttributeError: 'ChatCompletionMessageToolCall' object has no attribute 'index'
```
This error propagates as a `GENERIC_ERROR`, causing the canvas to return
an empty response. The subsequent Memory save task then receives the
empty `agent_response` and logs:
```
Document for referred_document_id XXXX not found
```
## Reproduction Steps
1. Set `DOC_ENGINE=infinity` (or `elasticsearch` — the engine itself is
not the root cause).
2. Create a blank **Agentic Agent** (not a Workflow).
3. Add **two Retrieval tools** to the Agent node:
- `Retrieval_DS` → Dataset (Knowledge Base)
- `Retrieval_Mem` → Memory component
4. Add a **Message** node with **Save to Memory** enabled.
5. Launch the agent and send any message (e.g., "hola").
6. The agent hangs and returns an empty response.
## Root Cause Analysis
The crash occurs in `_append_history` and `_append_history_batch` inside
`rag/llm/chat_model.py`. These methods directly access `.index` on tool
call objects:
```python
# _append_history_batch
{
"index": tc.index, # <-- crashes here
...
}
```
However, **non-streaming** LLM responses (`stream=False`) return
`ChatCompletionMessageToolCall` objects, which **do not have an `index`
field** according to the OpenAI API specification. The `index` field
only exists on `ChoiceDeltaToolCall` objects returned in **streaming**
responses (`stream=True`).
When the agentic agent triggers an internal `full_question` call (used
to compress multi-turn conversation history), the request is incorrectly
routed through `async_chat_with_tools` because `is_tools=True` is set at
the `LLMBundle` level. If the LLM decides to emit `tool_calls` during
this auxiliary request, the code enters the non-streaming tool loop and
crashes when trying to append history.
## Fix
Replaced all direct `.index` accesses with `getattr(..., "index", None)`
for safe, backward-compatible access:
| Method | File | Line | Change |
|--------|------|------|--------|
| `_append_history` | `rag/llm/chat_model.py` | ~L304 |
`tool_call.index` → `getattr(tool_call, "index", None)` |
| `_append_history_batch` | `rag/llm/chat_model.py` | ~L332 | `tc.index`
→ `getattr(tc, "index", None)` |
| `_append_history` | `rag/llm/chat_model.py` | ~L1467 |
`tool_call.index` → `getattr(tool_call, "index", None)` |
| `_append_history_batch` | `rag/llm/chat_model.py` | ~L1496 |
`tc.index` → `getattr(tc, "index", None)` |
### Type of change
- [x] Bug Fix (non-breaking change which fixes an issue)
Signed-off-by: noob <yixiao121314@outlook.com>
2026-05-05 23:39:40 -07:00
|
|
|
"index": getattr(tool_call, "index", None),
|
2025-06-27 19:28:41 +08:00
|
|
|
"id": tool_call.id,
|
|
|
|
|
"function": {
|
|
|
|
|
"name": tool_call.function.name,
|
|
|
|
|
"arguments": tool_call.function.arguments,
|
|
|
|
|
},
|
|
|
|
|
"type": "function",
|
|
|
|
|
},
|
|
|
|
|
],
|
|
|
|
|
}
|
|
|
|
|
)
|
|
|
|
|
try:
|
|
|
|
|
if isinstance(tool_res, dict):
|
|
|
|
|
tool_res = json.dumps(tool_res, ensure_ascii=False)
|
|
|
|
|
finally:
|
|
|
|
|
hist.append({"role": "tool", "tool_call_id": tool_call.id, "content": str(tool_res)})
|
|
|
|
|
return hist
|
|
|
|
|
|
2026-03-20 20:32:00 +08:00
|
|
|
def _append_history_batch(self, hist, results):
|
|
|
|
|
"""
|
|
|
|
|
Append a batch of tool calls to history following the OpenAI protocol:
|
|
|
|
|
one assistant message containing all tool_calls, followed by one tool message per call.
|
|
|
|
|
results: list of (tool_call, name, args, result, error)
|
|
|
|
|
"""
|
Fix AttributeError when appending non-streaming tool calls to chat history in Agentic Agent (#14456)
### What problem does this PR solve?
Fix #14340
## Problem Description
When using an **Agentic Agent** (not Workflow) with one or more
Retrieval tools (e.g., Dataset Retrieval + Memory Retrieval), the agent
silently returns an empty response (`agent_response: ""`) after hanging
for several minutes. The server logs show:
```
AttributeError: 'ChatCompletionMessageToolCall' object has no attribute 'index'
```
This error propagates as a `GENERIC_ERROR`, causing the canvas to return
an empty response. The subsequent Memory save task then receives the
empty `agent_response` and logs:
```
Document for referred_document_id XXXX not found
```
## Reproduction Steps
1. Set `DOC_ENGINE=infinity` (or `elasticsearch` — the engine itself is
not the root cause).
2. Create a blank **Agentic Agent** (not a Workflow).
3. Add **two Retrieval tools** to the Agent node:
- `Retrieval_DS` → Dataset (Knowledge Base)
- `Retrieval_Mem` → Memory component
4. Add a **Message** node with **Save to Memory** enabled.
5. Launch the agent and send any message (e.g., "hola").
6. The agent hangs and returns an empty response.
## Root Cause Analysis
The crash occurs in `_append_history` and `_append_history_batch` inside
`rag/llm/chat_model.py`. These methods directly access `.index` on tool
call objects:
```python
# _append_history_batch
{
"index": tc.index, # <-- crashes here
...
}
```
However, **non-streaming** LLM responses (`stream=False`) return
`ChatCompletionMessageToolCall` objects, which **do not have an `index`
field** according to the OpenAI API specification. The `index` field
only exists on `ChoiceDeltaToolCall` objects returned in **streaming**
responses (`stream=True`).
When the agentic agent triggers an internal `full_question` call (used
to compress multi-turn conversation history), the request is incorrectly
routed through `async_chat_with_tools` because `is_tools=True` is set at
the `LLMBundle` level. If the LLM decides to emit `tool_calls` during
this auxiliary request, the code enters the non-streaming tool loop and
crashes when trying to append history.
## Fix
Replaced all direct `.index` accesses with `getattr(..., "index", None)`
for safe, backward-compatible access:
| Method | File | Line | Change |
|--------|------|------|--------|
| `_append_history` | `rag/llm/chat_model.py` | ~L304 |
`tool_call.index` → `getattr(tool_call, "index", None)` |
| `_append_history_batch` | `rag/llm/chat_model.py` | ~L332 | `tc.index`
→ `getattr(tc, "index", None)` |
| `_append_history` | `rag/llm/chat_model.py` | ~L1467 |
`tool_call.index` → `getattr(tool_call, "index", None)` |
| `_append_history_batch` | `rag/llm/chat_model.py` | ~L1496 |
`tc.index` → `getattr(tc, "index", None)` |
### Type of change
- [x] Bug Fix (non-breaking change which fixes an issue)
Signed-off-by: noob <yixiao121314@outlook.com>
2026-05-05 23:39:40 -07:00
|
|
|
hist.append(
|
|
|
|
|
{
|
|
|
|
|
"role": "assistant",
|
|
|
|
|
"tool_calls": [
|
|
|
|
|
{
|
|
|
|
|
"index": getattr(tc, "index", None),
|
|
|
|
|
"id": tc.id,
|
|
|
|
|
"function": {"name": tc.function.name, "arguments": tc.function.arguments},
|
|
|
|
|
"type": "function",
|
|
|
|
|
}
|
|
|
|
|
for tc, _, _, _, _ in results
|
|
|
|
|
],
|
|
|
|
|
}
|
|
|
|
|
)
|
2026-03-20 20:32:00 +08:00
|
|
|
for tc, _, _, result, err in results:
|
|
|
|
|
if err:
|
|
|
|
|
content = str(err)
|
|
|
|
|
elif isinstance(result, dict):
|
|
|
|
|
content = json.dumps(result, ensure_ascii=False)
|
|
|
|
|
else:
|
|
|
|
|
content = str(result)
|
|
|
|
|
hist.append({"role": "tool", "tool_call_id": tc.id, "content": content})
|
|
|
|
|
return hist
|
|
|
|
|
|
Feat: @tool decorator for chat-model tool registration (#15047)
## Summary
- Adds a lightweight `@tool` decorator and `FunctionToolSession` adapter
in `rag/llm/tool_decorator.py` that let callers register plain Python
functions as LLM tools without hand-writing OpenAI function schemas or
building an MCP-style session.
- Refactors `Base.bind_tools` and `LiteLLMBase.bind_tools` in
`rag/llm/chat_model.py` to accept either the new decorator form
`bind_tools(tools=[fn1, fn2])` or the existing `(toolcall_session,
tools_schemas)` form, so existing agent/dialog call-sites in
`agent/component/agent_with_tools.py`, `api/db/services/llm_service.py`,
and `api/db/services/dialog_service.py` are unaffected.
- Adds 8 unit tests in `test/unit_test/rag/llm/test_tool_decorator.py`
covering schema shape, required/optional inference, sync + async
dispatch, and bad-input rejection.
## Usage
```python
from rag.llm.tool_decorator import tool
@tool
def get_weather(city: str) -> str:
"""Get current weather for a city.
:param city: City name to look up.
"""
return f"{city}: 21 C, partly cloudy"
chat_mdl.bind_tools(tools=[get_weather])
ans, tk = await chat_mdl.async_chat_with_tools(system, history)
```
The decorator introspects `inspect.signature` + type hints + the
docstring (`:param name:` style) and attaches an OpenAI-format
`openai_schema` to the callable. `FunctionToolSession` duck-types the
existing `ToolCallSession` protocol, dispatching async callables
directly and sync ones through `thread_pool_exec` so the event loop is
never blocked.
## Design notes
- `tool_decorator.py` deliberately does **not** live inside
`rag/llm/__init__.py` to avoid forcing every consumer through the heavy
provider auto-discovery loop and to sidestep a circular import
(`__init__.py` imports `chat_model`, which would otherwise need symbols
from `__init__.py`).
- `FunctionToolSession` is duck-typed against
`common.mcp_tool_call_conn.ToolCallSession` rather than explicitly
inheriting from it, so importing the decorator doesn't pull the MCP
client SDK into the import graph.
- Docstring parsing is intentionally minimal (`:param name:` only) to
keep this dependency-free; Google/NumPy styles can be added later via
`docstring_parser` if needed.
## Test plan
- [x] `python -m pytest test/unit_test/rag/llm/test_tool_decorator.py
-v` — 8 passed
- [x] `python -m pytest test/unit_test/rag/llm/
--ignore=test/unit_test/rag/llm/test_perplexity_embed.py` — 11 passed
(the ignored test has a pre-existing `numpy` import that's unrelated)
- [ ] Reviewer: smoke-test the new path end-to-end with a live model via
`chat_mdl.bind_tools(tools=[my_fn])` to confirm the OpenAI-format
schemas pass through unchanged
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---------
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-21 14:07:00 +08:00
|
|
|
def bind_tools(self, toolcall_session=None, tools=None):
|
|
|
|
|
"""Register tools the LLM can call.
|
|
|
|
|
|
|
|
|
|
Two calling styles are accepted:
|
|
|
|
|
|
|
|
|
|
* Legacy: ``bind_tools(toolcall_session, tools_schemas)`` where
|
|
|
|
|
``toolcall_session`` implements :class:`ToolCallSession` and
|
|
|
|
|
``tools_schemas`` is a pre-built list of OpenAI function-schema
|
|
|
|
|
dicts (used by the agent/dialog layer).
|
|
|
|
|
* Decorator: ``bind_tools(tools=[fn1, fn2, ...])`` where each ``fn``
|
|
|
|
|
is decorated with :func:`rag.llm.tool_decorator.tool`. The session
|
|
|
|
|
and schemas are derived from the callables automatically.
|
|
|
|
|
"""
|
|
|
|
|
if tools is None and isinstance(toolcall_session, list):
|
|
|
|
|
tools, toolcall_session = toolcall_session, None
|
|
|
|
|
|
|
|
|
|
if tools and toolcall_session is None and all(is_tool(t) for t in tools):
|
|
|
|
|
session = FunctionToolSession(tools)
|
|
|
|
|
self.is_tools = True
|
|
|
|
|
self.toolcall_session = session
|
|
|
|
|
self.tools = session.schemas
|
|
|
|
|
return
|
|
|
|
|
|
2025-04-08 16:09:03 +08:00
|
|
|
if not (toolcall_session and tools):
|
|
|
|
|
return
|
|
|
|
|
self.is_tools = True
|
2025-07-30 19:41:09 +08:00
|
|
|
self.toolcall_session = toolcall_session
|
|
|
|
|
self.tools = tools
|
2025-06-23 17:45:35 +08:00
|
|
|
|
fix(llm): replace mutable default `gen_conf={}` with None + defensive copy (#14566)
### What
19 methods across `rag/llm/chat_model.py` and `rag/llm/cv_model.py`
declare `gen_conf={}` (or `gen_conf: dict = {}`) as a parameter default
and then mutate `gen_conf` in place — typically `del
gen_conf["max_tokens"]`, `gen_conf["penalty_score"] = ...`, or
`gen_conf.pop(...)` as part of provider-specific normalization.
### The two bugs in this pattern
**1. Mutable default argument (Python footgun).** Python evaluates
default values **once** at function-definition time, so the single `{}`
dict is *shared* across every caller that doesn't pass `gen_conf`. The
first such call's mutations leak into the default seen by every
subsequent call.
```python
# Before
def chat_streamly(self, system, history, gen_conf={}, **kwargs):
if "max_tokens" in gen_conf:
del gen_conf["max_tokens"] # mutates the SHARED default dict
...
```
After call N with `max_tokens` set, call N+1 that omits `gen_conf` no
longer sees `max_tokens` — even though the caller never touched it.
**2. Caller-dict pollution.** When the caller *does* pass a `gen_conf`
dict, the same in-place mutations modify the caller's dict. A reused
`gen_conf` (very common for chat-loop callers that build the config once
and pass it on every turn) silently loses `max_tokens`,
`presence_penalty`, etc. after the first round.
### The fix
In every affected method:
- Change `gen_conf={}` (or `gen_conf: dict = {}`) → `gen_conf=None`.
- Add `gen_conf = dict(gen_conf or {})` as the first statement of the
body so all subsequent mutations operate on a fresh local copy.
```python
# After
def chat_streamly(self, system, history, gen_conf=None, **kwargs):
gen_conf = dict(gen_conf or {})
if "max_tokens" in gen_conf:
del gen_conf["max_tokens"] # local copy — safe
...
```
This is byte-for-byte identical provider-side behavior for callers that
already pass a fresh `gen_conf` per call. The new `dict(...)` copy is
O(small constant) per call.
### Files changed
- `rag/llm/chat_model.py` — 17 methods
- `rag/llm/cv_model.py` — 2 methods
### Tests
Adds `test/unit_test/rag/llm/test_gen_conf_no_mutable_default.py` — an
`ast`-based regression guard that walks both modules and asserts no
parameter named `gen_conf` ever has a mutable literal (`{}` or `[]`) as
its default. The test caught **five additional `gen_conf: dict = {}`
sites** that an initial `gen_conf={}` text grep had missed (annotated
parameters with whitespace), and would fail again if the pattern is ever
reintroduced.
```
$ pytest test/unit_test/rag/llm/test_gen_conf_no_mutable_default.py -v
============================== 3 passed in 0.04s ===============================
```
`ruff check` passes on all touched files.
### Notes
- This PR is intentionally focused on **just** the `gen_conf` default +
copy fix. There's a related (but separate) `history.insert(0, ...)`
pattern in the same files that mutates the caller's history list in 12
places — left for a follow-up so this PR stays mechanical and easy to
review.
### Latest revision (`700bb54a7`) — addresses CodeRabbit review
- Type annotation: `gen_conf: dict = None` → `gen_conf: dict | None =
None` (5 occurrences in `chat_model.py`). The old annotation was a
static-checker mismatch since `None` isn't a `dict`.
- Regression test: the AST check accessed `default.keys` directly.
`ast.List` has no `.keys` attribute — a future `gen_conf=[]` would crash
with `AttributeError` instead of being caught. Use `getattr` for both
`.keys` (Dict) and `.elts` (List). Manually verified the updated check
correctly catches both `gen_conf={}` and `gen_conf=[]` while ignoring
`gen_conf=None` and non-empty literals.
---------
Co-authored-by: Ricardo <ricardo@example.com>
2026-05-09 13:11:44 +08:00
|
|
|
async def async_chat_with_tools(self, system: str, history: list, gen_conf: dict | None = None):
|
|
|
|
|
gen_conf = dict(gen_conf or {})
|
2025-12-01 14:24:06 +08:00
|
|
|
gen_conf = self._clean_conf(gen_conf)
|
|
|
|
|
if system and history and history[0].get("role") != "system":
|
|
|
|
|
history.insert(0, {"role": "system", "content": system})
|
|
|
|
|
|
|
|
|
|
ans = ""
|
|
|
|
|
tk_count = 0
|
|
|
|
|
hist = deepcopy(history)
|
|
|
|
|
for attempt in range(self.max_retries + 1):
|
|
|
|
|
history = deepcopy(hist)
|
|
|
|
|
try:
|
|
|
|
|
for _ in range(self.max_rounds + 1):
|
|
|
|
|
logging.info(f"{self.tools=}")
|
|
|
|
|
response = await self.async_client.chat.completions.create(model=self.model_name, messages=history, tools=self.tools, tool_choice="auto", **gen_conf)
|
|
|
|
|
tk_count += total_token_count_from_response(response)
|
2026-05-19 22:05:52 -05:00
|
|
|
if not response.choices or not response.choices[0].message:
|
2025-12-01 14:24:06 +08:00
|
|
|
raise Exception(f"500 response structure error. Response: {response}")
|
|
|
|
|
|
|
|
|
|
if not hasattr(response.choices[0].message, "tool_calls") or not response.choices[0].message.tool_calls:
|
2026-03-10 21:13:14 +08:00
|
|
|
_reasoning = getattr(response.choices[0].message, "reasoning_content", None) or getattr(response.choices[0].message, "reasoning", None)
|
|
|
|
|
if _reasoning:
|
|
|
|
|
ans += "<think>" + _reasoning + "</think>"
|
2025-12-01 14:24:06 +08:00
|
|
|
|
|
|
|
|
ans += response.choices[0].message.content
|
|
|
|
|
if response.choices[0].finish_reason == "length":
|
|
|
|
|
ans = self._length_stop(ans)
|
|
|
|
|
|
|
|
|
|
return ans, tk_count
|
|
|
|
|
|
2026-03-20 20:32:00 +08:00
|
|
|
async def _exec_tool(tc):
|
|
|
|
|
name = tc.function.name
|
2025-12-01 14:24:06 +08:00
|
|
|
try:
|
2026-03-20 20:32:00 +08:00
|
|
|
args = json_repair.loads(tc.function.arguments)
|
2026-05-20 16:56:20 +08:00
|
|
|
if not isinstance(args, dict):
|
|
|
|
|
raise TypeError(
|
|
|
|
|
f"Tool arguments for {name} must be a JSON object, got {type(args).__name__}"
|
|
|
|
|
)
|
2026-03-20 20:32:00 +08:00
|
|
|
if hasattr(self.toolcall_session, "tool_call_async"):
|
|
|
|
|
result = await self.toolcall_session.tool_call_async(name, args)
|
|
|
|
|
else:
|
|
|
|
|
result = await thread_pool_exec(self.toolcall_session.tool_call, name, args)
|
|
|
|
|
return tc, name, args, result, None
|
2025-12-01 14:24:06 +08:00
|
|
|
except Exception as e:
|
2026-03-20 20:32:00 +08:00
|
|
|
logging.exception(f"Tool call failed: {tc}")
|
|
|
|
|
return tc, name, {}, None, e
|
|
|
|
|
|
|
|
|
|
logging.info(f"Response tool_calls={response.choices[0].message.tool_calls}")
|
|
|
|
|
results = await asyncio.gather(*[_exec_tool(tc) for tc in response.choices[0].message.tool_calls])
|
|
|
|
|
history = self._append_history_batch(history, results)
|
|
|
|
|
for tc, name, args, result, err in results:
|
|
|
|
|
ans += self._verbose_tool_use(name, args, err if err else result)
|
2025-12-01 14:24:06 +08:00
|
|
|
|
|
|
|
|
logging.warning(f"Exceed max rounds: {self.max_rounds}")
|
|
|
|
|
history.append({"role": "user", "content": f"Exceed max rounds: {self.max_rounds}"})
|
|
|
|
|
response, token_count = await self._async_chat(history, gen_conf)
|
|
|
|
|
ans += response
|
|
|
|
|
tk_count += token_count
|
|
|
|
|
return ans, tk_count
|
|
|
|
|
except Exception as e:
|
|
|
|
|
e = await self._exceptions_async(e, attempt)
|
|
|
|
|
if e:
|
|
|
|
|
return e, tk_count
|
|
|
|
|
|
|
|
|
|
assert False, "Shouldn't be here."
|
|
|
|
|
|
fix(llm): replace mutable default `gen_conf={}` with None + defensive copy (#14566)
### What
19 methods across `rag/llm/chat_model.py` and `rag/llm/cv_model.py`
declare `gen_conf={}` (or `gen_conf: dict = {}`) as a parameter default
and then mutate `gen_conf` in place — typically `del
gen_conf["max_tokens"]`, `gen_conf["penalty_score"] = ...`, or
`gen_conf.pop(...)` as part of provider-specific normalization.
### The two bugs in this pattern
**1. Mutable default argument (Python footgun).** Python evaluates
default values **once** at function-definition time, so the single `{}`
dict is *shared* across every caller that doesn't pass `gen_conf`. The
first such call's mutations leak into the default seen by every
subsequent call.
```python
# Before
def chat_streamly(self, system, history, gen_conf={}, **kwargs):
if "max_tokens" in gen_conf:
del gen_conf["max_tokens"] # mutates the SHARED default dict
...
```
After call N with `max_tokens` set, call N+1 that omits `gen_conf` no
longer sees `max_tokens` — even though the caller never touched it.
**2. Caller-dict pollution.** When the caller *does* pass a `gen_conf`
dict, the same in-place mutations modify the caller's dict. A reused
`gen_conf` (very common for chat-loop callers that build the config once
and pass it on every turn) silently loses `max_tokens`,
`presence_penalty`, etc. after the first round.
### The fix
In every affected method:
- Change `gen_conf={}` (or `gen_conf: dict = {}`) → `gen_conf=None`.
- Add `gen_conf = dict(gen_conf or {})` as the first statement of the
body so all subsequent mutations operate on a fresh local copy.
```python
# After
def chat_streamly(self, system, history, gen_conf=None, **kwargs):
gen_conf = dict(gen_conf or {})
if "max_tokens" in gen_conf:
del gen_conf["max_tokens"] # local copy — safe
...
```
This is byte-for-byte identical provider-side behavior for callers that
already pass a fresh `gen_conf` per call. The new `dict(...)` copy is
O(small constant) per call.
### Files changed
- `rag/llm/chat_model.py` — 17 methods
- `rag/llm/cv_model.py` — 2 methods
### Tests
Adds `test/unit_test/rag/llm/test_gen_conf_no_mutable_default.py` — an
`ast`-based regression guard that walks both modules and asserts no
parameter named `gen_conf` ever has a mutable literal (`{}` or `[]`) as
its default. The test caught **five additional `gen_conf: dict = {}`
sites** that an initial `gen_conf={}` text grep had missed (annotated
parameters with whitespace), and would fail again if the pattern is ever
reintroduced.
```
$ pytest test/unit_test/rag/llm/test_gen_conf_no_mutable_default.py -v
============================== 3 passed in 0.04s ===============================
```
`ruff check` passes on all touched files.
### Notes
- This PR is intentionally focused on **just** the `gen_conf` default +
copy fix. There's a related (but separate) `history.insert(0, ...)`
pattern in the same files that mutates the caller's history list in 12
places — left for a follow-up so this PR stays mechanical and easy to
review.
### Latest revision (`700bb54a7`) — addresses CodeRabbit review
- Type annotation: `gen_conf: dict = None` → `gen_conf: dict | None =
None` (5 occurrences in `chat_model.py`). The old annotation was a
static-checker mismatch since `None` isn't a `dict`.
- Regression test: the AST check accessed `default.keys` directly.
`ast.List` has no `.keys` attribute — a future `gen_conf=[]` would crash
with `AttributeError` instead of being caught. Use `getattr` for both
`.keys` (Dict) and `.elts` (List). Manually verified the updated check
correctly catches both `gen_conf={}` and `gen_conf=[]` while ignoring
`gen_conf=None` and non-empty literals.
---------
Co-authored-by: Ricardo <ricardo@example.com>
2026-05-09 13:11:44 +08:00
|
|
|
async def async_chat_streamly_with_tools(self, system: str, history: list, gen_conf: dict | None = None):
|
|
|
|
|
gen_conf = dict(gen_conf or {})
|
2025-12-01 14:24:06 +08:00
|
|
|
gen_conf = self._clean_conf(gen_conf)
|
|
|
|
|
tools = self.tools
|
|
|
|
|
if system and history and history[0].get("role") != "system":
|
|
|
|
|
history.insert(0, {"role": "system", "content": system})
|
|
|
|
|
|
|
|
|
|
total_tokens = 0
|
|
|
|
|
hist = deepcopy(history)
|
|
|
|
|
|
|
|
|
|
for attempt in range(self.max_retries + 1):
|
|
|
|
|
history = deepcopy(hist)
|
|
|
|
|
try:
|
2026-03-20 20:32:00 +08:00
|
|
|
for _round in range(self.max_rounds + 1):
|
2025-12-01 14:24:06 +08:00
|
|
|
reasoning_start = False
|
2026-03-20 20:32:00 +08:00
|
|
|
logging.info(f"[ToolLoop] round={_round} model={self.model_name} tools={[t['function']['name'] for t in tools]}")
|
2025-12-01 14:24:06 +08:00
|
|
|
|
|
|
|
|
response = await self.async_client.chat.completions.create(model=self.model_name, messages=history, stream=True, tools=tools, tool_choice="auto", **gen_conf)
|
|
|
|
|
|
|
|
|
|
final_tool_calls = {}
|
|
|
|
|
answer = ""
|
|
|
|
|
|
|
|
|
|
async for resp in response:
|
|
|
|
|
if not hasattr(resp, "choices") or not resp.choices:
|
|
|
|
|
continue
|
|
|
|
|
|
|
|
|
|
delta = resp.choices[0].delta
|
|
|
|
|
|
|
|
|
|
if hasattr(delta, "tool_calls") and delta.tool_calls:
|
|
|
|
|
for tool_call in delta.tool_calls:
|
|
|
|
|
index = tool_call.index
|
|
|
|
|
if index not in final_tool_calls:
|
|
|
|
|
if not tool_call.function.arguments:
|
|
|
|
|
tool_call.function.arguments = ""
|
|
|
|
|
final_tool_calls[index] = tool_call
|
|
|
|
|
else:
|
|
|
|
|
final_tool_calls[index].function.arguments += tool_call.function.arguments or ""
|
|
|
|
|
continue
|
|
|
|
|
|
|
|
|
|
if not hasattr(delta, "content") or delta.content is None:
|
|
|
|
|
delta.content = ""
|
|
|
|
|
|
2026-03-10 21:13:14 +08:00
|
|
|
_reasoning = getattr(delta, "reasoning_content", None) or getattr(delta, "reasoning", None)
|
|
|
|
|
if _reasoning:
|
2025-12-01 14:24:06 +08:00
|
|
|
ans = ""
|
|
|
|
|
if not reasoning_start:
|
|
|
|
|
reasoning_start = True
|
|
|
|
|
ans = "<think>"
|
2026-03-10 21:13:14 +08:00
|
|
|
ans += _reasoning + "</think>"
|
2025-12-01 14:24:06 +08:00
|
|
|
yield ans
|
|
|
|
|
else:
|
|
|
|
|
reasoning_start = False
|
|
|
|
|
answer += delta.content
|
|
|
|
|
yield delta.content
|
|
|
|
|
|
|
|
|
|
tol = total_token_count_from_response(resp)
|
|
|
|
|
if not tol:
|
|
|
|
|
total_tokens += num_tokens_from_string(delta.content)
|
|
|
|
|
else:
|
|
|
|
|
total_tokens = tol
|
|
|
|
|
|
|
|
|
|
finish_reason = getattr(resp.choices[0], "finish_reason", "")
|
|
|
|
|
if finish_reason == "length":
|
|
|
|
|
yield self._length_stop("")
|
|
|
|
|
|
2026-03-20 20:32:00 +08:00
|
|
|
if answer and not final_tool_calls:
|
|
|
|
|
logging.info(f"[ToolLoop] round={_round} completed with text response, exiting")
|
2025-12-01 14:24:06 +08:00
|
|
|
yield total_tokens
|
|
|
|
|
return
|
|
|
|
|
|
2026-03-20 20:32:00 +08:00
|
|
|
async def _exec_tool(tc):
|
|
|
|
|
name = tc.function.name
|
2025-12-01 14:24:06 +08:00
|
|
|
try:
|
2026-03-20 20:32:00 +08:00
|
|
|
args = json_repair.loads(tc.function.arguments)
|
2026-05-20 16:56:20 +08:00
|
|
|
if not isinstance(args, dict):
|
|
|
|
|
raise TypeError(
|
|
|
|
|
f"Tool arguments for {name} must be a JSON object, got {type(args).__name__}"
|
|
|
|
|
)
|
2026-03-20 20:32:00 +08:00
|
|
|
if hasattr(self.toolcall_session, "tool_call_async"):
|
|
|
|
|
result = await self.toolcall_session.tool_call_async(name, args)
|
|
|
|
|
else:
|
|
|
|
|
result = await thread_pool_exec(self.toolcall_session.tool_call, name, args)
|
|
|
|
|
return tc, name, args, result, None
|
2025-12-01 14:24:06 +08:00
|
|
|
except Exception as e:
|
2026-03-20 20:32:00 +08:00
|
|
|
logging.exception(f"Tool call failed: {tc}")
|
|
|
|
|
return tc, name, {}, None, e
|
|
|
|
|
|
|
|
|
|
tcs = list(final_tool_calls.values())
|
|
|
|
|
logging.info(f"[ToolLoop] round={_round} executing {len(tcs)} tool(s): {[tc.function.name for tc in tcs]}")
|
|
|
|
|
for tc in tcs:
|
|
|
|
|
try:
|
|
|
|
|
args = json_repair.loads(tc.function.arguments)
|
|
|
|
|
except Exception:
|
|
|
|
|
args = {}
|
|
|
|
|
yield self._verbose_tool_use(tc.function.name, args, "Begin to call...")
|
|
|
|
|
results = await asyncio.gather(*[_exec_tool(tc) for tc in tcs])
|
|
|
|
|
history = self._append_history_batch(history, results)
|
|
|
|
|
for tc, name, args, result, err in results:
|
|
|
|
|
yield self._verbose_tool_use(name, args, err if err else result)
|
2025-12-01 14:24:06 +08:00
|
|
|
|
|
|
|
|
logging.warning(f"Exceed max rounds: {self.max_rounds}")
|
|
|
|
|
history.append({"role": "user", "content": f"Exceed max rounds: {self.max_rounds}"})
|
|
|
|
|
|
|
|
|
|
response = await self.async_client.chat.completions.create(model=self.model_name, messages=history, stream=True, tools=tools, tool_choice="auto", **gen_conf)
|
|
|
|
|
|
|
|
|
|
async for resp in response:
|
|
|
|
|
if not hasattr(resp, "choices") or not resp.choices:
|
|
|
|
|
continue
|
|
|
|
|
delta = resp.choices[0].delta
|
|
|
|
|
if not hasattr(delta, "content") or delta.content is None:
|
|
|
|
|
continue
|
|
|
|
|
tol = total_token_count_from_response(resp)
|
|
|
|
|
if not tol:
|
|
|
|
|
total_tokens += num_tokens_from_string(delta.content)
|
|
|
|
|
else:
|
|
|
|
|
total_tokens = tol
|
|
|
|
|
yield delta.content
|
|
|
|
|
|
|
|
|
|
yield total_tokens
|
|
|
|
|
return
|
|
|
|
|
|
|
|
|
|
except Exception as e:
|
|
|
|
|
e = await self._exceptions_async(e, attempt)
|
|
|
|
|
if e:
|
|
|
|
|
logging.error(f"async_chat_streamly failed: {e}")
|
|
|
|
|
yield e
|
|
|
|
|
yield total_tokens
|
|
|
|
|
return
|
|
|
|
|
|
|
|
|
|
assert False, "Shouldn't be here."
|
|
|
|
|
|
|
|
|
|
async def _async_chat(self, history, gen_conf, **kwargs):
|
|
|
|
|
logging.info("[HISTORY]" + json.dumps(history, ensure_ascii=False, indent=2))
|
|
|
|
|
if self.model_name.lower().find("qwq") >= 0:
|
|
|
|
|
logging.info(f"[INFO] {self.model_name} detected as reasoning model, using async_chat_streamly")
|
2025-12-08 09:43:03 +08:00
|
|
|
|
2025-12-01 14:24:06 +08:00
|
|
|
final_ans = ""
|
|
|
|
|
tol_token = 0
|
2025-12-08 09:43:03 +08:00
|
|
|
async for delta, tol in self._async_chat_streamly(history, gen_conf, with_reasoning=False, **kwargs):
|
2025-12-01 14:24:06 +08:00
|
|
|
if delta.startswith("<think>") or delta.endswith("</think>"):
|
|
|
|
|
continue
|
|
|
|
|
final_ans += delta
|
|
|
|
|
tol_token = tol
|
|
|
|
|
|
|
|
|
|
if len(final_ans.strip()) == 0:
|
|
|
|
|
final_ans = "**ERROR**: Empty response from reasoning model"
|
|
|
|
|
|
|
|
|
|
return final_ans.strip(), tol_token
|
|
|
|
|
|
2026-03-18 17:28:20 +08:00
|
|
|
_, kwargs = _apply_model_family_policies(
|
|
|
|
|
self.model_name,
|
|
|
|
|
backend="base",
|
|
|
|
|
request_kwargs=kwargs,
|
|
|
|
|
)
|
2025-12-01 14:24:06 +08:00
|
|
|
|
|
|
|
|
response = await self.async_client.chat.completions.create(model=self.model_name, messages=history, **gen_conf, **kwargs)
|
|
|
|
|
|
|
|
|
|
if not response.choices or not response.choices[0].message or not response.choices[0].message.content:
|
|
|
|
|
return "", 0
|
|
|
|
|
ans = response.choices[0].message.content.strip()
|
|
|
|
|
if response.choices[0].finish_reason == "length":
|
|
|
|
|
ans = self._length_stop(ans)
|
|
|
|
|
return ans, total_token_count_from_response(response)
|
|
|
|
|
|
fix(llm): replace mutable default `gen_conf={}` with None + defensive copy (#14566)
### What
19 methods across `rag/llm/chat_model.py` and `rag/llm/cv_model.py`
declare `gen_conf={}` (or `gen_conf: dict = {}`) as a parameter default
and then mutate `gen_conf` in place — typically `del
gen_conf["max_tokens"]`, `gen_conf["penalty_score"] = ...`, or
`gen_conf.pop(...)` as part of provider-specific normalization.
### The two bugs in this pattern
**1. Mutable default argument (Python footgun).** Python evaluates
default values **once** at function-definition time, so the single `{}`
dict is *shared* across every caller that doesn't pass `gen_conf`. The
first such call's mutations leak into the default seen by every
subsequent call.
```python
# Before
def chat_streamly(self, system, history, gen_conf={}, **kwargs):
if "max_tokens" in gen_conf:
del gen_conf["max_tokens"] # mutates the SHARED default dict
...
```
After call N with `max_tokens` set, call N+1 that omits `gen_conf` no
longer sees `max_tokens` — even though the caller never touched it.
**2. Caller-dict pollution.** When the caller *does* pass a `gen_conf`
dict, the same in-place mutations modify the caller's dict. A reused
`gen_conf` (very common for chat-loop callers that build the config once
and pass it on every turn) silently loses `max_tokens`,
`presence_penalty`, etc. after the first round.
### The fix
In every affected method:
- Change `gen_conf={}` (or `gen_conf: dict = {}`) → `gen_conf=None`.
- Add `gen_conf = dict(gen_conf or {})` as the first statement of the
body so all subsequent mutations operate on a fresh local copy.
```python
# After
def chat_streamly(self, system, history, gen_conf=None, **kwargs):
gen_conf = dict(gen_conf or {})
if "max_tokens" in gen_conf:
del gen_conf["max_tokens"] # local copy — safe
...
```
This is byte-for-byte identical provider-side behavior for callers that
already pass a fresh `gen_conf` per call. The new `dict(...)` copy is
O(small constant) per call.
### Files changed
- `rag/llm/chat_model.py` — 17 methods
- `rag/llm/cv_model.py` — 2 methods
### Tests
Adds `test/unit_test/rag/llm/test_gen_conf_no_mutable_default.py` — an
`ast`-based regression guard that walks both modules and asserts no
parameter named `gen_conf` ever has a mutable literal (`{}` or `[]`) as
its default. The test caught **five additional `gen_conf: dict = {}`
sites** that an initial `gen_conf={}` text grep had missed (annotated
parameters with whitespace), and would fail again if the pattern is ever
reintroduced.
```
$ pytest test/unit_test/rag/llm/test_gen_conf_no_mutable_default.py -v
============================== 3 passed in 0.04s ===============================
```
`ruff check` passes on all touched files.
### Notes
- This PR is intentionally focused on **just** the `gen_conf` default +
copy fix. There's a related (but separate) `history.insert(0, ...)`
pattern in the same files that mutates the caller's history list in 12
places — left for a follow-up so this PR stays mechanical and easy to
review.
### Latest revision (`700bb54a7`) — addresses CodeRabbit review
- Type annotation: `gen_conf: dict = None` → `gen_conf: dict | None =
None` (5 occurrences in `chat_model.py`). The old annotation was a
static-checker mismatch since `None` isn't a `dict`.
- Regression test: the AST check accessed `default.keys` directly.
`ast.List` has no `.keys` attribute — a future `gen_conf=[]` would crash
with `AttributeError` instead of being caught. Use `getattr` for both
`.keys` (Dict) and `.elts` (List). Manually verified the updated check
correctly catches both `gen_conf={}` and `gen_conf=[]` while ignoring
`gen_conf=None` and non-empty literals.
---------
Co-authored-by: Ricardo <ricardo@example.com>
2026-05-09 13:11:44 +08:00
|
|
|
async def async_chat(self, system, history, gen_conf=None, **kwargs):
|
|
|
|
|
gen_conf = dict(gen_conf or {})
|
2025-12-01 14:24:06 +08:00
|
|
|
if system and history and history[0].get("role") != "system":
|
|
|
|
|
history.insert(0, {"role": "system", "content": system})
|
|
|
|
|
gen_conf = self._clean_conf(gen_conf)
|
|
|
|
|
|
|
|
|
|
for attempt in range(self.max_retries + 1):
|
|
|
|
|
try:
|
|
|
|
|
return await self._async_chat(history, gen_conf, **kwargs)
|
|
|
|
|
except Exception as e:
|
|
|
|
|
e = await self._exceptions_async(e, attempt)
|
|
|
|
|
if e:
|
|
|
|
|
return e, 0
|
|
|
|
|
assert False, "Shouldn't be here."
|
|
|
|
|
|
2025-04-08 16:09:03 +08:00
|
|
|
|
2024-05-08 10:30:02 +08:00
|
|
|
class XinferenceChat(Base):
|
2025-07-03 19:05:31 +08:00
|
|
|
_FACTORY_NAME = "Xinference"
|
|
|
|
|
|
2025-06-11 17:20:12 +08:00
|
|
|
def __init__(self, key=None, model_name="", base_url="", **kwargs):
|
2024-07-25 10:23:35 +08:00
|
|
|
if not base_url:
|
|
|
|
|
raise ValueError("Local llm url cannot be None")
|
2025-06-03 14:18:40 +08:00
|
|
|
base_url = urljoin(base_url, "v1")
|
2025-06-11 17:20:12 +08:00
|
|
|
super().__init__(key, model_name, base_url, **kwargs)
|
2024-10-29 10:42:45 +08:00
|
|
|
|
|
|
|
|
|
2024-10-11 14:45:48 +08:00
|
|
|
class HuggingFaceChat(Base):
|
2025-07-03 19:05:31 +08:00
|
|
|
_FACTORY_NAME = "HuggingFace"
|
|
|
|
|
|
2025-06-11 17:20:12 +08:00
|
|
|
def __init__(self, key=None, model_name="", base_url="", **kwargs):
|
2024-10-11 14:45:48 +08:00
|
|
|
if not base_url:
|
|
|
|
|
raise ValueError("Local llm url cannot be None")
|
2025-06-03 14:18:40 +08:00
|
|
|
base_url = urljoin(base_url, "v1")
|
2025-06-11 17:20:12 +08:00
|
|
|
super().__init__(key, model_name.split("___")[0], base_url, **kwargs)
|
2024-05-08 10:30:02 +08:00
|
|
|
|
2024-10-29 10:42:45 +08:00
|
|
|
|
2025-02-24 10:12:20 +08:00
|
|
|
class ModelScopeChat(Base):
|
2025-07-03 19:05:31 +08:00
|
|
|
_FACTORY_NAME = "ModelScope"
|
|
|
|
|
|
2025-06-11 17:20:12 +08:00
|
|
|
def __init__(self, key=None, model_name="", base_url="", **kwargs):
|
2025-02-24 10:12:20 +08:00
|
|
|
if not base_url:
|
|
|
|
|
raise ValueError("Local llm url cannot be None")
|
2025-06-03 14:18:40 +08:00
|
|
|
base_url = urljoin(base_url, "v1")
|
2025-06-11 17:20:12 +08:00
|
|
|
super().__init__(key, model_name.split("___")[0], base_url, **kwargs)
|
2025-02-24 10:12:20 +08:00
|
|
|
|
|
|
|
|
|
2024-05-28 09:09:37 +08:00
|
|
|
class BaiChuanChat(Base):
|
2025-07-03 19:05:31 +08:00
|
|
|
_FACTORY_NAME = "BaiChuan"
|
|
|
|
|
|
2025-06-11 17:20:12 +08:00
|
|
|
def __init__(self, key, model_name="Baichuan3-Turbo", base_url="https://api.baichuan-ai.com/v1", **kwargs):
|
2024-05-28 09:09:37 +08:00
|
|
|
if not base_url:
|
|
|
|
|
base_url = "https://api.baichuan-ai.com/v1"
|
2025-06-11 17:20:12 +08:00
|
|
|
super().__init__(key, model_name, base_url, **kwargs)
|
2024-05-28 09:09:37 +08:00
|
|
|
|
|
|
|
|
@staticmethod
|
|
|
|
|
def _format_params(params):
|
|
|
|
|
return {
|
|
|
|
|
"temperature": params.get("temperature", 0.3),
|
|
|
|
|
"top_p": params.get("top_p", 0.85),
|
|
|
|
|
}
|
|
|
|
|
|
2025-06-11 17:20:12 +08:00
|
|
|
def _clean_conf(self, gen_conf):
|
|
|
|
|
return {
|
|
|
|
|
"temperature": gen_conf.get("temperature", 0.3),
|
|
|
|
|
"top_p": gen_conf.get("top_p", 0.85),
|
|
|
|
|
}
|
|
|
|
|
|
fix(llm): replace mutable default `gen_conf={}` with None + defensive copy (#14566)
### What
19 methods across `rag/llm/chat_model.py` and `rag/llm/cv_model.py`
declare `gen_conf={}` (or `gen_conf: dict = {}`) as a parameter default
and then mutate `gen_conf` in place — typically `del
gen_conf["max_tokens"]`, `gen_conf["penalty_score"] = ...`, or
`gen_conf.pop(...)` as part of provider-specific normalization.
### The two bugs in this pattern
**1. Mutable default argument (Python footgun).** Python evaluates
default values **once** at function-definition time, so the single `{}`
dict is *shared* across every caller that doesn't pass `gen_conf`. The
first such call's mutations leak into the default seen by every
subsequent call.
```python
# Before
def chat_streamly(self, system, history, gen_conf={}, **kwargs):
if "max_tokens" in gen_conf:
del gen_conf["max_tokens"] # mutates the SHARED default dict
...
```
After call N with `max_tokens` set, call N+1 that omits `gen_conf` no
longer sees `max_tokens` — even though the caller never touched it.
**2. Caller-dict pollution.** When the caller *does* pass a `gen_conf`
dict, the same in-place mutations modify the caller's dict. A reused
`gen_conf` (very common for chat-loop callers that build the config once
and pass it on every turn) silently loses `max_tokens`,
`presence_penalty`, etc. after the first round.
### The fix
In every affected method:
- Change `gen_conf={}` (or `gen_conf: dict = {}`) → `gen_conf=None`.
- Add `gen_conf = dict(gen_conf or {})` as the first statement of the
body so all subsequent mutations operate on a fresh local copy.
```python
# After
def chat_streamly(self, system, history, gen_conf=None, **kwargs):
gen_conf = dict(gen_conf or {})
if "max_tokens" in gen_conf:
del gen_conf["max_tokens"] # local copy — safe
...
```
This is byte-for-byte identical provider-side behavior for callers that
already pass a fresh `gen_conf` per call. The new `dict(...)` copy is
O(small constant) per call.
### Files changed
- `rag/llm/chat_model.py` — 17 methods
- `rag/llm/cv_model.py` — 2 methods
### Tests
Adds `test/unit_test/rag/llm/test_gen_conf_no_mutable_default.py` — an
`ast`-based regression guard that walks both modules and asserts no
parameter named `gen_conf` ever has a mutable literal (`{}` or `[]`) as
its default. The test caught **five additional `gen_conf: dict = {}`
sites** that an initial `gen_conf={}` text grep had missed (annotated
parameters with whitespace), and would fail again if the pattern is ever
reintroduced.
```
$ pytest test/unit_test/rag/llm/test_gen_conf_no_mutable_default.py -v
============================== 3 passed in 0.04s ===============================
```
`ruff check` passes on all touched files.
### Notes
- This PR is intentionally focused on **just** the `gen_conf` default +
copy fix. There's a related (but separate) `history.insert(0, ...)`
pattern in the same files that mutates the caller's history list in 12
places — left for a follow-up so this PR stays mechanical and easy to
review.
### Latest revision (`700bb54a7`) — addresses CodeRabbit review
- Type annotation: `gen_conf: dict = None` → `gen_conf: dict | None =
None` (5 occurrences in `chat_model.py`). The old annotation was a
static-checker mismatch since `None` isn't a `dict`.
- Regression test: the AST check accessed `default.keys` directly.
`ast.List` has no `.keys` attribute — a future `gen_conf=[]` would crash
with `AttributeError` instead of being caught. Use `getattr` for both
`.keys` (Dict) and `.elts` (List). Manually verified the updated check
correctly catches both `gen_conf={}` and `gen_conf=[]` while ignoring
`gen_conf=None` and non-empty literals.
---------
Co-authored-by: Ricardo <ricardo@example.com>
2026-05-09 13:11:44 +08:00
|
|
|
def _chat(self, history, gen_conf=None, **kwargs):
|
|
|
|
|
gen_conf = dict(gen_conf or {})
|
2025-09-23 16:06:12 +08:00
|
|
|
response = self.client.chat.completions.create(
|
2025-06-11 17:20:12 +08:00
|
|
|
model=self.model_name,
|
|
|
|
|
messages=history,
|
|
|
|
|
extra_body={"tools": [{"type": "web_search", "web_search": {"enable": True, "search_mode": "performance_first"}}]},
|
|
|
|
|
**gen_conf,
|
|
|
|
|
)
|
2026-05-19 22:05:52 -05:00
|
|
|
if not response.choices:
|
|
|
|
|
raise ValueError("LLM returned empty response") # pact: guard empty choices list
|
2025-06-11 17:20:12 +08:00
|
|
|
ans = response.choices[0].message.content.strip()
|
|
|
|
|
if response.choices[0].finish_reason == "length":
|
|
|
|
|
if is_chinese([ans]):
|
|
|
|
|
ans += LENGTH_NOTIFICATION_CN
|
|
|
|
|
else:
|
|
|
|
|
ans += LENGTH_NOTIFICATION_EN
|
2025-10-22 12:25:31 +08:00
|
|
|
return ans, total_token_count_from_response(response)
|
2024-05-28 09:09:37 +08:00
|
|
|
|
fix(llm): replace mutable default `gen_conf={}` with None + defensive copy (#14566)
### What
19 methods across `rag/llm/chat_model.py` and `rag/llm/cv_model.py`
declare `gen_conf={}` (or `gen_conf: dict = {}`) as a parameter default
and then mutate `gen_conf` in place — typically `del
gen_conf["max_tokens"]`, `gen_conf["penalty_score"] = ...`, or
`gen_conf.pop(...)` as part of provider-specific normalization.
### The two bugs in this pattern
**1. Mutable default argument (Python footgun).** Python evaluates
default values **once** at function-definition time, so the single `{}`
dict is *shared* across every caller that doesn't pass `gen_conf`. The
first such call's mutations leak into the default seen by every
subsequent call.
```python
# Before
def chat_streamly(self, system, history, gen_conf={}, **kwargs):
if "max_tokens" in gen_conf:
del gen_conf["max_tokens"] # mutates the SHARED default dict
...
```
After call N with `max_tokens` set, call N+1 that omits `gen_conf` no
longer sees `max_tokens` — even though the caller never touched it.
**2. Caller-dict pollution.** When the caller *does* pass a `gen_conf`
dict, the same in-place mutations modify the caller's dict. A reused
`gen_conf` (very common for chat-loop callers that build the config once
and pass it on every turn) silently loses `max_tokens`,
`presence_penalty`, etc. after the first round.
### The fix
In every affected method:
- Change `gen_conf={}` (or `gen_conf: dict = {}`) → `gen_conf=None`.
- Add `gen_conf = dict(gen_conf or {})` as the first statement of the
body so all subsequent mutations operate on a fresh local copy.
```python
# After
def chat_streamly(self, system, history, gen_conf=None, **kwargs):
gen_conf = dict(gen_conf or {})
if "max_tokens" in gen_conf:
del gen_conf["max_tokens"] # local copy — safe
...
```
This is byte-for-byte identical provider-side behavior for callers that
already pass a fresh `gen_conf` per call. The new `dict(...)` copy is
O(small constant) per call.
### Files changed
- `rag/llm/chat_model.py` — 17 methods
- `rag/llm/cv_model.py` — 2 methods
### Tests
Adds `test/unit_test/rag/llm/test_gen_conf_no_mutable_default.py` — an
`ast`-based regression guard that walks both modules and asserts no
parameter named `gen_conf` ever has a mutable literal (`{}` or `[]`) as
its default. The test caught **five additional `gen_conf: dict = {}`
sites** that an initial `gen_conf={}` text grep had missed (annotated
parameters with whitespace), and would fail again if the pattern is ever
reintroduced.
```
$ pytest test/unit_test/rag/llm/test_gen_conf_no_mutable_default.py -v
============================== 3 passed in 0.04s ===============================
```
`ruff check` passes on all touched files.
### Notes
- This PR is intentionally focused on **just** the `gen_conf` default +
copy fix. There's a related (but separate) `history.insert(0, ...)`
pattern in the same files that mutates the caller's history list in 12
places — left for a follow-up so this PR stays mechanical and easy to
review.
### Latest revision (`700bb54a7`) — addresses CodeRabbit review
- Type annotation: `gen_conf: dict = None` → `gen_conf: dict | None =
None` (5 occurrences in `chat_model.py`). The old annotation was a
static-checker mismatch since `None` isn't a `dict`.
- Regression test: the AST check accessed `default.keys` directly.
`ast.List` has no `.keys` attribute — a future `gen_conf=[]` would crash
with `AttributeError` instead of being caught. Use `getattr` for both
`.keys` (Dict) and `.elts` (List). Manually verified the updated check
correctly catches both `gen_conf={}` and `gen_conf=[]` while ignoring
`gen_conf=None` and non-empty literals.
---------
Co-authored-by: Ricardo <ricardo@example.com>
2026-05-09 13:11:44 +08:00
|
|
|
def chat_streamly(self, system, history, gen_conf=None, **kwargs):
|
|
|
|
|
gen_conf = dict(gen_conf or {})
|
Refa: revise the implementation of LightRAG and enable response caching (#9828)
### What problem does this PR solve?
This revision performed a comprehensive check on LightRAG to ensure the
correctness of its implementation. It **did not involve** Entity
Resolution and Community Reports Generation. There is an example using
default entity types and the General chunking method, which shows good
results in both time and effectiveness. Moreover, response caching is
enabled for resuming failed tasks.
[The-Necklace.pdf](https://github.com/user-attachments/files/22042432/The-Necklace.pdf)
After:

```bash
Begin at:
Fri, 29 Aug 2025 16:48:03 GMT
Duration:
222.31 s
Progress:
16:48:04 Task has been received.
16:48:06 Page(1~7): Start to parse.
16:48:06 Page(1~7): OCR started
16:48:08 Page(1~7): OCR finished (1.89s)
16:48:11 Page(1~7): Layout analysis (3.72s)
16:48:11 Page(1~7): Table analysis (0.00s)
16:48:11 Page(1~7): Text merged (0.00s)
16:48:11 Page(1~7): Finish parsing.
16:48:12 Page(1~7): Generate 7 chunks
16:48:12 Page(1~7): Embedding chunks (0.29s)
16:48:12 Page(1~7): Indexing done (0.04s). Task done (7.84s)
16:48:17 Start processing for f421fb06849e11f0bdd32724b93a52b2: She had no dresses, no je...
16:48:17 Start processing for f421fb06849e11f0bdd32724b93a52b2: Her husband, already half...
16:48:17 Start processing for f421fb06849e11f0bdd32724b93a52b2: And this life lasted ten ...
16:48:17 Start processing for f421fb06849e11f0bdd32724b93a52b2: Then she asked, hesitatin...
16:49:30 Completed processing for f421fb06849e11f0bdd32724b93a52b2: She had no dresses, no je... after 1 gleanings, 21985 tokens.
16:49:30 Entities extraction of chunk 3 1/7 done, 12 nodes, 13 edges, 21985 tokens.
16:49:40 Completed processing for f421fb06849e11f0bdd32724b93a52b2: Finally, she replied, hes... after 1 gleanings, 22584 tokens.
16:49:40 Entities extraction of chunk 5 2/7 done, 19 nodes, 19 edges, 22584 tokens.
16:50:02 Completed processing for f421fb06849e11f0bdd32724b93a52b2: Then she asked, hesitatin... after 1 gleanings, 24610 tokens.
16:50:02 Entities extraction of chunk 0 3/7 done, 16 nodes, 28 edges, 24610 tokens.
16:50:03 Completed processing for f421fb06849e11f0bdd32724b93a52b2: And this life lasted ten ... after 1 gleanings, 24031 tokens.
16:50:04 Entities extraction of chunk 1 4/7 done, 24 nodes, 22 edges, 24031 tokens.
16:50:14 Completed processing for f421fb06849e11f0bdd32724b93a52b2: So they begged the jewell... after 1 gleanings, 24635 tokens.
16:50:14 Entities extraction of chunk 6 5/7 done, 27 nodes, 26 edges, 24635 tokens.
16:50:29 Completed processing for f421fb06849e11f0bdd32724b93a52b2: Her husband, already half... after 1 gleanings, 25758 tokens.
16:50:29 Entities extraction of chunk 2 6/7 done, 25 nodes, 35 edges, 25758 tokens.
16:51:35 Completed processing for f421fb06849e11f0bdd32724b93a52b2: The Necklace By Guy de Ma... after 1 gleanings, 27491 tokens.
16:51:35 Entities extraction of chunk 4 7/7 done, 39 nodes, 37 edges, 27491 tokens.
16:51:35 Entities and relationships extraction done, 147 nodes, 177 edges, 171094 tokens, 198.58s.
16:51:35 Entities merging done, 0.01s.
16:51:35 Relationships merging done, 0.01s.
16:51:35 ignored 7 relations due to missing entities.
16:51:35 generated subgraph for doc f421fb06849e11f0bdd32724b93a52b2 in 198.68 seconds.
16:51:35 run_graphrag f421fb06849e11f0bdd32724b93a52b2 graphrag_task_lock acquired
16:51:35 set_graph removed 0 nodes and 0 edges from index in 0.00s.
16:51:35 Get embedding of nodes: 9/147
16:51:35 Get embedding of nodes: 109/147
16:51:37 Get embedding of edges: 9/170
16:51:37 Get embedding of edges: 109/170
16:51:40 set_graph converted graph change to 319 chunks in 4.21s.
16:51:40 Insert chunks: 4/319
16:51:40 Insert chunks: 104/319
16:51:40 Insert chunks: 204/319
16:51:40 Insert chunks: 304/319
16:51:40 set_graph added/updated 147 nodes and 170 edges from index in 0.53s.
16:51:40 merging subgraph for doc f421fb06849e11f0bdd32724b93a52b2 into the global graph done in 4.79 seconds.
16:51:40 Knowledge Graph done (204.29s)
```
Before:

```bash
Begin at:
Fri, 29 Aug 2025 17:00:47 GMT
processDuration:
173.38 s
Progress:
17:00:49 Task has been received.
17:00:51 Page(1~7): Start to parse.
17:00:51 Page(1~7): OCR started
17:00:53 Page(1~7): OCR finished (1.82s)
17:00:57 Page(1~7): Layout analysis (3.64s)
17:00:57 Page(1~7): Table analysis (0.00s)
17:00:57 Page(1~7): Text merged (0.00s)
17:00:57 Page(1~7): Finish parsing.
17:00:57 Page(1~7): Generate 7 chunks
17:00:57 Page(1~7): Embedding chunks (0.31s)
17:00:57 Page(1~7): Indexing done (0.03s). Task done (7.88s)
17:00:57 created task graphrag
17:01:00 Task has been received.
17:02:17 Entities extraction of chunk 1 1/7 done, 9 nodes, 9 edges, 10654 tokens.
17:02:31 Entities extraction of chunk 2 2/7 done, 12 nodes, 13 edges, 11066 tokens.
17:02:33 Entities extraction of chunk 4 3/7 done, 9 nodes, 10 edges, 10433 tokens.
17:02:42 Entities extraction of chunk 5 4/7 done, 11 nodes, 14 edges, 11290 tokens.
17:02:52 Entities extraction of chunk 6 5/7 done, 13 nodes, 15 edges, 11039 tokens.
17:02:55 Entities extraction of chunk 3 6/7 done, 14 nodes, 13 edges, 11466 tokens.
17:03:32 Entities extraction of chunk 0 7/7 done, 19 nodes, 18 edges, 13107 tokens.
17:03:32 Entities and relationships extraction done, 71 nodes, 89 edges, 79055 tokens, 149.66s.
17:03:32 Entities merging done, 0.01s.
17:03:32 Relationships merging done, 0.01s.
17:03:32 ignored 1 relations due to missing entities.
17:03:32 generated subgraph for doc b1d9d3b6848711f0aacd7ddc0714c4d3 in 149.69 seconds.
17:03:32 run_graphrag b1d9d3b6848711f0aacd7ddc0714c4d3 graphrag_task_lock acquired
17:03:32 set_graph removed 0 nodes and 0 edges from index in 0.00s.
17:03:32 Get embedding of nodes: 9/71
17:03:33 Get embedding of edges: 9/88
17:03:34 set_graph converted graph change to 161 chunks in 2.27s.
17:03:34 Insert chunks: 4/161
17:03:34 Insert chunks: 104/161
17:03:34 set_graph added/updated 71 nodes and 88 edges from index in 0.28s.
17:03:34 merging subgraph for doc b1d9d3b6848711f0aacd7ddc0714c4d3 into the global graph done in 2.60 seconds.
17:03:34 Knowledge Graph done (153.18s)
```
### Type of change
- [x] Bug Fix (non-breaking change which fixes an issue)
- [x] Refactoring
- [x] Performance Improvement
2025-08-29 17:58:36 +08:00
|
|
|
if system and history and history[0].get("role") != "system":
|
2024-05-28 09:09:37 +08:00
|
|
|
history.insert(0, {"role": "system", "content": system})
|
2025-03-06 11:29:40 +08:00
|
|
|
if "max_tokens" in gen_conf:
|
|
|
|
|
del gen_conf["max_tokens"]
|
2024-05-28 09:09:37 +08:00
|
|
|
ans = ""
|
|
|
|
|
total_tokens = 0
|
|
|
|
|
try:
|
2025-09-23 16:06:12 +08:00
|
|
|
response = self.client.chat.completions.create(
|
2024-05-28 09:09:37 +08:00
|
|
|
model=self.model_name,
|
|
|
|
|
messages=history,
|
2025-03-26 19:33:14 +08:00
|
|
|
extra_body={"tools": [{"type": "web_search", "web_search": {"enable": True, "search_mode": "performance_first"}}]},
|
2024-05-28 09:09:37 +08:00
|
|
|
stream=True,
|
2025-03-26 19:33:14 +08:00
|
|
|
**self._format_params(gen_conf),
|
|
|
|
|
)
|
2024-05-28 09:09:37 +08:00
|
|
|
for resp in response:
|
2024-12-08 14:21:12 +08:00
|
|
|
if not resp.choices:
|
|
|
|
|
continue
|
2024-05-28 09:09:37 +08:00
|
|
|
if not resp.choices[0].delta.content:
|
2024-10-08 18:27:04 +08:00
|
|
|
resp.choices[0].delta.content = ""
|
2025-03-26 19:33:14 +08:00
|
|
|
ans = resp.choices[0].delta.content
|
2025-10-22 12:25:31 +08:00
|
|
|
tol = total_token_count_from_response(resp)
|
2025-01-26 13:54:26 +08:00
|
|
|
if not tol:
|
|
|
|
|
total_tokens += num_tokens_from_string(resp.choices[0].delta.content)
|
|
|
|
|
else:
|
|
|
|
|
total_tokens = tol
|
2024-05-28 09:09:37 +08:00
|
|
|
if resp.choices[0].finish_reason == "length":
|
2024-12-04 09:34:49 +08:00
|
|
|
if is_chinese([ans]):
|
|
|
|
|
ans += LENGTH_NOTIFICATION_CN
|
|
|
|
|
else:
|
|
|
|
|
ans += LENGTH_NOTIFICATION_EN
|
2024-05-28 09:09:37 +08:00
|
|
|
yield ans
|
|
|
|
|
|
|
|
|
|
except Exception as e:
|
|
|
|
|
yield ans + "\n**ERROR**: " + str(e)
|
|
|
|
|
|
|
|
|
|
yield total_tokens
|
|
|
|
|
|
|
|
|
|
|
2024-07-19 15:50:28 +08:00
|
|
|
class LocalAIChat(Base):
|
2025-07-03 19:05:31 +08:00
|
|
|
_FACTORY_NAME = "LocalAI"
|
|
|
|
|
|
2025-06-11 17:20:12 +08:00
|
|
|
def __init__(self, key, model_name, base_url=None, **kwargs):
|
|
|
|
|
super().__init__(key, model_name, base_url=base_url, **kwargs)
|
2025-04-08 16:09:03 +08:00
|
|
|
|
2024-07-25 10:23:35 +08:00
|
|
|
if not base_url:
|
|
|
|
|
raise ValueError("Local llm url cannot be None")
|
2025-06-03 14:18:40 +08:00
|
|
|
base_url = urljoin(base_url, "v1")
|
2024-08-07 18:10:42 +08:00
|
|
|
self.client = OpenAI(api_key="empty", base_url=base_url)
|
2024-07-19 15:50:28 +08:00
|
|
|
self.model_name = model_name.split("___")[0]
|
|
|
|
|
|
|
|
|
|
|
2024-05-20 12:23:51 +08:00
|
|
|
class LocalLLM(Base):
|
2025-06-11 17:20:12 +08:00
|
|
|
def __init__(self, key, model_name, base_url=None, **kwargs):
|
|
|
|
|
super().__init__(key, model_name, base_url=base_url, **kwargs)
|
2024-07-30 14:07:00 +08:00
|
|
|
from jina import Client
|
2025-06-23 15:59:25 +08:00
|
|
|
|
2024-07-30 14:07:00 +08:00
|
|
|
self.client = Client(port=12345, protocol="grpc", asyncio=True)
|
2024-05-20 12:40:59 +08:00
|
|
|
|
2024-07-30 14:07:00 +08:00
|
|
|
def _prepare_prompt(self, system, history, gen_conf):
|
2024-11-29 14:52:27 +08:00
|
|
|
from rag.svr.jina_server import Prompt
|
2025-03-26 19:33:14 +08:00
|
|
|
|
Refa: revise the implementation of LightRAG and enable response caching (#9828)
### What problem does this PR solve?
This revision performed a comprehensive check on LightRAG to ensure the
correctness of its implementation. It **did not involve** Entity
Resolution and Community Reports Generation. There is an example using
default entity types and the General chunking method, which shows good
results in both time and effectiveness. Moreover, response caching is
enabled for resuming failed tasks.
[The-Necklace.pdf](https://github.com/user-attachments/files/22042432/The-Necklace.pdf)
After:

```bash
Begin at:
Fri, 29 Aug 2025 16:48:03 GMT
Duration:
222.31 s
Progress:
16:48:04 Task has been received.
16:48:06 Page(1~7): Start to parse.
16:48:06 Page(1~7): OCR started
16:48:08 Page(1~7): OCR finished (1.89s)
16:48:11 Page(1~7): Layout analysis (3.72s)
16:48:11 Page(1~7): Table analysis (0.00s)
16:48:11 Page(1~7): Text merged (0.00s)
16:48:11 Page(1~7): Finish parsing.
16:48:12 Page(1~7): Generate 7 chunks
16:48:12 Page(1~7): Embedding chunks (0.29s)
16:48:12 Page(1~7): Indexing done (0.04s). Task done (7.84s)
16:48:17 Start processing for f421fb06849e11f0bdd32724b93a52b2: She had no dresses, no je...
16:48:17 Start processing for f421fb06849e11f0bdd32724b93a52b2: Her husband, already half...
16:48:17 Start processing for f421fb06849e11f0bdd32724b93a52b2: And this life lasted ten ...
16:48:17 Start processing for f421fb06849e11f0bdd32724b93a52b2: Then she asked, hesitatin...
16:49:30 Completed processing for f421fb06849e11f0bdd32724b93a52b2: She had no dresses, no je... after 1 gleanings, 21985 tokens.
16:49:30 Entities extraction of chunk 3 1/7 done, 12 nodes, 13 edges, 21985 tokens.
16:49:40 Completed processing for f421fb06849e11f0bdd32724b93a52b2: Finally, she replied, hes... after 1 gleanings, 22584 tokens.
16:49:40 Entities extraction of chunk 5 2/7 done, 19 nodes, 19 edges, 22584 tokens.
16:50:02 Completed processing for f421fb06849e11f0bdd32724b93a52b2: Then she asked, hesitatin... after 1 gleanings, 24610 tokens.
16:50:02 Entities extraction of chunk 0 3/7 done, 16 nodes, 28 edges, 24610 tokens.
16:50:03 Completed processing for f421fb06849e11f0bdd32724b93a52b2: And this life lasted ten ... after 1 gleanings, 24031 tokens.
16:50:04 Entities extraction of chunk 1 4/7 done, 24 nodes, 22 edges, 24031 tokens.
16:50:14 Completed processing for f421fb06849e11f0bdd32724b93a52b2: So they begged the jewell... after 1 gleanings, 24635 tokens.
16:50:14 Entities extraction of chunk 6 5/7 done, 27 nodes, 26 edges, 24635 tokens.
16:50:29 Completed processing for f421fb06849e11f0bdd32724b93a52b2: Her husband, already half... after 1 gleanings, 25758 tokens.
16:50:29 Entities extraction of chunk 2 6/7 done, 25 nodes, 35 edges, 25758 tokens.
16:51:35 Completed processing for f421fb06849e11f0bdd32724b93a52b2: The Necklace By Guy de Ma... after 1 gleanings, 27491 tokens.
16:51:35 Entities extraction of chunk 4 7/7 done, 39 nodes, 37 edges, 27491 tokens.
16:51:35 Entities and relationships extraction done, 147 nodes, 177 edges, 171094 tokens, 198.58s.
16:51:35 Entities merging done, 0.01s.
16:51:35 Relationships merging done, 0.01s.
16:51:35 ignored 7 relations due to missing entities.
16:51:35 generated subgraph for doc f421fb06849e11f0bdd32724b93a52b2 in 198.68 seconds.
16:51:35 run_graphrag f421fb06849e11f0bdd32724b93a52b2 graphrag_task_lock acquired
16:51:35 set_graph removed 0 nodes and 0 edges from index in 0.00s.
16:51:35 Get embedding of nodes: 9/147
16:51:35 Get embedding of nodes: 109/147
16:51:37 Get embedding of edges: 9/170
16:51:37 Get embedding of edges: 109/170
16:51:40 set_graph converted graph change to 319 chunks in 4.21s.
16:51:40 Insert chunks: 4/319
16:51:40 Insert chunks: 104/319
16:51:40 Insert chunks: 204/319
16:51:40 Insert chunks: 304/319
16:51:40 set_graph added/updated 147 nodes and 170 edges from index in 0.53s.
16:51:40 merging subgraph for doc f421fb06849e11f0bdd32724b93a52b2 into the global graph done in 4.79 seconds.
16:51:40 Knowledge Graph done (204.29s)
```
Before:

```bash
Begin at:
Fri, 29 Aug 2025 17:00:47 GMT
processDuration:
173.38 s
Progress:
17:00:49 Task has been received.
17:00:51 Page(1~7): Start to parse.
17:00:51 Page(1~7): OCR started
17:00:53 Page(1~7): OCR finished (1.82s)
17:00:57 Page(1~7): Layout analysis (3.64s)
17:00:57 Page(1~7): Table analysis (0.00s)
17:00:57 Page(1~7): Text merged (0.00s)
17:00:57 Page(1~7): Finish parsing.
17:00:57 Page(1~7): Generate 7 chunks
17:00:57 Page(1~7): Embedding chunks (0.31s)
17:00:57 Page(1~7): Indexing done (0.03s). Task done (7.88s)
17:00:57 created task graphrag
17:01:00 Task has been received.
17:02:17 Entities extraction of chunk 1 1/7 done, 9 nodes, 9 edges, 10654 tokens.
17:02:31 Entities extraction of chunk 2 2/7 done, 12 nodes, 13 edges, 11066 tokens.
17:02:33 Entities extraction of chunk 4 3/7 done, 9 nodes, 10 edges, 10433 tokens.
17:02:42 Entities extraction of chunk 5 4/7 done, 11 nodes, 14 edges, 11290 tokens.
17:02:52 Entities extraction of chunk 6 5/7 done, 13 nodes, 15 edges, 11039 tokens.
17:02:55 Entities extraction of chunk 3 6/7 done, 14 nodes, 13 edges, 11466 tokens.
17:03:32 Entities extraction of chunk 0 7/7 done, 19 nodes, 18 edges, 13107 tokens.
17:03:32 Entities and relationships extraction done, 71 nodes, 89 edges, 79055 tokens, 149.66s.
17:03:32 Entities merging done, 0.01s.
17:03:32 Relationships merging done, 0.01s.
17:03:32 ignored 1 relations due to missing entities.
17:03:32 generated subgraph for doc b1d9d3b6848711f0aacd7ddc0714c4d3 in 149.69 seconds.
17:03:32 run_graphrag b1d9d3b6848711f0aacd7ddc0714c4d3 graphrag_task_lock acquired
17:03:32 set_graph removed 0 nodes and 0 edges from index in 0.00s.
17:03:32 Get embedding of nodes: 9/71
17:03:33 Get embedding of edges: 9/88
17:03:34 set_graph converted graph change to 161 chunks in 2.27s.
17:03:34 Insert chunks: 4/161
17:03:34 Insert chunks: 104/161
17:03:34 set_graph added/updated 71 nodes and 88 edges from index in 0.28s.
17:03:34 merging subgraph for doc b1d9d3b6848711f0aacd7ddc0714c4d3 into the global graph done in 2.60 seconds.
17:03:34 Knowledge Graph done (153.18s)
```
### Type of change
- [x] Bug Fix (non-breaking change which fixes an issue)
- [x] Refactoring
- [x] Performance Improvement
2025-08-29 17:58:36 +08:00
|
|
|
if system and history and history[0].get("role") != "system":
|
2024-05-20 12:40:59 +08:00
|
|
|
history.insert(0, {"role": "system", "content": system})
|
2024-07-30 14:07:00 +08:00
|
|
|
return Prompt(message=history, gen_conf=gen_conf)
|
|
|
|
|
|
|
|
|
|
def _stream_response(self, endpoint, prompt):
|
2024-11-29 14:52:27 +08:00
|
|
|
from rag.svr.jina_server import Generation
|
2025-03-26 19:33:14 +08:00
|
|
|
|
2024-05-20 12:40:59 +08:00
|
|
|
answer = ""
|
2026-05-25 16:45:40 +02:00
|
|
|
loop = asyncio.new_event_loop()
|
2024-05-20 12:40:59 +08:00
|
|
|
try:
|
2025-03-26 19:33:14 +08:00
|
|
|
res = self.client.stream_doc(on=endpoint, inputs=prompt, return_type=Generation)
|
2024-07-30 14:07:00 +08:00
|
|
|
try:
|
|
|
|
|
while True:
|
|
|
|
|
answer = loop.run_until_complete(res.__anext__()).text
|
|
|
|
|
yield answer
|
|
|
|
|
except StopAsyncIteration:
|
|
|
|
|
pass
|
2024-05-20 12:40:59 +08:00
|
|
|
except Exception as e:
|
|
|
|
|
yield answer + "\n**ERROR**: " + str(e)
|
2026-05-25 16:45:40 +02:00
|
|
|
finally:
|
|
|
|
|
loop.close()
|
2024-07-30 14:07:00 +08:00
|
|
|
yield num_tokens_from_string(answer)
|
2024-05-20 12:40:59 +08:00
|
|
|
|
fix(llm): replace mutable default `gen_conf={}` with None + defensive copy (#14566)
### What
19 methods across `rag/llm/chat_model.py` and `rag/llm/cv_model.py`
declare `gen_conf={}` (or `gen_conf: dict = {}`) as a parameter default
and then mutate `gen_conf` in place — typically `del
gen_conf["max_tokens"]`, `gen_conf["penalty_score"] = ...`, or
`gen_conf.pop(...)` as part of provider-specific normalization.
### The two bugs in this pattern
**1. Mutable default argument (Python footgun).** Python evaluates
default values **once** at function-definition time, so the single `{}`
dict is *shared* across every caller that doesn't pass `gen_conf`. The
first such call's mutations leak into the default seen by every
subsequent call.
```python
# Before
def chat_streamly(self, system, history, gen_conf={}, **kwargs):
if "max_tokens" in gen_conf:
del gen_conf["max_tokens"] # mutates the SHARED default dict
...
```
After call N with `max_tokens` set, call N+1 that omits `gen_conf` no
longer sees `max_tokens` — even though the caller never touched it.
**2. Caller-dict pollution.** When the caller *does* pass a `gen_conf`
dict, the same in-place mutations modify the caller's dict. A reused
`gen_conf` (very common for chat-loop callers that build the config once
and pass it on every turn) silently loses `max_tokens`,
`presence_penalty`, etc. after the first round.
### The fix
In every affected method:
- Change `gen_conf={}` (or `gen_conf: dict = {}`) → `gen_conf=None`.
- Add `gen_conf = dict(gen_conf or {})` as the first statement of the
body so all subsequent mutations operate on a fresh local copy.
```python
# After
def chat_streamly(self, system, history, gen_conf=None, **kwargs):
gen_conf = dict(gen_conf or {})
if "max_tokens" in gen_conf:
del gen_conf["max_tokens"] # local copy — safe
...
```
This is byte-for-byte identical provider-side behavior for callers that
already pass a fresh `gen_conf` per call. The new `dict(...)` copy is
O(small constant) per call.
### Files changed
- `rag/llm/chat_model.py` — 17 methods
- `rag/llm/cv_model.py` — 2 methods
### Tests
Adds `test/unit_test/rag/llm/test_gen_conf_no_mutable_default.py` — an
`ast`-based regression guard that walks both modules and asserts no
parameter named `gen_conf` ever has a mutable literal (`{}` or `[]`) as
its default. The test caught **five additional `gen_conf: dict = {}`
sites** that an initial `gen_conf={}` text grep had missed (annotated
parameters with whitespace), and would fail again if the pattern is ever
reintroduced.
```
$ pytest test/unit_test/rag/llm/test_gen_conf_no_mutable_default.py -v
============================== 3 passed in 0.04s ===============================
```
`ruff check` passes on all touched files.
### Notes
- This PR is intentionally focused on **just** the `gen_conf` default +
copy fix. There's a related (but separate) `history.insert(0, ...)`
pattern in the same files that mutates the caller's history list in 12
places — left for a follow-up so this PR stays mechanical and easy to
review.
### Latest revision (`700bb54a7`) — addresses CodeRabbit review
- Type annotation: `gen_conf: dict = None` → `gen_conf: dict | None =
None` (5 occurrences in `chat_model.py`). The old annotation was a
static-checker mismatch since `None` isn't a `dict`.
- Regression test: the AST check accessed `default.keys` directly.
`ast.List` has no `.keys` attribute — a future `gen_conf=[]` would crash
with `AttributeError` instead of being caught. Use `getattr` for both
`.keys` (Dict) and `.elts` (List). Manually verified the updated check
correctly catches both `gen_conf={}` and `gen_conf=[]` while ignoring
`gen_conf=None` and non-empty literals.
---------
Co-authored-by: Ricardo <ricardo@example.com>
2026-05-09 13:11:44 +08:00
|
|
|
def chat(self, system, history, gen_conf=None, **kwargs):
|
|
|
|
|
gen_conf = dict(gen_conf or {})
|
2025-03-06 11:29:40 +08:00
|
|
|
if "max_tokens" in gen_conf:
|
|
|
|
|
del gen_conf["max_tokens"]
|
2024-07-30 14:07:00 +08:00
|
|
|
prompt = self._prepare_prompt(system, history, gen_conf)
|
|
|
|
|
chat_gen = self._stream_response("/chat", prompt)
|
|
|
|
|
ans = next(chat_gen)
|
|
|
|
|
total_tokens = next(chat_gen)
|
|
|
|
|
return ans, total_tokens
|
|
|
|
|
|
fix(llm): replace mutable default `gen_conf={}` with None + defensive copy (#14566)
### What
19 methods across `rag/llm/chat_model.py` and `rag/llm/cv_model.py`
declare `gen_conf={}` (or `gen_conf: dict = {}`) as a parameter default
and then mutate `gen_conf` in place — typically `del
gen_conf["max_tokens"]`, `gen_conf["penalty_score"] = ...`, or
`gen_conf.pop(...)` as part of provider-specific normalization.
### The two bugs in this pattern
**1. Mutable default argument (Python footgun).** Python evaluates
default values **once** at function-definition time, so the single `{}`
dict is *shared* across every caller that doesn't pass `gen_conf`. The
first such call's mutations leak into the default seen by every
subsequent call.
```python
# Before
def chat_streamly(self, system, history, gen_conf={}, **kwargs):
if "max_tokens" in gen_conf:
del gen_conf["max_tokens"] # mutates the SHARED default dict
...
```
After call N with `max_tokens` set, call N+1 that omits `gen_conf` no
longer sees `max_tokens` — even though the caller never touched it.
**2. Caller-dict pollution.** When the caller *does* pass a `gen_conf`
dict, the same in-place mutations modify the caller's dict. A reused
`gen_conf` (very common for chat-loop callers that build the config once
and pass it on every turn) silently loses `max_tokens`,
`presence_penalty`, etc. after the first round.
### The fix
In every affected method:
- Change `gen_conf={}` (or `gen_conf: dict = {}`) → `gen_conf=None`.
- Add `gen_conf = dict(gen_conf or {})` as the first statement of the
body so all subsequent mutations operate on a fresh local copy.
```python
# After
def chat_streamly(self, system, history, gen_conf=None, **kwargs):
gen_conf = dict(gen_conf or {})
if "max_tokens" in gen_conf:
del gen_conf["max_tokens"] # local copy — safe
...
```
This is byte-for-byte identical provider-side behavior for callers that
already pass a fresh `gen_conf` per call. The new `dict(...)` copy is
O(small constant) per call.
### Files changed
- `rag/llm/chat_model.py` — 17 methods
- `rag/llm/cv_model.py` — 2 methods
### Tests
Adds `test/unit_test/rag/llm/test_gen_conf_no_mutable_default.py` — an
`ast`-based regression guard that walks both modules and asserts no
parameter named `gen_conf` ever has a mutable literal (`{}` or `[]`) as
its default. The test caught **five additional `gen_conf: dict = {}`
sites** that an initial `gen_conf={}` text grep had missed (annotated
parameters with whitespace), and would fail again if the pattern is ever
reintroduced.
```
$ pytest test/unit_test/rag/llm/test_gen_conf_no_mutable_default.py -v
============================== 3 passed in 0.04s ===============================
```
`ruff check` passes on all touched files.
### Notes
- This PR is intentionally focused on **just** the `gen_conf` default +
copy fix. There's a related (but separate) `history.insert(0, ...)`
pattern in the same files that mutates the caller's history list in 12
places — left for a follow-up so this PR stays mechanical and easy to
review.
### Latest revision (`700bb54a7`) — addresses CodeRabbit review
- Type annotation: `gen_conf: dict = None` → `gen_conf: dict | None =
None` (5 occurrences in `chat_model.py`). The old annotation was a
static-checker mismatch since `None` isn't a `dict`.
- Regression test: the AST check accessed `default.keys` directly.
`ast.List` has no `.keys` attribute — a future `gen_conf=[]` would crash
with `AttributeError` instead of being caught. Use `getattr` for both
`.keys` (Dict) and `.elts` (List). Manually verified the updated check
correctly catches both `gen_conf={}` and `gen_conf=[]` while ignoring
`gen_conf=None` and non-empty literals.
---------
Co-authored-by: Ricardo <ricardo@example.com>
2026-05-09 13:11:44 +08:00
|
|
|
def chat_streamly(self, system, history, gen_conf=None, **kwargs):
|
|
|
|
|
gen_conf = dict(gen_conf or {})
|
2025-03-06 11:29:40 +08:00
|
|
|
if "max_tokens" in gen_conf:
|
|
|
|
|
del gen_conf["max_tokens"]
|
2024-07-30 14:07:00 +08:00
|
|
|
prompt = self._prepare_prompt(system, history, gen_conf)
|
|
|
|
|
return self._stream_response("/stream", prompt)
|
2024-05-23 11:15:29 +08:00
|
|
|
|
|
|
|
|
|
|
|
|
|
class VolcEngineChat(Base):
|
2025-07-03 19:05:31 +08:00
|
|
|
_FACTORY_NAME = "VolcEngine"
|
|
|
|
|
|
2025-06-11 17:20:12 +08:00
|
|
|
def __init__(self, key, model_name, base_url="https://ark.cn-beijing.volces.com/api/v3", **kwargs):
|
2024-05-23 11:15:29 +08:00
|
|
|
"""
|
|
|
|
|
Since do not want to modify the original database fields, and the VolcEngine authentication method is quite special,
|
2024-08-26 13:34:29 +08:00
|
|
|
Assemble ark_api_key, ep_id into api_key, store it as a dictionary type, and parse it for use
|
2024-05-23 11:15:29 +08:00
|
|
|
model_name is for display only
|
|
|
|
|
"""
|
2025-03-26 19:33:14 +08:00
|
|
|
base_url = base_url if base_url else "https://ark.cn-beijing.volces.com/api/v3"
|
2026-06-05 09:45:44 +08:00
|
|
|
try:
|
|
|
|
|
ark_api_key = json.loads(key).get("ark_api_key", "")
|
|
|
|
|
model_name = json.loads(key).get("ep_id", "") + json.loads(key).get("endpoint_id", "")
|
|
|
|
|
super().__init__(ark_api_key, model_name, base_url, **kwargs)
|
|
|
|
|
except JSONDecodeError:
|
|
|
|
|
super().__init__(key, model_name, base_url, **kwargs)
|
2024-05-31 16:38:53 +08:00
|
|
|
|
|
|
|
|
|
2024-06-14 11:32:58 +08:00
|
|
|
class MistralChat(Base):
|
2025-07-03 19:05:31 +08:00
|
|
|
_FACTORY_NAME = "Mistral"
|
|
|
|
|
|
2025-06-11 17:20:12 +08:00
|
|
|
def __init__(self, key, model_name, base_url=None, **kwargs):
|
|
|
|
|
super().__init__(key, model_name, base_url=base_url, **kwargs)
|
2025-04-08 16:09:03 +08:00
|
|
|
|
2024-06-14 11:32:58 +08:00
|
|
|
from mistralai.client import MistralClient
|
2025-03-26 19:33:14 +08:00
|
|
|
|
2024-06-14 11:32:58 +08:00
|
|
|
self.client = MistralClient(api_key=key)
|
|
|
|
|
self.model_name = model_name
|
|
|
|
|
|
2025-06-11 17:20:12 +08:00
|
|
|
def _clean_conf(self, gen_conf):
|
2024-06-14 11:32:58 +08:00
|
|
|
for k in list(gen_conf.keys()):
|
|
|
|
|
if k not in ["temperature", "top_p", "max_tokens"]:
|
|
|
|
|
del gen_conf[k]
|
2025-06-11 17:20:12 +08:00
|
|
|
return gen_conf
|
|
|
|
|
|
fix(llm): replace mutable default `gen_conf={}` with None + defensive copy (#14566)
### What
19 methods across `rag/llm/chat_model.py` and `rag/llm/cv_model.py`
declare `gen_conf={}` (or `gen_conf: dict = {}`) as a parameter default
and then mutate `gen_conf` in place — typically `del
gen_conf["max_tokens"]`, `gen_conf["penalty_score"] = ...`, or
`gen_conf.pop(...)` as part of provider-specific normalization.
### The two bugs in this pattern
**1. Mutable default argument (Python footgun).** Python evaluates
default values **once** at function-definition time, so the single `{}`
dict is *shared* across every caller that doesn't pass `gen_conf`. The
first such call's mutations leak into the default seen by every
subsequent call.
```python
# Before
def chat_streamly(self, system, history, gen_conf={}, **kwargs):
if "max_tokens" in gen_conf:
del gen_conf["max_tokens"] # mutates the SHARED default dict
...
```
After call N with `max_tokens` set, call N+1 that omits `gen_conf` no
longer sees `max_tokens` — even though the caller never touched it.
**2. Caller-dict pollution.** When the caller *does* pass a `gen_conf`
dict, the same in-place mutations modify the caller's dict. A reused
`gen_conf` (very common for chat-loop callers that build the config once
and pass it on every turn) silently loses `max_tokens`,
`presence_penalty`, etc. after the first round.
### The fix
In every affected method:
- Change `gen_conf={}` (or `gen_conf: dict = {}`) → `gen_conf=None`.
- Add `gen_conf = dict(gen_conf or {})` as the first statement of the
body so all subsequent mutations operate on a fresh local copy.
```python
# After
def chat_streamly(self, system, history, gen_conf=None, **kwargs):
gen_conf = dict(gen_conf or {})
if "max_tokens" in gen_conf:
del gen_conf["max_tokens"] # local copy — safe
...
```
This is byte-for-byte identical provider-side behavior for callers that
already pass a fresh `gen_conf` per call. The new `dict(...)` copy is
O(small constant) per call.
### Files changed
- `rag/llm/chat_model.py` — 17 methods
- `rag/llm/cv_model.py` — 2 methods
### Tests
Adds `test/unit_test/rag/llm/test_gen_conf_no_mutable_default.py` — an
`ast`-based regression guard that walks both modules and asserts no
parameter named `gen_conf` ever has a mutable literal (`{}` or `[]`) as
its default. The test caught **five additional `gen_conf: dict = {}`
sites** that an initial `gen_conf={}` text grep had missed (annotated
parameters with whitespace), and would fail again if the pattern is ever
reintroduced.
```
$ pytest test/unit_test/rag/llm/test_gen_conf_no_mutable_default.py -v
============================== 3 passed in 0.04s ===============================
```
`ruff check` passes on all touched files.
### Notes
- This PR is intentionally focused on **just** the `gen_conf` default +
copy fix. There's a related (but separate) `history.insert(0, ...)`
pattern in the same files that mutates the caller's history list in 12
places — left for a follow-up so this PR stays mechanical and easy to
review.
### Latest revision (`700bb54a7`) — addresses CodeRabbit review
- Type annotation: `gen_conf: dict = None` → `gen_conf: dict | None =
None` (5 occurrences in `chat_model.py`). The old annotation was a
static-checker mismatch since `None` isn't a `dict`.
- Regression test: the AST check accessed `default.keys` directly.
`ast.List` has no `.keys` attribute — a future `gen_conf=[]` would crash
with `AttributeError` instead of being caught. Use `getattr` for both
`.keys` (Dict) and `.elts` (List). Manually verified the updated check
correctly catches both `gen_conf={}` and `gen_conf=[]` while ignoring
`gen_conf=None` and non-empty literals.
---------
Co-authored-by: Ricardo <ricardo@example.com>
2026-05-09 13:11:44 +08:00
|
|
|
def _chat(self, history, gen_conf=None, **kwargs):
|
|
|
|
|
gen_conf = dict(gen_conf or {})
|
2025-09-24 10:49:34 +08:00
|
|
|
gen_conf = self._clean_conf(gen_conf)
|
2025-06-11 17:20:12 +08:00
|
|
|
response = self.client.chat(model=self.model_name, messages=history, **gen_conf)
|
2026-05-19 22:05:52 -05:00
|
|
|
if not response.choices:
|
|
|
|
|
raise ValueError("LLM returned empty response") # pact: guard empty choices list
|
2025-06-11 17:20:12 +08:00
|
|
|
ans = response.choices[0].message.content
|
|
|
|
|
if response.choices[0].finish_reason == "length":
|
|
|
|
|
if is_chinese(ans):
|
|
|
|
|
ans += LENGTH_NOTIFICATION_CN
|
|
|
|
|
else:
|
|
|
|
|
ans += LENGTH_NOTIFICATION_EN
|
2025-10-22 12:25:31 +08:00
|
|
|
return ans, total_token_count_from_response(response)
|
2024-06-14 11:32:58 +08:00
|
|
|
|
fix(llm): replace mutable default `gen_conf={}` with None + defensive copy (#14566)
### What
19 methods across `rag/llm/chat_model.py` and `rag/llm/cv_model.py`
declare `gen_conf={}` (or `gen_conf: dict = {}`) as a parameter default
and then mutate `gen_conf` in place — typically `del
gen_conf["max_tokens"]`, `gen_conf["penalty_score"] = ...`, or
`gen_conf.pop(...)` as part of provider-specific normalization.
### The two bugs in this pattern
**1. Mutable default argument (Python footgun).** Python evaluates
default values **once** at function-definition time, so the single `{}`
dict is *shared* across every caller that doesn't pass `gen_conf`. The
first such call's mutations leak into the default seen by every
subsequent call.
```python
# Before
def chat_streamly(self, system, history, gen_conf={}, **kwargs):
if "max_tokens" in gen_conf:
del gen_conf["max_tokens"] # mutates the SHARED default dict
...
```
After call N with `max_tokens` set, call N+1 that omits `gen_conf` no
longer sees `max_tokens` — even though the caller never touched it.
**2. Caller-dict pollution.** When the caller *does* pass a `gen_conf`
dict, the same in-place mutations modify the caller's dict. A reused
`gen_conf` (very common for chat-loop callers that build the config once
and pass it on every turn) silently loses `max_tokens`,
`presence_penalty`, etc. after the first round.
### The fix
In every affected method:
- Change `gen_conf={}` (or `gen_conf: dict = {}`) → `gen_conf=None`.
- Add `gen_conf = dict(gen_conf or {})` as the first statement of the
body so all subsequent mutations operate on a fresh local copy.
```python
# After
def chat_streamly(self, system, history, gen_conf=None, **kwargs):
gen_conf = dict(gen_conf or {})
if "max_tokens" in gen_conf:
del gen_conf["max_tokens"] # local copy — safe
...
```
This is byte-for-byte identical provider-side behavior for callers that
already pass a fresh `gen_conf` per call. The new `dict(...)` copy is
O(small constant) per call.
### Files changed
- `rag/llm/chat_model.py` — 17 methods
- `rag/llm/cv_model.py` — 2 methods
### Tests
Adds `test/unit_test/rag/llm/test_gen_conf_no_mutable_default.py` — an
`ast`-based regression guard that walks both modules and asserts no
parameter named `gen_conf` ever has a mutable literal (`{}` or `[]`) as
its default. The test caught **five additional `gen_conf: dict = {}`
sites** that an initial `gen_conf={}` text grep had missed (annotated
parameters with whitespace), and would fail again if the pattern is ever
reintroduced.
```
$ pytest test/unit_test/rag/llm/test_gen_conf_no_mutable_default.py -v
============================== 3 passed in 0.04s ===============================
```
`ruff check` passes on all touched files.
### Notes
- This PR is intentionally focused on **just** the `gen_conf` default +
copy fix. There's a related (but separate) `history.insert(0, ...)`
pattern in the same files that mutates the caller's history list in 12
places — left for a follow-up so this PR stays mechanical and easy to
review.
### Latest revision (`700bb54a7`) — addresses CodeRabbit review
- Type annotation: `gen_conf: dict = None` → `gen_conf: dict | None =
None` (5 occurrences in `chat_model.py`). The old annotation was a
static-checker mismatch since `None` isn't a `dict`.
- Regression test: the AST check accessed `default.keys` directly.
`ast.List` has no `.keys` attribute — a future `gen_conf=[]` would crash
with `AttributeError` instead of being caught. Use `getattr` for both
`.keys` (Dict) and `.elts` (List). Manually verified the updated check
correctly catches both `gen_conf={}` and `gen_conf=[]` while ignoring
`gen_conf=None` and non-empty literals.
---------
Co-authored-by: Ricardo <ricardo@example.com>
2026-05-09 13:11:44 +08:00
|
|
|
def chat_streamly(self, system, history, gen_conf=None, **kwargs):
|
|
|
|
|
gen_conf = dict(gen_conf or {})
|
Refa: revise the implementation of LightRAG and enable response caching (#9828)
### What problem does this PR solve?
This revision performed a comprehensive check on LightRAG to ensure the
correctness of its implementation. It **did not involve** Entity
Resolution and Community Reports Generation. There is an example using
default entity types and the General chunking method, which shows good
results in both time and effectiveness. Moreover, response caching is
enabled for resuming failed tasks.
[The-Necklace.pdf](https://github.com/user-attachments/files/22042432/The-Necklace.pdf)
After:

```bash
Begin at:
Fri, 29 Aug 2025 16:48:03 GMT
Duration:
222.31 s
Progress:
16:48:04 Task has been received.
16:48:06 Page(1~7): Start to parse.
16:48:06 Page(1~7): OCR started
16:48:08 Page(1~7): OCR finished (1.89s)
16:48:11 Page(1~7): Layout analysis (3.72s)
16:48:11 Page(1~7): Table analysis (0.00s)
16:48:11 Page(1~7): Text merged (0.00s)
16:48:11 Page(1~7): Finish parsing.
16:48:12 Page(1~7): Generate 7 chunks
16:48:12 Page(1~7): Embedding chunks (0.29s)
16:48:12 Page(1~7): Indexing done (0.04s). Task done (7.84s)
16:48:17 Start processing for f421fb06849e11f0bdd32724b93a52b2: She had no dresses, no je...
16:48:17 Start processing for f421fb06849e11f0bdd32724b93a52b2: Her husband, already half...
16:48:17 Start processing for f421fb06849e11f0bdd32724b93a52b2: And this life lasted ten ...
16:48:17 Start processing for f421fb06849e11f0bdd32724b93a52b2: Then she asked, hesitatin...
16:49:30 Completed processing for f421fb06849e11f0bdd32724b93a52b2: She had no dresses, no je... after 1 gleanings, 21985 tokens.
16:49:30 Entities extraction of chunk 3 1/7 done, 12 nodes, 13 edges, 21985 tokens.
16:49:40 Completed processing for f421fb06849e11f0bdd32724b93a52b2: Finally, she replied, hes... after 1 gleanings, 22584 tokens.
16:49:40 Entities extraction of chunk 5 2/7 done, 19 nodes, 19 edges, 22584 tokens.
16:50:02 Completed processing for f421fb06849e11f0bdd32724b93a52b2: Then she asked, hesitatin... after 1 gleanings, 24610 tokens.
16:50:02 Entities extraction of chunk 0 3/7 done, 16 nodes, 28 edges, 24610 tokens.
16:50:03 Completed processing for f421fb06849e11f0bdd32724b93a52b2: And this life lasted ten ... after 1 gleanings, 24031 tokens.
16:50:04 Entities extraction of chunk 1 4/7 done, 24 nodes, 22 edges, 24031 tokens.
16:50:14 Completed processing for f421fb06849e11f0bdd32724b93a52b2: So they begged the jewell... after 1 gleanings, 24635 tokens.
16:50:14 Entities extraction of chunk 6 5/7 done, 27 nodes, 26 edges, 24635 tokens.
16:50:29 Completed processing for f421fb06849e11f0bdd32724b93a52b2: Her husband, already half... after 1 gleanings, 25758 tokens.
16:50:29 Entities extraction of chunk 2 6/7 done, 25 nodes, 35 edges, 25758 tokens.
16:51:35 Completed processing for f421fb06849e11f0bdd32724b93a52b2: The Necklace By Guy de Ma... after 1 gleanings, 27491 tokens.
16:51:35 Entities extraction of chunk 4 7/7 done, 39 nodes, 37 edges, 27491 tokens.
16:51:35 Entities and relationships extraction done, 147 nodes, 177 edges, 171094 tokens, 198.58s.
16:51:35 Entities merging done, 0.01s.
16:51:35 Relationships merging done, 0.01s.
16:51:35 ignored 7 relations due to missing entities.
16:51:35 generated subgraph for doc f421fb06849e11f0bdd32724b93a52b2 in 198.68 seconds.
16:51:35 run_graphrag f421fb06849e11f0bdd32724b93a52b2 graphrag_task_lock acquired
16:51:35 set_graph removed 0 nodes and 0 edges from index in 0.00s.
16:51:35 Get embedding of nodes: 9/147
16:51:35 Get embedding of nodes: 109/147
16:51:37 Get embedding of edges: 9/170
16:51:37 Get embedding of edges: 109/170
16:51:40 set_graph converted graph change to 319 chunks in 4.21s.
16:51:40 Insert chunks: 4/319
16:51:40 Insert chunks: 104/319
16:51:40 Insert chunks: 204/319
16:51:40 Insert chunks: 304/319
16:51:40 set_graph added/updated 147 nodes and 170 edges from index in 0.53s.
16:51:40 merging subgraph for doc f421fb06849e11f0bdd32724b93a52b2 into the global graph done in 4.79 seconds.
16:51:40 Knowledge Graph done (204.29s)
```
Before:

```bash
Begin at:
Fri, 29 Aug 2025 17:00:47 GMT
processDuration:
173.38 s
Progress:
17:00:49 Task has been received.
17:00:51 Page(1~7): Start to parse.
17:00:51 Page(1~7): OCR started
17:00:53 Page(1~7): OCR finished (1.82s)
17:00:57 Page(1~7): Layout analysis (3.64s)
17:00:57 Page(1~7): Table analysis (0.00s)
17:00:57 Page(1~7): Text merged (0.00s)
17:00:57 Page(1~7): Finish parsing.
17:00:57 Page(1~7): Generate 7 chunks
17:00:57 Page(1~7): Embedding chunks (0.31s)
17:00:57 Page(1~7): Indexing done (0.03s). Task done (7.88s)
17:00:57 created task graphrag
17:01:00 Task has been received.
17:02:17 Entities extraction of chunk 1 1/7 done, 9 nodes, 9 edges, 10654 tokens.
17:02:31 Entities extraction of chunk 2 2/7 done, 12 nodes, 13 edges, 11066 tokens.
17:02:33 Entities extraction of chunk 4 3/7 done, 9 nodes, 10 edges, 10433 tokens.
17:02:42 Entities extraction of chunk 5 4/7 done, 11 nodes, 14 edges, 11290 tokens.
17:02:52 Entities extraction of chunk 6 5/7 done, 13 nodes, 15 edges, 11039 tokens.
17:02:55 Entities extraction of chunk 3 6/7 done, 14 nodes, 13 edges, 11466 tokens.
17:03:32 Entities extraction of chunk 0 7/7 done, 19 nodes, 18 edges, 13107 tokens.
17:03:32 Entities and relationships extraction done, 71 nodes, 89 edges, 79055 tokens, 149.66s.
17:03:32 Entities merging done, 0.01s.
17:03:32 Relationships merging done, 0.01s.
17:03:32 ignored 1 relations due to missing entities.
17:03:32 generated subgraph for doc b1d9d3b6848711f0aacd7ddc0714c4d3 in 149.69 seconds.
17:03:32 run_graphrag b1d9d3b6848711f0aacd7ddc0714c4d3 graphrag_task_lock acquired
17:03:32 set_graph removed 0 nodes and 0 edges from index in 0.00s.
17:03:32 Get embedding of nodes: 9/71
17:03:33 Get embedding of edges: 9/88
17:03:34 set_graph converted graph change to 161 chunks in 2.27s.
17:03:34 Insert chunks: 4/161
17:03:34 Insert chunks: 104/161
17:03:34 set_graph added/updated 71 nodes and 88 edges from index in 0.28s.
17:03:34 merging subgraph for doc b1d9d3b6848711f0aacd7ddc0714c4d3 into the global graph done in 2.60 seconds.
17:03:34 Knowledge Graph done (153.18s)
```
### Type of change
- [x] Bug Fix (non-breaking change which fixes an issue)
- [x] Refactoring
- [x] Performance Improvement
2025-08-29 17:58:36 +08:00
|
|
|
if system and history and history[0].get("role") != "system":
|
2024-06-14 11:32:58 +08:00
|
|
|
history.insert(0, {"role": "system", "content": system})
|
2025-09-24 10:49:34 +08:00
|
|
|
gen_conf = self._clean_conf(gen_conf)
|
2024-06-14 11:32:58 +08:00
|
|
|
ans = ""
|
|
|
|
|
total_tokens = 0
|
|
|
|
|
try:
|
2025-07-30 19:41:09 +08:00
|
|
|
response = self.client.chat_stream(model=self.model_name, messages=history, **gen_conf, **kwargs)
|
2024-06-14 11:32:58 +08:00
|
|
|
for resp in response:
|
2024-12-08 14:21:12 +08:00
|
|
|
if not resp.choices or not resp.choices[0].delta.content:
|
|
|
|
|
continue
|
2025-03-26 19:33:14 +08:00
|
|
|
ans = resp.choices[0].delta.content
|
2024-06-14 11:32:58 +08:00
|
|
|
total_tokens += 1
|
|
|
|
|
if resp.choices[0].finish_reason == "length":
|
2024-12-04 09:34:49 +08:00
|
|
|
if is_chinese(ans):
|
|
|
|
|
ans += LENGTH_NOTIFICATION_CN
|
|
|
|
|
else:
|
|
|
|
|
ans += LENGTH_NOTIFICATION_EN
|
2024-06-14 11:32:58 +08:00
|
|
|
yield ans
|
|
|
|
|
|
|
|
|
|
except openai.APIError as e:
|
|
|
|
|
yield ans + "\n**ERROR**: " + str(e)
|
|
|
|
|
|
|
|
|
|
yield total_tokens
|
2024-07-08 09:37:34 +08:00
|
|
|
|
|
|
|
|
|
2024-07-24 12:46:43 +08:00
|
|
|
class LmStudioChat(Base):
|
2025-07-03 19:05:31 +08:00
|
|
|
_FACTORY_NAME = "LM-Studio"
|
|
|
|
|
|
2025-06-11 17:20:12 +08:00
|
|
|
def __init__(self, key, model_name, base_url, **kwargs):
|
2024-07-24 12:46:43 +08:00
|
|
|
if not base_url:
|
|
|
|
|
raise ValueError("Local llm url cannot be None")
|
2025-06-03 14:18:40 +08:00
|
|
|
base_url = urljoin(base_url, "v1")
|
2025-06-11 17:20:12 +08:00
|
|
|
super().__init__(key, model_name, base_url, **kwargs)
|
2024-08-06 16:20:21 +08:00
|
|
|
self.client = OpenAI(api_key="lm-studio", base_url=base_url)
|
2024-07-24 12:46:43 +08:00
|
|
|
self.model_name = model_name
|
2024-08-06 16:20:21 +08:00
|
|
|
|
|
|
|
|
|
|
|
|
|
class OpenAI_APIChat(Base):
|
2025-07-03 19:05:31 +08:00
|
|
|
_FACTORY_NAME = ["VLLM", "OpenAI-API-Compatible"]
|
|
|
|
|
|
2025-08-07 08:45:37 +07:00
|
|
|
def __init__(self, key, model_name, base_url, **kwargs):
|
2024-08-06 16:20:21 +08:00
|
|
|
if not base_url:
|
|
|
|
|
raise ValueError("url cannot be None")
|
|
|
|
|
model_name = model_name.split("___")[0]
|
2025-08-07 08:45:37 +07:00
|
|
|
super().__init__(key, model_name, base_url, **kwargs)
|
2024-08-07 18:40:51 +08:00
|
|
|
|
|
|
|
|
|
2024-08-08 12:09:50 +08:00
|
|
|
class LeptonAIChat(Base):
|
2025-07-03 19:05:31 +08:00
|
|
|
_FACTORY_NAME = "LeptonAI"
|
|
|
|
|
|
2025-06-11 17:20:12 +08:00
|
|
|
def __init__(self, key, model_name, base_url=None, **kwargs):
|
2024-08-08 12:09:50 +08:00
|
|
|
if not base_url:
|
2025-06-03 14:18:40 +08:00
|
|
|
base_url = urljoin("https://" + model_name + ".lepton.run", "api/v1")
|
2025-06-11 17:20:12 +08:00
|
|
|
super().__init__(key, model_name, base_url, **kwargs)
|
2024-08-12 10:11:50 +08:00
|
|
|
|
|
|
|
|
|
2024-08-19 10:36:57 +08:00
|
|
|
class ReplicateChat(Base):
|
2025-07-03 19:05:31 +08:00
|
|
|
_FACTORY_NAME = "Replicate"
|
|
|
|
|
|
2025-06-11 17:20:12 +08:00
|
|
|
def __init__(self, key, model_name, base_url=None, **kwargs):
|
|
|
|
|
super().__init__(key, model_name, base_url=base_url, **kwargs)
|
2025-04-08 16:09:03 +08:00
|
|
|
|
2024-08-19 10:36:57 +08:00
|
|
|
from replicate.client import Client
|
|
|
|
|
|
|
|
|
|
self.model_name = model_name
|
|
|
|
|
self.client = Client(api_token=key)
|
|
|
|
|
|
fix(llm): replace mutable default `gen_conf={}` with None + defensive copy (#14566)
### What
19 methods across `rag/llm/chat_model.py` and `rag/llm/cv_model.py`
declare `gen_conf={}` (or `gen_conf: dict = {}`) as a parameter default
and then mutate `gen_conf` in place — typically `del
gen_conf["max_tokens"]`, `gen_conf["penalty_score"] = ...`, or
`gen_conf.pop(...)` as part of provider-specific normalization.
### The two bugs in this pattern
**1. Mutable default argument (Python footgun).** Python evaluates
default values **once** at function-definition time, so the single `{}`
dict is *shared* across every caller that doesn't pass `gen_conf`. The
first such call's mutations leak into the default seen by every
subsequent call.
```python
# Before
def chat_streamly(self, system, history, gen_conf={}, **kwargs):
if "max_tokens" in gen_conf:
del gen_conf["max_tokens"] # mutates the SHARED default dict
...
```
After call N with `max_tokens` set, call N+1 that omits `gen_conf` no
longer sees `max_tokens` — even though the caller never touched it.
**2. Caller-dict pollution.** When the caller *does* pass a `gen_conf`
dict, the same in-place mutations modify the caller's dict. A reused
`gen_conf` (very common for chat-loop callers that build the config once
and pass it on every turn) silently loses `max_tokens`,
`presence_penalty`, etc. after the first round.
### The fix
In every affected method:
- Change `gen_conf={}` (or `gen_conf: dict = {}`) → `gen_conf=None`.
- Add `gen_conf = dict(gen_conf or {})` as the first statement of the
body so all subsequent mutations operate on a fresh local copy.
```python
# After
def chat_streamly(self, system, history, gen_conf=None, **kwargs):
gen_conf = dict(gen_conf or {})
if "max_tokens" in gen_conf:
del gen_conf["max_tokens"] # local copy — safe
...
```
This is byte-for-byte identical provider-side behavior for callers that
already pass a fresh `gen_conf` per call. The new `dict(...)` copy is
O(small constant) per call.
### Files changed
- `rag/llm/chat_model.py` — 17 methods
- `rag/llm/cv_model.py` — 2 methods
### Tests
Adds `test/unit_test/rag/llm/test_gen_conf_no_mutable_default.py` — an
`ast`-based regression guard that walks both modules and asserts no
parameter named `gen_conf` ever has a mutable literal (`{}` or `[]`) as
its default. The test caught **five additional `gen_conf: dict = {}`
sites** that an initial `gen_conf={}` text grep had missed (annotated
parameters with whitespace), and would fail again if the pattern is ever
reintroduced.
```
$ pytest test/unit_test/rag/llm/test_gen_conf_no_mutable_default.py -v
============================== 3 passed in 0.04s ===============================
```
`ruff check` passes on all touched files.
### Notes
- This PR is intentionally focused on **just** the `gen_conf` default +
copy fix. There's a related (but separate) `history.insert(0, ...)`
pattern in the same files that mutates the caller's history list in 12
places — left for a follow-up so this PR stays mechanical and easy to
review.
### Latest revision (`700bb54a7`) — addresses CodeRabbit review
- Type annotation: `gen_conf: dict = None` → `gen_conf: dict | None =
None` (5 occurrences in `chat_model.py`). The old annotation was a
static-checker mismatch since `None` isn't a `dict`.
- Regression test: the AST check accessed `default.keys` directly.
`ast.List` has no `.keys` attribute — a future `gen_conf=[]` would crash
with `AttributeError` instead of being caught. Use `getattr` for both
`.keys` (Dict) and `.elts` (List). Manually verified the updated check
correctly catches both `gen_conf={}` and `gen_conf=[]` while ignoring
`gen_conf=None` and non-empty literals.
---------
Co-authored-by: Ricardo <ricardo@example.com>
2026-05-09 13:11:44 +08:00
|
|
|
def _chat(self, history, gen_conf=None, **kwargs):
|
|
|
|
|
gen_conf = dict(gen_conf or {})
|
2025-06-11 17:20:12 +08:00
|
|
|
system = history[0]["content"] if history and history[0]["role"] == "system" else ""
|
|
|
|
|
prompt = "\n".join([item["role"] + ":" + item["content"] for item in history[-5:] if item["role"] != "system"])
|
|
|
|
|
response = self.client.run(
|
|
|
|
|
self.model_name,
|
|
|
|
|
input={"system_prompt": system, "prompt": prompt, **gen_conf},
|
|
|
|
|
)
|
|
|
|
|
ans = "".join(response)
|
|
|
|
|
return ans, num_tokens_from_string(ans)
|
2024-08-19 10:36:57 +08:00
|
|
|
|
fix(llm): replace mutable default `gen_conf={}` with None + defensive copy (#14566)
### What
19 methods across `rag/llm/chat_model.py` and `rag/llm/cv_model.py`
declare `gen_conf={}` (or `gen_conf: dict = {}`) as a parameter default
and then mutate `gen_conf` in place — typically `del
gen_conf["max_tokens"]`, `gen_conf["penalty_score"] = ...`, or
`gen_conf.pop(...)` as part of provider-specific normalization.
### The two bugs in this pattern
**1. Mutable default argument (Python footgun).** Python evaluates
default values **once** at function-definition time, so the single `{}`
dict is *shared* across every caller that doesn't pass `gen_conf`. The
first such call's mutations leak into the default seen by every
subsequent call.
```python
# Before
def chat_streamly(self, system, history, gen_conf={}, **kwargs):
if "max_tokens" in gen_conf:
del gen_conf["max_tokens"] # mutates the SHARED default dict
...
```
After call N with `max_tokens` set, call N+1 that omits `gen_conf` no
longer sees `max_tokens` — even though the caller never touched it.
**2. Caller-dict pollution.** When the caller *does* pass a `gen_conf`
dict, the same in-place mutations modify the caller's dict. A reused
`gen_conf` (very common for chat-loop callers that build the config once
and pass it on every turn) silently loses `max_tokens`,
`presence_penalty`, etc. after the first round.
### The fix
In every affected method:
- Change `gen_conf={}` (or `gen_conf: dict = {}`) → `gen_conf=None`.
- Add `gen_conf = dict(gen_conf or {})` as the first statement of the
body so all subsequent mutations operate on a fresh local copy.
```python
# After
def chat_streamly(self, system, history, gen_conf=None, **kwargs):
gen_conf = dict(gen_conf or {})
if "max_tokens" in gen_conf:
del gen_conf["max_tokens"] # local copy — safe
...
```
This is byte-for-byte identical provider-side behavior for callers that
already pass a fresh `gen_conf` per call. The new `dict(...)` copy is
O(small constant) per call.
### Files changed
- `rag/llm/chat_model.py` — 17 methods
- `rag/llm/cv_model.py` — 2 methods
### Tests
Adds `test/unit_test/rag/llm/test_gen_conf_no_mutable_default.py` — an
`ast`-based regression guard that walks both modules and asserts no
parameter named `gen_conf` ever has a mutable literal (`{}` or `[]`) as
its default. The test caught **five additional `gen_conf: dict = {}`
sites** that an initial `gen_conf={}` text grep had missed (annotated
parameters with whitespace), and would fail again if the pattern is ever
reintroduced.
```
$ pytest test/unit_test/rag/llm/test_gen_conf_no_mutable_default.py -v
============================== 3 passed in 0.04s ===============================
```
`ruff check` passes on all touched files.
### Notes
- This PR is intentionally focused on **just** the `gen_conf` default +
copy fix. There's a related (but separate) `history.insert(0, ...)`
pattern in the same files that mutates the caller's history list in 12
places — left for a follow-up so this PR stays mechanical and easy to
review.
### Latest revision (`700bb54a7`) — addresses CodeRabbit review
- Type annotation: `gen_conf: dict = None` → `gen_conf: dict | None =
None` (5 occurrences in `chat_model.py`). The old annotation was a
static-checker mismatch since `None` isn't a `dict`.
- Regression test: the AST check accessed `default.keys` directly.
`ast.List` has no `.keys` attribute — a future `gen_conf=[]` would crash
with `AttributeError` instead of being caught. Use `getattr` for both
`.keys` (Dict) and `.elts` (List). Manually verified the updated check
correctly catches both `gen_conf={}` and `gen_conf=[]` while ignoring
`gen_conf=None` and non-empty literals.
---------
Co-authored-by: Ricardo <ricardo@example.com>
2026-05-09 13:11:44 +08:00
|
|
|
def chat_streamly(self, system, history, gen_conf=None, **kwargs):
|
|
|
|
|
gen_conf = dict(gen_conf or {})
|
2024-08-19 10:36:57 +08:00
|
|
|
if "max_tokens" in gen_conf:
|
2025-03-06 11:29:40 +08:00
|
|
|
del gen_conf["max_tokens"]
|
2025-03-26 19:33:14 +08:00
|
|
|
prompt = "\n".join([item["role"] + ":" + item["content"] for item in history[-5:]])
|
2024-08-19 10:36:57 +08:00
|
|
|
ans = ""
|
|
|
|
|
try:
|
|
|
|
|
response = self.client.run(
|
|
|
|
|
self.model_name,
|
2025-06-11 17:20:12 +08:00
|
|
|
input={"system_prompt": system, "prompt": prompt, **gen_conf},
|
2024-08-19 10:36:57 +08:00
|
|
|
)
|
|
|
|
|
for resp in response:
|
2025-03-26 19:33:14 +08:00
|
|
|
ans = resp
|
2024-08-19 10:36:57 +08:00
|
|
|
yield ans
|
|
|
|
|
|
|
|
|
|
except Exception as e:
|
|
|
|
|
yield ans + "\n**ERROR**: " + str(e)
|
|
|
|
|
|
|
|
|
|
yield num_tokens_from_string(ans)
|
2024-08-20 15:27:13 +08:00
|
|
|
|
|
|
|
|
|
2024-08-20 16:56:42 +08:00
|
|
|
class SparkChat(Base):
|
2025-07-03 19:05:31 +08:00
|
|
|
_FACTORY_NAME = "XunFei Spark"
|
|
|
|
|
|
2025-06-11 17:20:12 +08:00
|
|
|
def __init__(self, key, model_name, base_url="https://spark-api-open.xf-yun.com/v1", **kwargs):
|
2024-08-20 16:56:42 +08:00
|
|
|
if not base_url:
|
|
|
|
|
base_url = "https://spark-api-open.xf-yun.com/v1"
|
|
|
|
|
model2version = {
|
|
|
|
|
"Spark-Max": "generalv3.5",
|
2026-01-29 19:22:35 +08:00
|
|
|
"Spark-Max-32K": "max-32k",
|
|
|
|
|
"Spark-Lite": "lite",
|
2024-08-20 16:56:42 +08:00
|
|
|
"Spark-Pro": "generalv3",
|
|
|
|
|
"Spark-Pro-128K": "pro-128k",
|
|
|
|
|
"Spark-4.0-Ultra": "4.0Ultra",
|
|
|
|
|
}
|
2024-11-20 12:16:36 +08:00
|
|
|
version2model = {v: k for k, v in model2version.items()}
|
|
|
|
|
assert model_name in model2version or model_name in version2model, f"The given model name is not supported yet. Support: {list(model2version.keys())}"
|
|
|
|
|
if model_name in model2version:
|
|
|
|
|
model_version = model2version[model_name]
|
2024-12-08 14:21:12 +08:00
|
|
|
else:
|
|
|
|
|
model_version = model_name
|
2025-06-11 17:20:12 +08:00
|
|
|
super().__init__(key, model_version, base_url, **kwargs)
|
2024-08-22 16:45:15 +08:00
|
|
|
|
|
|
|
|
|
|
|
|
|
class BaiduYiyanChat(Base):
|
2025-07-03 19:05:31 +08:00
|
|
|
_FACTORY_NAME = "BaiduYiyan"
|
|
|
|
|
|
2025-06-11 17:20:12 +08:00
|
|
|
def __init__(self, key, model_name, base_url=None, **kwargs):
|
|
|
|
|
super().__init__(key, model_name, base_url=base_url, **kwargs)
|
2025-04-08 16:09:03 +08:00
|
|
|
|
2024-08-22 16:45:15 +08:00
|
|
|
import qianfan
|
2024-08-29 13:30:06 +08:00
|
|
|
|
2024-08-22 16:45:15 +08:00
|
|
|
key = json.loads(key)
|
2024-10-08 18:27:04 +08:00
|
|
|
ak = key.get("yiyan_ak", "")
|
|
|
|
|
sk = key.get("yiyan_sk", "")
|
|
|
|
|
self.client = qianfan.ChatCompletion(ak=ak, sk=sk)
|
2024-08-22 16:45:15 +08:00
|
|
|
self.model_name = model_name.lower()
|
|
|
|
|
|
2025-06-11 17:20:12 +08:00
|
|
|
def _clean_conf(self, gen_conf):
|
2025-03-26 19:33:14 +08:00
|
|
|
gen_conf["penalty_score"] = ((gen_conf.get("presence_penalty", 0) + gen_conf.get("frequency_penalty", 0)) / 2) + 1
|
2024-08-22 16:45:15 +08:00
|
|
|
if "max_tokens" in gen_conf:
|
2025-03-06 11:29:40 +08:00
|
|
|
del gen_conf["max_tokens"]
|
2025-06-11 17:20:12 +08:00
|
|
|
return gen_conf
|
2024-08-29 13:30:06 +08:00
|
|
|
|
2025-06-11 17:20:12 +08:00
|
|
|
def _chat(self, history, gen_conf):
|
|
|
|
|
system = history[0]["content"] if history and history[0]["role"] == "system" else ""
|
|
|
|
|
response = self.client.do(model=self.model_name, messages=[h for h in history if h["role"] != "system"], system=system, **gen_conf).body
|
|
|
|
|
ans = response["result"]
|
2025-10-22 12:25:31 +08:00
|
|
|
return ans, total_token_count_from_response(response)
|
2024-08-22 16:45:15 +08:00
|
|
|
|
fix(llm): replace mutable default `gen_conf={}` with None + defensive copy (#14566)
### What
19 methods across `rag/llm/chat_model.py` and `rag/llm/cv_model.py`
declare `gen_conf={}` (or `gen_conf: dict = {}`) as a parameter default
and then mutate `gen_conf` in place — typically `del
gen_conf["max_tokens"]`, `gen_conf["penalty_score"] = ...`, or
`gen_conf.pop(...)` as part of provider-specific normalization.
### The two bugs in this pattern
**1. Mutable default argument (Python footgun).** Python evaluates
default values **once** at function-definition time, so the single `{}`
dict is *shared* across every caller that doesn't pass `gen_conf`. The
first such call's mutations leak into the default seen by every
subsequent call.
```python
# Before
def chat_streamly(self, system, history, gen_conf={}, **kwargs):
if "max_tokens" in gen_conf:
del gen_conf["max_tokens"] # mutates the SHARED default dict
...
```
After call N with `max_tokens` set, call N+1 that omits `gen_conf` no
longer sees `max_tokens` — even though the caller never touched it.
**2. Caller-dict pollution.** When the caller *does* pass a `gen_conf`
dict, the same in-place mutations modify the caller's dict. A reused
`gen_conf` (very common for chat-loop callers that build the config once
and pass it on every turn) silently loses `max_tokens`,
`presence_penalty`, etc. after the first round.
### The fix
In every affected method:
- Change `gen_conf={}` (or `gen_conf: dict = {}`) → `gen_conf=None`.
- Add `gen_conf = dict(gen_conf or {})` as the first statement of the
body so all subsequent mutations operate on a fresh local copy.
```python
# After
def chat_streamly(self, system, history, gen_conf=None, **kwargs):
gen_conf = dict(gen_conf or {})
if "max_tokens" in gen_conf:
del gen_conf["max_tokens"] # local copy — safe
...
```
This is byte-for-byte identical provider-side behavior for callers that
already pass a fresh `gen_conf` per call. The new `dict(...)` copy is
O(small constant) per call.
### Files changed
- `rag/llm/chat_model.py` — 17 methods
- `rag/llm/cv_model.py` — 2 methods
### Tests
Adds `test/unit_test/rag/llm/test_gen_conf_no_mutable_default.py` — an
`ast`-based regression guard that walks both modules and asserts no
parameter named `gen_conf` ever has a mutable literal (`{}` or `[]`) as
its default. The test caught **five additional `gen_conf: dict = {}`
sites** that an initial `gen_conf={}` text grep had missed (annotated
parameters with whitespace), and would fail again if the pattern is ever
reintroduced.
```
$ pytest test/unit_test/rag/llm/test_gen_conf_no_mutable_default.py -v
============================== 3 passed in 0.04s ===============================
```
`ruff check` passes on all touched files.
### Notes
- This PR is intentionally focused on **just** the `gen_conf` default +
copy fix. There's a related (but separate) `history.insert(0, ...)`
pattern in the same files that mutates the caller's history list in 12
places — left for a follow-up so this PR stays mechanical and easy to
review.
### Latest revision (`700bb54a7`) — addresses CodeRabbit review
- Type annotation: `gen_conf: dict = None` → `gen_conf: dict | None =
None` (5 occurrences in `chat_model.py`). The old annotation was a
static-checker mismatch since `None` isn't a `dict`.
- Regression test: the AST check accessed `default.keys` directly.
`ast.List` has no `.keys` attribute — a future `gen_conf=[]` would crash
with `AttributeError` instead of being caught. Use `getattr` for both
`.keys` (Dict) and `.elts` (List). Manually verified the updated check
correctly catches both `gen_conf={}` and `gen_conf=[]` while ignoring
`gen_conf=None` and non-empty literals.
---------
Co-authored-by: Ricardo <ricardo@example.com>
2026-05-09 13:11:44 +08:00
|
|
|
def chat_streamly(self, system, history, gen_conf=None, **kwargs):
|
|
|
|
|
gen_conf = dict(gen_conf or {})
|
2025-03-26 19:33:14 +08:00
|
|
|
gen_conf["penalty_score"] = ((gen_conf.get("presence_penalty", 0) + gen_conf.get("frequency_penalty", 0)) / 2) + 1
|
2024-08-22 16:45:15 +08:00
|
|
|
if "max_tokens" in gen_conf:
|
2025-03-06 11:29:40 +08:00
|
|
|
del gen_conf["max_tokens"]
|
2024-08-22 16:45:15 +08:00
|
|
|
ans = ""
|
|
|
|
|
total_tokens = 0
|
2024-08-29 13:30:06 +08:00
|
|
|
|
2024-08-22 16:45:15 +08:00
|
|
|
try:
|
2025-06-11 17:20:12 +08:00
|
|
|
response = self.client.do(model=self.model_name, messages=history, system=system, stream=True, **gen_conf)
|
2024-08-22 16:45:15 +08:00
|
|
|
for resp in response:
|
|
|
|
|
resp = resp.body
|
2025-03-26 19:33:14 +08:00
|
|
|
ans = resp["result"]
|
2025-10-22 12:25:31 +08:00
|
|
|
total_tokens = total_token_count_from_response(resp)
|
2024-08-22 16:45:15 +08:00
|
|
|
|
|
|
|
|
yield ans
|
|
|
|
|
|
|
|
|
|
except Exception as e:
|
|
|
|
|
return ans + "\n**ERROR**: " + str(e), 0
|
|
|
|
|
|
|
|
|
|
yield total_tokens
|
2024-08-29 13:30:06 +08:00
|
|
|
|
|
|
|
|
|
2024-09-02 12:06:41 +08:00
|
|
|
class GoogleChat(Base):
|
2025-07-03 19:05:31 +08:00
|
|
|
_FACTORY_NAME = "Google Cloud"
|
|
|
|
|
|
2025-06-11 17:20:12 +08:00
|
|
|
def __init__(self, key, model_name, base_url=None, **kwargs):
|
|
|
|
|
super().__init__(key, model_name, base_url=base_url, **kwargs)
|
2025-04-08 16:09:03 +08:00
|
|
|
|
2024-09-02 12:06:41 +08:00
|
|
|
import base64
|
|
|
|
|
|
2025-03-26 19:33:14 +08:00
|
|
|
from google.oauth2 import service_account
|
|
|
|
|
|
2025-02-07 12:00:19 +08:00
|
|
|
key = json.loads(key)
|
2025-03-26 19:33:14 +08:00
|
|
|
access_token = json.loads(base64.b64decode(key.get("google_service_account_key", "")))
|
2024-09-02 12:06:41 +08:00
|
|
|
project_id = key.get("google_project_id", "")
|
|
|
|
|
region = key.get("google_region", "")
|
|
|
|
|
|
|
|
|
|
scopes = ["https://www.googleapis.com/auth/cloud-platform"]
|
|
|
|
|
self.model_name = model_name
|
|
|
|
|
|
|
|
|
|
if "claude" in self.model_name:
|
|
|
|
|
from anthropic import AnthropicVertex
|
|
|
|
|
from google.auth.transport.requests import Request
|
|
|
|
|
|
|
|
|
|
if access_token:
|
2025-03-26 19:33:14 +08:00
|
|
|
credits = service_account.Credentials.from_service_account_info(access_token, scopes=scopes)
|
2024-09-02 12:06:41 +08:00
|
|
|
request = Request()
|
|
|
|
|
credits.refresh(request)
|
|
|
|
|
token = credits.token
|
2025-03-26 19:33:14 +08:00
|
|
|
self.client = AnthropicVertex(region=region, project_id=project_id, access_token=token)
|
2024-09-02 12:06:41 +08:00
|
|
|
else:
|
|
|
|
|
self.client = AnthropicVertex(region=region, project_id=project_id)
|
|
|
|
|
else:
|
2025-10-15 08:54:20 +02:00
|
|
|
from google import genai
|
2024-09-02 12:06:41 +08:00
|
|
|
|
|
|
|
|
if access_token:
|
2025-10-15 08:54:20 +02:00
|
|
|
credits = service_account.Credentials.from_service_account_info(access_token, scopes=scopes)
|
|
|
|
|
self.client = genai.Client(vertexai=True, project=project_id, location=region, credentials=credits)
|
2024-09-02 12:06:41 +08:00
|
|
|
else:
|
2025-10-15 08:54:20 +02:00
|
|
|
self.client = genai.Client(vertexai=True, project=project_id, location=region)
|
2024-09-02 12:06:41 +08:00
|
|
|
|
2025-06-11 17:20:12 +08:00
|
|
|
def _clean_conf(self, gen_conf):
|
2024-09-02 12:06:41 +08:00
|
|
|
if "claude" in self.model_name:
|
2025-03-06 11:29:40 +08:00
|
|
|
if "max_tokens" in gen_conf:
|
|
|
|
|
del gen_conf["max_tokens"]
|
2024-09-02 12:06:41 +08:00
|
|
|
else:
|
|
|
|
|
if "max_tokens" in gen_conf:
|
|
|
|
|
gen_conf["max_output_tokens"] = gen_conf["max_tokens"]
|
2025-10-10 13:18:24 +02:00
|
|
|
del gen_conf["max_tokens"]
|
2024-09-02 12:06:41 +08:00
|
|
|
for k in list(gen_conf.keys()):
|
|
|
|
|
if k not in ["temperature", "top_p", "max_output_tokens"]:
|
|
|
|
|
del gen_conf[k]
|
2025-06-11 17:20:12 +08:00
|
|
|
return gen_conf
|
2024-09-02 12:06:41 +08:00
|
|
|
|
fix(llm): replace mutable default `gen_conf={}` with None + defensive copy (#14566)
### What
19 methods across `rag/llm/chat_model.py` and `rag/llm/cv_model.py`
declare `gen_conf={}` (or `gen_conf: dict = {}`) as a parameter default
and then mutate `gen_conf` in place — typically `del
gen_conf["max_tokens"]`, `gen_conf["penalty_score"] = ...`, or
`gen_conf.pop(...)` as part of provider-specific normalization.
### The two bugs in this pattern
**1. Mutable default argument (Python footgun).** Python evaluates
default values **once** at function-definition time, so the single `{}`
dict is *shared* across every caller that doesn't pass `gen_conf`. The
first such call's mutations leak into the default seen by every
subsequent call.
```python
# Before
def chat_streamly(self, system, history, gen_conf={}, **kwargs):
if "max_tokens" in gen_conf:
del gen_conf["max_tokens"] # mutates the SHARED default dict
...
```
After call N with `max_tokens` set, call N+1 that omits `gen_conf` no
longer sees `max_tokens` — even though the caller never touched it.
**2. Caller-dict pollution.** When the caller *does* pass a `gen_conf`
dict, the same in-place mutations modify the caller's dict. A reused
`gen_conf` (very common for chat-loop callers that build the config once
and pass it on every turn) silently loses `max_tokens`,
`presence_penalty`, etc. after the first round.
### The fix
In every affected method:
- Change `gen_conf={}` (or `gen_conf: dict = {}`) → `gen_conf=None`.
- Add `gen_conf = dict(gen_conf or {})` as the first statement of the
body so all subsequent mutations operate on a fresh local copy.
```python
# After
def chat_streamly(self, system, history, gen_conf=None, **kwargs):
gen_conf = dict(gen_conf or {})
if "max_tokens" in gen_conf:
del gen_conf["max_tokens"] # local copy — safe
...
```
This is byte-for-byte identical provider-side behavior for callers that
already pass a fresh `gen_conf` per call. The new `dict(...)` copy is
O(small constant) per call.
### Files changed
- `rag/llm/chat_model.py` — 17 methods
- `rag/llm/cv_model.py` — 2 methods
### Tests
Adds `test/unit_test/rag/llm/test_gen_conf_no_mutable_default.py` — an
`ast`-based regression guard that walks both modules and asserts no
parameter named `gen_conf` ever has a mutable literal (`{}` or `[]`) as
its default. The test caught **five additional `gen_conf: dict = {}`
sites** that an initial `gen_conf={}` text grep had missed (annotated
parameters with whitespace), and would fail again if the pattern is ever
reintroduced.
```
$ pytest test/unit_test/rag/llm/test_gen_conf_no_mutable_default.py -v
============================== 3 passed in 0.04s ===============================
```
`ruff check` passes on all touched files.
### Notes
- This PR is intentionally focused on **just** the `gen_conf` default +
copy fix. There's a related (but separate) `history.insert(0, ...)`
pattern in the same files that mutates the caller's history list in 12
places — left for a follow-up so this PR stays mechanical and easy to
review.
### Latest revision (`700bb54a7`) — addresses CodeRabbit review
- Type annotation: `gen_conf: dict = None` → `gen_conf: dict | None =
None` (5 occurrences in `chat_model.py`). The old annotation was a
static-checker mismatch since `None` isn't a `dict`.
- Regression test: the AST check accessed `default.keys` directly.
`ast.List` has no `.keys` attribute — a future `gen_conf=[]` would crash
with `AttributeError` instead of being caught. Use `getattr` for both
`.keys` (Dict) and `.elts` (List). Manually verified the updated check
correctly catches both `gen_conf={}` and `gen_conf=[]` while ignoring
`gen_conf=None` and non-empty literals.
---------
Co-authored-by: Ricardo <ricardo@example.com>
2026-05-09 13:11:44 +08:00
|
|
|
def _chat(self, history, gen_conf=None, **kwargs):
|
|
|
|
|
gen_conf = dict(gen_conf or {})
|
2025-06-11 17:20:12 +08:00
|
|
|
system = history[0]["content"] if history and history[0]["role"] == "system" else ""
|
2025-10-15 08:54:20 +02:00
|
|
|
|
2025-06-11 17:20:12 +08:00
|
|
|
if "claude" in self.model_name:
|
2025-10-15 08:54:20 +02:00
|
|
|
gen_conf = self._clean_conf(gen_conf)
|
2025-06-11 17:20:12 +08:00
|
|
|
response = self.client.messages.create(
|
|
|
|
|
model=self.model_name,
|
|
|
|
|
messages=[h for h in history if h["role"] != "system"],
|
|
|
|
|
system=system,
|
|
|
|
|
stream=False,
|
|
|
|
|
**gen_conf,
|
|
|
|
|
).json()
|
|
|
|
|
ans = response["content"][0]["text"]
|
|
|
|
|
if response["stop_reason"] == "max_tokens":
|
|
|
|
|
ans += "...\nFor the content length reason, it stopped, continue?" if is_english([ans]) else "······\n由于长度的原因,回答被截断了,要继续吗?"
|
|
|
|
|
return (
|
|
|
|
|
ans,
|
|
|
|
|
response["usage"]["input_tokens"] + response["usage"]["output_tokens"],
|
|
|
|
|
)
|
2024-09-02 12:06:41 +08:00
|
|
|
|
2025-10-15 08:54:20 +02:00
|
|
|
# Gemini models with google-genai SDK
|
|
|
|
|
# Set default thinking_budget=0 if not specified
|
|
|
|
|
if "thinking_budget" not in gen_conf:
|
|
|
|
|
gen_conf["thinking_budget"] = 0
|
|
|
|
|
|
|
|
|
|
thinking_budget = gen_conf.pop("thinking_budget", 0)
|
|
|
|
|
gen_conf = self._clean_conf(gen_conf)
|
|
|
|
|
|
|
|
|
|
# Build GenerateContentConfig
|
|
|
|
|
try:
|
2025-12-01 12:17:43 +08:00
|
|
|
from google.genai.types import Content, GenerateContentConfig, Part, ThinkingConfig
|
2025-10-15 08:54:20 +02:00
|
|
|
except ImportError as e:
|
|
|
|
|
logging.error(f"[GoogleChat] Failed to import google-genai: {e}. Please install: pip install google-genai>=1.41.0")
|
|
|
|
|
raise
|
|
|
|
|
|
|
|
|
|
config_dict = {}
|
|
|
|
|
if system:
|
|
|
|
|
config_dict["system_instruction"] = system
|
|
|
|
|
if "temperature" in gen_conf:
|
|
|
|
|
config_dict["temperature"] = gen_conf["temperature"]
|
|
|
|
|
if "top_p" in gen_conf:
|
|
|
|
|
config_dict["top_p"] = gen_conf["top_p"]
|
|
|
|
|
if "max_output_tokens" in gen_conf:
|
|
|
|
|
config_dict["max_output_tokens"] = gen_conf["max_output_tokens"]
|
|
|
|
|
|
|
|
|
|
# Add ThinkingConfig
|
|
|
|
|
config_dict["thinking_config"] = ThinkingConfig(thinking_budget=thinking_budget)
|
|
|
|
|
|
|
|
|
|
config = GenerateContentConfig(**config_dict)
|
|
|
|
|
|
|
|
|
|
# Convert history to google-genai Content format
|
|
|
|
|
contents = []
|
2025-06-11 17:20:12 +08:00
|
|
|
for item in history:
|
|
|
|
|
if item["role"] == "system":
|
|
|
|
|
continue
|
2025-10-15 08:54:20 +02:00
|
|
|
# google-genai uses 'model' instead of 'assistant'
|
|
|
|
|
role = "model" if item["role"] == "assistant" else item["role"]
|
|
|
|
|
content = Content(
|
|
|
|
|
role=role,
|
2025-12-01 12:17:43 +08:00
|
|
|
parts=[Part(text=item["content"])],
|
2025-10-15 08:54:20 +02:00
|
|
|
)
|
|
|
|
|
contents.append(content)
|
|
|
|
|
|
|
|
|
|
response = self.client.models.generate_content(
|
|
|
|
|
model=self.model_name,
|
|
|
|
|
contents=contents,
|
2025-12-01 12:17:43 +08:00
|
|
|
config=config,
|
2025-10-15 08:54:20 +02:00
|
|
|
)
|
2025-06-11 17:20:12 +08:00
|
|
|
|
|
|
|
|
ans = response.text
|
2025-10-15 08:54:20 +02:00
|
|
|
# Get token count from response
|
|
|
|
|
try:
|
|
|
|
|
total_tokens = response.usage_metadata.total_token_count
|
|
|
|
|
except Exception:
|
|
|
|
|
total_tokens = 0
|
|
|
|
|
|
|
|
|
|
return ans, total_tokens
|
2025-06-11 17:20:12 +08:00
|
|
|
|
fix(llm): replace mutable default `gen_conf={}` with None + defensive copy (#14566)
### What
19 methods across `rag/llm/chat_model.py` and `rag/llm/cv_model.py`
declare `gen_conf={}` (or `gen_conf: dict = {}`) as a parameter default
and then mutate `gen_conf` in place — typically `del
gen_conf["max_tokens"]`, `gen_conf["penalty_score"] = ...`, or
`gen_conf.pop(...)` as part of provider-specific normalization.
### The two bugs in this pattern
**1. Mutable default argument (Python footgun).** Python evaluates
default values **once** at function-definition time, so the single `{}`
dict is *shared* across every caller that doesn't pass `gen_conf`. The
first such call's mutations leak into the default seen by every
subsequent call.
```python
# Before
def chat_streamly(self, system, history, gen_conf={}, **kwargs):
if "max_tokens" in gen_conf:
del gen_conf["max_tokens"] # mutates the SHARED default dict
...
```
After call N with `max_tokens` set, call N+1 that omits `gen_conf` no
longer sees `max_tokens` — even though the caller never touched it.
**2. Caller-dict pollution.** When the caller *does* pass a `gen_conf`
dict, the same in-place mutations modify the caller's dict. A reused
`gen_conf` (very common for chat-loop callers that build the config once
and pass it on every turn) silently loses `max_tokens`,
`presence_penalty`, etc. after the first round.
### The fix
In every affected method:
- Change `gen_conf={}` (or `gen_conf: dict = {}`) → `gen_conf=None`.
- Add `gen_conf = dict(gen_conf or {})` as the first statement of the
body so all subsequent mutations operate on a fresh local copy.
```python
# After
def chat_streamly(self, system, history, gen_conf=None, **kwargs):
gen_conf = dict(gen_conf or {})
if "max_tokens" in gen_conf:
del gen_conf["max_tokens"] # local copy — safe
...
```
This is byte-for-byte identical provider-side behavior for callers that
already pass a fresh `gen_conf` per call. The new `dict(...)` copy is
O(small constant) per call.
### Files changed
- `rag/llm/chat_model.py` — 17 methods
- `rag/llm/cv_model.py` — 2 methods
### Tests
Adds `test/unit_test/rag/llm/test_gen_conf_no_mutable_default.py` — an
`ast`-based regression guard that walks both modules and asserts no
parameter named `gen_conf` ever has a mutable literal (`{}` or `[]`) as
its default. The test caught **five additional `gen_conf: dict = {}`
sites** that an initial `gen_conf={}` text grep had missed (annotated
parameters with whitespace), and would fail again if the pattern is ever
reintroduced.
```
$ pytest test/unit_test/rag/llm/test_gen_conf_no_mutable_default.py -v
============================== 3 passed in 0.04s ===============================
```
`ruff check` passes on all touched files.
### Notes
- This PR is intentionally focused on **just** the `gen_conf` default +
copy fix. There's a related (but separate) `history.insert(0, ...)`
pattern in the same files that mutates the caller's history list in 12
places — left for a follow-up so this PR stays mechanical and easy to
review.
### Latest revision (`700bb54a7`) — addresses CodeRabbit review
- Type annotation: `gen_conf: dict = None` → `gen_conf: dict | None =
None` (5 occurrences in `chat_model.py`). The old annotation was a
static-checker mismatch since `None` isn't a `dict`.
- Regression test: the AST check accessed `default.keys` directly.
`ast.List` has no `.keys` attribute — a future `gen_conf=[]` would crash
with `AttributeError` instead of being caught. Use `getattr` for both
`.keys` (Dict) and `.elts` (List). Manually verified the updated check
correctly catches both `gen_conf={}` and `gen_conf=[]` while ignoring
`gen_conf=None` and non-empty literals.
---------
Co-authored-by: Ricardo <ricardo@example.com>
2026-05-09 13:11:44 +08:00
|
|
|
def chat_streamly(self, system, history, gen_conf=None, **kwargs):
|
|
|
|
|
gen_conf = dict(gen_conf or {})
|
2024-09-02 12:06:41 +08:00
|
|
|
if "claude" in self.model_name:
|
2025-03-06 11:29:40 +08:00
|
|
|
if "max_tokens" in gen_conf:
|
|
|
|
|
del gen_conf["max_tokens"]
|
2024-09-02 12:06:41 +08:00
|
|
|
ans = ""
|
|
|
|
|
total_tokens = 0
|
|
|
|
|
try:
|
|
|
|
|
response = self.client.messages.create(
|
|
|
|
|
model=self.model_name,
|
|
|
|
|
messages=history,
|
2025-06-11 17:20:12 +08:00
|
|
|
system=system,
|
2024-09-02 12:06:41 +08:00
|
|
|
stream=True,
|
|
|
|
|
**gen_conf,
|
|
|
|
|
)
|
|
|
|
|
for res in response.iter_lines():
|
|
|
|
|
res = res.decode("utf-8")
|
|
|
|
|
if "content_block_delta" in res and "data" in res:
|
|
|
|
|
text = json.loads(res[6:])["delta"]["text"]
|
2025-03-26 19:33:14 +08:00
|
|
|
ans = text
|
2024-09-02 12:06:41 +08:00
|
|
|
total_tokens += num_tokens_from_string(text)
|
|
|
|
|
except Exception as e:
|
|
|
|
|
yield ans + "\n**ERROR**: " + str(e)
|
|
|
|
|
|
|
|
|
|
yield total_tokens
|
|
|
|
|
else:
|
2025-10-15 08:54:20 +02:00
|
|
|
# Gemini models with google-genai SDK
|
|
|
|
|
ans = ""
|
2025-10-10 13:18:24 +02:00
|
|
|
total_tokens = 0
|
2025-10-15 08:54:20 +02:00
|
|
|
|
|
|
|
|
# Set default thinking_budget=0 if not specified
|
|
|
|
|
if "thinking_budget" not in gen_conf:
|
|
|
|
|
gen_conf["thinking_budget"] = 0
|
|
|
|
|
|
|
|
|
|
thinking_budget = gen_conf.pop("thinking_budget", 0)
|
|
|
|
|
gen_conf = self._clean_conf(gen_conf)
|
|
|
|
|
|
|
|
|
|
# Build GenerateContentConfig
|
|
|
|
|
try:
|
2025-12-01 12:17:43 +08:00
|
|
|
from google.genai.types import Content, GenerateContentConfig, Part, ThinkingConfig
|
2025-10-15 08:54:20 +02:00
|
|
|
except ImportError as e:
|
|
|
|
|
logging.error(f"[GoogleChat] Failed to import google-genai: {e}. Please install: pip install google-genai>=1.41.0")
|
|
|
|
|
raise
|
|
|
|
|
|
|
|
|
|
config_dict = {}
|
|
|
|
|
if system:
|
|
|
|
|
config_dict["system_instruction"] = system
|
|
|
|
|
if "temperature" in gen_conf:
|
|
|
|
|
config_dict["temperature"] = gen_conf["temperature"]
|
|
|
|
|
if "top_p" in gen_conf:
|
|
|
|
|
config_dict["top_p"] = gen_conf["top_p"]
|
|
|
|
|
if "max_output_tokens" in gen_conf:
|
|
|
|
|
config_dict["max_output_tokens"] = gen_conf["max_output_tokens"]
|
|
|
|
|
|
|
|
|
|
# Add ThinkingConfig
|
|
|
|
|
config_dict["thinking_config"] = ThinkingConfig(thinking_budget=thinking_budget)
|
|
|
|
|
|
|
|
|
|
config = GenerateContentConfig(**config_dict)
|
|
|
|
|
|
|
|
|
|
# Convert history to google-genai Content format
|
|
|
|
|
contents = []
|
2024-09-02 12:06:41 +08:00
|
|
|
for item in history:
|
2025-10-15 08:54:20 +02:00
|
|
|
# google-genai uses 'model' instead of 'assistant'
|
|
|
|
|
role = "model" if item["role"] == "assistant" else item["role"]
|
|
|
|
|
content = Content(
|
|
|
|
|
role=role,
|
2025-12-01 12:17:43 +08:00
|
|
|
parts=[Part(text=item["content"])],
|
2025-10-15 08:54:20 +02:00
|
|
|
)
|
|
|
|
|
contents.append(content)
|
|
|
|
|
|
2024-09-02 12:06:41 +08:00
|
|
|
try:
|
2025-10-15 08:54:20 +02:00
|
|
|
for chunk in self.client.models.generate_content_stream(
|
|
|
|
|
model=self.model_name,
|
|
|
|
|
contents=contents,
|
2025-12-01 12:17:43 +08:00
|
|
|
config=config,
|
2025-10-15 08:54:20 +02:00
|
|
|
):
|
|
|
|
|
text = chunk.text
|
|
|
|
|
ans = text
|
|
|
|
|
total_tokens += num_tokens_from_string(text)
|
2024-09-02 12:06:41 +08:00
|
|
|
yield ans
|
|
|
|
|
|
|
|
|
|
except Exception as e:
|
|
|
|
|
yield ans + "\n**ERROR**: " + str(e)
|
|
|
|
|
|
2025-10-10 13:18:24 +02:00
|
|
|
yield total_tokens
|
2025-01-15 14:15:58 +08:00
|
|
|
|
2025-03-06 11:29:40 +08:00
|
|
|
|
2025-09-11 17:25:31 +08:00
|
|
|
class TokenPonyChat(Base):
|
|
|
|
|
_FACTORY_NAME = "TokenPony"
|
|
|
|
|
|
|
|
|
|
def __init__(self, key, model_name, base_url="https://ragflow.vip-api.tokenpony.cn/v1", **kwargs):
|
|
|
|
|
if not base_url:
|
|
|
|
|
base_url = "https://ragflow.vip-api.tokenpony.cn/v1"
|
2025-10-28 10:04:41 +08:00
|
|
|
super().__init__(key, model_name, base_url, **kwargs)
|
|
|
|
|
|
2025-09-11 17:25:31 +08:00
|
|
|
|
2026-01-19 13:12:42 +08:00
|
|
|
class N1nChat(Base):
|
|
|
|
|
_FACTORY_NAME = "n1n"
|
|
|
|
|
|
|
|
|
|
def __init__(self, key, model_name, base_url="https://api.n1n.ai/v1", **kwargs):
|
|
|
|
|
if not base_url:
|
|
|
|
|
base_url = "https://api.n1n.ai/v1"
|
|
|
|
|
super().__init__(key, model_name, base_url, **kwargs)
|
|
|
|
|
|
|
|
|
|
|
feat: Add Avian as an LLM provider (#13256)
### What problem does this PR solve?
This PR adds [Avian](https://avian.io) as a new LLM provider to RAGFlow.
Avian provides an OpenAI-compatible API with competitive pricing,
offering access to models like DeepSeek V3.2, Kimi K2.5, GLM-5, and
MiniMax M2.5.
**Provider details:**
- API Base URL: `https://api.avian.io/v1`
- Auth: Bearer token via API key
- OpenAI-compatible (chat completions, streaming, function calling)
- Models:
- `deepseek/deepseek-v3.2` — 164K context, $0.26/$0.38 per 1M tokens
- `moonshotai/kimi-k2.5` — 131K context, $0.45/$2.20 per 1M tokens
- `z-ai/glm-5` — 131K context, $0.30/$2.55 per 1M tokens
- `minimax/minimax-m2.5` — 1M context, $0.30/$1.10 per 1M tokens
**Changes:**
- `rag/llm/chat_model.py` — Add `AvianChat` class extending `Base`
- `rag/llm/__init__.py` — Register in `SupportedLiteLLMProvider`,
`FACTORY_DEFAULT_BASE_URL`, `LITELLM_PROVIDER_PREFIX`
- `conf/llm_factories.json` — Add Avian factory with model definitions
- `web/src/constants/llm.ts` — Add to `LLMFactory` enum, `IconMap`,
`APIMapUrl`
- `web/src/components/svg-icon.tsx` — Register SVG icon
- `web/src/assets/svg/llm/avian.svg` — Provider icon
- `docs/references/supported_models.mdx` — Add to supported models table
This follows the same pattern as other OpenAI-compatible providers
(e.g., n1n #12680, TokenPony).
cc @KevinHuSh @JinHai-CN
### Type of change
- [x] New Feature (non-breaking change which adds functionality)
- [x] Documentation Update
2026-02-27 09:36:55 +00:00
|
|
|
class AvianChat(Base):
|
|
|
|
|
_FACTORY_NAME = "Avian"
|
|
|
|
|
|
|
|
|
|
def __init__(self, key, model_name, base_url="https://api.avian.io/v1", **kwargs):
|
|
|
|
|
if not base_url:
|
|
|
|
|
base_url = "https://api.avian.io/v1"
|
|
|
|
|
super().__init__(key, model_name, base_url, **kwargs)
|
|
|
|
|
|
|
|
|
|
|
feat: Add Astraflow provider support (global + China endpoints) (#14270)
## Add Astraflow Provider Support
This PR integrates [Astraflow](https://astraflow.ucloud.cn/) (by UCloud
/ 优刻得) as a new AI model provider in RAGFlow, with support for both
global and China endpoints.
### About Astraflow
Astraflow is an OpenAI-compatible AI model aggregation platform
supporting 200+ models from major providers including DeepSeek, Qwen,
GPT, Claude, Gemini, Llama, Mistral, and more.
| Variant | Factory Name | Endpoint | Env Var |
|---------|-------------|----------|---------|
| Global | `Astraflow` | `https://api-us-ca.umodelverse.ai/v1` |
`ASTRAFLOW_API_KEY` |
| China | `Astraflow-CN` | `https://api.modelverse.cn/v1` |
`ASTRAFLOW_CN_API_KEY` |
- **API key signup**: https://astraflow.ucloud.cn/
---
### Files Changed
| File | Change |
|------|--------|
| `rag/llm/__init__.py` | Register `Astraflow` and `Astraflow-CN` in
`SupportedLiteLLMProvider` enum, `FACTORY_DEFAULT_BASE_URL`, and
`LITELLM_PROVIDER_PREFIX` |
| `rag/llm/chat_model.py` | Add `AstraflowChat` and `AstraflowCNChat`
(OpenAI-compatible `Base` subclass) |
| `rag/llm/embedding_model.py` | Add `AstraflowEmbed` and
`AstraflowCNEmbed` (subclasses of `OpenAIEmbed`) |
| `rag/llm/rerank_model.py` | Add `AstraflowRerank` and
`AstraflowCNRerank` (subclasses of `OpenAI_APIRerank`) |
| `rag/llm/cv_model.py` | Add `AstraflowCV` and `AstraflowCNCV`
(subclasses of `GptV4`) |
| `rag/llm/tts_model.py` | Add `AstraflowTTS` and `AstraflowCNTTS`
(subclasses of `OpenAITTS`) |
| `rag/llm/sequence2txt_model.py` | Add `AstraflowSeq2txt` and
`AstraflowCNSeq2txt` (subclasses of `GPTSeq2txt`) |
| `conf/llm_factories.json` | Register `Astraflow` and `Astraflow-CN`
factories with a curated list of popular models |
---
### Supported Model Types
- ✅ **Chat / LLM** — DeepSeek-V3/R1, Qwen3, GPT-4o/4.1, Claude 3.5/3.7,
Gemini 2.0/2.5 Flash, Llama 3.3/4, Mistral, and 200+ more
- ✅ **Text Embedding** — text-embedding-3-small/large
- ✅ **Image / Vision (IMAGE2TEXT)** — GPT-4o, GPT-4.1, Claude, Gemini,
Llama-4, etc.
- ✅ **Text Re-Rank**
- ✅ **TTS** — tts-1
- ✅ **Speech-to-Text (SPEECH2TEXT)** — whisper-1
### Implementation Notes
- Uses the `openai/` LiteLLM prefix — consistent with other
OpenAI-compatible aggregation platforms (SILICONFLOW, DeerAPI, CometAPI,
OpenRouter, n1n, Avian, etc.)
- `Astraflow` (global, rank 250) and `Astraflow-CN` (China, rank 249)
are separate factory entries, allowing users to choose the optimal
endpoint based on their region.
- All model classes cleanly subclass existing base classes (`Base`,
`OpenAIEmbed`, `OpenAI_APIRerank`, `GptV4`, `OpenAITTS`, `GPTSeq2txt`)
with no custom logic needed — the provider is fully OpenAI-compatible.
---------
Co-authored-by: user <user@xzaaaMacBook-Air.local>
2026-04-22 15:38:34 +08:00
|
|
|
class AstraflowChat(Base):
|
|
|
|
|
_FACTORY_NAME = "Astraflow"
|
|
|
|
|
|
|
|
|
|
def __init__(self, key, model_name, base_url="https://api-us-ca.umodelverse.ai/v1", **kwargs):
|
|
|
|
|
if not base_url:
|
|
|
|
|
base_url = "https://api-us-ca.umodelverse.ai/v1"
|
|
|
|
|
super().__init__(key, model_name, base_url, **kwargs)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
class AstraflowCNChat(Base):
|
|
|
|
|
_FACTORY_NAME = "Astraflow-CN"
|
|
|
|
|
|
|
|
|
|
def __init__(self, key, model_name, base_url="https://api.modelverse.cn/v1", **kwargs):
|
|
|
|
|
if not base_url:
|
|
|
|
|
base_url = "https://api.modelverse.cn/v1"
|
|
|
|
|
super().__init__(key, model_name, base_url, **kwargs)
|
|
|
|
|
|
|
|
|
|
|
feat: add FuturMix as model provider (#14419)
## Summary
Add [FuturMix](https://futurmix.ai) as a new model provider. FuturMix is
an OpenAI-compatible unified AI gateway that provides access to 22+
models (GPT, Claude, Gemini, DeepSeek, and more) through a single API
endpoint and key.
- **API Base**: `https://futurmix.ai/v1` (OpenAI-compatible)
- **Supported capabilities**: Chat, Embedding, Image2Text, TTS,
Speech2Text, Rerank
### Changes
| File | Change |
|------|--------|
| `rag/llm/__init__.py` | Add `FuturMix` to `SupportedLiteLLMProvider`
enum, `FACTORY_DEFAULT_BASE_URL`, and `LITELLM_PROVIDER_PREFIX` |
| `rag/llm/chat_model.py` | Add `FuturMixChat(Base)` — follows
Astraflow/Avian pattern |
| `rag/llm/embedding_model.py` | Add `FuturMixEmbed(OpenAIEmbed)` —
follows Astraflow pattern |
| `rag/llm/cv_model.py` | Add `FuturMixCV(GptV4)` — follows
SILICONFLOW/OpenRouter pattern |
| `rag/llm/tts_model.py` | Add `FuturMixTTS(OpenAITTS)` — follows
CometAPI/DeerAPI pattern |
| `rag/llm/sequence2txt_model.py` | Add `FuturMixSeq2txt(GPTSeq2txt)` —
follows StepFun pattern |
| `rag/llm/rerank_model.py` | Add `FuturMixRerank(OpenAI_APIRerank)` |
| `conf/llm_factories.json` | Add factory config with 8 chat, 2
embedding, 1 image2text, 2 TTS, 1 speech2text models |
| `docs/guides/models/supported_models.mdx` | Add FuturMix to supported
models table |
### Models included
- **Chat**: claude-sonnet-4-20250514, claude-3.5-haiku, gpt-4o,
gpt-4o-mini, gemini-2.5-flash, gemini-2.0-flash, deepseek-chat,
deepseek-reasoner
- **Embedding**: text-embedding-3-small, text-embedding-3-large
- **Image2Text**: gpt-4o
- **TTS**: tts-1, tts-1-hd
- **Speech2Text**: whisper-1
## Test plan
- [ ] Verify FuturMix appears in the model provider list in RAGFlow UI
- [ ] Configure FuturMix with API key and test chat completion
- [ ] Test embedding model with document indexing
- [ ] Test image2text with a sample image
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---------
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-04-30 10:59:37 +08:00
|
|
|
class FuturMixChat(Base):
|
|
|
|
|
_FACTORY_NAME = "FuturMix"
|
|
|
|
|
|
|
|
|
|
def __init__(self, key, model_name, base_url="https://futurmix.ai/v1", **kwargs):
|
|
|
|
|
if not base_url:
|
|
|
|
|
base_url = "https://futurmix.ai/v1"
|
|
|
|
|
super().__init__(key, model_name, base_url, **kwargs)
|
|
|
|
|
logging.info("[FuturMix] Chat initialized with model %s", model_name)
|
|
|
|
|
|
|
|
|
|
|
2025-08-12 10:59:20 +08:00
|
|
|
class LiteLLMBase(ABC):
|
2025-09-18 17:16:59 +08:00
|
|
|
_FACTORY_NAME = [
|
|
|
|
|
"Tongyi-Qianwen",
|
|
|
|
|
"Bedrock",
|
|
|
|
|
"Moonshot",
|
|
|
|
|
"xAI",
|
|
|
|
|
"DeepInfra",
|
|
|
|
|
"Groq",
|
|
|
|
|
"Cohere",
|
|
|
|
|
"Gemini",
|
|
|
|
|
"DeepSeek",
|
|
|
|
|
"NVIDIA",
|
|
|
|
|
"TogetherAI",
|
|
|
|
|
"Anthropic",
|
|
|
|
|
"Ollama",
|
2025-11-11 16:58:47 +08:00
|
|
|
"LongCat",
|
2025-09-18 17:16:59 +08:00
|
|
|
"CometAPI",
|
|
|
|
|
"SILICONFLOW",
|
|
|
|
|
"OpenRouter",
|
|
|
|
|
"StepFun",
|
|
|
|
|
"PPIO",
|
|
|
|
|
"PerfXCloud",
|
|
|
|
|
"Upstage",
|
|
|
|
|
"NovitaAI",
|
|
|
|
|
"01.AI",
|
|
|
|
|
"GiteeAI",
|
|
|
|
|
"302.AI",
|
2025-11-17 19:47:46 +08:00
|
|
|
"Jiekou.AI",
|
2025-12-01 14:24:06 +08:00
|
|
|
"ZHIPU-AI",
|
2025-12-02 14:43:44 +08:00
|
|
|
"MiniMax",
|
2025-12-08 09:43:03 +08:00
|
|
|
"DeerAPI",
|
|
|
|
|
"GPUStack",
|
2025-12-12 17:35:08 +08:00
|
|
|
"OpenAI",
|
2025-12-13 11:32:46 +08:00
|
|
|
"Azure-OpenAI",
|
2026-01-27 17:04:53 +08:00
|
|
|
"Tencent Hunyuan",
|
2025-09-18 17:16:59 +08:00
|
|
|
]
|
|
|
|
|
|
2025-08-12 10:59:20 +08:00
|
|
|
def __init__(self, key, model_name, base_url=None, **kwargs):
|
2025-12-01 12:17:43 +08:00
|
|
|
self.timeout = int(os.environ.get("LLM_TIMEOUT_SECONDS", 600))
|
2025-08-12 10:59:20 +08:00
|
|
|
self.provider = kwargs.get("provider", "")
|
|
|
|
|
self.prefix = LITELLM_PROVIDER_PREFIX.get(self.provider, "")
|
|
|
|
|
self.model_name = f"{self.prefix}{model_name}"
|
|
|
|
|
self.api_key = key
|
2025-09-18 17:16:59 +08:00
|
|
|
self.base_url = (base_url or FACTORY_DEFAULT_BASE_URL.get(self.provider, "")).rstrip("/")
|
2025-08-12 10:59:20 +08:00
|
|
|
# Configure retry parameters
|
|
|
|
|
self.max_retries = kwargs.get("max_retries", int(os.environ.get("LLM_MAX_RETRIES", 5)))
|
|
|
|
|
self.base_delay = kwargs.get("retry_interval", float(os.environ.get("LLM_BASE_DELAY", 2.0)))
|
|
|
|
|
self.max_rounds = kwargs.get("max_rounds", 5)
|
|
|
|
|
self.is_tools = False
|
|
|
|
|
self.tools = []
|
|
|
|
|
self.toolcall_sessions = {}
|
|
|
|
|
|
|
|
|
|
# Factory specific fields
|
2025-12-19 11:32:20 +08:00
|
|
|
if self.provider == SupportedLiteLLMProvider.OpenRouter:
|
2025-10-16 09:39:59 +08:00
|
|
|
self.api_key = json.loads(key).get("api_key", "")
|
|
|
|
|
self.provider_order = json.loads(key).get("provider_order", "")
|
2025-12-13 11:32:46 +08:00
|
|
|
elif self.provider == SupportedLiteLLMProvider.Azure_OpenAI:
|
|
|
|
|
self.api_key = json.loads(key).get("api_key", "")
|
|
|
|
|
self.api_version = json.loads(key).get("api_version", "2024-02-01")
|
2026-05-07 11:54:49 +08:00
|
|
|
elif self.provider == SupportedLiteLLMProvider.MiniMax:
|
|
|
|
|
# MiniMax requires GroupId as a query parameter for API authentication
|
|
|
|
|
try:
|
|
|
|
|
key_obj = json.loads(key) if isinstance(key, str) else key
|
|
|
|
|
self.api_key = key_obj.get("api_key", key) if isinstance(key_obj, dict) else key
|
|
|
|
|
self.group_id = key_obj.get("group_id", "") if isinstance(key_obj, dict) else ""
|
|
|
|
|
except (json.JSONDecodeError, TypeError):
|
|
|
|
|
self.api_key = key
|
|
|
|
|
self.group_id = ""
|
|
|
|
|
else:
|
|
|
|
|
self.group_id = ""
|
2025-08-12 10:59:20 +08:00
|
|
|
|
|
|
|
|
def _get_delay(self):
|
|
|
|
|
return self.base_delay * random.uniform(10, 150)
|
|
|
|
|
|
|
|
|
|
def _classify_error(self, error):
|
|
|
|
|
error_str = str(error).lower()
|
|
|
|
|
|
|
|
|
|
keywords_mapping = [
|
|
|
|
|
(["quota", "capacity", "credit", "billing", "balance", "欠费"], LLMErrorCode.ERROR_QUOTA),
|
|
|
|
|
(["rate limit", "429", "tpm limit", "too many requests", "requests per minute"], LLMErrorCode.ERROR_RATE_LIMIT),
|
|
|
|
|
(["auth", "key", "apikey", "401", "forbidden", "permission"], LLMErrorCode.ERROR_AUTHENTICATION),
|
|
|
|
|
(["invalid", "bad request", "400", "format", "malformed", "parameter"], LLMErrorCode.ERROR_INVALID_REQUEST),
|
|
|
|
|
(["server", "503", "502", "504", "500", "unavailable"], LLMErrorCode.ERROR_SERVER),
|
|
|
|
|
(["timeout", "timed out"], LLMErrorCode.ERROR_TIMEOUT),
|
|
|
|
|
(["connect", "network", "unreachable", "dns"], LLMErrorCode.ERROR_CONNECTION),
|
|
|
|
|
(["filter", "content", "policy", "blocked", "safety", "inappropriate"], LLMErrorCode.ERROR_CONTENT_FILTER),
|
|
|
|
|
(["model", "not found", "does not exist", "not available"], LLMErrorCode.ERROR_MODEL),
|
|
|
|
|
(["max rounds"], LLMErrorCode.ERROR_MODEL),
|
|
|
|
|
]
|
|
|
|
|
for words, code in keywords_mapping:
|
|
|
|
|
if re.search("({})".format("|".join(words)), error_str):
|
|
|
|
|
return code
|
|
|
|
|
|
|
|
|
|
return LLMErrorCode.ERROR_GENERIC
|
|
|
|
|
|
|
|
|
|
def _clean_conf(self, gen_conf):
|
2026-03-18 17:28:20 +08:00
|
|
|
gen_conf, _ = _apply_model_family_policies(
|
|
|
|
|
self.model_name,
|
|
|
|
|
backend="litellm",
|
|
|
|
|
provider=self.provider,
|
|
|
|
|
gen_conf=gen_conf,
|
|
|
|
|
)
|
2026-01-28 12:41:20 +08:00
|
|
|
|
|
|
|
|
gen_conf.pop("max_tokens", None)
|
fix(llm): strip non-generation keys from gen_conf for LiteLLM providers (#15427) (#15432)
### What problem does this PR solve?
Fixes #15427.
All LiteLLM-routed chats fail with:
- Anthropic: `litellm.BadRequestError: AnthropicException -
{"type":"invalid_request_error","message":"model_type: Extra inputs are
not permitted"}`
- OpenAI: `litellm.BadRequestError: OpenAIException - Unknown parameter:
'model_type'`
This is a regression from v0.25.4.
#### Root cause
A chat assistant's `llm_setting` is forwarded to the model as
`gen_conf`. `llm_setting` can legitimately carry RAGFlow-internal
metadata such as `model_type` (the chat REST APIs in
`api/apps/restful_apis/` read it back out of `llm_setting`), so that key
ends up inside `gen_conf`.
`Base._clean_conf` (OpenAI-compatible providers) already **whitelists**
the keys it forwards, so direct-OpenAI providers were unaffected.
`LiteLLMBase._clean_conf` only dropped `max_tokens` and passed
everything else straight through to `litellm.acompletion`, which
forwarded `model_type` to the upstream provider — and Anthropic / OpenAI
reject it. Because both Claude and GPT route through LiteLLM, every chat
broke.
#### Fix
- Extract the allowed-key set into a shared `ALLOWED_GEN_CONF_KEYS`
constant and reuse it in `Base._clean_conf`.
- Apply the same whitelist in `LiteLLMBase._clean_conf`, plus the
LiteLLM-specific reasoning params (`thinking`, `reasoning_effort`,
`extra_body`) that the model-family policies inject for reasoning
models.
This covers all four LiteLLM completion paths (`async_chat`,
`async_chat_streamly`, `async_chat_with_tools`,
`async_chat_streamly_with_tools`), since they all route through
`_clean_conf`.
#### Tests
Adds `test/unit_test/rag/llm/test_clean_conf_whitelist.py` covering both
backends: `model_type` (and other stray keys) are dropped, genuine
generation params and `thinking` survive, `max_tokens` is removed, and
the whitelist invariants hold.
### Type of change
- [x] Bug Fix (non-breaking change which fixes an issue)
- [x] Added test cases
2026-06-02 05:04:11 +03:00
|
|
|
gen_conf = {k: v for k, v in gen_conf.items() if k in LITELLM_ALLOWED_GEN_CONF_KEYS}
|
2025-08-12 10:59:20 +08:00
|
|
|
return gen_conf
|
|
|
|
|
|
2026-04-28 17:09:08 +08:00
|
|
|
def _need_reasoning_content_back(self) -> bool:
|
|
|
|
|
return self.provider == SupportedLiteLLMProvider.DeepSeek
|
|
|
|
|
|
2025-12-03 14:19:53 +08:00
|
|
|
async def async_chat(self, system, history, gen_conf, **kwargs):
|
|
|
|
|
hist = list(history) if history else []
|
|
|
|
|
if system:
|
|
|
|
|
if not hist or hist[0].get("role") != "system":
|
|
|
|
|
hist.insert(0, {"role": "system", "content": system})
|
|
|
|
|
|
|
|
|
|
logging.info("[HISTORY]" + json.dumps(hist, ensure_ascii=False, indent=2))
|
2026-03-18 17:28:20 +08:00
|
|
|
gen_conf = self._clean_conf(gen_conf)
|
|
|
|
|
_, kwargs = _apply_model_family_policies(
|
|
|
|
|
self.model_name,
|
|
|
|
|
backend="litellm",
|
|
|
|
|
provider=self.provider,
|
|
|
|
|
request_kwargs=kwargs,
|
|
|
|
|
)
|
2025-12-01 14:24:06 +08:00
|
|
|
|
2026-01-14 03:35:46 -05:00
|
|
|
completion_args = self._construct_completion_args(history=hist, stream=False, tools=False, **{**gen_conf, **kwargs})
|
2025-12-01 14:24:06 +08:00
|
|
|
|
|
|
|
|
for attempt in range(self.max_retries + 1):
|
|
|
|
|
try:
|
|
|
|
|
response = await litellm.acompletion(
|
|
|
|
|
**completion_args,
|
|
|
|
|
drop_params=True,
|
|
|
|
|
timeout=self.timeout,
|
|
|
|
|
)
|
|
|
|
|
|
2026-05-19 22:05:52 -05:00
|
|
|
if not response.choices or not response.choices[0].message or not response.choices[0].message.content:
|
2025-12-01 14:24:06 +08:00
|
|
|
return "", 0
|
|
|
|
|
ans = response.choices[0].message.content.strip()
|
|
|
|
|
if response.choices[0].finish_reason == "length":
|
|
|
|
|
ans = self._length_stop(ans)
|
|
|
|
|
|
|
|
|
|
return ans, total_token_count_from_response(response)
|
|
|
|
|
except Exception as e:
|
|
|
|
|
e = await self._exceptions_async(e, attempt)
|
|
|
|
|
if e:
|
|
|
|
|
return e, 0
|
|
|
|
|
|
|
|
|
|
assert False, "Shouldn't be here."
|
|
|
|
|
|
|
|
|
|
async def async_chat_streamly(self, system, history, gen_conf, **kwargs):
|
|
|
|
|
if system and history and history[0].get("role") != "system":
|
|
|
|
|
history.insert(0, {"role": "system", "content": system})
|
|
|
|
|
logging.info("[HISTORY STREAMLY]" + json.dumps(history, ensure_ascii=False, indent=4))
|
|
|
|
|
gen_conf = self._clean_conf(gen_conf)
|
|
|
|
|
reasoning_start = False
|
|
|
|
|
total_tokens = 0
|
|
|
|
|
|
|
|
|
|
completion_args = self._construct_completion_args(history=history, stream=True, tools=False, **gen_conf)
|
|
|
|
|
stop = kwargs.get("stop")
|
|
|
|
|
if stop:
|
|
|
|
|
completion_args["stop"] = stop
|
|
|
|
|
|
|
|
|
|
for attempt in range(self.max_retries + 1):
|
|
|
|
|
try:
|
|
|
|
|
stream = await litellm.acompletion(
|
|
|
|
|
**completion_args,
|
|
|
|
|
drop_params=True,
|
|
|
|
|
timeout=self.timeout,
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
async for resp in stream:
|
|
|
|
|
if not hasattr(resp, "choices") or not resp.choices:
|
|
|
|
|
continue
|
|
|
|
|
|
|
|
|
|
delta = resp.choices[0].delta
|
|
|
|
|
if not hasattr(delta, "content") or delta.content is None:
|
|
|
|
|
delta.content = ""
|
|
|
|
|
|
2026-03-10 21:13:14 +08:00
|
|
|
_reasoning = getattr(delta, "reasoning_content", None) or getattr(delta, "reasoning", None)
|
|
|
|
|
if kwargs.get("with_reasoning", True) and _reasoning:
|
2025-12-01 14:24:06 +08:00
|
|
|
ans = ""
|
|
|
|
|
if not reasoning_start:
|
|
|
|
|
reasoning_start = True
|
|
|
|
|
ans = "<think>"
|
2026-03-10 21:13:14 +08:00
|
|
|
ans += _reasoning + "</think>"
|
2025-12-01 14:24:06 +08:00
|
|
|
else:
|
|
|
|
|
reasoning_start = False
|
|
|
|
|
ans = delta.content
|
|
|
|
|
|
|
|
|
|
tol = total_token_count_from_response(resp)
|
|
|
|
|
if not tol:
|
|
|
|
|
tol = num_tokens_from_string(delta.content)
|
|
|
|
|
total_tokens += tol
|
|
|
|
|
|
|
|
|
|
finish_reason = resp.choices[0].finish_reason if hasattr(resp.choices[0], "finish_reason") else ""
|
|
|
|
|
if finish_reason == "length":
|
|
|
|
|
if is_chinese(ans):
|
|
|
|
|
ans += LENGTH_NOTIFICATION_CN
|
|
|
|
|
else:
|
|
|
|
|
ans += LENGTH_NOTIFICATION_EN
|
|
|
|
|
|
|
|
|
|
yield ans
|
|
|
|
|
yield total_tokens
|
|
|
|
|
return
|
|
|
|
|
except Exception as e:
|
|
|
|
|
e = await self._exceptions_async(e, attempt)
|
|
|
|
|
if e:
|
|
|
|
|
yield e
|
|
|
|
|
yield total_tokens
|
|
|
|
|
return
|
|
|
|
|
|
2025-08-12 10:59:20 +08:00
|
|
|
def _length_stop(self, ans):
|
|
|
|
|
if is_chinese([ans]):
|
|
|
|
|
return ans + LENGTH_NOTIFICATION_CN
|
|
|
|
|
return ans + LENGTH_NOTIFICATION_EN
|
|
|
|
|
|
2025-09-23 06:19:28 +02:00
|
|
|
@property
|
|
|
|
|
def _retryable_errors(self) -> set[str]:
|
|
|
|
|
return {
|
|
|
|
|
LLMErrorCode.ERROR_RATE_LIMIT,
|
|
|
|
|
LLMErrorCode.ERROR_SERVER,
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
def _should_retry(self, error_code: str) -> bool:
|
|
|
|
|
return error_code in self._retryable_errors
|
|
|
|
|
|
2025-12-08 09:43:03 +08:00
|
|
|
async def _exceptions_async(self, e, attempt):
|
2025-12-01 14:24:06 +08:00
|
|
|
logging.exception("LiteLLMBase async completion")
|
|
|
|
|
error_code = self._classify_error(e)
|
|
|
|
|
if attempt == self.max_retries:
|
|
|
|
|
error_code = LLMErrorCode.ERROR_MAX_RETRIES
|
|
|
|
|
|
|
|
|
|
if self._should_retry(error_code):
|
|
|
|
|
delay = self._get_delay()
|
|
|
|
|
logging.warning(f"Error: {error_code}. Retrying in {delay:.2f} seconds... (Attempt {attempt + 1}/{self.max_retries})")
|
|
|
|
|
await asyncio.sleep(delay)
|
|
|
|
|
return None
|
|
|
|
|
msg = f"{ERROR_PREFIX}: {error_code} - {str(e)}"
|
|
|
|
|
logging.error(f"async_chat_streamly giving up: {msg}")
|
|
|
|
|
return msg
|
|
|
|
|
|
2025-08-12 10:59:20 +08:00
|
|
|
def _verbose_tool_use(self, name, args, res):
|
2026-05-20 16:56:20 +08:00
|
|
|
return "<tool_call>" + json.dumps(
|
|
|
|
|
{"name": name, "args": args, "result": str(res) if isinstance(res, Exception) else res},
|
|
|
|
|
ensure_ascii=False,
|
|
|
|
|
indent=2,
|
|
|
|
|
) + "</tool_call>"
|
2025-08-12 10:59:20 +08:00
|
|
|
|
2026-04-28 17:09:08 +08:00
|
|
|
def _append_history(self, hist, tool_call, tool_res, reasoning_content=None):
|
|
|
|
|
assistant_msg = {
|
|
|
|
|
"role": "assistant",
|
|
|
|
|
"tool_calls": [
|
|
|
|
|
{
|
Fix AttributeError when appending non-streaming tool calls to chat history in Agentic Agent (#14456)
### What problem does this PR solve?
Fix #14340
## Problem Description
When using an **Agentic Agent** (not Workflow) with one or more
Retrieval tools (e.g., Dataset Retrieval + Memory Retrieval), the agent
silently returns an empty response (`agent_response: ""`) after hanging
for several minutes. The server logs show:
```
AttributeError: 'ChatCompletionMessageToolCall' object has no attribute 'index'
```
This error propagates as a `GENERIC_ERROR`, causing the canvas to return
an empty response. The subsequent Memory save task then receives the
empty `agent_response` and logs:
```
Document for referred_document_id XXXX not found
```
## Reproduction Steps
1. Set `DOC_ENGINE=infinity` (or `elasticsearch` — the engine itself is
not the root cause).
2. Create a blank **Agentic Agent** (not a Workflow).
3. Add **two Retrieval tools** to the Agent node:
- `Retrieval_DS` → Dataset (Knowledge Base)
- `Retrieval_Mem` → Memory component
4. Add a **Message** node with **Save to Memory** enabled.
5. Launch the agent and send any message (e.g., "hola").
6. The agent hangs and returns an empty response.
## Root Cause Analysis
The crash occurs in `_append_history` and `_append_history_batch` inside
`rag/llm/chat_model.py`. These methods directly access `.index` on tool
call objects:
```python
# _append_history_batch
{
"index": tc.index, # <-- crashes here
...
}
```
However, **non-streaming** LLM responses (`stream=False`) return
`ChatCompletionMessageToolCall` objects, which **do not have an `index`
field** according to the OpenAI API specification. The `index` field
only exists on `ChoiceDeltaToolCall` objects returned in **streaming**
responses (`stream=True`).
When the agentic agent triggers an internal `full_question` call (used
to compress multi-turn conversation history), the request is incorrectly
routed through `async_chat_with_tools` because `is_tools=True` is set at
the `LLMBundle` level. If the LLM decides to emit `tool_calls` during
this auxiliary request, the code enters the non-streaming tool loop and
crashes when trying to append history.
## Fix
Replaced all direct `.index` accesses with `getattr(..., "index", None)`
for safe, backward-compatible access:
| Method | File | Line | Change |
|--------|------|------|--------|
| `_append_history` | `rag/llm/chat_model.py` | ~L304 |
`tool_call.index` → `getattr(tool_call, "index", None)` |
| `_append_history_batch` | `rag/llm/chat_model.py` | ~L332 | `tc.index`
→ `getattr(tc, "index", None)` |
| `_append_history` | `rag/llm/chat_model.py` | ~L1467 |
`tool_call.index` → `getattr(tool_call, "index", None)` |
| `_append_history_batch` | `rag/llm/chat_model.py` | ~L1496 |
`tc.index` → `getattr(tc, "index", None)` |
### Type of change
- [x] Bug Fix (non-breaking change which fixes an issue)
Signed-off-by: noob <yixiao121314@outlook.com>
2026-05-05 23:39:40 -07:00
|
|
|
"index": getattr(tool_call, "index", None),
|
2026-04-28 17:09:08 +08:00
|
|
|
"id": tool_call.id,
|
|
|
|
|
"function": {
|
|
|
|
|
"name": tool_call.function.name,
|
|
|
|
|
"arguments": tool_call.function.arguments,
|
2025-08-12 10:59:20 +08:00
|
|
|
},
|
2026-04-28 17:09:08 +08:00
|
|
|
"type": "function",
|
|
|
|
|
},
|
|
|
|
|
],
|
|
|
|
|
}
|
|
|
|
|
if reasoning_content:
|
|
|
|
|
assistant_msg["reasoning_content"] = reasoning_content
|
|
|
|
|
hist.append(assistant_msg)
|
2025-08-12 10:59:20 +08:00
|
|
|
try:
|
|
|
|
|
if isinstance(tool_res, dict):
|
|
|
|
|
tool_res = json.dumps(tool_res, ensure_ascii=False)
|
|
|
|
|
finally:
|
|
|
|
|
hist.append({"role": "tool", "tool_call_id": tool_call.id, "content": str(tool_res)})
|
|
|
|
|
return hist
|
|
|
|
|
|
2026-04-28 17:09:08 +08:00
|
|
|
def _append_history_batch(self, hist, results, reasoning_content=None):
|
2026-03-20 20:32:00 +08:00
|
|
|
"""
|
|
|
|
|
Append a batch of tool calls to history following the OpenAI protocol:
|
|
|
|
|
one assistant message containing all tool_calls, followed by one tool message per call.
|
|
|
|
|
results: list of (tool_call, name, args, result, error)
|
|
|
|
|
"""
|
2026-04-28 17:09:08 +08:00
|
|
|
assistant_msg = {
|
2026-03-20 20:32:00 +08:00
|
|
|
"role": "assistant",
|
|
|
|
|
"tool_calls": [
|
|
|
|
|
{
|
Fix AttributeError when appending non-streaming tool calls to chat history in Agentic Agent (#14456)
### What problem does this PR solve?
Fix #14340
## Problem Description
When using an **Agentic Agent** (not Workflow) with one or more
Retrieval tools (e.g., Dataset Retrieval + Memory Retrieval), the agent
silently returns an empty response (`agent_response: ""`) after hanging
for several minutes. The server logs show:
```
AttributeError: 'ChatCompletionMessageToolCall' object has no attribute 'index'
```
This error propagates as a `GENERIC_ERROR`, causing the canvas to return
an empty response. The subsequent Memory save task then receives the
empty `agent_response` and logs:
```
Document for referred_document_id XXXX not found
```
## Reproduction Steps
1. Set `DOC_ENGINE=infinity` (or `elasticsearch` — the engine itself is
not the root cause).
2. Create a blank **Agentic Agent** (not a Workflow).
3. Add **two Retrieval tools** to the Agent node:
- `Retrieval_DS` → Dataset (Knowledge Base)
- `Retrieval_Mem` → Memory component
4. Add a **Message** node with **Save to Memory** enabled.
5. Launch the agent and send any message (e.g., "hola").
6. The agent hangs and returns an empty response.
## Root Cause Analysis
The crash occurs in `_append_history` and `_append_history_batch` inside
`rag/llm/chat_model.py`. These methods directly access `.index` on tool
call objects:
```python
# _append_history_batch
{
"index": tc.index, # <-- crashes here
...
}
```
However, **non-streaming** LLM responses (`stream=False`) return
`ChatCompletionMessageToolCall` objects, which **do not have an `index`
field** according to the OpenAI API specification. The `index` field
only exists on `ChoiceDeltaToolCall` objects returned in **streaming**
responses (`stream=True`).
When the agentic agent triggers an internal `full_question` call (used
to compress multi-turn conversation history), the request is incorrectly
routed through `async_chat_with_tools` because `is_tools=True` is set at
the `LLMBundle` level. If the LLM decides to emit `tool_calls` during
this auxiliary request, the code enters the non-streaming tool loop and
crashes when trying to append history.
## Fix
Replaced all direct `.index` accesses with `getattr(..., "index", None)`
for safe, backward-compatible access:
| Method | File | Line | Change |
|--------|------|------|--------|
| `_append_history` | `rag/llm/chat_model.py` | ~L304 |
`tool_call.index` → `getattr(tool_call, "index", None)` |
| `_append_history_batch` | `rag/llm/chat_model.py` | ~L332 | `tc.index`
→ `getattr(tc, "index", None)` |
| `_append_history` | `rag/llm/chat_model.py` | ~L1467 |
`tool_call.index` → `getattr(tool_call, "index", None)` |
| `_append_history_batch` | `rag/llm/chat_model.py` | ~L1496 |
`tc.index` → `getattr(tc, "index", None)` |
### Type of change
- [x] Bug Fix (non-breaking change which fixes an issue)
Signed-off-by: noob <yixiao121314@outlook.com>
2026-05-05 23:39:40 -07:00
|
|
|
"index": getattr(tc, "index", None),
|
2026-03-20 20:32:00 +08:00
|
|
|
"id": tc.id,
|
|
|
|
|
"function": {"name": tc.function.name, "arguments": tc.function.arguments},
|
|
|
|
|
"type": "function",
|
|
|
|
|
}
|
|
|
|
|
for tc, _, _, _, _ in results
|
|
|
|
|
],
|
2026-04-28 17:09:08 +08:00
|
|
|
}
|
|
|
|
|
if reasoning_content:
|
|
|
|
|
assistant_msg["reasoning_content"] = reasoning_content
|
|
|
|
|
hist.append(assistant_msg)
|
2026-03-20 20:32:00 +08:00
|
|
|
for tc, _, _, result, err in results:
|
|
|
|
|
if err:
|
|
|
|
|
content = str(err)
|
|
|
|
|
elif isinstance(result, dict):
|
|
|
|
|
content = json.dumps(result, ensure_ascii=False)
|
|
|
|
|
else:
|
|
|
|
|
content = str(result)
|
|
|
|
|
hist.append({"role": "tool", "tool_call_id": tc.id, "content": content})
|
|
|
|
|
return hist
|
|
|
|
|
|
Feat: @tool decorator for chat-model tool registration (#15047)
## Summary
- Adds a lightweight `@tool` decorator and `FunctionToolSession` adapter
in `rag/llm/tool_decorator.py` that let callers register plain Python
functions as LLM tools without hand-writing OpenAI function schemas or
building an MCP-style session.
- Refactors `Base.bind_tools` and `LiteLLMBase.bind_tools` in
`rag/llm/chat_model.py` to accept either the new decorator form
`bind_tools(tools=[fn1, fn2])` or the existing `(toolcall_session,
tools_schemas)` form, so existing agent/dialog call-sites in
`agent/component/agent_with_tools.py`, `api/db/services/llm_service.py`,
and `api/db/services/dialog_service.py` are unaffected.
- Adds 8 unit tests in `test/unit_test/rag/llm/test_tool_decorator.py`
covering schema shape, required/optional inference, sync + async
dispatch, and bad-input rejection.
## Usage
```python
from rag.llm.tool_decorator import tool
@tool
def get_weather(city: str) -> str:
"""Get current weather for a city.
:param city: City name to look up.
"""
return f"{city}: 21 C, partly cloudy"
chat_mdl.bind_tools(tools=[get_weather])
ans, tk = await chat_mdl.async_chat_with_tools(system, history)
```
The decorator introspects `inspect.signature` + type hints + the
docstring (`:param name:` style) and attaches an OpenAI-format
`openai_schema` to the callable. `FunctionToolSession` duck-types the
existing `ToolCallSession` protocol, dispatching async callables
directly and sync ones through `thread_pool_exec` so the event loop is
never blocked.
## Design notes
- `tool_decorator.py` deliberately does **not** live inside
`rag/llm/__init__.py` to avoid forcing every consumer through the heavy
provider auto-discovery loop and to sidestep a circular import
(`__init__.py` imports `chat_model`, which would otherwise need symbols
from `__init__.py`).
- `FunctionToolSession` is duck-typed against
`common.mcp_tool_call_conn.ToolCallSession` rather than explicitly
inheriting from it, so importing the decorator doesn't pull the MCP
client SDK into the import graph.
- Docstring parsing is intentionally minimal (`:param name:` only) to
keep this dependency-free; Google/NumPy styles can be added later via
`docstring_parser` if needed.
## Test plan
- [x] `python -m pytest test/unit_test/rag/llm/test_tool_decorator.py
-v` — 8 passed
- [x] `python -m pytest test/unit_test/rag/llm/
--ignore=test/unit_test/rag/llm/test_perplexity_embed.py` — 11 passed
(the ignored test has a pre-existing `numpy` import that's unrelated)
- [ ] Reviewer: smoke-test the new path end-to-end with a live model via
`chat_mdl.bind_tools(tools=[my_fn])` to confirm the OpenAI-format
schemas pass through unchanged
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---------
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-21 14:07:00 +08:00
|
|
|
def bind_tools(self, toolcall_session=None, tools=None):
|
|
|
|
|
"""Register tools the LLM can call.
|
|
|
|
|
|
|
|
|
|
Two calling styles are accepted:
|
|
|
|
|
|
|
|
|
|
* Legacy: ``bind_tools(toolcall_session, tools_schemas)`` where
|
|
|
|
|
``toolcall_session`` implements :class:`ToolCallSession` and
|
|
|
|
|
``tools_schemas`` is a pre-built list of OpenAI function-schema
|
|
|
|
|
dicts (used by the agent/dialog layer).
|
|
|
|
|
* Decorator: ``bind_tools(tools=[fn1, fn2, ...])`` where each ``fn``
|
|
|
|
|
is decorated with :func:`rag.llm.tool_decorator.tool`. The session
|
|
|
|
|
and schemas are derived from the callables automatically.
|
|
|
|
|
"""
|
|
|
|
|
if tools is None and isinstance(toolcall_session, list):
|
|
|
|
|
tools, toolcall_session = toolcall_session, None
|
|
|
|
|
|
|
|
|
|
if tools and toolcall_session is None and all(is_tool(t) for t in tools):
|
|
|
|
|
session = FunctionToolSession(tools)
|
|
|
|
|
self.is_tools = True
|
|
|
|
|
self.toolcall_session = session
|
|
|
|
|
self.tools = session.schemas
|
|
|
|
|
return
|
|
|
|
|
|
2025-08-12 10:59:20 +08:00
|
|
|
if not (toolcall_session and tools):
|
|
|
|
|
return
|
|
|
|
|
self.is_tools = True
|
|
|
|
|
self.toolcall_session = toolcall_session
|
|
|
|
|
self.tools = tools
|
|
|
|
|
|
fix(llm): replace mutable default `gen_conf={}` with None + defensive copy (#14566)
### What
19 methods across `rag/llm/chat_model.py` and `rag/llm/cv_model.py`
declare `gen_conf={}` (or `gen_conf: dict = {}`) as a parameter default
and then mutate `gen_conf` in place — typically `del
gen_conf["max_tokens"]`, `gen_conf["penalty_score"] = ...`, or
`gen_conf.pop(...)` as part of provider-specific normalization.
### The two bugs in this pattern
**1. Mutable default argument (Python footgun).** Python evaluates
default values **once** at function-definition time, so the single `{}`
dict is *shared* across every caller that doesn't pass `gen_conf`. The
first such call's mutations leak into the default seen by every
subsequent call.
```python
# Before
def chat_streamly(self, system, history, gen_conf={}, **kwargs):
if "max_tokens" in gen_conf:
del gen_conf["max_tokens"] # mutates the SHARED default dict
...
```
After call N with `max_tokens` set, call N+1 that omits `gen_conf` no
longer sees `max_tokens` — even though the caller never touched it.
**2. Caller-dict pollution.** When the caller *does* pass a `gen_conf`
dict, the same in-place mutations modify the caller's dict. A reused
`gen_conf` (very common for chat-loop callers that build the config once
and pass it on every turn) silently loses `max_tokens`,
`presence_penalty`, etc. after the first round.
### The fix
In every affected method:
- Change `gen_conf={}` (or `gen_conf: dict = {}`) → `gen_conf=None`.
- Add `gen_conf = dict(gen_conf or {})` as the first statement of the
body so all subsequent mutations operate on a fresh local copy.
```python
# After
def chat_streamly(self, system, history, gen_conf=None, **kwargs):
gen_conf = dict(gen_conf or {})
if "max_tokens" in gen_conf:
del gen_conf["max_tokens"] # local copy — safe
...
```
This is byte-for-byte identical provider-side behavior for callers that
already pass a fresh `gen_conf` per call. The new `dict(...)` copy is
O(small constant) per call.
### Files changed
- `rag/llm/chat_model.py` — 17 methods
- `rag/llm/cv_model.py` — 2 methods
### Tests
Adds `test/unit_test/rag/llm/test_gen_conf_no_mutable_default.py` — an
`ast`-based regression guard that walks both modules and asserts no
parameter named `gen_conf` ever has a mutable literal (`{}` or `[]`) as
its default. The test caught **five additional `gen_conf: dict = {}`
sites** that an initial `gen_conf={}` text grep had missed (annotated
parameters with whitespace), and would fail again if the pattern is ever
reintroduced.
```
$ pytest test/unit_test/rag/llm/test_gen_conf_no_mutable_default.py -v
============================== 3 passed in 0.04s ===============================
```
`ruff check` passes on all touched files.
### Notes
- This PR is intentionally focused on **just** the `gen_conf` default +
copy fix. There's a related (but separate) `history.insert(0, ...)`
pattern in the same files that mutates the caller's history list in 12
places — left for a follow-up so this PR stays mechanical and easy to
review.
### Latest revision (`700bb54a7`) — addresses CodeRabbit review
- Type annotation: `gen_conf: dict = None` → `gen_conf: dict | None =
None` (5 occurrences in `chat_model.py`). The old annotation was a
static-checker mismatch since `None` isn't a `dict`.
- Regression test: the AST check accessed `default.keys` directly.
`ast.List` has no `.keys` attribute — a future `gen_conf=[]` would crash
with `AttributeError` instead of being caught. Use `getattr` for both
`.keys` (Dict) and `.elts` (List). Manually verified the updated check
correctly catches both `gen_conf={}` and `gen_conf=[]` while ignoring
`gen_conf=None` and non-empty literals.
---------
Co-authored-by: Ricardo <ricardo@example.com>
2026-05-09 13:11:44 +08:00
|
|
|
async def async_chat_with_tools(self, system: str, history: list, gen_conf: dict | None = None):
|
|
|
|
|
gen_conf = dict(gen_conf or {})
|
2025-08-12 10:59:20 +08:00
|
|
|
gen_conf = self._clean_conf(gen_conf)
|
Refa: revise the implementation of LightRAG and enable response caching (#9828)
### What problem does this PR solve?
This revision performed a comprehensive check on LightRAG to ensure the
correctness of its implementation. It **did not involve** Entity
Resolution and Community Reports Generation. There is an example using
default entity types and the General chunking method, which shows good
results in both time and effectiveness. Moreover, response caching is
enabled for resuming failed tasks.
[The-Necklace.pdf](https://github.com/user-attachments/files/22042432/The-Necklace.pdf)
After:

```bash
Begin at:
Fri, 29 Aug 2025 16:48:03 GMT
Duration:
222.31 s
Progress:
16:48:04 Task has been received.
16:48:06 Page(1~7): Start to parse.
16:48:06 Page(1~7): OCR started
16:48:08 Page(1~7): OCR finished (1.89s)
16:48:11 Page(1~7): Layout analysis (3.72s)
16:48:11 Page(1~7): Table analysis (0.00s)
16:48:11 Page(1~7): Text merged (0.00s)
16:48:11 Page(1~7): Finish parsing.
16:48:12 Page(1~7): Generate 7 chunks
16:48:12 Page(1~7): Embedding chunks (0.29s)
16:48:12 Page(1~7): Indexing done (0.04s). Task done (7.84s)
16:48:17 Start processing for f421fb06849e11f0bdd32724b93a52b2: She had no dresses, no je...
16:48:17 Start processing for f421fb06849e11f0bdd32724b93a52b2: Her husband, already half...
16:48:17 Start processing for f421fb06849e11f0bdd32724b93a52b2: And this life lasted ten ...
16:48:17 Start processing for f421fb06849e11f0bdd32724b93a52b2: Then she asked, hesitatin...
16:49:30 Completed processing for f421fb06849e11f0bdd32724b93a52b2: She had no dresses, no je... after 1 gleanings, 21985 tokens.
16:49:30 Entities extraction of chunk 3 1/7 done, 12 nodes, 13 edges, 21985 tokens.
16:49:40 Completed processing for f421fb06849e11f0bdd32724b93a52b2: Finally, she replied, hes... after 1 gleanings, 22584 tokens.
16:49:40 Entities extraction of chunk 5 2/7 done, 19 nodes, 19 edges, 22584 tokens.
16:50:02 Completed processing for f421fb06849e11f0bdd32724b93a52b2: Then she asked, hesitatin... after 1 gleanings, 24610 tokens.
16:50:02 Entities extraction of chunk 0 3/7 done, 16 nodes, 28 edges, 24610 tokens.
16:50:03 Completed processing for f421fb06849e11f0bdd32724b93a52b2: And this life lasted ten ... after 1 gleanings, 24031 tokens.
16:50:04 Entities extraction of chunk 1 4/7 done, 24 nodes, 22 edges, 24031 tokens.
16:50:14 Completed processing for f421fb06849e11f0bdd32724b93a52b2: So they begged the jewell... after 1 gleanings, 24635 tokens.
16:50:14 Entities extraction of chunk 6 5/7 done, 27 nodes, 26 edges, 24635 tokens.
16:50:29 Completed processing for f421fb06849e11f0bdd32724b93a52b2: Her husband, already half... after 1 gleanings, 25758 tokens.
16:50:29 Entities extraction of chunk 2 6/7 done, 25 nodes, 35 edges, 25758 tokens.
16:51:35 Completed processing for f421fb06849e11f0bdd32724b93a52b2: The Necklace By Guy de Ma... after 1 gleanings, 27491 tokens.
16:51:35 Entities extraction of chunk 4 7/7 done, 39 nodes, 37 edges, 27491 tokens.
16:51:35 Entities and relationships extraction done, 147 nodes, 177 edges, 171094 tokens, 198.58s.
16:51:35 Entities merging done, 0.01s.
16:51:35 Relationships merging done, 0.01s.
16:51:35 ignored 7 relations due to missing entities.
16:51:35 generated subgraph for doc f421fb06849e11f0bdd32724b93a52b2 in 198.68 seconds.
16:51:35 run_graphrag f421fb06849e11f0bdd32724b93a52b2 graphrag_task_lock acquired
16:51:35 set_graph removed 0 nodes and 0 edges from index in 0.00s.
16:51:35 Get embedding of nodes: 9/147
16:51:35 Get embedding of nodes: 109/147
16:51:37 Get embedding of edges: 9/170
16:51:37 Get embedding of edges: 109/170
16:51:40 set_graph converted graph change to 319 chunks in 4.21s.
16:51:40 Insert chunks: 4/319
16:51:40 Insert chunks: 104/319
16:51:40 Insert chunks: 204/319
16:51:40 Insert chunks: 304/319
16:51:40 set_graph added/updated 147 nodes and 170 edges from index in 0.53s.
16:51:40 merging subgraph for doc f421fb06849e11f0bdd32724b93a52b2 into the global graph done in 4.79 seconds.
16:51:40 Knowledge Graph done (204.29s)
```
Before:

```bash
Begin at:
Fri, 29 Aug 2025 17:00:47 GMT
processDuration:
173.38 s
Progress:
17:00:49 Task has been received.
17:00:51 Page(1~7): Start to parse.
17:00:51 Page(1~7): OCR started
17:00:53 Page(1~7): OCR finished (1.82s)
17:00:57 Page(1~7): Layout analysis (3.64s)
17:00:57 Page(1~7): Table analysis (0.00s)
17:00:57 Page(1~7): Text merged (0.00s)
17:00:57 Page(1~7): Finish parsing.
17:00:57 Page(1~7): Generate 7 chunks
17:00:57 Page(1~7): Embedding chunks (0.31s)
17:00:57 Page(1~7): Indexing done (0.03s). Task done (7.88s)
17:00:57 created task graphrag
17:01:00 Task has been received.
17:02:17 Entities extraction of chunk 1 1/7 done, 9 nodes, 9 edges, 10654 tokens.
17:02:31 Entities extraction of chunk 2 2/7 done, 12 nodes, 13 edges, 11066 tokens.
17:02:33 Entities extraction of chunk 4 3/7 done, 9 nodes, 10 edges, 10433 tokens.
17:02:42 Entities extraction of chunk 5 4/7 done, 11 nodes, 14 edges, 11290 tokens.
17:02:52 Entities extraction of chunk 6 5/7 done, 13 nodes, 15 edges, 11039 tokens.
17:02:55 Entities extraction of chunk 3 6/7 done, 14 nodes, 13 edges, 11466 tokens.
17:03:32 Entities extraction of chunk 0 7/7 done, 19 nodes, 18 edges, 13107 tokens.
17:03:32 Entities and relationships extraction done, 71 nodes, 89 edges, 79055 tokens, 149.66s.
17:03:32 Entities merging done, 0.01s.
17:03:32 Relationships merging done, 0.01s.
17:03:32 ignored 1 relations due to missing entities.
17:03:32 generated subgraph for doc b1d9d3b6848711f0aacd7ddc0714c4d3 in 149.69 seconds.
17:03:32 run_graphrag b1d9d3b6848711f0aacd7ddc0714c4d3 graphrag_task_lock acquired
17:03:32 set_graph removed 0 nodes and 0 edges from index in 0.00s.
17:03:32 Get embedding of nodes: 9/71
17:03:33 Get embedding of edges: 9/88
17:03:34 set_graph converted graph change to 161 chunks in 2.27s.
17:03:34 Insert chunks: 4/161
17:03:34 Insert chunks: 104/161
17:03:34 set_graph added/updated 71 nodes and 88 edges from index in 0.28s.
17:03:34 merging subgraph for doc b1d9d3b6848711f0aacd7ddc0714c4d3 into the global graph done in 2.60 seconds.
17:03:34 Knowledge Graph done (153.18s)
```
### Type of change
- [x] Bug Fix (non-breaking change which fixes an issue)
- [x] Refactoring
- [x] Performance Improvement
2025-08-29 17:58:36 +08:00
|
|
|
if system and history and history[0].get("role") != "system":
|
2025-08-12 10:59:20 +08:00
|
|
|
history.insert(0, {"role": "system", "content": system})
|
|
|
|
|
|
|
|
|
|
ans = ""
|
|
|
|
|
tk_count = 0
|
|
|
|
|
hist = deepcopy(history)
|
|
|
|
|
for attempt in range(self.max_retries + 1):
|
2025-12-08 09:43:03 +08:00
|
|
|
history = deepcopy(hist)
|
2025-08-12 10:59:20 +08:00
|
|
|
try:
|
|
|
|
|
for _ in range(self.max_rounds + 1):
|
|
|
|
|
logging.info(f"{self.tools=}")
|
|
|
|
|
|
2025-08-12 15:54:30 +08:00
|
|
|
completion_args = self._construct_completion_args(history=history, stream=False, tools=True, **gen_conf)
|
2025-12-08 09:43:03 +08:00
|
|
|
response = await litellm.acompletion(
|
2025-08-12 10:59:20 +08:00
|
|
|
**completion_args,
|
|
|
|
|
drop_params=True,
|
|
|
|
|
timeout=self.timeout,
|
|
|
|
|
)
|
|
|
|
|
|
2025-10-22 12:25:31 +08:00
|
|
|
tk_count += total_token_count_from_response(response)
|
2025-08-12 10:59:20 +08:00
|
|
|
|
|
|
|
|
if not hasattr(response, "choices") or not response.choices or not response.choices[0].message:
|
|
|
|
|
raise Exception(f"500 response structure error. Response: {response}")
|
|
|
|
|
|
|
|
|
|
message = response.choices[0].message
|
2026-04-28 17:09:08 +08:00
|
|
|
reasoning_content = None
|
|
|
|
|
if self._need_reasoning_content_back():
|
|
|
|
|
reasoning_content = getattr(message, "reasoning_content", None) or getattr(message, "reasoning", None)
|
2025-08-12 10:59:20 +08:00
|
|
|
|
|
|
|
|
if not hasattr(message, "tool_calls") or not message.tool_calls:
|
2026-04-28 17:09:08 +08:00
|
|
|
if reasoning_content:
|
|
|
|
|
ans += f"<think>{reasoning_content}</think>"
|
2025-08-12 10:59:20 +08:00
|
|
|
ans += message.content or ""
|
|
|
|
|
if response.choices[0].finish_reason == "length":
|
|
|
|
|
ans = self._length_stop(ans)
|
|
|
|
|
return ans, tk_count
|
|
|
|
|
|
2026-03-20 20:32:00 +08:00
|
|
|
async def _exec_tool(tc):
|
|
|
|
|
name = tc.function.name
|
2025-08-12 10:59:20 +08:00
|
|
|
try:
|
2026-03-20 20:32:00 +08:00
|
|
|
args = json_repair.loads(tc.function.arguments)
|
2026-05-20 16:56:20 +08:00
|
|
|
if not isinstance(args, dict):
|
|
|
|
|
raise TypeError(f"Tool arguments for {name} must be a JSON object, got {type(args).__name__}")
|
2026-03-20 20:32:00 +08:00
|
|
|
if hasattr(self.toolcall_session, "tool_call_async"):
|
|
|
|
|
result = await self.toolcall_session.tool_call_async(name, args)
|
|
|
|
|
else:
|
|
|
|
|
result = await thread_pool_exec(self.toolcall_session.tool_call, name, args)
|
|
|
|
|
return tc, name, args, result, None
|
2025-08-12 10:59:20 +08:00
|
|
|
except Exception as e:
|
2026-03-20 20:32:00 +08:00
|
|
|
logging.exception(f"Tool call failed: {tc}")
|
|
|
|
|
return tc, name, {}, None, e
|
|
|
|
|
|
|
|
|
|
logging.info(f"Response tool_calls={message.tool_calls}")
|
|
|
|
|
results = await asyncio.gather(*[_exec_tool(tc) for tc in message.tool_calls])
|
2026-04-28 17:09:08 +08:00
|
|
|
history = self._append_history_batch(
|
|
|
|
|
history,
|
|
|
|
|
results,
|
|
|
|
|
reasoning_content=reasoning_content if self._need_reasoning_content_back() else None,
|
|
|
|
|
)
|
2026-03-20 20:32:00 +08:00
|
|
|
for tc, name, args, result, err in results:
|
|
|
|
|
ans += self._verbose_tool_use(name, args, err if err else result)
|
2025-08-12 10:59:20 +08:00
|
|
|
|
|
|
|
|
logging.warning(f"Exceed max rounds: {self.max_rounds}")
|
|
|
|
|
history.append({"role": "user", "content": f"Exceed max rounds: {self.max_rounds}"})
|
|
|
|
|
|
2025-12-08 09:43:03 +08:00
|
|
|
response, token_count = await self.async_chat("", history, gen_conf)
|
2025-08-12 10:59:20 +08:00
|
|
|
ans += response
|
|
|
|
|
tk_count += token_count
|
|
|
|
|
return ans, tk_count
|
|
|
|
|
|
|
|
|
|
except Exception as e:
|
2025-12-08 09:43:03 +08:00
|
|
|
e = await self._exceptions_async(e, attempt)
|
2025-08-12 10:59:20 +08:00
|
|
|
if e:
|
|
|
|
|
return e, tk_count
|
|
|
|
|
|
|
|
|
|
assert False, "Shouldn't be here."
|
|
|
|
|
|
fix(llm): replace mutable default `gen_conf={}` with None + defensive copy (#14566)
### What
19 methods across `rag/llm/chat_model.py` and `rag/llm/cv_model.py`
declare `gen_conf={}` (or `gen_conf: dict = {}`) as a parameter default
and then mutate `gen_conf` in place — typically `del
gen_conf["max_tokens"]`, `gen_conf["penalty_score"] = ...`, or
`gen_conf.pop(...)` as part of provider-specific normalization.
### The two bugs in this pattern
**1. Mutable default argument (Python footgun).** Python evaluates
default values **once** at function-definition time, so the single `{}`
dict is *shared* across every caller that doesn't pass `gen_conf`. The
first such call's mutations leak into the default seen by every
subsequent call.
```python
# Before
def chat_streamly(self, system, history, gen_conf={}, **kwargs):
if "max_tokens" in gen_conf:
del gen_conf["max_tokens"] # mutates the SHARED default dict
...
```
After call N with `max_tokens` set, call N+1 that omits `gen_conf` no
longer sees `max_tokens` — even though the caller never touched it.
**2. Caller-dict pollution.** When the caller *does* pass a `gen_conf`
dict, the same in-place mutations modify the caller's dict. A reused
`gen_conf` (very common for chat-loop callers that build the config once
and pass it on every turn) silently loses `max_tokens`,
`presence_penalty`, etc. after the first round.
### The fix
In every affected method:
- Change `gen_conf={}` (or `gen_conf: dict = {}`) → `gen_conf=None`.
- Add `gen_conf = dict(gen_conf or {})` as the first statement of the
body so all subsequent mutations operate on a fresh local copy.
```python
# After
def chat_streamly(self, system, history, gen_conf=None, **kwargs):
gen_conf = dict(gen_conf or {})
if "max_tokens" in gen_conf:
del gen_conf["max_tokens"] # local copy — safe
...
```
This is byte-for-byte identical provider-side behavior for callers that
already pass a fresh `gen_conf` per call. The new `dict(...)` copy is
O(small constant) per call.
### Files changed
- `rag/llm/chat_model.py` — 17 methods
- `rag/llm/cv_model.py` — 2 methods
### Tests
Adds `test/unit_test/rag/llm/test_gen_conf_no_mutable_default.py` — an
`ast`-based regression guard that walks both modules and asserts no
parameter named `gen_conf` ever has a mutable literal (`{}` or `[]`) as
its default. The test caught **five additional `gen_conf: dict = {}`
sites** that an initial `gen_conf={}` text grep had missed (annotated
parameters with whitespace), and would fail again if the pattern is ever
reintroduced.
```
$ pytest test/unit_test/rag/llm/test_gen_conf_no_mutable_default.py -v
============================== 3 passed in 0.04s ===============================
```
`ruff check` passes on all touched files.
### Notes
- This PR is intentionally focused on **just** the `gen_conf` default +
copy fix. There's a related (but separate) `history.insert(0, ...)`
pattern in the same files that mutates the caller's history list in 12
places — left for a follow-up so this PR stays mechanical and easy to
review.
### Latest revision (`700bb54a7`) — addresses CodeRabbit review
- Type annotation: `gen_conf: dict = None` → `gen_conf: dict | None =
None` (5 occurrences in `chat_model.py`). The old annotation was a
static-checker mismatch since `None` isn't a `dict`.
- Regression test: the AST check accessed `default.keys` directly.
`ast.List` has no `.keys` attribute — a future `gen_conf=[]` would crash
with `AttributeError` instead of being caught. Use `getattr` for both
`.keys` (Dict) and `.elts` (List). Manually verified the updated check
correctly catches both `gen_conf={}` and `gen_conf=[]` while ignoring
`gen_conf=None` and non-empty literals.
---------
Co-authored-by: Ricardo <ricardo@example.com>
2026-05-09 13:11:44 +08:00
|
|
|
async def async_chat_streamly_with_tools(self, system: str, history: list, gen_conf: dict | None = None):
|
|
|
|
|
gen_conf = dict(gen_conf or {})
|
2025-08-12 10:59:20 +08:00
|
|
|
gen_conf = self._clean_conf(gen_conf)
|
|
|
|
|
tools = self.tools
|
Refa: revise the implementation of LightRAG and enable response caching (#9828)
### What problem does this PR solve?
This revision performed a comprehensive check on LightRAG to ensure the
correctness of its implementation. It **did not involve** Entity
Resolution and Community Reports Generation. There is an example using
default entity types and the General chunking method, which shows good
results in both time and effectiveness. Moreover, response caching is
enabled for resuming failed tasks.
[The-Necklace.pdf](https://github.com/user-attachments/files/22042432/The-Necklace.pdf)
After:

```bash
Begin at:
Fri, 29 Aug 2025 16:48:03 GMT
Duration:
222.31 s
Progress:
16:48:04 Task has been received.
16:48:06 Page(1~7): Start to parse.
16:48:06 Page(1~7): OCR started
16:48:08 Page(1~7): OCR finished (1.89s)
16:48:11 Page(1~7): Layout analysis (3.72s)
16:48:11 Page(1~7): Table analysis (0.00s)
16:48:11 Page(1~7): Text merged (0.00s)
16:48:11 Page(1~7): Finish parsing.
16:48:12 Page(1~7): Generate 7 chunks
16:48:12 Page(1~7): Embedding chunks (0.29s)
16:48:12 Page(1~7): Indexing done (0.04s). Task done (7.84s)
16:48:17 Start processing for f421fb06849e11f0bdd32724b93a52b2: She had no dresses, no je...
16:48:17 Start processing for f421fb06849e11f0bdd32724b93a52b2: Her husband, already half...
16:48:17 Start processing for f421fb06849e11f0bdd32724b93a52b2: And this life lasted ten ...
16:48:17 Start processing for f421fb06849e11f0bdd32724b93a52b2: Then she asked, hesitatin...
16:49:30 Completed processing for f421fb06849e11f0bdd32724b93a52b2: She had no dresses, no je... after 1 gleanings, 21985 tokens.
16:49:30 Entities extraction of chunk 3 1/7 done, 12 nodes, 13 edges, 21985 tokens.
16:49:40 Completed processing for f421fb06849e11f0bdd32724b93a52b2: Finally, she replied, hes... after 1 gleanings, 22584 tokens.
16:49:40 Entities extraction of chunk 5 2/7 done, 19 nodes, 19 edges, 22584 tokens.
16:50:02 Completed processing for f421fb06849e11f0bdd32724b93a52b2: Then she asked, hesitatin... after 1 gleanings, 24610 tokens.
16:50:02 Entities extraction of chunk 0 3/7 done, 16 nodes, 28 edges, 24610 tokens.
16:50:03 Completed processing for f421fb06849e11f0bdd32724b93a52b2: And this life lasted ten ... after 1 gleanings, 24031 tokens.
16:50:04 Entities extraction of chunk 1 4/7 done, 24 nodes, 22 edges, 24031 tokens.
16:50:14 Completed processing for f421fb06849e11f0bdd32724b93a52b2: So they begged the jewell... after 1 gleanings, 24635 tokens.
16:50:14 Entities extraction of chunk 6 5/7 done, 27 nodes, 26 edges, 24635 tokens.
16:50:29 Completed processing for f421fb06849e11f0bdd32724b93a52b2: Her husband, already half... after 1 gleanings, 25758 tokens.
16:50:29 Entities extraction of chunk 2 6/7 done, 25 nodes, 35 edges, 25758 tokens.
16:51:35 Completed processing for f421fb06849e11f0bdd32724b93a52b2: The Necklace By Guy de Ma... after 1 gleanings, 27491 tokens.
16:51:35 Entities extraction of chunk 4 7/7 done, 39 nodes, 37 edges, 27491 tokens.
16:51:35 Entities and relationships extraction done, 147 nodes, 177 edges, 171094 tokens, 198.58s.
16:51:35 Entities merging done, 0.01s.
16:51:35 Relationships merging done, 0.01s.
16:51:35 ignored 7 relations due to missing entities.
16:51:35 generated subgraph for doc f421fb06849e11f0bdd32724b93a52b2 in 198.68 seconds.
16:51:35 run_graphrag f421fb06849e11f0bdd32724b93a52b2 graphrag_task_lock acquired
16:51:35 set_graph removed 0 nodes and 0 edges from index in 0.00s.
16:51:35 Get embedding of nodes: 9/147
16:51:35 Get embedding of nodes: 109/147
16:51:37 Get embedding of edges: 9/170
16:51:37 Get embedding of edges: 109/170
16:51:40 set_graph converted graph change to 319 chunks in 4.21s.
16:51:40 Insert chunks: 4/319
16:51:40 Insert chunks: 104/319
16:51:40 Insert chunks: 204/319
16:51:40 Insert chunks: 304/319
16:51:40 set_graph added/updated 147 nodes and 170 edges from index in 0.53s.
16:51:40 merging subgraph for doc f421fb06849e11f0bdd32724b93a52b2 into the global graph done in 4.79 seconds.
16:51:40 Knowledge Graph done (204.29s)
```
Before:

```bash
Begin at:
Fri, 29 Aug 2025 17:00:47 GMT
processDuration:
173.38 s
Progress:
17:00:49 Task has been received.
17:00:51 Page(1~7): Start to parse.
17:00:51 Page(1~7): OCR started
17:00:53 Page(1~7): OCR finished (1.82s)
17:00:57 Page(1~7): Layout analysis (3.64s)
17:00:57 Page(1~7): Table analysis (0.00s)
17:00:57 Page(1~7): Text merged (0.00s)
17:00:57 Page(1~7): Finish parsing.
17:00:57 Page(1~7): Generate 7 chunks
17:00:57 Page(1~7): Embedding chunks (0.31s)
17:00:57 Page(1~7): Indexing done (0.03s). Task done (7.88s)
17:00:57 created task graphrag
17:01:00 Task has been received.
17:02:17 Entities extraction of chunk 1 1/7 done, 9 nodes, 9 edges, 10654 tokens.
17:02:31 Entities extraction of chunk 2 2/7 done, 12 nodes, 13 edges, 11066 tokens.
17:02:33 Entities extraction of chunk 4 3/7 done, 9 nodes, 10 edges, 10433 tokens.
17:02:42 Entities extraction of chunk 5 4/7 done, 11 nodes, 14 edges, 11290 tokens.
17:02:52 Entities extraction of chunk 6 5/7 done, 13 nodes, 15 edges, 11039 tokens.
17:02:55 Entities extraction of chunk 3 6/7 done, 14 nodes, 13 edges, 11466 tokens.
17:03:32 Entities extraction of chunk 0 7/7 done, 19 nodes, 18 edges, 13107 tokens.
17:03:32 Entities and relationships extraction done, 71 nodes, 89 edges, 79055 tokens, 149.66s.
17:03:32 Entities merging done, 0.01s.
17:03:32 Relationships merging done, 0.01s.
17:03:32 ignored 1 relations due to missing entities.
17:03:32 generated subgraph for doc b1d9d3b6848711f0aacd7ddc0714c4d3 in 149.69 seconds.
17:03:32 run_graphrag b1d9d3b6848711f0aacd7ddc0714c4d3 graphrag_task_lock acquired
17:03:32 set_graph removed 0 nodes and 0 edges from index in 0.00s.
17:03:32 Get embedding of nodes: 9/71
17:03:33 Get embedding of edges: 9/88
17:03:34 set_graph converted graph change to 161 chunks in 2.27s.
17:03:34 Insert chunks: 4/161
17:03:34 Insert chunks: 104/161
17:03:34 set_graph added/updated 71 nodes and 88 edges from index in 0.28s.
17:03:34 merging subgraph for doc b1d9d3b6848711f0aacd7ddc0714c4d3 into the global graph done in 2.60 seconds.
17:03:34 Knowledge Graph done (153.18s)
```
### Type of change
- [x] Bug Fix (non-breaking change which fixes an issue)
- [x] Refactoring
- [x] Performance Improvement
2025-08-29 17:58:36 +08:00
|
|
|
if system and history and history[0].get("role") != "system":
|
2025-08-12 10:59:20 +08:00
|
|
|
history.insert(0, {"role": "system", "content": system})
|
|
|
|
|
|
|
|
|
|
total_tokens = 0
|
|
|
|
|
hist = deepcopy(history)
|
|
|
|
|
|
|
|
|
|
for attempt in range(self.max_retries + 1):
|
2025-12-08 09:43:03 +08:00
|
|
|
history = deepcopy(hist)
|
2025-08-12 10:59:20 +08:00
|
|
|
try:
|
2026-03-20 20:32:00 +08:00
|
|
|
for _round in range(self.max_rounds + 1):
|
2025-08-12 10:59:20 +08:00
|
|
|
reasoning_start = False
|
2026-04-28 17:09:08 +08:00
|
|
|
reasoning_content = ""
|
2026-03-20 20:32:00 +08:00
|
|
|
logging.info(f"[ToolLoop] round={_round} model={self.model_name} tools={[t['function']['name'] for t in tools]}")
|
2025-08-12 10:59:20 +08:00
|
|
|
|
2025-08-12 15:54:30 +08:00
|
|
|
completion_args = self._construct_completion_args(history=history, stream=True, tools=True, **gen_conf)
|
2025-12-08 09:43:03 +08:00
|
|
|
response = await litellm.acompletion(
|
2025-08-12 10:59:20 +08:00
|
|
|
**completion_args,
|
|
|
|
|
drop_params=True,
|
|
|
|
|
timeout=self.timeout,
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
final_tool_calls = {}
|
|
|
|
|
answer = ""
|
|
|
|
|
|
2025-12-08 09:43:03 +08:00
|
|
|
async for resp in response:
|
2025-08-12 10:59:20 +08:00
|
|
|
if not hasattr(resp, "choices") or not resp.choices:
|
|
|
|
|
continue
|
|
|
|
|
|
|
|
|
|
delta = resp.choices[0].delta
|
|
|
|
|
|
|
|
|
|
if hasattr(delta, "tool_calls") and delta.tool_calls:
|
|
|
|
|
for tool_call in delta.tool_calls:
|
|
|
|
|
index = tool_call.index
|
|
|
|
|
if index not in final_tool_calls:
|
|
|
|
|
if not tool_call.function.arguments:
|
|
|
|
|
tool_call.function.arguments = ""
|
|
|
|
|
final_tool_calls[index] = tool_call
|
|
|
|
|
else:
|
|
|
|
|
final_tool_calls[index].function.arguments += tool_call.function.arguments or ""
|
|
|
|
|
continue
|
|
|
|
|
|
|
|
|
|
if not hasattr(delta, "content") or delta.content is None:
|
|
|
|
|
delta.content = ""
|
|
|
|
|
|
2026-03-10 21:13:14 +08:00
|
|
|
_reasoning = getattr(delta, "reasoning_content", None) or getattr(delta, "reasoning", None)
|
|
|
|
|
if _reasoning:
|
2026-04-28 17:09:08 +08:00
|
|
|
if self._need_reasoning_content_back():
|
|
|
|
|
reasoning_content += _reasoning
|
2025-08-12 10:59:20 +08:00
|
|
|
ans = ""
|
|
|
|
|
if not reasoning_start:
|
|
|
|
|
reasoning_start = True
|
|
|
|
|
ans = "<think>"
|
2026-03-10 21:13:14 +08:00
|
|
|
ans += _reasoning + "</think>"
|
2025-08-12 10:59:20 +08:00
|
|
|
yield ans
|
|
|
|
|
else:
|
|
|
|
|
reasoning_start = False
|
|
|
|
|
answer += delta.content
|
|
|
|
|
yield delta.content
|
|
|
|
|
|
2025-10-22 12:25:31 +08:00
|
|
|
tol = total_token_count_from_response(resp)
|
2025-08-12 10:59:20 +08:00
|
|
|
if not tol:
|
|
|
|
|
total_tokens += num_tokens_from_string(delta.content)
|
|
|
|
|
else:
|
2025-12-08 09:43:03 +08:00
|
|
|
total_tokens = tol
|
2025-08-12 10:59:20 +08:00
|
|
|
|
|
|
|
|
finish_reason = getattr(resp.choices[0], "finish_reason", "")
|
|
|
|
|
if finish_reason == "length":
|
|
|
|
|
yield self._length_stop("")
|
|
|
|
|
|
2026-03-20 20:32:00 +08:00
|
|
|
if answer and not final_tool_calls:
|
|
|
|
|
logging.info(f"[ToolLoop] round={_round} completed with text response, exiting")
|
2025-08-12 10:59:20 +08:00
|
|
|
yield total_tokens
|
|
|
|
|
return
|
|
|
|
|
|
2026-03-20 20:32:00 +08:00
|
|
|
async def _exec_tool(tc):
|
|
|
|
|
name = tc.function.name
|
2025-08-12 10:59:20 +08:00
|
|
|
try:
|
2026-03-20 20:32:00 +08:00
|
|
|
args = json_repair.loads(tc.function.arguments)
|
2026-05-20 16:56:20 +08:00
|
|
|
if not isinstance(args, dict):
|
|
|
|
|
raise TypeError(f"Tool arguments for {name} must be a JSON object, got {type(args).__name__}")
|
2026-03-20 20:32:00 +08:00
|
|
|
if hasattr(self.toolcall_session, "tool_call_async"):
|
|
|
|
|
result = await self.toolcall_session.tool_call_async(name, args)
|
|
|
|
|
else:
|
|
|
|
|
result = await thread_pool_exec(self.toolcall_session.tool_call, name, args)
|
|
|
|
|
return tc, name, args, result, None
|
2025-08-12 10:59:20 +08:00
|
|
|
except Exception as e:
|
2026-03-20 20:32:00 +08:00
|
|
|
logging.exception(f"Tool call failed: {tc}")
|
|
|
|
|
return tc, name, {}, None, e
|
|
|
|
|
|
|
|
|
|
tcs = list(final_tool_calls.values())
|
|
|
|
|
logging.info(f"[ToolLoop] round={_round} executing {len(tcs)} tool(s): {[tc.function.name for tc in tcs]}")
|
|
|
|
|
for tc in tcs:
|
|
|
|
|
try:
|
|
|
|
|
args = json_repair.loads(tc.function.arguments)
|
|
|
|
|
except Exception:
|
|
|
|
|
args = {}
|
|
|
|
|
yield self._verbose_tool_use(tc.function.name, args, "Begin to call...")
|
|
|
|
|
results = await asyncio.gather(*[_exec_tool(tc) for tc in tcs])
|
2026-04-28 17:09:08 +08:00
|
|
|
history = self._append_history_batch(
|
|
|
|
|
history,
|
|
|
|
|
results,
|
|
|
|
|
reasoning_content=reasoning_content if self._need_reasoning_content_back() else None,
|
|
|
|
|
)
|
2026-03-20 20:32:00 +08:00
|
|
|
for tc, name, args, result, err in results:
|
|
|
|
|
yield self._verbose_tool_use(name, args, err if err else result)
|
2025-08-12 10:59:20 +08:00
|
|
|
|
|
|
|
|
logging.warning(f"Exceed max rounds: {self.max_rounds}")
|
|
|
|
|
history.append({"role": "user", "content": f"Exceed max rounds: {self.max_rounds}"})
|
|
|
|
|
|
2025-08-12 15:54:30 +08:00
|
|
|
completion_args = self._construct_completion_args(history=history, stream=True, tools=True, **gen_conf)
|
2025-12-08 09:43:03 +08:00
|
|
|
response = await litellm.acompletion(
|
2025-08-12 10:59:20 +08:00
|
|
|
**completion_args,
|
|
|
|
|
drop_params=True,
|
|
|
|
|
timeout=self.timeout,
|
|
|
|
|
)
|
|
|
|
|
|
2025-12-08 09:43:03 +08:00
|
|
|
async for resp in response:
|
2025-08-12 10:59:20 +08:00
|
|
|
if not hasattr(resp, "choices") or not resp.choices:
|
|
|
|
|
continue
|
|
|
|
|
delta = resp.choices[0].delta
|
|
|
|
|
if not hasattr(delta, "content") or delta.content is None:
|
|
|
|
|
continue
|
2025-10-22 12:25:31 +08:00
|
|
|
tol = total_token_count_from_response(resp)
|
2025-08-12 10:59:20 +08:00
|
|
|
if not tol:
|
|
|
|
|
total_tokens += num_tokens_from_string(delta.content)
|
|
|
|
|
else:
|
2025-12-08 09:43:03 +08:00
|
|
|
total_tokens = tol
|
2025-08-12 10:59:20 +08:00
|
|
|
yield delta.content
|
|
|
|
|
|
|
|
|
|
yield total_tokens
|
|
|
|
|
return
|
|
|
|
|
|
|
|
|
|
except Exception as e:
|
2025-12-08 09:43:03 +08:00
|
|
|
e = await self._exceptions_async(e, attempt)
|
2025-08-12 10:59:20 +08:00
|
|
|
if e:
|
|
|
|
|
yield e
|
|
|
|
|
yield total_tokens
|
|
|
|
|
return
|
|
|
|
|
|
|
|
|
|
assert False, "Shouldn't be here."
|
|
|
|
|
|
2025-12-08 09:43:03 +08:00
|
|
|
def _construct_completion_args(self, history, stream: bool, tools: bool, **kwargs):
|
|
|
|
|
completion_args = {
|
|
|
|
|
"model": self.model_name,
|
|
|
|
|
"messages": history,
|
|
|
|
|
"api_key": self.api_key,
|
|
|
|
|
"num_retries": self.max_retries,
|
|
|
|
|
**kwargs,
|
|
|
|
|
}
|
|
|
|
|
if stream:
|
|
|
|
|
completion_args.update(
|
|
|
|
|
{
|
|
|
|
|
"stream": stream,
|
|
|
|
|
}
|
|
|
|
|
)
|
|
|
|
|
if tools and self.tools:
|
|
|
|
|
completion_args.update(
|
|
|
|
|
{
|
|
|
|
|
"tools": self.tools,
|
|
|
|
|
"tool_choice": "auto",
|
|
|
|
|
}
|
|
|
|
|
)
|
|
|
|
|
if self.provider in FACTORY_DEFAULT_BASE_URL:
|
|
|
|
|
completion_args.update({"api_base": self.base_url})
|
|
|
|
|
elif self.provider == SupportedLiteLLMProvider.Bedrock:
|
2025-12-19 11:32:20 +08:00
|
|
|
import boto3
|
|
|
|
|
|
2025-12-08 09:43:03 +08:00
|
|
|
completion_args.pop("api_key", None)
|
|
|
|
|
completion_args.pop("api_base", None)
|
2025-12-19 11:32:20 +08:00
|
|
|
|
|
|
|
|
bedrock_key = json.loads(self.api_key)
|
|
|
|
|
mode = bedrock_key.get("auth_mode")
|
|
|
|
|
if not mode:
|
|
|
|
|
logging.error("Bedrock auth_mode is not provided in the key")
|
|
|
|
|
raise ValueError("Bedrock auth_mode must be provided in the key")
|
|
|
|
|
|
|
|
|
|
bedrock_region = bedrock_key.get("bedrock_region")
|
|
|
|
|
|
|
|
|
|
if mode == "access_key_secret":
|
2026-01-08 12:53:41 +08:00
|
|
|
completion_args.update({"aws_region_name": bedrock_region})
|
|
|
|
|
completion_args.update({"aws_access_key_id": bedrock_key.get("bedrock_ak")})
|
|
|
|
|
completion_args.update({"aws_secret_access_key": bedrock_key.get("bedrock_sk")})
|
2025-12-19 11:32:20 +08:00
|
|
|
elif mode == "iam_role":
|
|
|
|
|
aws_role_arn = bedrock_key.get("aws_role_arn")
|
|
|
|
|
sts_client = boto3.client("sts", region_name=bedrock_region)
|
|
|
|
|
resp = sts_client.assume_role(RoleArn=aws_role_arn, RoleSessionName="BedrockSession")
|
|
|
|
|
creds = resp["Credentials"]
|
2026-01-08 12:53:41 +08:00
|
|
|
completion_args.update({"aws_region_name": bedrock_region})
|
|
|
|
|
completion_args.update({"aws_access_key_id": creds["AccessKeyId"]})
|
|
|
|
|
completion_args.update({"aws_secret_access_key": creds["SecretAccessKey"]})
|
|
|
|
|
completion_args.update({"aws_session_token": creds["SessionToken"]})
|
|
|
|
|
else: # assume_role - use default credential chain (IRSA, instance profile, etc.)
|
|
|
|
|
completion_args.update({"aws_region_name": bedrock_region})
|
2025-12-19 11:32:20 +08:00
|
|
|
|
2025-12-08 09:43:03 +08:00
|
|
|
elif self.provider == SupportedLiteLLMProvider.OpenRouter:
|
|
|
|
|
if self.provider_order:
|
2025-08-12 10:59:20 +08:00
|
|
|
|
2025-12-08 09:43:03 +08:00
|
|
|
def _to_order_list(x):
|
|
|
|
|
if x is None:
|
|
|
|
|
return []
|
|
|
|
|
if isinstance(x, str):
|
|
|
|
|
return [s.strip() for s in x.split(",") if s.strip()]
|
|
|
|
|
if isinstance(x, (list, tuple)):
|
|
|
|
|
return [str(s).strip() for s in x if str(s).strip()]
|
|
|
|
|
return []
|
2025-08-12 10:59:20 +08:00
|
|
|
|
2025-12-08 09:43:03 +08:00
|
|
|
extra_body = {}
|
|
|
|
|
provider_cfg = {}
|
|
|
|
|
provider_order = _to_order_list(self.provider_order)
|
|
|
|
|
provider_cfg["order"] = provider_order
|
|
|
|
|
provider_cfg["allow_fallbacks"] = False
|
|
|
|
|
extra_body["provider"] = provider_cfg
|
|
|
|
|
completion_args.update({"extra_body": extra_body})
|
|
|
|
|
elif self.provider == SupportedLiteLLMProvider.GPUStack:
|
|
|
|
|
completion_args.update(
|
|
|
|
|
{
|
2026-02-27 20:13:07 +08:00
|
|
|
"api_base": urljoin(self.base_url, "v1"),
|
2025-12-08 09:43:03 +08:00
|
|
|
}
|
|
|
|
|
)
|
2025-12-13 11:32:46 +08:00
|
|
|
elif self.provider == SupportedLiteLLMProvider.Azure_OpenAI:
|
|
|
|
|
completion_args.pop("api_key", None)
|
|
|
|
|
completion_args.pop("api_base", None)
|
|
|
|
|
completion_args.update(
|
|
|
|
|
{
|
|
|
|
|
"api_key": self.api_key,
|
|
|
|
|
"api_base": self.base_url,
|
|
|
|
|
"api_version": self.api_version,
|
|
|
|
|
}
|
|
|
|
|
)
|
2025-08-12 10:59:20 +08:00
|
|
|
|
2025-12-08 09:43:03 +08:00
|
|
|
# Ollama deployments commonly sit behind a reverse proxy that enforces
|
|
|
|
|
# Bearer auth. Ensure the Authorization header is set when an API key
|
|
|
|
|
# is provided, while respecting any user-supplied headers. #11350
|
|
|
|
|
extra_headers = deepcopy(completion_args.get("extra_headers") or {})
|
|
|
|
|
if self.provider == SupportedLiteLLMProvider.Ollama and self.api_key and "Authorization" not in extra_headers:
|
|
|
|
|
extra_headers["Authorization"] = f"Bearer {self.api_key}"
|
2026-05-07 11:54:49 +08:00
|
|
|
# MiniMax requires GroupId as a query parameter for API authentication
|
|
|
|
|
if self.provider == SupportedLiteLLMProvider.MiniMax and hasattr(self, 'group_id') and self.group_id:
|
|
|
|
|
api_base = completion_args.get("api_base", self.base_url)
|
|
|
|
|
separator = "&" if "?" in api_base else "?"
|
|
|
|
|
completion_args["api_base"] = f"{api_base}{separator}GroupId={self.group_id}"
|
2025-12-08 09:43:03 +08:00
|
|
|
if extra_headers:
|
|
|
|
|
completion_args["extra_headers"] = extra_headers
|
|
|
|
|
return completion_args
|
2026-01-27 17:04:53 +08:00
|
|
|
|
Fix AttributeError when appending non-streaming tool calls to chat history in Agentic Agent (#14456)
### What problem does this PR solve?
Fix #14340
## Problem Description
When using an **Agentic Agent** (not Workflow) with one or more
Retrieval tools (e.g., Dataset Retrieval + Memory Retrieval), the agent
silently returns an empty response (`agent_response: ""`) after hanging
for several minutes. The server logs show:
```
AttributeError: 'ChatCompletionMessageToolCall' object has no attribute 'index'
```
This error propagates as a `GENERIC_ERROR`, causing the canvas to return
an empty response. The subsequent Memory save task then receives the
empty `agent_response` and logs:
```
Document for referred_document_id XXXX not found
```
## Reproduction Steps
1. Set `DOC_ENGINE=infinity` (or `elasticsearch` — the engine itself is
not the root cause).
2. Create a blank **Agentic Agent** (not a Workflow).
3. Add **two Retrieval tools** to the Agent node:
- `Retrieval_DS` → Dataset (Knowledge Base)
- `Retrieval_Mem` → Memory component
4. Add a **Message** node with **Save to Memory** enabled.
5. Launch the agent and send any message (e.g., "hola").
6. The agent hangs and returns an empty response.
## Root Cause Analysis
The crash occurs in `_append_history` and `_append_history_batch` inside
`rag/llm/chat_model.py`. These methods directly access `.index` on tool
call objects:
```python
# _append_history_batch
{
"index": tc.index, # <-- crashes here
...
}
```
However, **non-streaming** LLM responses (`stream=False`) return
`ChatCompletionMessageToolCall` objects, which **do not have an `index`
field** according to the OpenAI API specification. The `index` field
only exists on `ChoiceDeltaToolCall` objects returned in **streaming**
responses (`stream=True`).
When the agentic agent triggers an internal `full_question` call (used
to compress multi-turn conversation history), the request is incorrectly
routed through `async_chat_with_tools` because `is_tools=True` is set at
the `LLMBundle` level. If the LLM decides to emit `tool_calls` during
this auxiliary request, the code enters the non-streaming tool loop and
crashes when trying to append history.
## Fix
Replaced all direct `.index` accesses with `getattr(..., "index", None)`
for safe, backward-compatible access:
| Method | File | Line | Change |
|--------|------|------|--------|
| `_append_history` | `rag/llm/chat_model.py` | ~L304 |
`tool_call.index` → `getattr(tool_call, "index", None)` |
| `_append_history_batch` | `rag/llm/chat_model.py` | ~L332 | `tc.index`
→ `getattr(tc, "index", None)` |
| `_append_history` | `rag/llm/chat_model.py` | ~L1467 |
`tool_call.index` → `getattr(tool_call, "index", None)` |
| `_append_history_batch` | `rag/llm/chat_model.py` | ~L1496 |
`tc.index` → `getattr(tc, "index", None)` |
### Type of change
- [x] Bug Fix (non-breaking change which fixes an issue)
Signed-off-by: noob <yixiao121314@outlook.com>
2026-05-05 23:39:40 -07:00
|
|
|
|
2026-03-06 02:37:27 +01:00
|
|
|
class RAGconChat(Base):
|
|
|
|
|
"""
|
|
|
|
|
RAGcon Chat Provider - routes through LiteLLM proxy
|
Fix AttributeError when appending non-streaming tool calls to chat history in Agentic Agent (#14456)
### What problem does this PR solve?
Fix #14340
## Problem Description
When using an **Agentic Agent** (not Workflow) with one or more
Retrieval tools (e.g., Dataset Retrieval + Memory Retrieval), the agent
silently returns an empty response (`agent_response: ""`) after hanging
for several minutes. The server logs show:
```
AttributeError: 'ChatCompletionMessageToolCall' object has no attribute 'index'
```
This error propagates as a `GENERIC_ERROR`, causing the canvas to return
an empty response. The subsequent Memory save task then receives the
empty `agent_response` and logs:
```
Document for referred_document_id XXXX not found
```
## Reproduction Steps
1. Set `DOC_ENGINE=infinity` (or `elasticsearch` — the engine itself is
not the root cause).
2. Create a blank **Agentic Agent** (not a Workflow).
3. Add **two Retrieval tools** to the Agent node:
- `Retrieval_DS` → Dataset (Knowledge Base)
- `Retrieval_Mem` → Memory component
4. Add a **Message** node with **Save to Memory** enabled.
5. Launch the agent and send any message (e.g., "hola").
6. The agent hangs and returns an empty response.
## Root Cause Analysis
The crash occurs in `_append_history` and `_append_history_batch` inside
`rag/llm/chat_model.py`. These methods directly access `.index` on tool
call objects:
```python
# _append_history_batch
{
"index": tc.index, # <-- crashes here
...
}
```
However, **non-streaming** LLM responses (`stream=False`) return
`ChatCompletionMessageToolCall` objects, which **do not have an `index`
field** according to the OpenAI API specification. The `index` field
only exists on `ChoiceDeltaToolCall` objects returned in **streaming**
responses (`stream=True`).
When the agentic agent triggers an internal `full_question` call (used
to compress multi-turn conversation history), the request is incorrectly
routed through `async_chat_with_tools` because `is_tools=True` is set at
the `LLMBundle` level. If the LLM decides to emit `tool_calls` during
this auxiliary request, the code enters the non-streaming tool loop and
crashes when trying to append history.
## Fix
Replaced all direct `.index` accesses with `getattr(..., "index", None)`
for safe, backward-compatible access:
| Method | File | Line | Change |
|--------|------|------|--------|
| `_append_history` | `rag/llm/chat_model.py` | ~L304 |
`tool_call.index` → `getattr(tool_call, "index", None)` |
| `_append_history_batch` | `rag/llm/chat_model.py` | ~L332 | `tc.index`
→ `getattr(tc, "index", None)` |
| `_append_history` | `rag/llm/chat_model.py` | ~L1467 |
`tool_call.index` → `getattr(tool_call, "index", None)` |
| `_append_history_batch` | `rag/llm/chat_model.py` | ~L1496 |
`tc.index` → `getattr(tc, "index", None)` |
### Type of change
- [x] Bug Fix (non-breaking change which fixes an issue)
Signed-off-by: noob <yixiao121314@outlook.com>
2026-05-05 23:39:40 -07:00
|
|
|
|
2026-03-06 02:37:27 +01:00
|
|
|
All model types are handled through a unified LiteLLM endpoint.
|
|
|
|
|
Default Base URL: https://connect.ragcon.com/v1
|
|
|
|
|
"""
|
Fix AttributeError when appending non-streaming tool calls to chat history in Agentic Agent (#14456)
### What problem does this PR solve?
Fix #14340
## Problem Description
When using an **Agentic Agent** (not Workflow) with one or more
Retrieval tools (e.g., Dataset Retrieval + Memory Retrieval), the agent
silently returns an empty response (`agent_response: ""`) after hanging
for several minutes. The server logs show:
```
AttributeError: 'ChatCompletionMessageToolCall' object has no attribute 'index'
```
This error propagates as a `GENERIC_ERROR`, causing the canvas to return
an empty response. The subsequent Memory save task then receives the
empty `agent_response` and logs:
```
Document for referred_document_id XXXX not found
```
## Reproduction Steps
1. Set `DOC_ENGINE=infinity` (or `elasticsearch` — the engine itself is
not the root cause).
2. Create a blank **Agentic Agent** (not a Workflow).
3. Add **two Retrieval tools** to the Agent node:
- `Retrieval_DS` → Dataset (Knowledge Base)
- `Retrieval_Mem` → Memory component
4. Add a **Message** node with **Save to Memory** enabled.
5. Launch the agent and send any message (e.g., "hola").
6. The agent hangs and returns an empty response.
## Root Cause Analysis
The crash occurs in `_append_history` and `_append_history_batch` inside
`rag/llm/chat_model.py`. These methods directly access `.index` on tool
call objects:
```python
# _append_history_batch
{
"index": tc.index, # <-- crashes here
...
}
```
However, **non-streaming** LLM responses (`stream=False`) return
`ChatCompletionMessageToolCall` objects, which **do not have an `index`
field** according to the OpenAI API specification. The `index` field
only exists on `ChoiceDeltaToolCall` objects returned in **streaming**
responses (`stream=True`).
When the agentic agent triggers an internal `full_question` call (used
to compress multi-turn conversation history), the request is incorrectly
routed through `async_chat_with_tools` because `is_tools=True` is set at
the `LLMBundle` level. If the LLM decides to emit `tool_calls` during
this auxiliary request, the code enters the non-streaming tool loop and
crashes when trying to append history.
## Fix
Replaced all direct `.index` accesses with `getattr(..., "index", None)`
for safe, backward-compatible access:
| Method | File | Line | Change |
|--------|------|------|--------|
| `_append_history` | `rag/llm/chat_model.py` | ~L304 |
`tool_call.index` → `getattr(tool_call, "index", None)` |
| `_append_history_batch` | `rag/llm/chat_model.py` | ~L332 | `tc.index`
→ `getattr(tc, "index", None)` |
| `_append_history` | `rag/llm/chat_model.py` | ~L1467 |
`tool_call.index` → `getattr(tool_call, "index", None)` |
| `_append_history_batch` | `rag/llm/chat_model.py` | ~L1496 |
`tc.index` → `getattr(tc, "index", None)` |
### Type of change
- [x] Bug Fix (non-breaking change which fixes an issue)
Signed-off-by: noob <yixiao121314@outlook.com>
2026-05-05 23:39:40 -07:00
|
|
|
|
2026-03-06 02:37:27 +01:00
|
|
|
_FACTORY_NAME = "RAGcon"
|
Fix AttributeError when appending non-streaming tool calls to chat history in Agentic Agent (#14456)
### What problem does this PR solve?
Fix #14340
## Problem Description
When using an **Agentic Agent** (not Workflow) with one or more
Retrieval tools (e.g., Dataset Retrieval + Memory Retrieval), the agent
silently returns an empty response (`agent_response: ""`) after hanging
for several minutes. The server logs show:
```
AttributeError: 'ChatCompletionMessageToolCall' object has no attribute 'index'
```
This error propagates as a `GENERIC_ERROR`, causing the canvas to return
an empty response. The subsequent Memory save task then receives the
empty `agent_response` and logs:
```
Document for referred_document_id XXXX not found
```
## Reproduction Steps
1. Set `DOC_ENGINE=infinity` (or `elasticsearch` — the engine itself is
not the root cause).
2. Create a blank **Agentic Agent** (not a Workflow).
3. Add **two Retrieval tools** to the Agent node:
- `Retrieval_DS` → Dataset (Knowledge Base)
- `Retrieval_Mem` → Memory component
4. Add a **Message** node with **Save to Memory** enabled.
5. Launch the agent and send any message (e.g., "hola").
6. The agent hangs and returns an empty response.
## Root Cause Analysis
The crash occurs in `_append_history` and `_append_history_batch` inside
`rag/llm/chat_model.py`. These methods directly access `.index` on tool
call objects:
```python
# _append_history_batch
{
"index": tc.index, # <-- crashes here
...
}
```
However, **non-streaming** LLM responses (`stream=False`) return
`ChatCompletionMessageToolCall` objects, which **do not have an `index`
field** according to the OpenAI API specification. The `index` field
only exists on `ChoiceDeltaToolCall` objects returned in **streaming**
responses (`stream=True`).
When the agentic agent triggers an internal `full_question` call (used
to compress multi-turn conversation history), the request is incorrectly
routed through `async_chat_with_tools` because `is_tools=True` is set at
the `LLMBundle` level. If the LLM decides to emit `tool_calls` during
this auxiliary request, the code enters the non-streaming tool loop and
crashes when trying to append history.
## Fix
Replaced all direct `.index` accesses with `getattr(..., "index", None)`
for safe, backward-compatible access:
| Method | File | Line | Change |
|--------|------|------|--------|
| `_append_history` | `rag/llm/chat_model.py` | ~L304 |
`tool_call.index` → `getattr(tool_call, "index", None)` |
| `_append_history_batch` | `rag/llm/chat_model.py` | ~L332 | `tc.index`
→ `getattr(tc, "index", None)` |
| `_append_history` | `rag/llm/chat_model.py` | ~L1467 |
`tool_call.index` → `getattr(tool_call, "index", None)` |
| `_append_history_batch` | `rag/llm/chat_model.py` | ~L1496 |
`tc.index` → `getattr(tc, "index", None)` |
### Type of change
- [x] Bug Fix (non-breaking change which fixes an issue)
Signed-off-by: noob <yixiao121314@outlook.com>
2026-05-05 23:39:40 -07:00
|
|
|
|
2026-03-06 02:37:27 +01:00
|
|
|
def __init__(self, key, model_name, base_url=None, **kwargs):
|
|
|
|
|
if not base_url:
|
|
|
|
|
base_url = "https://connect.ragcon.com/v1"
|
Fix AttributeError when appending non-streaming tool calls to chat history in Agentic Agent (#14456)
### What problem does this PR solve?
Fix #14340
## Problem Description
When using an **Agentic Agent** (not Workflow) with one or more
Retrieval tools (e.g., Dataset Retrieval + Memory Retrieval), the agent
silently returns an empty response (`agent_response: ""`) after hanging
for several minutes. The server logs show:
```
AttributeError: 'ChatCompletionMessageToolCall' object has no attribute 'index'
```
This error propagates as a `GENERIC_ERROR`, causing the canvas to return
an empty response. The subsequent Memory save task then receives the
empty `agent_response` and logs:
```
Document for referred_document_id XXXX not found
```
## Reproduction Steps
1. Set `DOC_ENGINE=infinity` (or `elasticsearch` — the engine itself is
not the root cause).
2. Create a blank **Agentic Agent** (not a Workflow).
3. Add **two Retrieval tools** to the Agent node:
- `Retrieval_DS` → Dataset (Knowledge Base)
- `Retrieval_Mem` → Memory component
4. Add a **Message** node with **Save to Memory** enabled.
5. Launch the agent and send any message (e.g., "hola").
6. The agent hangs and returns an empty response.
## Root Cause Analysis
The crash occurs in `_append_history` and `_append_history_batch` inside
`rag/llm/chat_model.py`. These methods directly access `.index` on tool
call objects:
```python
# _append_history_batch
{
"index": tc.index, # <-- crashes here
...
}
```
However, **non-streaming** LLM responses (`stream=False`) return
`ChatCompletionMessageToolCall` objects, which **do not have an `index`
field** according to the OpenAI API specification. The `index` field
only exists on `ChoiceDeltaToolCall` objects returned in **streaming**
responses (`stream=True`).
When the agentic agent triggers an internal `full_question` call (used
to compress multi-turn conversation history), the request is incorrectly
routed through `async_chat_with_tools` because `is_tools=True` is set at
the `LLMBundle` level. If the LLM decides to emit `tool_calls` during
this auxiliary request, the code enters the non-streaming tool loop and
crashes when trying to append history.
## Fix
Replaced all direct `.index` accesses with `getattr(..., "index", None)`
for safe, backward-compatible access:
| Method | File | Line | Change |
|--------|------|------|--------|
| `_append_history` | `rag/llm/chat_model.py` | ~L304 |
`tool_call.index` → `getattr(tool_call, "index", None)` |
| `_append_history_batch` | `rag/llm/chat_model.py` | ~L332 | `tc.index`
→ `getattr(tc, "index", None)` |
| `_append_history` | `rag/llm/chat_model.py` | ~L1467 |
`tool_call.index` → `getattr(tool_call, "index", None)` |
| `_append_history_batch` | `rag/llm/chat_model.py` | ~L1496 |
`tc.index` → `getattr(tc, "index", None)` |
### Type of change
- [x] Bug Fix (non-breaking change which fixes an issue)
Signed-off-by: noob <yixiao121314@outlook.com>
2026-05-05 23:39:40 -07:00
|
|
|
|
2026-03-06 02:37:27 +01:00
|
|
|
super().__init__(key, model_name, base_url, **kwargs)
|