Files
ragflow/internal/handler/search_handler_test.go

101 lines
2.9 KiB
Go
Raw Normal View History

//
// Copyright 2026 The InfiniFlow Authors. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//
package handler
import (
"encoding/json"
"net/http"
"strings"
"testing"
"github.com/gin-gonic/gin"
"github.com/glebarez/sqlite"
"gorm.io/gorm"
"ragflow/internal/common"
"ragflow/internal/dao"
"ragflow/internal/entity"
"ragflow/internal/service"
)
func setupSearchHandlerTestDB(t *testing.T) *gorm.DB {
t.Helper()
db, err := gorm.Open(sqlite.Open(":memory:"), &gorm.Config{
TranslateError: true,
})
if err != nil {
t.Fatalf("failed to open sqlite: %v", err)
}
if err := db.AutoMigrate(&entity.Search{}, &entity.UserTenant{}); err != nil {
t.Fatalf("failed to migrate test schema: %v", err)
}
origDB := dao.DB
dao.DB = db
t.Cleanup(func() { dao.DB = origDB })
return db
}
func TestSearchHandlerCreateRejectsEmptyName(t *testing.T) {
setupSearchHandlerTestDB(t)
h := NewSearchHandler(service.NewSearchService(), service.NewUserService())
c, w := setupGinContextWithUser("POST", "/api/v1/searches", `{"name": " "}`)
h.CreateSearch(c)
if w.Code != http.StatusOK {
t.Fatalf("expected 200, got %d: %s", w.Code, w.Body.String())
}
var resp map[string]interface{}
if err := json.Unmarshal(w.Body.Bytes(), &resp); err != nil {
t.Fatalf("failed to decode response: %v", err)
}
if resp["code"] != float64(common.CodeDataError) {
t.Fatalf("expected code 102, got %v", resp["code"])
}
if !strings.Contains(resp["message"].(string), "empty") {
t.Fatalf("expected message containing 'empty', got %v", resp["message"])
}
}
func TestSearchHandlerUpdateRejectsInvalidSearchID(t *testing.T) {
setupSearchHandlerTestDB(t)
h := NewSearchHandler(service.NewSearchService(), service.NewUserService())
c, w := setupGinContextWithUser("PUT", "/api/v1/searches/invalid_search_id", `{"name": "invalid", "search_config": {}}`)
c.Params = []gin.Param{{Key: "search_id", Value: "invalid_search_id"}}
h.UpdateSearch(c)
if w.Code != http.StatusOK {
t.Fatalf("expected 200, got %d: %s", w.Code, w.Body.String())
}
var resp map[string]interface{}
if err := json.Unmarshal(w.Body.Bytes(), &resp); err != nil {
t.Fatalf("failed to decode response: %v", err)
}
if resp["code"] != float64(common.CodeAuthenticationError) {
t.Fatalf("expected code 109, got %v", resp["code"])
}
Fix internal/handler test failures, align response with Python contract, and re-enable handler/storage/agent tests in CI (#17554) ## Summary Fixes the 6 pre-existing failures in `internal/handler`, aligns one response field with the Python API contract, and re-enables packages in CI that were previously excluded because of (or unrelated to) those failures. ### Test/handler fixes - **plugin.go**: return `"success"` (lowercase) instead of `"SUCCESS"` so the response envelope matches the Python backend, keeping backend-swap transparent. - **search_handler_test.go**: expect lowercase `"no authorization"` to match the service error message, which mirrors Python. - **agent_test.go**: seed versions with `CreateTime` instead of `UpdateTime` so `ListVersions` ordering (`create_time DESC`) is exercised correctly. - **agent_wait_for_user_test.go**: a clean run may emit only the `[DONE]` frame; relax the SSE assertion to require a non-empty stream ending in `[DONE]`. - **bot_test.go**: align attachment-download assertions with actual behavior (`Content-Disposition: attachment; filename="file"`, default `application/octet-stream`), matching Python `resolve_attachment_content_type`. ### CI - **tests.yml / sep-tests.yml**: - Remove the `grep -v '/internal/handler$'` filter — the 6 failures that motivated it are now fixed. - Remove the `grep -v '/internal/storage$'` filter — `internal/storage` tests self-skip via `t.Skipf` when MinIO is unavailable, so the package is safe to run in CI. - Remove the `grep -v '/internal/agent$'` filter (only present in the tests.yml infinity job) — the exclusion was undocumented and inconsistent with the other jobs that already run `internal/agent`. - Keep the `internal/tokenizer` exclusion: it is a genuine environmental dependency (dict files at `/usr/share/infinity/resource`, absent in the Go test environment). ## Test plan - `build.sh --test ./internal/handler/` is green (previously 6 FAIL). - `build.sh --test ./internal/storage/ ./internal/agent/` should pass; the MinIO-backed `internal/storage` tests skip gracefully without a MinIO server. - After this PR, `internal/handler`, `internal/storage`, and `internal/agent` run again in CI unit-test jobs; `internal/tokenizer` stays excluded. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
2026-07-30 16:59:39 +08:00
if !strings.Contains(resp["message"].(string), "no authorization") {
t.Fatalf("expected 'no authorization' in message, got %v", resp["message"])
}
}