mirror of
https://github.com/Comfy-Org/ComfyUI.git
synced 2026-08-22 09:16:02 +08:00
39e9db11e8
* feat(execution): attach media metadata to output entries
Enrich file-type output entries with a nested metadata object
({kind, width, height} for images, plus {duration, fps, frame_count}
for videos) at output-processing time, reusing the extractors from the
asset system's media_metadata service. Unlike asset-id enrichment this
is not gated on --enable-assets: the properties flow into the executed
websocket message and /history for every consumer, including ones
without the assets system enabled.
The path containment guard moves to media_enrichment.py and is shared
with asset_enrichment.py.
* fix(execution): harden output-entry media enrichment per review
- Resolve symlinks (realpath on base and candidate) before the
containment check, so a symlink planted inside output/ can't smuggle
an outside target past commonpath; also covers output dirs that are
themselves symlinks. Applies to both enrichers via the shared helper.
- Validate filename/subfolder/type are strings before path resolution
so a malformed entry skips cleanly instead of raising TypeError.
- Broaden the lazy-import guard beyond ImportError: the enrichment is
called unguarded on the output path and must degrade to a no-op when
a dependency fails to import for any reason.
- Tests: real-filesystem symlink escape/containment, non-string fields,
non-ImportError import failure.