mirror of
https://github.com/Comfy-Org/ComfyUI.git
synced 2026-08-26 19:02:36 +08:00
Document --cuda-device comma format and MultiGPU Options relative_speed gap
Two doc-only changes addressing minor CodeRabbit findings on PR #7063: * cli_args.py: clarify --cuda-device help text to document the required comma-separated format ('0' or '0,1'), matching how the value is consumed by CUDA_VISIBLE_DEVICES in main.py. * nodes_multigpu.py: add a docstring NOTE on the (currently unregistered) MultiGPUOptionsNode explaining that its relative_speed input is plumbed through to model_options['multigpu_options'] but is not yet consulted by the cond scheduler, which still uses uniform round-robin via next_available_device(). Wire relative_speed into the scheduler before re-enabling the node. Amp-Thread-ID: https://ampcode.com/threads/T-019e43b8-8258-70fd-ab3a-53e4c97f85d5 Co-authored-by: Amp <amp@ampcode.com>
This commit is contained in:
@@ -45,6 +45,16 @@ class MultiGPUCFGSplitNode(io.ComfyNode):
|
||||
class MultiGPUOptionsNode(io.ComfyNode):
|
||||
"""
|
||||
Select the relative speed of GPUs in the special case they have significantly different performance from one another.
|
||||
|
||||
NOTE (not registered yet, see MultiGPUExtension.get_node_list below):
|
||||
The output GPUOptionsGroup is plumbed through create_multigpu_deepclones() and stored on
|
||||
model.model_options['multigpu_options'] via GPUOptionsGroup.register(), but the cond
|
||||
scheduler in comfy/samplers.py (calc_cond_batch_outer_multigpu) does NOT yet consult
|
||||
relative_speed when distributing conds across devices; it uses a uniform conds_per_device
|
||||
round-robin via next_available_device(). Before re-enabling this node, wire its
|
||||
relative_speed into the scheduler (e.g. via comfy.multigpu.load_balance_devices(),
|
||||
which already implements the proportional split) so the input actually affects work
|
||||
distribution.
|
||||
"""
|
||||
|
||||
@classmethod
|
||||
|
||||
Reference in New Issue
Block a user