From 2d43a135eb2ce0d66b902b1d90df5a3ec8087d41 Mon Sep 17 00:00:00 2001
From: bymyself <cbyrne@comfy.org>
Date: Thu, 6 Aug 2026 20:35:47 -0700
Subject: [PATCH] ci: make unit and execution tests able to fail a PR

Both jobs were continue-on-error: true at the job level, so a failing
pytest run reported success. They are the only two jobs in the workflow
tree that do this.

Verified green before removing the flag: the last 30 completed runs of
each workflow on master (90 matrix jobs each, ubuntu/windows/macos) have
zero failing steps.

Also sets fail-fast: false so one OS failing no longer cancels the other
two matrix legs' results.
---
 .github/workflows/test-execution.yml | 2 +-
 .github/workflows/test-unit.yml      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/test-execution.yml b/.github/workflows/test-execution.yml
index 9012633d8..79aace424 100644
--- a/.github/workflows/test-execution.yml
+++ b/.github/workflows/test-execution.yml
@@ -9,10 +9,10 @@ on:
 jobs:
   test:
     strategy:
+      fail-fast: false
       matrix:
         os: [ubuntu-latest, windows-latest, macos-latest]
     runs-on: ${{ matrix.os }}
-    continue-on-error: true
     steps:
     - uses: actions/checkout@v4
     - name: Set up Python      
diff --git a/.github/workflows/test-unit.yml b/.github/workflows/test-unit.yml
index d05179cd3..3275e319e 100644
--- a/.github/workflows/test-unit.yml
+++ b/.github/workflows/test-unit.yml
@@ -9,10 +9,10 @@ on:
 jobs:
   test:
     strategy:
+      fail-fast: false
       matrix:
         os: [ubuntu-latest, windows-2022, macos-latest]
     runs-on: ${{ matrix.os }}
-    continue-on-error: true
     steps:
     - uses: actions/checkout@v4
     - name: Set up Python