mirror of
https://github.com/vercel/workflow.git
synced 2026-09-14 19:59:43 +08:00
7653e6bfdb
## Summary
- Replace Next.js App Router with React Router v7.13.0 framework mode (Vite-based), eliminating the large `next` dependency from the web, CLI, and workflow metapackages
- Serve the web UI in-process from the CLI via Express instead of spawning `next start` as a child process
- Switch RPC transport from JSON to CBOR to preserve binary data types across the wire
- Replace `nuqs` URL state management with React Router's `useSearchParams`
- Replace Next.js server actions with an RPC resource route (`/api/rpc`) and a thin CBOR-based client
## Motivation
The `next` package is ~300MB installed and was the single largest dependency in the monorepo. It also required spawning a separate child process from the CLI to run the o11y web server, adding complexity around process lifecycle management, port readiness polling, and environment variable forwarding.
With React Router framework mode, the web package builds to a standard Express-compatible server bundle that the CLI can import and serve directly in its own process.
## What changed
**Framework swap (`@workflow/web`):**
- `next.config.ts` / `postcss.config.mjs` → `react-router.config.ts` / `vite.config.ts`
- `src/` directory → `app/` directory (React Router convention)
- `src/app/layout.tsx` + `layout-client.tsx` → `app/root.tsx`
- `src/app/page.tsx` → `app/routes/home.tsx`
- `src/app/run/[runId]/page.tsx` → `app/routes/run-detail.tsx`
- Path alias `@/` → `~/`
- Removed all `'use client'` / `'use server'` directives
**Data transport:**
- Server actions → RPC resource route at `/api/rpc` with CBOR encoding
- CBOR preserves `Uint8Array` and other binary types natively (no base64 overhead)
- Stream reading → dedicated `/api/stream/:streamId` resource route
**URL state:**
- `nuqs` (`useQueryState`) → `useSearchParams` from `react-router`
**Fonts:**
- `next/font/google` → Geist `.woff2` files referenced directly from `node_modules/geist` via `@font-face` in CSS
**CLI integration (`@workflow/cli`):**
- `import('@workflow/web/server').then(m => m.startServer(port))`
- No child process, no readiness polling, no cleanup handlers
**Radix UI compatibility:**
- `onSubmit` preventDefault on `AlertDialogContent` and `SheetContent` to prevent Radix's internal `<form method="dialog">` from triggering React Router route actions
- Catch-all action on root route for any stray POSTs
## Dependencies removed
- `next`, `swr`, `nuqs`, `@tailwindcss/postcss`
## Dependencies added
- `react-router` / `@react-router/dev` / `@react-router/node` / `@react-router/express` (all `7.13.0`)
- `express`, `vite`, `@tailwindcss/vite`, `cbor-x`, `isbot`, `cross-env`
- `geist` (devDep)
168 lines
4.3 KiB
TypeScript
168 lines
4.3 KiB
TypeScript
import * as AlertDialogPrimitive from '@radix-ui/react-alert-dialog';
|
|
import type * as React from 'react';
|
|
import { buttonVariants } from '~/components/ui/button';
|
|
import { cn } from '~/lib/utils';
|
|
|
|
function AlertDialog({
|
|
...props
|
|
}: React.ComponentProps<typeof AlertDialogPrimitive.Root>) {
|
|
return <AlertDialogPrimitive.Root data-slot="alert-dialog" {...props} />;
|
|
}
|
|
|
|
function AlertDialogTrigger({
|
|
...props
|
|
}: React.ComponentProps<typeof AlertDialogPrimitive.Trigger>) {
|
|
return (
|
|
<AlertDialogPrimitive.Trigger data-slot="alert-dialog-trigger" {...props} />
|
|
);
|
|
}
|
|
|
|
function AlertDialogPortal({
|
|
...props
|
|
}: React.ComponentProps<typeof AlertDialogPrimitive.Portal>) {
|
|
return (
|
|
<AlertDialogPrimitive.Portal data-slot="alert-dialog-portal" {...props} />
|
|
);
|
|
}
|
|
|
|
function AlertDialogOverlay({
|
|
className,
|
|
...props
|
|
}: React.ComponentProps<typeof AlertDialogPrimitive.Overlay>) {
|
|
return (
|
|
<AlertDialogPrimitive.Overlay
|
|
data-slot="alert-dialog-overlay"
|
|
className={cn(
|
|
'data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 fixed inset-0 z-50 bg-black/50',
|
|
className
|
|
)}
|
|
{...props}
|
|
/>
|
|
);
|
|
}
|
|
|
|
function AlertDialogContent({
|
|
className,
|
|
onSubmit,
|
|
...props
|
|
}: React.ComponentProps<typeof AlertDialogPrimitive.Content> & {
|
|
onSubmit?: React.FormEventHandler<HTMLFormElement>;
|
|
}) {
|
|
return (
|
|
<AlertDialogPortal>
|
|
<AlertDialogOverlay />
|
|
<AlertDialogPrimitive.Content
|
|
data-slot="alert-dialog-content"
|
|
className={cn(
|
|
'bg-background data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 data-[state=closed]:zoom-out-95 data-[state=open]:zoom-in-95 fixed top-[50%] left-[50%] z-50 grid w-full max-w-[calc(100%-2rem)] translate-x-[-50%] translate-y-[-50%] gap-4 rounded-lg border p-6 shadow-lg duration-200 sm:max-w-lg',
|
|
className
|
|
)}
|
|
/**
|
|
* Radix AlertDialog renders an internal <form method="dialog">.
|
|
* Outside of a native <dialog> element, the browser treats this as
|
|
* a POST to the current URL — which React Router interprets as a
|
|
* route action. Prevent the default form submission to avoid this.
|
|
*/
|
|
onSubmit={(e: React.FormEvent) => {
|
|
e.preventDefault();
|
|
onSubmit?.(e as React.FormEvent<HTMLFormElement>);
|
|
}}
|
|
{...props}
|
|
/>
|
|
</AlertDialogPortal>
|
|
);
|
|
}
|
|
|
|
function AlertDialogHeader({
|
|
className,
|
|
...props
|
|
}: React.ComponentProps<'div'>) {
|
|
return (
|
|
<div
|
|
data-slot="alert-dialog-header"
|
|
className={cn('flex flex-col gap-2 text-center sm:text-left', className)}
|
|
{...props}
|
|
/>
|
|
);
|
|
}
|
|
|
|
function AlertDialogFooter({
|
|
className,
|
|
...props
|
|
}: React.ComponentProps<'div'>) {
|
|
return (
|
|
<div
|
|
data-slot="alert-dialog-footer"
|
|
className={cn(
|
|
'flex flex-col-reverse gap-2 sm:flex-row sm:justify-end',
|
|
className
|
|
)}
|
|
{...props}
|
|
/>
|
|
);
|
|
}
|
|
|
|
function AlertDialogTitle({
|
|
className,
|
|
...props
|
|
}: React.ComponentProps<typeof AlertDialogPrimitive.Title>) {
|
|
return (
|
|
<AlertDialogPrimitive.Title
|
|
data-slot="alert-dialog-title"
|
|
className={cn('text-lg font-semibold', className)}
|
|
{...props}
|
|
/>
|
|
);
|
|
}
|
|
|
|
function AlertDialogDescription({
|
|
className,
|
|
...props
|
|
}: React.ComponentProps<typeof AlertDialogPrimitive.Description>) {
|
|
return (
|
|
<AlertDialogPrimitive.Description
|
|
data-slot="alert-dialog-description"
|
|
className={cn('text-muted-foreground text-sm', className)}
|
|
{...props}
|
|
/>
|
|
);
|
|
}
|
|
|
|
function AlertDialogAction({
|
|
className,
|
|
...props
|
|
}: React.ComponentProps<typeof AlertDialogPrimitive.Action>) {
|
|
return (
|
|
<AlertDialogPrimitive.Action
|
|
className={cn(buttonVariants(), className)}
|
|
{...props}
|
|
/>
|
|
);
|
|
}
|
|
|
|
function AlertDialogCancel({
|
|
className,
|
|
...props
|
|
}: React.ComponentProps<typeof AlertDialogPrimitive.Cancel>) {
|
|
return (
|
|
<AlertDialogPrimitive.Cancel
|
|
className={cn(buttonVariants({ variant: 'outline' }), className)}
|
|
{...props}
|
|
/>
|
|
);
|
|
}
|
|
|
|
export {
|
|
AlertDialog,
|
|
AlertDialogPortal,
|
|
AlertDialogOverlay,
|
|
AlertDialogTrigger,
|
|
AlertDialogContent,
|
|
AlertDialogHeader,
|
|
AlertDialogFooter,
|
|
AlertDialogTitle,
|
|
AlertDialogDescription,
|
|
AlertDialogAction,
|
|
AlertDialogCancel,
|
|
};
|