vercel__workflow/.changeset/wise-frogs-thank.md at identify-condition-causing-reported-error

mirror of https://github.com/vercel/workflow.git synced 2026-09-14 19:59:43 +08:00

Files

T

Mitul Shah 34481af4b6 Detail Pane Cleanup (#1973 )

* cleanup items

* Update events-list.tsx

* nice

* Update attribute-panel.tsx

* woo

* remove toast

* Fix: Unused variable `selectedResource` causes TypeScript build failure (TS6133) due to `noUnusedLocals: true` in tsconfig.

This commit fixes the issue reported at packages/web-shared/src/components/new-trace-viewer/trace-viewer.tsx:462

**Bug explanation:**

The variable `selectedResource` is declared on line 462 of `trace-viewer.tsx`:

```ts
const selectedResource = selectedSpan?.resource as string | undefined;
```

However, all references to this variable were removed in the PR (the colored resource badge in the panel header was removed), leaving behind the unused declaration. The project's TypeScript configuration has `noUnusedLocals: true`, which causes TypeScript to emit error TS6133 for any declared-but-unused local variables. This is confirmed directly in the Vercel build logs:

```
@workflow/web-shared:build: src/components/new-trace-viewer/trace-viewer.tsx(462,9): error TS6133: 'selectedResource' is declared but its value is never read.
```

This caused the `@workflow/web-shared#build` task to fail with exit code 2, which in turn caused the entire Vercel deployment to fail.

**Fix explanation:**

Removed the unused `const selectedResource = selectedSpan?.resource as string | undefined;` declaration on line 462. The nearby `selectedResourceId` variable (which was NOT removed) remains in place and is still actively used in the JSX below. This is a minimal one-line deletion that resolves the build failure.

Co-authored-by: Vercel <vercel[bot]@users.noreply.github.com>
Co-authored-by: mitul-s <mitulxshah@gmail.com>

* tweak

* Update events-list.tsx

* Update events-list.tsx

* cleanup

* Update attribute-panel.tsx

* copy button

* Create button.tsx

* cleanup

* rename `this` to Context

* cleanup

* Update button.tsx

* avoid decrypt flashign

* cleanup

* Update attribute-panel.tsx

* nav on detail card

* polish

* Update detail-card.tsx

* Update trace-viewer.tsx

* colors

* Update attribute-panel.tsx

* Update detail-card.tsx

* Update copyable-data-block.tsx

* Detail Pane + Other cleanup items (#2020)

* polish

* Update attribute-panel.tsx

* Create wise-frogs-thank.md

Signed-off-by: Mitul Shah <mitulxshah@gmail.com>

---------

Signed-off-by: Mitul Shah <mitulxshah@gmail.com>

---------

Signed-off-by: Mitul Shah <mitulxshah@gmail.com>
Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com>
Co-authored-by: Vercel <vercel[bot]@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>

2026-05-22 15:30:38 +00:00

88 B

Raw Permalink Blame History

@workflow/web-shared

@workflow/web-shared
patch

adjusted spacing on trace viewer and detail pane

88 B Raw Permalink Blame History

88 B

Raw Permalink Blame History