mirror of
https://github.com/vercel/next.js.git
synced 2026-09-20 02:25:18 +08:00
Tim Neutkens
8141dcf12e
### What?
Converts every test under `test/integration/` to an isolated test
running through `nextTestSetup` (under `test/e2e/`, `test/production/`,
`test/development/`, or `test/unit/`), then deletes `test/integration/`
along with the legacy CI orchestration that was specific to it.
- `test/integration/` removed entirely (~327 test suites)
- New isolated suites added across the existing folders:
- `test/e2e/` — 175
- `test/production/` — 130
- `test/development/` — 43
- `test/unit/` — 1
- `.github/workflows/build_and_test.yml` and `run-tests.js` no longer
have any `integration` branches
- `nextTestSetup` gained a `baseUrl` option on `next.browser()` so a
small number of tests that drive their own proxy/static-export server
can keep using `next.browser(...)` instead of importing `next-webdriver`
directly
### Why?
`test/integration/` predated `nextTestSetup` and ran tests directly
against the source checkout via custom helpers (`launchApp`,
`nextBuild`, `nextStart`, `runNextCommand`, `webdriver`, `fetchViaHTTP`,
…). Each suite hand-rolled its own dev/start/build orchestration,
fixture mutation, and process management.
The isolated test model used by the rest of the repo gives each suite an
isolated working directory containing a packed `next.tgz` install, a
uniform `next.start()` / `next.build()` / `next.fetch()` /
`next.browser()` API, and the same lifecycle for dev, start, and deploy
modes — so a single set of assertions covers all three. Deploy-mode
skips and per-feature gates are expressed declaratively
(`skipDeployment`, `disableAutoSkewProtection`, `if (skipped) return`)
instead of branching on `process.env`.
Removing `test/integration/` lets us:
- Delete the bespoke orchestration code in the CI workflow and
`run-tests.js`
- Run every converted suite consistently in dev, start, and deploy modes
(where applicable)
- Reproduce every test locally with the same `pnpm
test-{dev,start}-{turbo,webpack}` commands; no separate `integration`
path
- Open the door to running `test/production` against deployments in the
future (the converted suites already declare `skipDeployment` so they
can be flipped on)
### How?
Mechanical conversion per suite, with targeted clean-ups:
1. **Per-suite conversion.** Each
`test/integration/<name>/test/index.test.{js,ts}` was rewritten into a
single `<name>.test.ts` under the right folder based on what the
original exercised:
- `launchApp` / dev-only assertions → `test/development/`
- `nextBuild` + `nextStart` / start-only assertions → `test/production/`
- Both → `test/e2e/`
- The one pure jsdom render check (`link-without-router`) → `test/unit/`
2. **API mapping.** Custom helpers were replaced by `nextTestSetup`
equivalents: `launchApp` → `next.start()`, `nextBuild` → `next.build()`,
`runNextCommand` → `next.runCommand`, `fetchViaHTTP` → `next.fetch`,
`webdriver(...)` → `next.browser(...)`. Fixture mutations switched from
raw `fs.writeFile`/`fs.rename` to `next.patchFile` (with the 3-arg
`runWithTempContent` callback when the change has a defined scope) and
`next.deleteFile`.
3. **Deploy-mode handling.** Suites that can't run in deploy mode (use
`patchFile` / `next.build()` / depend on local CLI output) declare
`skipDeployment: true` and early-return on the `skipped` boolean. Suites
where Vercel's edge mutates URLs (`&dpl=`, immutable assets) declare
`disableAutoSkewProtection: true`.
4. **`next.browser({ baseUrl })`.** A handful of tests
(`prerender-export`, `cdn-cache-busting`, `preload-viewport`, both
`react-virtualized` suites) need to drive a separate server (a
static-export server or an `http-proxy` instance) rather than the
Next.js process. Instead of importing `next-webdriver` directly, those
tests now pass `{ baseUrl: <port|url> }` to `next.browser()`. For the
proxy cases, the proxy was moved into `server.js` inside the fixture and
`http-proxy` declared via the `dependencies` option of `nextTestSetup`,
so the test runs with a fully isolated dependency graph.
5. **CI clean-up.** With `test/integration` gone, the `test
integration*` jobs and `integration-tests-manifest`-related logic in
`.github/workflows/build_and_test.yml` were removed, and `run-tests.js`
no longer has the `integration` test-folder branch.
6. **Validation.** The PR was iterated against multiple full CI runs;
the remaining failures on the latest run are pre-existing flakes
(segment-cache 60s `act` timeouts in turbopack-prod) or transient
infrastructure issues unrelated to the conversion.
29 lines
1.7 KiB
Plaintext
29 lines
1.7 KiB
Plaintext
-----BEGIN PRIVATE KEY-----
|
|
MIIEvAIBADANBgkqhkiG9w0BAQEFAASCBKYwggSiAgEAAoIBAQC4RjLHONsy01T+
|
|
akh92wD+JORLGQAb0rM2s02vFMMOzGUCyVk4nP4u/lY+iA6LwJpOXC2cst8PdMXc
|
|
R3WwyVBolOdep0gImR5mUJZK2y5KSbXSY2YK+S2seC7XZX6IfYflzzq46aBqQKdC
|
|
kanGEmCSkKKk9g0/5zd+ckobAxGrVAhP2xi837CtXlR8Du9j1Yp8VsmTElPr9F2L
|
|
o9s1NuqiAQwN5VSQ4sg3WjD5YxLeksL2LPfr5uuBZpPeoSVlFxFxjpqvBgmhr0Qm
|
|
KQJPk0vtj22304EjIlfQdmiCUBmAglp/7BoszRNZEdNEgFzIR6DN1wIpoA9tyFZV
|
|
YuFoZedDAgMBAAECggEAGD8K/7dQRuPoqzXH27YnxMjiOFa4nXCVVRgK8NkIq1dN
|
|
3oEoxLAKKpvGNEx0VtjHqjzVtuhlkjk5WY5rgrs9DG20nc82mq8EVs5kCsMZLabS
|
|
OOBhn7BWsqVOSy2BvyrT6UiMP6K55pEi5jmX/vBnFZHYsgo6sb2rdG9MUePkUh2v
|
|
arnQxWnPM1cf2VjOwVJxanqTUim0tsZeL7jtWHFfvmrk7NBumCaCMp+Qr1Di+hlQ
|
|
Uv7jvGc16KpG0GDrpPr6Cc/bII1aRCVLX8dX+IM3/hMxouSqJRwi39Hc3BMZGzZE
|
|
3EMZImKoimnj6iZUHj6W/6vueuMXBHDeGQFNwXUMKQKBgQDiMZZWejFaYDFCW+cp
|
|
0L57fmpAZ0cM5fbu03cF+5FhEXkIAbFEiR6vm68hairk1Qaz8AJarlb/mvt+A2Nd
|
|
O4Tyu+lsZEmEjpRRXN1Y9SyKdq1LPSbJUK6TA6mGxHNRAkMNrR/fH2YnrGdIVTEi
|
|
ZHtcofuaz5Zn12mgb1zu5zDLSQKBgQDQjoAHqv2QjH1idzgXhyZa+rK8PcTeXFz8
|
|
2vw6QWiIsepsr1NOc2PRuGrr97to1/mpg3D07bbhyQg3getsV4xSCRrUQey+G/ha
|
|
HINRcWI+OibvH0rr5ATTv7sVcv3sgns/MOX81TW1+4hyYc/Q/LyUQqYxvxjDcXZC
|
|
7sEYJAOyKwKBgHDMXbZeVUJGegonno2hxXv8PKxFVI9AFvZeihp3q7YGap7tiSMu
|
|
ZhkYwCsfsKhQ+3i8FdB25HevJ/9dXS3fQptxziP5lxf9qkUw1ElKap3aNO0yX6dB
|
|
Du3Ng7rrOL6LLDkjvqMcG2tpdFAD++60wTgep0Q6hTzflZMmNegFbrXRAoGAU+aP
|
|
8QXD/mvWYU9u3GA9eOpUD1CWK5JiwkJiqBj6McvJcDHURMI9DPiw4v8FgPcp9Bzx
|
|
y0b6hLi4OoRkrnBF/ha1mWBwGkbsUWwZFCGWEUyZrycan+1aV8lRPR7GsmgHpvNI
|
|
Ar/PXMe1K7bXwM58GvT5IRgsoSu7FNAyFEEgz4MCgYBVV8igQWZRkR+lK7KmRU8A
|
|
9D8m4UGmvyrHXmJq0WvfVPEI7XNk6P4xIpoSFHmuIWPGie8L919ohMG5pb8UxHyZ
|
|
NYgyhbqQmZ8mpn7f3RjwrQT5JpSGFnHtkRw8d4sfYEnx/KaXMv0h5Jc0vsR3M3jU
|
|
aAMnx52Djc5JZynoLNwO8A==
|
|
-----END PRIVATE KEY-----
|