mirror of
https://github.com/vercel/next.js.git
synced 2026-09-20 02:25:18 +08:00
JJ Kasper
aeaa006b14
When configuring a body with `NextRequest` in node runtime without the
`duplex: 'half'` option it can throw an error un-necessarily since it's
an extension of the node `Request` instance. This auto-configures
`duplex: 'half'` when using `NextRequest` for easier migration from edge
-> node runtime for middleware.
```sh
TypeError: RequestInit: duplex option is required when sending a body.
at new Request (/opt/rust/undici-runtime.js:40:31096)
```
x-ref: [slack
thread](https://vercel.slack.com/archives/C07LQPFERGF/p1740490607381379)
60 lines
1.7 KiB
TypeScript
60 lines
1.7 KiB
TypeScript
// this file must not use the edge-runtime env setup
|
|
// so that we test node runtime properly
|
|
import { expectTypeOf } from 'expect-type'
|
|
import { NextRequest } from 'next/dist/server/web/spec-extension/request'
|
|
|
|
it('should have 1 required parameter for constructor', () => {
|
|
expect(NextRequest.length).toBe(1)
|
|
})
|
|
|
|
it('should allow the 2nd parameter to be undefined', () => {
|
|
const request = new NextRequest('https://vercel.com')
|
|
expectTypeOf(request).toMatchTypeOf<NextRequest>()
|
|
|
|
expect(new NextRequest('https://vercel.com')).toHaveProperty(
|
|
'nextUrl.pathname',
|
|
'/'
|
|
)
|
|
})
|
|
|
|
it('should clone Request with headers', () => {
|
|
const request = new Request('https://example.com', {
|
|
headers: { 'x-foo': 'bar' },
|
|
})
|
|
|
|
const nextRequest = new NextRequest(request)
|
|
|
|
expect(Object.fromEntries(nextRequest.headers)).toEqual(
|
|
Object.fromEntries(request.headers)
|
|
)
|
|
|
|
// Second argument should override headers
|
|
const headers = new Headers({ 'x-header': 'some header' })
|
|
const nextRequest2 = new NextRequest(request, { headers })
|
|
|
|
expect(Object.fromEntries(nextRequest2.headers)).toEqual(
|
|
Object.fromEntries(headers)
|
|
)
|
|
})
|
|
|
|
it('should handle Request with body', () => {
|
|
let nextRequest = new NextRequest('https://example.com', {
|
|
body: new ReadableStream(),
|
|
method: 'POST',
|
|
})
|
|
expect(nextRequest.body).toBeTruthy()
|
|
expect(nextRequest.method).toBe('POST')
|
|
|
|
const request = new Request('https://example.com', {
|
|
body: new ReadableStream(),
|
|
method: 'POST',
|
|
// @ts-expect-error this exists but not in type
|
|
duplex: 'half',
|
|
})
|
|
|
|
nextRequest = new NextRequest(request)
|
|
|
|
expect(nextRequest.body).toBeTruthy()
|
|
expect(nextRequest.method).toBe('POST')
|
|
})
|