It compiles fine, but we have another problem: `cargo fmt` really doesn't like it
```
cargo fmt -- turbopack/crates/turbo-tasks-fs/src/lib.rs
error: let chains are only allowed in Rust 2024 or later
--> /Users/niklas/code/next.js/turbopack/crates/turbo-tasks-fs/src/lib.rs:749:44
|
749 | if create_directory && let Some(parent) = full_path.parent() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: let chains are only allowed in Rust 2024 or later
--> /Users/niklas/code/next.js/turbopack/crates/turbo-tasks-fs/src/lib.rs:893:44
|
893 | if create_directory && let Some(parent) = full_path.parent() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: let chains are only allowed in Rust 2024 or later
--> /Users/niklas/code/next.js/turbopack/crates/turbo-tasks-fs/src/lib.rs:1233:12
|
1233 | if let Some(path) = join_path(&self.path, path)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
```
The precommit hook that selectively runs on files is simply not a supported usecase.
So I changed that to `rustfmt --edition 2024 -- ` now 🤷
Previous discussion: https://vercel.slack.com/archives/C03EWR7LGEN/p1748898285716779
Devcontainers support custom `Dockerfile`s, but it seems like it's more recommended to use a base image with "features" on top: https://containers.dev/implementors/features/
Features get applied after the `Dockerfile`, so e.g. if we're installing `rust` with a feature, then we can't install things that depend on `rust` (e.g. `cargo-nextest`: https://nexte.st/) in the `Dockerfile`. So you're forced to do things with features instead, which can specify dependencies and ordering requirements.
I removed a bunch of comments that were left over from the template. People wishing to update this file should refer to the https://aka.ms/devcontainer.json link at the top of the file.
Also added a lockfile for the features, generated with:
```
devcontainer upgrade --workspace-folder=.
```
**Note:** The `base.Dockerfile` here was entirely unused.
### Testing
```
podman stop --all && podman rm --all # replace podman with docker if you're using docker
devcontainer up --workspace-folder=.
devcontainer exec --workspace-folder=. zsh
```
Benjamin Woodruff