a41d94a171
chore(github): add labels-to-add-when-unstale label -> not stale ( #75721 )
...
## Why?
To track issues that are marked "not stale," we need to explicitly add a not stale label. https://github.com/actions/stale does not use this label by default.
2025-02-06 12:26:34 -08:00
df0573a478
Report build-and-deploy failures ( #75749 )
2025-02-06 15:57:40 +01:00
dd676ccbdd
Remove github runner specific step ( #75655 )
...
Removes this step as it fails on self-hosted runners.
<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:
## For Contributors
### Improving Documentation
- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide
### Adding or Updating Examples
- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md
### Fixing a bug
- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md
### Adding a feature
- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas )
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs )
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md
## For Maintainers
- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change
### What?
### Why?
### How?
Closes NEXT-
Fixes #
-->
2025-02-04 15:15:28 +01:00
c70bf4277b
Run build-nextjs for Turbopack test runs on metal machines instead of GitHub hosted runner ( #75654 )
...
## What?
All the test runs that happen after this workflow runs are running on
our self hosted runners but the initial setup is running on GitHub's
runner, this causes an environment mismatch that seems to be causing
these errors:
```
⚠ Error: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.39' not found (required by /root/actions-runner/_work/next.js/next.js/packages/next-swc/native/next-swc.linux-x64-gnu.node)
at mod.require (packages/next/dist/server/require-hook.js:65:28)
at loadNative (packages/next/dist/build/swc/index.js:853:69)
at <unknown> (packages/next/dist/build/swc/index.js:264:28)
at new Promise (<anonymous>)
at loadBindings (packages/next/dist/build/swc/index.js:232:23) {
code: 'ERR_DLOPEN_FAILED'
}
```
Going to land this to verify it remedies the problem.
<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:
## For Contributors
### Improving Documentation
- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide
### Adding or Updating Examples
- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md
### Fixing a bug
- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md
### Adding a feature
- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas )
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs )
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md
## For Maintainers
- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change
### What?
### Why?
### How?
Closes NEXT-
Fixes #
-->
2025-02-04 14:23:20 +01:00
a9490686de
chore(github): update stale bot ( #75630 )
...
## Why?
A `days-before-issue-stale` period of two years has so far been successful. We can now move this to ~1.5 years (545 days).
2025-02-03 17:51:40 -08:00
1ef4dfa2bb
fix corepack check in build_reusable workflow ( #75629 )
...
Fixes the order of this check
Validated run:
https://github.com/vercel/next.js/actions/runs/13124372480/job/36617509828
2025-02-03 16:19:09 -08:00
2daa7e1fc8
chore(github): add conditional to triage workflow ( #75524 )
...
## Why?
If an issue has the `stale` label, let's not run Nissuer.
2025-02-03 15:04:22 -08:00
7320fd5620
Fix corepack keys in deploy e2e tests ( #75622 )
2025-02-03 20:41:49 +00:00
bab37ffd11
Bring back rust bindings path ( #75620 )
...
Ensures swc/turbopack don't fail to load in CI.
<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:
## For Contributors
### Improving Documentation
- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide
### Adding or Updating Examples
- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md
### Fixing a bug
- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md
### Adding a feature
- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas )
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs )
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md
## For Maintainers
- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change
### What?
### Why?
### How?
Closes NEXT-
Fixes #
-->
2025-02-03 19:16:00 +01:00
8db22f7568
Ensure junit-report is uploaded ( #75615 )
...
Ensures the subsequent steps don't fail on a missing file.
<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:
## For Contributors
### Improving Documentation
- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide
### Adding or Updating Examples
- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md
### Fixing a bug
- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md
### Adding a feature
- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas )
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs )
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md
## For Maintainers
- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change
### What?
### Why?
### How?
Closes NEXT-
Fixes #
-->
2025-02-03 16:29:48 +01:00
d8ba60d3a6
Fix rustflags in *-musl builds ( #75614 )
2025-02-03 16:16:09 +01:00
a840415e45
Update test-junit-report path ( #75612 )
...
Updates the last path that is incorrect.
<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:
## For Contributors
### Improving Documentation
- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide
### Adding or Updating Examples
- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md
### Fixing a bug
- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md
### Adding a feature
- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas )
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs )
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md
## For Maintainers
- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change
### What?
### Why?
### How?
Closes NEXT-
Fixes #
-->
2025-02-03 15:37:14 +01:00
4e39460842
Turbopack CI: Update test results artifact ( #75429 )
...
## What?
Makes it easier to understand which test results are loaded. Mirrors the
naming we use for production tests.
No functional changes in this PR. Only updating the name.
<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:
## For Contributors
### Improving Documentation
- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide
### Adding or Updating Examples
- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md
### Fixing a bug
- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md
### Adding a feature
- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas )
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs )
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md
## For Maintainers
- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change
### What?
### Why?
### How?
Closes NEXT-
Fixes #
-->
2025-02-03 12:23:00 +01:00
bcef4dd3b4
fix rustflags for musl targets ( #75599 )
2025-02-03 11:15:42 +01:00
cefa93ca5c
Fix corepack keys ( #75600 )
2025-02-03 10:57:22 +01:00
82026906a6
Read and write rspack test manifests by name ( #75445 )
...
Previously, rspack test runs were writing to `test-junit-report`, but
were expected to be found at `turbopack-test-junit-report`.
This renames both sides to be `rspack-test-junit-report`.
2025-01-30 14:09:05 +01:00
348c7fe30e
Add temporary CI workflows for testing ( #75432 )
...
## What?
Temporary CI workflows for #74554 .
<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:
## For Contributors
### Improving Documentation
- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide
### Adding or Updating Examples
- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md
### Fixing a bug
- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md
### Adding a feature
- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas )
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs )
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md
## For Maintainers
- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change
### What?
### Why?
### How?
Closes NEXT-
Fixes #
-->
2025-01-29 16:55:14 +01:00
baa4f787d2
[DevOverlay] Align old and new overlay ( #74935 )
...
Enable the new UI for the CI testings of existing redbox tests.
There are several changes made to let the test pass, including
backporting changes to the old UI or removing one from the new, and are
as follows:
- Added back `|` after line number in code frame
([link](https://github.com/vercel/next.js/pull/74935#discussion_r1925725941 ))
- Removed unnecessary `@` in Terminal component
([link](https://github.com/vercel/next.js/pull/74935#discussion_r1925727156 ))
- Set open overlay default value to `true` in Pages Router
([link](https://github.com/vercel/next.js/pull/74935#discussion_r1925728104 ))
- Backport displaying the first first-party call stack frame to the
CallStack component
([link](https://github.com/vercel/next.js/pull/74935#discussion_r1925731313 ))
- Move the devTools component back to the error boundary
([link](https://github.com/vercel/next.js/pull/74935#discussion_r1925732706 ))
- Was moved out at
https://github.com/vercel/next.js/pull/74999#discussion_r1922998021
Closes NDX-674
Closes NDX-687
2025-01-24 06:53:32 +09:00
6d17cc6b0f
Include CI runner labels in Turborepo hashes ( #75099 )
...
Avoids cache collisions for output with platform-specific contents (e.g.
paths) that may be generated on Linux or Windows runners. Docs:
https://turbo.build/repo/docs/crafting-your-repository/using-environment-variables#adding-environment-variables-to-task-hashes
2025-01-20 13:26:28 +01:00
213c710306
ci: ensure fnm is installed in build_reusable ( #74891 )
...
`build_reusable` assumes `fnm` is available but on GH hosted runners we
have to ensure it's installed. This adds an installation step if fnm is
not available.
Fixes failing deployment tests, eg:
https://github.com/vercel/next.js/actions/runs/12778327338/attempts/3
Validated in https://github.com/vercel/next.js/actions/runs/12778954324
2025-01-15 00:40:58 +00:00
2261bd37d5
Update CI config for Windows runner ( #74850 )
...
As discussed this replaces our Azure pipelines handling with our own
runners instead. This allows us to build the `next-swc` binary to run
tests against for Windows when necessary instead of trying to leverage
the canary binary which requires any relevant changes to have been
published which can cause us to miss Windows specific failures until
after a canary is published.
This also has the benefit of us being able to consolidate our CI config
for Windows/Linux for better consistency.
Since running workloads on Windows is slower still this just starts with
copying over the tests we had configured previously although we can look
at adding more we see useful for catching regressions.
2025-01-14 08:25:13 -08:00
885e70eb1a
chore(github): fix days-before-issue-close/stale ( #74838 )
...
## Why?
We mixed up `days-before-issue-close` and `days-before-issue-stale`.
2025-01-13 17:35:55 -08:00
d737cefcc4
chore(github): ignore PRs in for stale issue bot ( #74767 )
...
## Why?
We have to explicitly give a `-1` for `days-before-pr-close` and `days-before-pr-stale` in order to ignore sifting through PRs.
- https://github.com/vercel/next.js/actions/runs/12716117689/job/35449724177#step:2:376
2025-01-10 12:57:37 -08:00
36a138a421
chore(github): update how we handle stale issues ( #73488 )
...
## Why?
We currently have no automated process for handling stale issues. This PR adds an automated process for this.
2025-01-10 11:34:09 -08:00
da3f782046
build: Update swc_core to v10.1.0 ( #74580 )
...
### What?
Update swc crates to https://github.com/swc-project/swc/releases/tag/swc_core%40v10.1.0
### Why?
To apply https://github.com/vercel/next.js/pull/73696 and parallelization improvements.
### How?
2025-01-10 16:21:06 +01:00
d2c45d0ddd
Upgrade Turborepo to v2.3.3 ( #74736 )
...
This reduces the high CPU usage that was caused by TUI during idle time
significantly when running `pnpm dev` in the Next.js repo.
### Running `pnpm dev -F next` in 4 git worktrees concurrently (as you
do)
#### Before
<img width="852" alt="before"
src="https://github.com/user-attachments/assets/17c811c8-38dd-4373-abfb-8a41415df372 "
/>
#### After
<img width="852" alt="after"
src="https://github.com/user-attachments/assets/58913f78-8fc4-4b7c-a052-ff27e8c1cc06 "
/>
2025-01-10 11:06:36 +00:00
07e636f952
chore(github): switch back to STALE_TOKEN ( #74723 )
...
## Why?
We have regenerated the token with necessary permission as `STALE_TOKEN`.
2025-01-09 18:28:52 -08:00
a876d6ca30
Use prefer offline flag for CI ( #74663 )
...
Aims to speed up CI by avoiding checking npm registry un-necessarily for
every test run since we mostly hard code our test package versions when
the version matters.
2025-01-08 22:56:57 +00:00
450a04f35e
chore(ci): Ensure all 6 shards are used equally in deploy tests ( #74574 )
2025-01-07 11:50:57 +01:00
0e6185e1b5
chore(github): update issue_stale token to release bot token ( #74575 )
...
## Why?
Updating from `STALE_TOKEN` to `RELEASE_BOT_TOKEN` because `STALE_TOKEN` has expired.
2025-01-06 19:52:49 -08:00
6dcfb1fc60
Instal Vercel CLI at start of E2E deploy tests ( #74047 )
...
This ensures we install Vercel CLI before we start running tests so they
aren't attempted to be installed during each test run which are done in
parallel so could have issues from trying to do multiple installs at the
same time.
x-ref:
https://github.com/vercel/next.js/actions/runs/12381595565/job/34560897615
2024-12-17 22:55:14 +00:00
3babf7a5a5
chore: increase test sharding ( #73852 )
...
<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:
## For Contributors
### Improving Documentation
- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide
### Adding or Updating Examples
- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md
### Fixing a bug
- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md
### Adding a feature
- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas )
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs )
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md
## For Maintainers
- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change
### What?
### Why?
### How?
Closes NEXT-
Fixes #
-->
2024-12-13 18:58:05 -07:00
8e64b2cfe2
chore(github): add issue_wrong_template workflow ( #73882 )
...
## Why?
Mini-automation to automatically close issues when using the `please use the correct issue template` label.
2024-12-13 15:25:49 -08:00
c92e845296
chore(github): fix typo in close-issue-message ( #73878 )
...
## Why?
Fix typo.
2024-12-12 22:28:23 -08:00
c442fb42ee
Detach next-error-code-swc-plugin from workspace ( #73806 )
...
Because the next-error-code-swc-plugin crate uses the wasm32-wasip1
target, including it in the workspace causes cargo check to fail, which
in turn causes the main build to fail. To work around this, I'm removing
the crate from the workspace.
2024-12-11 13:13:18 -05:00
306d4bda68
feat: error code ( #73332 )
...
This update introduces a custom `swc-plugin` for Next.js that appends a
non-enumerable `__NEXT_ERROR_CODE` property to all `Error` instances,
enabling anonymous telemetry while keeping error codes hidden from
console logs. The plugin manages error codes through an append-only
`/packages/next/errors.json` file, which is automatically updated during
the `pnpm build` process using a two-pass system to ensure consistent
error mapping, even during concurrent builds.
2024-12-11 11:30:28 -05:00
09aa303a76
Skip build_and_deploy on docs-only changes ( #73659 )
2024-12-10 11:28:52 +00:00
0c78009841
chore(github): update stale issue periods ( #73709 )
...
## Why?
We should be more aggressive with how we close issues.
- Update the stale waiting period for `please add a complete reproduction` to 2 days
- Update the stale waiting period for `please simplify reproduction` to 14 days
- Update the stale waiting period for `please verify canary` to 14 days
2024-12-09 20:51:58 -08:00
c9aae2f3e9
chore(turbo-tasks): improve ast-grep lint time ( #73440 )
...
<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:
## For Contributors
### Improving Documentation
- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide
### Adding or Updating Examples
- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md
### Fixing a bug
- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md
### Adding a feature
- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas )
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs )
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md
## For Maintainers
- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change
-->
Hi Vercel team, ast-grep author here. Thanks for using the tool to lint
Rust files in Next.js!
### What?
Improve the `ast-grep` task's linting time from 8 seconds to sub second,
by bumping the CLI version.
### Why?
Previously the CLI scans all files even if a file has no matching rule.
Now the new version will only scan candidate files which can produce
lint errors.
### How?
Bumping ast-grep version. Also see [this
post](https://x.com/hd_nvim/status/1863403568813744320 ) for local
reproduction.
---------
Co-authored-by: Will Binns-Smith <wbinnssmith@gmail.com >
2024-12-02 17:21:52 -08:00
e0eed7d7f6
chore(CI): Remove sysroot override for macos arm64 ( #73188 )
...
This is extracted from #72513 . This override appears to break the build for rocksdb. It doesn't seem like there's any good reason for us to do this.
It looks like we used to do a cross-build for macos arm64 (#28138 ), which would explain the need to override the sysroot, but we don't do that anymore. We don't do this override for x86-64 builds (even though that one _is_ a cross-build? The napi cli probably does the right thing for us...).
Manually triggered `build-and-deploy` CI job: https://github.com/vercel/next.js/actions/runs/12018322261
2024-11-25 13:14:39 -08:00
35c755a644
Turbopack build: Add bench for Turbopack cache ( #73040 )
...
Adds a separate bench for Turbopack build enabled.
<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:
## For Contributors
### Improving Documentation
- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide
### Adding or Updating Examples
- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md
### Fixing a bug
- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md
### Adding a feature
- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas )
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs )
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md
## For Maintainers
- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change
### What?
### Why?
### How?
Closes NEXT-
Fixes #
-->
2024-11-21 15:27:18 +01:00
6c3fd0f494
Revert "[Turbopack] add rocksdb" ( #72505 )
2024-11-08 14:01:45 +01:00
b7aadf7614
[Turbopack] add rocksdb ( #71688 )
...
### What?
switches the database for persistent caching from lmdb to rocksdb.
### Why?
* No preallocated sparse file which cause problems
* Compression support
* Multiple files instead of a big single file
* Better performance
2024-11-08 00:09:02 +01:00
e0ce7da712
Add provenance to Turbopack misc. packages ( #72475 )
...
Following #72360 , this adds the necessary options in GitHub Actions to
allow npm to publish the packages with provenance
(authenticity/signing).
Closes PACK-3419
2024-11-07 11:00:57 -08:00
db9d092444
Publish misc. Turbopack packages ( #72360 )
...
The `turbopack/` directory includes miscellaneous JavaScript packages
that should be published to npm. This was handled in
https://github.com/vercel/turbo/tree/5fc75a38477e9f810bc4ee8aba4c741425fe2342
before Turbopack moved to the Next.js repo.
Test Plan: Run workflow manually or with this PR and verify the publish
xtask is run.
Closes PACK-3390
2024-11-06 09:38:47 -08:00
1b5c269abf
Snowflake backend for devlow ( #72162 )
...
This adds a backend to devlow for Vercel’s HTTP data api for sending
values to Snowflake. It requires the gateway’s batch uri endpoint,
schema id, and topic name.
It collects the metrics and sends them as a batch, each with relevant
metadata similar to the metadata collected by the Datadog backend.
Test Plan:
- [x] Manual test
- [x] Unit test
Closes PACK-3363
2024-11-05 13:40:38 -08:00
f485963879
Increase timeout for deploy tests from 120 (default) to 240 seconds ( #71428 )
...
When running deploy tests, the deployments are done in the `beforeAll`
hook of a test. For some more complex test apps the deployment may take
a while to complete which can result in the test timing out after 120
seconds. To mitigate this, we increase the timeout to 240 seconds.
x-ref: [example run with a
timeout](https://github.com/vercel/next.js/actions/runs/11385828170/job/31678217067 )
2024-10-17 17:16:14 +02:00
872cb617b8
fix: make "Release stats" use the correct artifact name ( #71323 )
...
There's no artifact called `next-swc-binaries`, all the other places use
`next-swc-binaries-*`
The name's coming from here:
https://github.com/vercel/next.js/blob/bc309364d09c11cc6c149e643fa012c4d88dcb6c/.github/workflows/build_and_deploy.yml#L377
Example failing run:
https://github.com/vercel/next.js/actions/runs/11352776677/job/31576710878
It's failing because `download-artifact` didn't download anything
(because of the incorrect name), and the `native` directory no longer
exists (it used to have a .gitkeep inside, but we removed that a while
ago), so it just crashes
2024-10-15 21:44:26 +02:00
dc92b51e9c
Remove windows i686 next-swc build target ( #71041 )
...
After https://github.com/vercel/next.js/pull/70995 investigated how much
our windows 32 bit build is actually leveraged and it seems it is not at
all. Also it seems Windows itself is [ending support for 32
bit](https://community.f-secure.com/total-en/kb/articles/29675-support-for-windows-10-32-bit-ending-on-september-30-2024#:~:text=Other%20Languages&text=F%2DSecure%20will%20stop%20supporting,a%20new%20version%20of%20Windows )
arch so no reason for us to continue supporting it.
Build and deploy workflow run:
https://github.com/vercel/next.js/actions/runs/11260148483
x-ref: [slack
thread](https://vercel.slack.com/archives/C04KC8A53T7/p1728431976293749 )
2024-10-09 11:15:49 -07:00
f5f424cdf6
support running React 18 tests on PRs with a label ( #70737 )
...
When we make changes that we want to assert pass on the React 18.3
matrix, we should have a way to do so on PRs so that we can avoid
failures hitting canary.
This adds a label that will make the 18.3.1 tests run on PRs.
2024-10-02 20:27:22 -07:00
Sam Ko