mirror of
https://github.com/trailofbits/skills.git
synced 2026-09-14 14:28:48 +08:00
kz-tob
bc5991b992
Two fixes from the review of the cut-down branch. The agent-signal gate was written for one row type and then applied to the whole Unresolved References table. Its closing clause -- "Only references that passed the agent-signal test appear there" -- is unqualified, while the test itself reads a step's `with:`/`env:`, the action name and its prompt inputs. A job-level `uses: org/private/.github/workflows/scan.yml@v2` with `secrets: inherit`, 404ing because the repository is private, fires none of them: no `with:`, no visible key, and "scan" is not an agent word. The row was dropped, so a workflow running with every secret the caller holds and a body nobody could read reported as "0 AI action instances, 0 findings" with no Unresolved References section at all. Both rows of the section's own example table fail the test the same way. That is the clean-bill-of-health-over-unread-ground this skill exists to prevent, reintroduced one layer down by the commit that added the gate. The test is now scoped where it belongs -- the reference types marked "Only if it carries an agent signal", which are out of scope by default and which the signal pulls back in -- and anything this file marks in scope is reported whenever it could not be read: 404s, auth failures, depth-limit stops, missing action.yml, unfetchable 2b scripts. Vector I was broadened in the applicability table last commit but not in its own definition, so the two disagreed. A model reading top-down hit "User allowlist fields are set to wildcard values", grepped `with:` for a `"*"`, found none and stopped -- never reaching the rows or the `if:` rule below. The definition, the General pattern line and SKILL.md's quick-check column now all carry both forms: a wildcard allowlist, or no allowlist input and no `if:` on an externally triggerable event. Only the first leaves something to grep for, which is why the second kept getting written as out of scope. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>