 Donald Pinckney
|
44eba4e91c
|
Add .NET SDK support to temporal-developer skill (#39)
* Add .NET reference files for temporal-developer skill
Created 11 .NET reference files covering: dotnet.md (overview/quick start),
patterns.md, determinism.md, determinism-protection.md, error-handling.md,
testing.md, versioning.md, observability.md, data-handling.md, gotchas.md,
and advanced-features.md. Follows Python/TypeScript patterns with .NET-specific
content for Task determinism, CancellationToken, dependency injection, etc.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* Fix .NET alignment issues from self-review
- dotnet.md: Reduce Determinism Rules section to brief cross-reference
(was duplicating determinism.md content)
- patterns.md: Add ParentClosePolicy to Child Workflows example
- gotchas.md: Add missing "Heartbeat Timeout Too Short" subsection
- versioning.md: Add missing Key Concepts, Deployment Strategies,
Query Filters, PINNED/AUTO_UPGRADE guidance, CLI examples
- advanced-features.md: Add worker-level heading for exception types
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* Fix .NET correctness issues from verification pass
- patterns.md: Fix cancellation pattern to use official
TemporalException.IsCanceledException(e) with detached CancellationTokenSource
- advanced-features.md: Fix DI hosting example to use official
AddHostedTemporalWorker(clientTargetHost:, clientNamespace:, taskQueue:) pattern
Verified against official SDK README, API docs, and temporal-docs.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* Update supported language references to include .NET
- SKILL.md: Add "Temporal .NET" and "Temporal C#" trigger phrases,
update overview to mention .NET, add .NET entry in getting started
- core/determinism.md: Add .NET entry in SDK Protection Mechanisms
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* Edits to advanced features
* edits to determinism protection, and move the .editorconfig section
* missed one
* edit determinism.md
* edit error-handling.md
* edit gotchas.md
* edit patterns.md
* edit versioning.md
* edit observability.md
* fix metrics
* self-review round 1
* minor correctness fixed
* Update references/dotnet/patterns.md
Co-authored-by: Justin Anderson <44687433+jmaeagle99@users.noreply.github.com>
* address comments, clarify reference to earlier code snippet
* clarify that operations are forbidden IN WORKFLOWS
* cleanup workflow cancellation handling example
* add task token retrieval comment
* update .net requirements
* Fix propagation of workflow cancellation
---------
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Justin Anderson <44687433+jmaeagle99@users.noreply.github.com>
|
2026-04-17 14:28:02 -04:00 |
|
|
Donald Pinckney
|
0c8586b4c2
|
Add Java SDK support (#42)
* Add Java SDK reference files (11 files)
Create complete Java reference documentation covering:
- java.md: Entry point with quick start tutorial, key concepts
- patterns.md: 17 patterns (signals, queries, updates, child workflows,
saga, cancellation scopes, heartbeating, etc.)
- determinism.md: Safe alternatives table, forbidden operations
- determinism-protection.md: Convention-based enforcement (no sandbox)
- error-handling.md: ApplicationFailure, retry/timeout config
- gotchas.md: Non-deterministic operations, cancellation, heartbeating
- testing.md: TestWorkflowEnvironment, Mockito mocking, replay testing
- versioning.md: Workflow.getVersion(), worker versioning
- data-handling.md: Jackson, PayloadConverter, encryption, search attributes
- observability.md: SLF4J logging, Micrometer metrics
- advanced-features.md: Schedules, async completion, worker tuning
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* Fix Java alignment issues from self-review
- Reduce gotchas.md Non-Deterministic Operations from ~94 lines to ~12
(reference determinism.md instead of duplicating)
- Remove Workflow Failure Exception Types duplication from error-handling.md
(keep only in advanced-features.md)
- Expand versioning.md Worker Versioning with Key Concepts, PINNED vs
AUTO_UPGRADE, Deployment Strategies subsections
- Fix section names to match Python reference style:
Activity Heartbeat Details, Handling Activity Errors,
Retry Policy Configuration, Workflow Test Environment,
Mocking Activities, Workflow Replay Testing
- Reduce data-handling.md Payload Encryption verbosity
- Reduce observability.md Logger Customization verbosity
- Reduce testing.md to single approach per section
- Rename determinism.md "Convention-Based Enforcement" to "SDK Protection"
- Fix handler guidance in patterns.md to match Python
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* Fix correctness issues in Java reference files
- patterns.md: Fix Queries section — ActivityStub → typed interface
(Workflow.newActivityStub returns the typed interface, not ActivityStub)
- data-handling.md: Add missing ProtobufPayloadConverter to default
converter chain (4th of 5 converters)
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* Add Java to SKILL.md and core/determinism.md
- SKILL.md: Add "Temporal Java" trigger phrase, update Overview to
list Java, add Java entry to Getting Started references
- core/determinism.md: Add Java entry to SDK Protection Mechanisms
(no sandbox, convention-based, NonDeterministicException at replay)
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* Apply manual editorial fixes to Java references
- java.md: Remove "Understanding Replay" section (covered by Overview),
simplify File Organization note (no sandbox rationale)
- gotchas.md: Move Heartbeating before Cancellation, make Wrong Retry
Classification brief with reference (not inline examples)
- error-handling.md: Remove editorializing from Workflow Failure note
- determinism-protection.md: Remove cross-language comparison paragraph
(state Java's approach on its own terms)
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* Add temporal-workflowcheck static analysis to Java determinism docs
- determinism-protection.md: Add "Static Analysis with temporal-workflowcheck"
section with Gradle/Maven setup, manual run, and suppression instructions.
Beta warning included.
- determinism.md: Update overview and SDK Protection to reference workflowcheck
- core/determinism.md: Update Java entry in SDK Protection Mechanisms
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* Integrate feedback from Go PR into Java patterns
- Updates: Add validator note — validators must not mutate state or
block (matches note added to Python, TypeScript, Go, and core)
- Saga Pattern: Use Workflow.newDetachedCancellationScope() for
compensations so they execute even if the workflow is cancelled
(mirrors Go's workflow.NewDisconnectedContext pattern)
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
* docs: add @WorkflowInit description to java.md Key Concepts
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* mark java as supported
* Apply suggestions from code review
Co-authored-by: Brian Strauch <brian@brianstrauch.com>
* strongly recommend java 21+
* Softened stance on static checker and replay testing.
* address python/typescript sandboxing comment
---------
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Brian Strauch <brian.strauch@temporal.io>
Co-authored-by: Brian Strauch <brian@brianstrauch.com>
|
2026-04-02 17:07:33 -04:00 |
|