mirror of
https://github.com/supabase/supabase.git
synced 2026-09-22 13:37:53 +08:00
476d4a5851
## What kind of change does this PR introduce? Mechanical cleanup on top of the Button default-variant change (#50160). ## What is the current behavior? Many callsites still pass `variant="default"` even though that is now the component default. ## What is the new behavior? Removes redundant static `variant="default"` from legacy `Button` and `ButtonTooltip` callsites. Keeps explicit defaults where they document the API: - `button-default.tsx` and `button-sizes.tsx` demos - `DocsButton`, which pins neutral styling at the wrapper boundary ## To test Studio: - [Auth → Rate Limits](https://studio-staging-2s957kwc4-supabase.vercel.app/dashboard/project/_/auth/rate-limits): dirty the form so Cancel appears; Cancel stays neutral, Save stays green - [Project Settings → API Keys](https://studio-staging-2s957kwc4-supabase.vercel.app/dashboard/project/_/settings/api-keys): `DocsButton` in the header actions stays neutral Design system: - [Design system → Button](https://design-system-git-dnywh-dc924ac1-supabase.vercel.app/design-system/docs/components/button): `button-default` / `button-sizes` still show explicit default styling; Primary (green) is restricted to the Primary section (and `asChild`) WWW: - [www → Brand assets](https://zone-www-dot-com-git-dnywh-dc924ac1-supabase.vercel.app/brand-assets): Download logo kit / Download button kit stay neutral
37 lines
1.1 KiB
TypeScript
37 lines
1.1 KiB
TypeScript
import { X } from 'lucide-react'
|
|
import { Button } from 'ui'
|
|
|
|
import { useDataTable } from './providers/DataTableProvider'
|
|
import { ShortcutTooltip } from '@/components/ui/ShortcutTooltip'
|
|
import { SHORTCUT_IDS } from '@/state/shortcuts/registry'
|
|
import { useShortcut } from '@/state/shortcuts/useShortcut'
|
|
|
|
export interface DataTableResetButtonProps {
|
|
/** Called alongside `table.resetColumnFilters()` — for filters that live outside TanStack Table's columnFilters state (e.g. a cross-cutting URL param). */
|
|
onReset?: () => void
|
|
}
|
|
|
|
export function DataTableResetButton({ onReset }: DataTableResetButtonProps) {
|
|
const { table } = useDataTable()
|
|
const reset = () => {
|
|
table.resetColumnFilters()
|
|
onReset?.()
|
|
}
|
|
|
|
useShortcut(SHORTCUT_IDS.DATA_TABLE_RESET_FILTERS, reset, {
|
|
registerInCommandMenu: true,
|
|
})
|
|
|
|
return (
|
|
<ShortcutTooltip
|
|
shortcutId={SHORTCUT_IDS.DATA_TABLE_RESET_FILTERS}
|
|
label="Reset filters"
|
|
side="left"
|
|
>
|
|
<Button size="tiny" onClick={reset} icon={<X />}>
|
|
Reset
|
|
</Button>
|
|
</ShortcutTooltip>
|
|
)
|
|
}
|