Files
Danny White 476d4a5851 refactor(ui): drop redundant Button variant="default" props (#50161)
## What kind of change does this PR introduce?

Mechanical cleanup on top of the Button default-variant change (#50160).

## What is the current behavior?

Many callsites still pass `variant="default"` even though that is now
the component default.

## What is the new behavior?

Removes redundant static `variant="default"` from legacy `Button` and
`ButtonTooltip` callsites. Keeps explicit defaults where they document
the API:

- `button-default.tsx` and `button-sizes.tsx` demos
- `DocsButton`, which pins neutral styling at the wrapper boundary

## To test

Studio:

- [Auth → Rate
Limits](https://studio-staging-2s957kwc4-supabase.vercel.app/dashboard/project/_/auth/rate-limits):
dirty the form so Cancel appears; Cancel stays neutral, Save stays green
- [Project Settings → API
Keys](https://studio-staging-2s957kwc4-supabase.vercel.app/dashboard/project/_/settings/api-keys):
`DocsButton` in the header actions stays neutral

Design system:

- [Design system →
Button](https://design-system-git-dnywh-dc924ac1-supabase.vercel.app/design-system/docs/components/button):
`button-default` / `button-sizes` still show explicit default styling;
Primary (green) is restricted to the Primary section (and `asChild`)

WWW:

- [www → Brand
assets](https://zone-www-dot-com-git-dnywh-dc924ac1-supabase.vercel.app/brand-assets):
Download logo kit / Download button kit stay neutral
2026-09-11 17:05:26 +10:00

202 lines
7.2 KiB
TypeScript

import { PermissionAction } from '@supabase/shared-types/out/constants'
import { useParams } from 'common'
import Link from 'next/link'
import { useRouter } from 'next/router'
import { parseAsString, useQueryState } from 'nuqs'
import { useCallback } from 'react'
import { Button } from 'ui'
import { Admonition } from 'ui-patterns/Admonition'
import { GenericSkeletonLoader } from 'ui-patterns/ShimmeringLoader'
import DeleteConfirmationDialogs from './DeleteConfirmationDialogs'
import { SidePanelEditor } from './SidePanelEditor/SidePanelEditor'
import { TableDefinition } from './TableDefinition'
import { SupabaseGrid } from '@/components/grid/SupabaseGrid'
import { useSyncTableEditorStateFromLocalStorageWithUrl } from '@/components/grid/SupabaseGrid.utils'
import {
Entity,
isForeignTable,
isMaterializedView,
isTableLike,
isView,
TableLike,
} from '@/data/table-editor/table-editor-types'
import { useAsyncCheckPermissions } from '@/hooks/misc/useCheckPermissions'
import { useDashboardHistory } from '@/hooks/misc/useDashboardHistory'
import { useQuerySchemaState } from '@/hooks/misc/useSchemaQueryState'
import { useIsProtectedSchema } from '@/hooks/useProtectedSchemas'
import { TableEditorTableStateContextProvider } from '@/state/table-editor-table'
import { createTabId, useTabsStateSnapshot } from '@/state/tabs'
export interface TableGridEditorProps {
isLoadingSelectedTable?: boolean
selectedTable?: Entity
}
export const TableGridEditor = ({
isLoadingSelectedTable = false,
selectedTable,
}: TableGridEditorProps) => {
const router = useRouter()
const { ref: projectRef, id } = useParams()
const { setLastVisitedTable } = useDashboardHistory()
const { selectedSchema } = useQuerySchemaState()
const tabs = useTabsStateSnapshot()
useSyncTableEditorStateFromLocalStorageWithUrl({
projectRef,
table: selectedTable,
})
const [selectedView] = useQueryState('view', parseAsString.withDefault('data'))
const { can: canEditTables } = useAsyncCheckPermissions(
PermissionAction.TENANT_SQL_ADMIN_WRITE,
'tables'
)
const { can: canEditColumns } = useAsyncCheckPermissions(
PermissionAction.TENANT_SQL_ADMIN_WRITE,
'columns'
)
const isReadOnly = !canEditTables && !canEditColumns
const tabId = !!id ? tabs.openTabs.find((x) => x.endsWith(id)) : undefined
const openTabs = tabs.openTabs.filter((x) => !x.startsWith('sql'))
const onTableCreated = useCallback(
(table: { id: number }) => {
router.push(
`/project/${projectRef}/editor/${table.id}${!!selectedSchema ? `?schema=${selectedSchema}` : ''}`
)
},
[projectRef, router, selectedSchema]
)
const onTableDeleted = useCallback(async () => {
// For simplicity for now, we just open the first table within the same schema
if (selectedTable) {
// Close tab
const tabId = createTabId(selectedTable.entity_type, { id: selectedTable.id })
tabs.handleTabClose({
id: tabId,
router,
editor: 'table',
onClearDashboardHistory: () => setLastVisitedTable(undefined),
})
}
}, [router, selectedTable, setLastVisitedTable, tabs])
const { isSchemaLocked } = useIsProtectedSchema({ schema: selectedTable?.schema ?? '' })
// NOTE: DO NOT PUT HOOKS AFTER THIS LINE
if (isLoadingSelectedTable || !projectRef) {
return (
<div className="flex flex-col">
<div className="h-10 bg-dash-sidebar dark:bg-surface-100" />
<div className="h-9 border-y" />
<div className="p-2 col-span-full">
<GenericSkeletonLoader />
</div>
</div>
)
}
const isViewSelected = isView(selectedTable) || isMaterializedView(selectedTable)
const isTableSelected = isTableLike(selectedTable)
const isForeignTableSelected = isForeignTable(selectedTable)
const canEditViaTableEditor = isTableSelected && !isSchemaLocked
const editable = !isReadOnly && canEditViaTableEditor
const gridKey = !!selectedTable
? `${selectedTable.schema}_${selectedTable.name}`
: 'unknown-table'
/** [Joshen] We're going to need to refactor SupabaseGrid eventually to make the code here more readable
* For context we previously built the SupabaseGrid as a reusable npm component, but eventually decided
* to just integrate it directly into the dashboard. The header, and body (+footer) should be decoupled.
*/
return (
// When any click happens in a table tab, the tab becomes permanent
<div className="h-full" onClick={() => tabs.makeActiveTabPermanent()}>
{!selectedTable ? (
<div className="flex items-center justify-center h-full">
<div className="w-[400px]">
<Admonition
type="default"
title={`Unable to find your table with ID ${id}`}
description="This table doesn't exist in your database"
>
{!!tabId ? (
<Button
className="mt-2"
onClick={() => {
tabs.handleTabClose({
id: tabId,
router,
editor: 'table',
onClearDashboardHistory: () => setLastVisitedTable(undefined),
})
}}
>
Close tab
</Button>
) : openTabs.length > 0 ? (
<Button asChild className="mt-2" onClick={() => setLastVisitedTable(undefined)}>
<Link href={`/project/${projectRef}/editor/${openTabs[0].split('-')[1]}`}>
Close tab
</Link>
</Button>
) : (
<Button asChild className="mt-2" onClick={() => setLastVisitedTable(undefined)}>
<Link href={`/project/${projectRef}/editor`}>Head back</Link>
</Button>
)}
</Admonition>
</div>
</div>
) : (
<TableEditorTableStateContextProvider
key={`table-editor-table-${selectedTable.id}`}
projectRef={projectRef}
table={selectedTable}
editable={editable}
>
<SupabaseGrid
key={gridKey}
gridProps={{ height: '100%' }}
customHeader={
(isViewSelected || isTableSelected) && selectedView === 'definition' ? (
<div className="px-2 flex items-center gap-x-2">
<p>
SQL Definition of <code className="text-sm">{selectedTable.name}</code>{' '}
</p>
<p className="text-foreground-light text-sm">(Read only)</p>
</div>
) : null
}
>
{(isViewSelected || isTableSelected) && selectedView === 'definition' && (
<TableDefinition entity={selectedTable} />
)}
</SupabaseGrid>
<DeleteConfirmationDialogs
selectedTable={selectedTable}
onTableDeleted={onTableDeleted}
/>
</TableEditorTableStateContextProvider>
)}
<SidePanelEditor
editable={editable}
selectedTable={
isTableSelected || isForeignTableSelected ? (selectedTable as TableLike) : undefined
}
onTableCreated={onTableCreated}
/>
</div>
)
}