mirror of
https://github.com/supabase/supabase.git
synced 2026-09-22 13:37:53 +08:00
a31ca2bad0
## What kind of change does this PR introduce? Bug fix and design-system update. Resolves DEPR-316. Follow-up rename (`text-brand` → `text-primary`) is in a dedicated PR (https://github.com/supabase/supabase/pull/50564) stacked on this one. ## What is the current behavior? `text-brand` resolves to the canonical bright brand green in places that need readable text, which fails WCAG AA on light surfaces. A separate `text-brand-display` token adds another green for large type. ## What is the new behavior? - `text-brand` maps to accessible `--primary` (light mode darkened to meet ~4.5:1 AA) - `--hue` / `--primary-hue` aligned to 157.5 - `text-brand-display` removed; former display callsites use `text-brand` - Bright fills/borders stay on `brand-default` - Design-system colour and typography docs updated | Before | After | | --- | --- | | <img width="514" height="112" alt="CleanShot 2026-09-02 at 11 13 09@2x" src="https://github.com/user-attachments/assets/4e0138a9-a32d-4e4c-a426-90736706e1e7" /> | <img width="512" height="138" alt="CleanShot 2026-09-21 at 11 42 05@2x" src="https://github.com/user-attachments/assets/164cc5b1-a0c5-4e93-95f1-80016641a114" /> | | <img width="864" height="266" alt="CleanShot 2026-09-02 at 11 13 53@2x" src="https://github.com/user-attachments/assets/3c1ca53f-bf9e-431e-bc15-816b4a275b8e" /> | <img width="882" height="248" alt="CleanShot 2026-09-21 at 11 41 37@2x" src="https://github.com/user-attachments/assets/24828e7b-ed6b-44cb-b9dc-becc3398bdfc" /> | | <img width="782" height="692" alt="CleanShot 2026-09-02 at 11 16 30@2x" src="https://github.com/user-attachments/assets/fc871977-77bc-47fb-9e0e-9284e0ecd5cc" /> | <img width="730" height="690" alt="CleanShot 2026-09-21 at 11 42 52@2x" src="https://github.com/user-attachments/assets/bf479515-d5f9-471e-b82d-f097c0f4b56c" /> | | <img width="480" height="306" alt="CleanShot 2026-09-02 at 11 18 53@2x" src="https://github.com/user-attachments/assets/03f341f4-f02e-44f8-a2b2-8c31670d0427" /> | <img width="470" height="300" alt="CleanShot 2026-09-21 at 11 43 19@2x" src="https://github.com/user-attachments/assets/9df18217-d5e6-48b8-ba0b-579d2664b94b" /> | | <img width="960" height="300" alt="CleanShot 2026-09-02 at 11 32 04@2x" src="https://github.com/user-attachments/assets/6b1d9373-7a71-4247-81ff-26441604b09d" /> | <img width="980" height="306" alt="CleanShot 2026-09-21 at 11 44 13@2x" src="https://github.com/user-attachments/assets/41ad4784-02ec-4b29-b860-32af9fa79aa8" /> | | <img width="924" height="214" alt="CleanShot 2026-09-02 at 11 34 44@2x" src="https://github.com/user-attachments/assets/1de661fe-c7b6-499b-a94f-e4737436ec79" /> | <img width="752" height="162" alt="CleanShot 2026-09-21 at 11 44 56@2x" src="https://github.com/user-attachments/assets/1811890f-0660-4445-84e9-447720954fa1" /> | ## To test Test each callsite **in light mode** (dark mode is largely unchanged). ### WWW - [Homepage](https://zone-www-dot-com-git-dnywh-depr-316-brand-text-tokens-supabase.vercel.app/): “Scale to millions” uses readable brand text (display token is gone) - [Careers](https://zone-www-dot-com-git-dnywh-depr-316-brand-text-tokens-supabase.vercel.app/careers): small “Careers” eyebrow readable; green dividers stay bright `brand-default` - [Contact](https://zone-www-dot-com-git-dnywh-depr-316-brand-text-tokens-supabase.vercel.app/contact-us): email / policy links use readable brand text - [Regions](https://zone-www-dot-com-git-dnywh-depr-316-brand-text-tokens-supabase.vercel.app/regions): “Ask about early access to BYOC” readable ### Docs - [Docs homepage](https://docs-git-dnywh-depr-316-brand-text-tokens-supabase.vercel.app/docs): “DOCS” wordmark and resource links readable - [Database overview](https://docs-git-dnywh-depr-316-brand-text-tokens-supabase.vercel.app/docs/guides/database/overview): nav / footer brand links readable - [JavaScript reference](https://docs-git-dnywh-depr-316-brand-text-tokens-supabase.vercel.app/docs/reference/javascript/introduction): active sidebar treatment readable ### Design system - [Typography](https://design-system-git-dnywh-depr-316-brand-text-tokens-supabase.vercel.app/docs/typography): documents `text-brand` only (no display) - [Colour usage](https://design-system-git-dnywh-depr-316-brand-text-tokens-supabase.vercel.app/docs/color-usage): `text-brand` vs `bg-brand-default` - [Design-system homepage](https://design-system-git-dnywh-depr-316-brand-text-tokens-supabase.vercel.app/): brand text examples across themes ### Studio - [Auth providers](https://studio-staging-git-dnywh-depr-316-brand-text-tokens-supabase.vercel.app/dashboard/project/_/auth/providers): enabled provider badge text readable; status dot stays bright - [Database policies](https://studio-staging-git-dnywh-depr-316-brand-text-tokens-supabase.vercel.app/dashboard/project/_/database/policies?new=true): template hover text more legible - [Database connections](https://studio-staging-git-dnywh-depr-316-brand-text-tokens-supabase.vercel.app/dashboard/project/_/observability/connections): “Live” status readable; animated dot stays bright green --------- Co-authored-by: Joshen Lim <joshenlimek@gmail.com>
146 lines
5.8 KiB
TypeScript
146 lines
5.8 KiB
TypeScript
import { PermissionAction } from '@supabase/shared-types/out/constants'
|
|
import { ArrowUp, ChevronDown, FileText } from 'lucide-react'
|
|
import {
|
|
Button,
|
|
cn,
|
|
DropdownMenu,
|
|
DropdownMenuContent,
|
|
DropdownMenuItem,
|
|
DropdownMenuTrigger,
|
|
} from 'ui'
|
|
|
|
import { ShortcutBadge } from '@/components/ui/ShortcutBadge'
|
|
import { useAsyncCheckPermissions } from '@/hooks/misc/useCheckPermissions'
|
|
import { useTrack } from '@/lib/telemetry/track'
|
|
import { SHORTCUT_IDS } from '@/state/shortcuts/registry'
|
|
import { useShortcut } from '@/state/shortcuts/useShortcut'
|
|
import { useTableEditorStateSnapshot } from '@/state/table-editor'
|
|
import { useTableEditorTableStateSnapshot } from '@/state/table-editor-table'
|
|
|
|
export const InsertButton = () => {
|
|
const track = useTrack()
|
|
|
|
const snap = useTableEditorTableStateSnapshot()
|
|
const tableEditorSnap = useTableEditorStateSnapshot()
|
|
const { can: canCreateColumns } = useAsyncCheckPermissions(
|
|
PermissionAction.TENANT_SQL_ADMIN_WRITE,
|
|
'columns'
|
|
)
|
|
|
|
const onAddRow =
|
|
snap.editable && (snap.table.columns ?? []).length > 0 ? tableEditorSnap.onAddRow : undefined
|
|
const onAddColumn = snap.editable ? tableEditorSnap.onAddColumn : undefined
|
|
const onImportData = snap.editable ? tableEditorSnap.onImportData : undefined
|
|
|
|
const canAddNew = onAddRow !== undefined || onAddColumn !== undefined
|
|
|
|
useShortcut(SHORTCUT_IDS.TABLE_EDITOR_INSERT_ROW, () => onAddRow?.(), {
|
|
registerInCommandMenu: true,
|
|
enabled: onAddRow !== undefined && canAddNew && canCreateColumns,
|
|
})
|
|
useShortcut(SHORTCUT_IDS.TABLE_EDITOR_INSERT_COLUMN, () => onAddColumn?.(), {
|
|
registerInCommandMenu: true,
|
|
enabled: onAddColumn !== undefined && canAddNew && canCreateColumns,
|
|
})
|
|
useShortcut(SHORTCUT_IDS.TABLE_EDITOR_IMPORT_CSV, () => onImportData?.(), {
|
|
registerInCommandMenu: true,
|
|
enabled: onImportData !== undefined && canAddNew && canCreateColumns,
|
|
})
|
|
|
|
if (!canAddNew || !canCreateColumns) return null
|
|
|
|
return (
|
|
<DropdownMenu>
|
|
<DropdownMenuTrigger asChild>
|
|
<Button
|
|
data-testid="table-editor-insert-new-row"
|
|
variant="primary"
|
|
size="tiny"
|
|
icon={<ChevronDown strokeWidth={1.5} />}
|
|
>
|
|
Insert
|
|
</Button>
|
|
</DropdownMenuTrigger>
|
|
<DropdownMenuContent side="bottom" align="end">
|
|
{[
|
|
...(onAddRow !== undefined
|
|
? [
|
|
<DropdownMenuItem
|
|
key="add-row"
|
|
className="flex items-center group gap-x-3"
|
|
onClick={onAddRow}
|
|
>
|
|
<div className="shrink-0 w-4">
|
|
<div className="border border-foreground-lighter w-[15px] h-[4px]" />
|
|
<div className="border border-foreground-lighter w-[15px] h-[4px] my-[2px]" />
|
|
<div
|
|
className={cn([
|
|
'border border-foreground-light w-[15px] h-[4px] translate-x-0.5',
|
|
'transition duration-200 group-data-highlighted:border-brand-default group-data-highlighted:translate-x-0',
|
|
])}
|
|
/>
|
|
</div>
|
|
<p className="flex-1 min-w-0 pr-4">Insert row</p>
|
|
<ShortcutBadge
|
|
shortcutId={SHORTCUT_IDS.TABLE_EDITOR_INSERT_ROW}
|
|
className="shrink-0"
|
|
/>
|
|
</DropdownMenuItem>,
|
|
]
|
|
: []),
|
|
...(onAddColumn !== undefined
|
|
? [
|
|
<DropdownMenuItem key="add-column" className="group gap-x-3" onClick={onAddColumn}>
|
|
<div className="flex shrink-0 w-4">
|
|
<div className="border border-foreground-lighter w-[4px] h-[15px]" />
|
|
<div className="border border-foreground-lighter w-[4px] h-[15px] mx-[2px]" />
|
|
<div
|
|
className={cn([
|
|
'border border-foreground-light w-[4px] h-[15px] -translate-y-0.5',
|
|
'transition duration-200 group-data-highlighted:border-brand-default group-data-highlighted:translate-y-0',
|
|
])}
|
|
/>
|
|
</div>
|
|
<p className="flex-1 min-w-0 pr-4">Insert column</p>
|
|
<ShortcutBadge
|
|
shortcutId={SHORTCUT_IDS.TABLE_EDITOR_INSERT_COLUMN}
|
|
className="shrink-0"
|
|
/>
|
|
</DropdownMenuItem>,
|
|
]
|
|
: []),
|
|
...(onImportData !== undefined
|
|
? [
|
|
<DropdownMenuItem
|
|
key="import-data"
|
|
className="group gap-x-3"
|
|
onClick={() => {
|
|
onImportData()
|
|
track('import_data_button_clicked', { tableType: 'Existing Table' })
|
|
}}
|
|
>
|
|
<div className="relative shrink-0 w-4">
|
|
<FileText size={18} strokeWidth={1.5} className="translate-x-[-2px]" />
|
|
<ArrowUp
|
|
className={cn(
|
|
'transition duration-200 absolute bottom-0 right-0 translate-y-1 opacity-0 bg-brand-400 rounded-full',
|
|
'group-data-highlighted:translate-y-0 group-data-highlighted:text-brand group-data-highlighted:opacity-100'
|
|
)}
|
|
strokeWidth={3}
|
|
size={12}
|
|
/>
|
|
</div>
|
|
<p className="flex-1 min-w-0 pr-4">Import data from CSV</p>
|
|
<ShortcutBadge
|
|
shortcutId={SHORTCUT_IDS.TABLE_EDITOR_IMPORT_CSV}
|
|
className="shrink-0"
|
|
/>
|
|
</DropdownMenuItem>,
|
|
]
|
|
: []),
|
|
]}
|
|
</DropdownMenuContent>
|
|
</DropdownMenu>
|
|
)
|
|
}
|