Files
Danny White 476d4a5851 refactor(ui): drop redundant Button variant="default" props (#50161)
## What kind of change does this PR introduce?

Mechanical cleanup on top of the Button default-variant change (#50160).

## What is the current behavior?

Many callsites still pass `variant="default"` even though that is now
the component default.

## What is the new behavior?

Removes redundant static `variant="default"` from legacy `Button` and
`ButtonTooltip` callsites. Keeps explicit defaults where they document
the API:

- `button-default.tsx` and `button-sizes.tsx` demos
- `DocsButton`, which pins neutral styling at the wrapper boundary

## To test

Studio:

- [Auth → Rate
Limits](https://studio-staging-2s957kwc4-supabase.vercel.app/dashboard/project/_/auth/rate-limits):
dirty the form so Cancel appears; Cancel stays neutral, Save stays green
- [Project Settings → API
Keys](https://studio-staging-2s957kwc4-supabase.vercel.app/dashboard/project/_/settings/api-keys):
`DocsButton` in the header actions stays neutral

Design system:

- [Design system →
Button](https://design-system-git-dnywh-dc924ac1-supabase.vercel.app/design-system/docs/components/button):
`button-default` / `button-sizes` still show explicit default styling;
Primary (green) is restricted to the Primary section (and `asChild`)

WWW:

- [www → Brand
assets](https://zone-www-dot-com-git-dnywh-dc924ac1-supabase.vercel.app/brand-assets):
Download logo kit / Download button kit stay neutral
2026-09-11 17:05:26 +10:00

84 lines
2.4 KiB
TypeScript

import { useParams } from 'common'
import { toast } from 'sonner'
import {
Button,
Dialog,
DialogContent,
DialogFooter,
DialogHeader,
DialogSection,
DialogSectionSeparator,
DialogTitle,
} from 'ui'
import { Admonition } from 'ui-patterns/Admonition'
import { useBucketEmptyMutation } from '@/data/storage/bucket-empty-mutation'
import type { Bucket } from '@/data/storage/buckets-query'
import { useStorageExplorerStateSnapshot } from '@/state/storage-explorer'
export interface EmptyBucketModalProps {
visible: boolean
bucket?: Bucket
onClose: () => void
}
export const EmptyBucketModal = ({ visible, bucket, onClose }: EmptyBucketModalProps) => {
const { ref: projectRef } = useParams()
const { fetchFolderContents } = useStorageExplorerStateSnapshot()
const { mutate: emptyBucket, isPending } = useBucketEmptyMutation({
onSuccess: async () => {
if (bucket === undefined) return
await fetchFolderContents({
bucketId: bucket.id,
folderId: bucket.id,
folderName: bucket.name,
index: -1,
})
toast.success(`Successfully emptied bucket ${bucket!.name}`)
onClose()
},
})
const onEmptyBucket = async () => {
if (!projectRef) return console.error('Project ref is required')
if (!bucket) return console.error('No bucket is selected')
emptyBucket({ projectRef, id: bucket.id })
}
return (
<Dialog
open={visible}
onOpenChange={(open) => {
if (!open) onClose()
}}
>
<DialogContent>
<DialogHeader>
<DialogTitle>{`Empty bucket “${bucket?.name}”`}</DialogTitle>
</DialogHeader>
<DialogSectionSeparator />
<Admonition
type="destructive"
className="rounded-none border-x-0 border-t-0"
title="This action cannot be undone"
description="The contents of your bucket cannot be recovered once deleted."
/>
<DialogSection>
<p className="text-sm">
Are you sure you want to remove all contents from the bucket “{bucket?.name}”?
</p>
</DialogSection>
<DialogFooter>
<Button disabled={isPending} onClick={onClose}>
Cancel
</Button>
<Button variant="danger" loading={isPending} onClick={onEmptyBucket}>
Empty bucket
</Button>
</DialogFooter>
</DialogContent>
</Dialog>
)
}