Files
Danny White 476d4a5851 refactor(ui): drop redundant Button variant="default" props (#50161)
## What kind of change does this PR introduce?

Mechanical cleanup on top of the Button default-variant change (#50160).

## What is the current behavior?

Many callsites still pass `variant="default"` even though that is now
the component default.

## What is the new behavior?

Removes redundant static `variant="default"` from legacy `Button` and
`ButtonTooltip` callsites. Keeps explicit defaults where they document
the API:

- `button-default.tsx` and `button-sizes.tsx` demos
- `DocsButton`, which pins neutral styling at the wrapper boundary

## To test

Studio:

- [Auth → Rate
Limits](https://studio-staging-2s957kwc4-supabase.vercel.app/dashboard/project/_/auth/rate-limits):
dirty the form so Cancel appears; Cancel stays neutral, Save stays green
- [Project Settings → API
Keys](https://studio-staging-2s957kwc4-supabase.vercel.app/dashboard/project/_/settings/api-keys):
`DocsButton` in the header actions stays neutral

Design system:

- [Design system →
Button](https://design-system-git-dnywh-dc924ac1-supabase.vercel.app/design-system/docs/components/button):
`button-default` / `button-sizes` still show explicit default styling;
Primary (green) is restricted to the Primary section (and `asChild`)

WWW:

- [www → Brand
assets](https://zone-www-dot-com-git-dnywh-dc924ac1-supabase.vercel.app/brand-assets):
Download logo kit / Download button kit stay neutral
2026-09-11 17:05:26 +10:00

77 lines
2.5 KiB
TypeScript

import { Plus, Trash } from 'lucide-react'
import { useFieldArray, useForm } from 'react-hook-form'
import { Button, FormControl, FormField, FormItem, FormMessage, Input } from 'ui'
import { FormItemLayout } from 'ui-patterns/form/FormItemLayout/FormItemLayout'
import { SSOConfigFormSchema } from './SSOConfig'
export const SSODomains = ({ form }: { form: ReturnType<typeof useForm<SSOConfigFormSchema>> }) => {
const { fields, append, remove } = useFieldArray({
control: form.control,
name: 'domains',
})
const domainsError = form.formState.errors.domains
// Handle different error structures - could be root error or direct error
const arrayLevelError =
domainsError &&
typeof domainsError === 'object' &&
'message' in domainsError &&
typeof domainsError.message === 'string'
? domainsError.message
: domainsError &&
typeof domainsError === 'object' &&
'root' in domainsError &&
domainsError.root &&
typeof domainsError.root === 'object' &&
'message' in domainsError.root
? String(domainsError.root.message)
: null
return (
<>
<FormItemLayout
label="Email Domains"
layout="flex-row-reverse"
description="Users with these email domains will be redirected to your identity provider when logging in from Supabase."
>
<div className="grid gap-2 w-full">
{fields.map((field, idx) => (
<div key={field.id} className="flex gap-2 items-top">
<FormField
name={`domains.${idx}.value`}
render={({ field }) => (
<FormItem className="flex-1">
<FormControl>
<Input {...field} autoComplete="off" placeholder="example.com" />
</FormControl>
<FormMessage />
</FormItem>
)}
/>
<Button
icon={<Trash size={12} />}
className="h-[34px] w-[34px]"
onClick={() => remove(idx)}
/>
</div>
))}
<div>
<Button
icon={<Plus className="w-4 h-4" />}
size="tiny"
onClick={() => append({ value: '' })}
>
Add another
</Button>
</div>
{arrayLevelError && (
<p className="text-sm font-medium text-destructive">{arrayLevelError}</p>
)}
</div>
</FormItemLayout>
</>
)
}