Files
Alaister Young 1966209483 chore(deps): upgrade vitest to v5 (#49994)
Upgrades Vitest from 4.1.4 to 5.0.0 across the monorepo, fixes the
handful of things v5 turned into hard errors, and drops the
`vi.clearAllMocks()` boilerplate that v5's `clearMocks` default makes
redundant.

**Changed:**
- `vitest`, `@vitest/ui`, `@vitest/coverage-v8` 4.1.4 → 5.0.0 (catalog)
- `vi.mock` calls that lived inside `beforeAll`/`beforeEach`/test bodies
moved to module scope (v5 throws on nested calls). Affects the Studio
and docs setup files and four Studio tests.
- `detectBrowser` test restores `navigator` via `vi.unstubAllGlobals()`
instead of assigning `global.navigator`, which now reaches jsdom's
getter-only property.
- `RowEditor.utils.test.ts` restores its `JSON.stringify` spy. It used
to leak a throwing mock for the rest of the file, which v5's coverage
provider now trips over. A later test in the same file had been
asserting the leak's side effect (valid JSON reported as invalid) and
now asserts the correct behavior.
- `@testing-library/jest-dom` 6.6 → 7.0.1. Its vitest type augmentation
resolves through a peer now, so it lands on each package's own `vitest`
instead of whichever copy pnpm hoisted. Fixes `toBeInTheDocument` type
errors in dev-tools after the reshuffle.
- `@testing-library/react` 16.0.0 → 16.3.3 for the React 19 peer range.
- `vite: catalog:` added to dev-tools, www, and common. Without it they
resolved a newer vite than the catalog pin, which forked a second vitest
instance in the lockfile. There's now one.
- ai-commands custom matcher types use v5's `Matchers<R, T>` form.
- 110 test files: `vi.clearAllMocks()` removed from
`beforeEach`/`afterEach` hooks, along with hooks that only did that and
the imports they left unused. Calls that also reset/restore mocks are
untouched. Second commit, mechanical.

**Added:**
- `.vitest/` to the root gitignore (v5 writes JSON/JUnit/HTML reporter
output there)

**Removed:**
- `vite-tsconfig-paths` catalog entry and deps. Vitest 5 resolves
tsconfig paths itself.

Release-age note: this sat in draft with a temporary
`minimumReleaseAgeExclude` entry for `vitest` and `@vitest/*` while
5.0.0 was inside the workspace's 3-day `minimumReleaseAge` window. That
window has closed, so the exclusion is gone and nothing bypasses the
release-age gate.

**Perf** (local, medians of 3 runs, same machine):

| Suite | v4.1.4 | v5.0.0 |
|---|---|---|
| studio | 144.1s | 141.7s (-2%) |
| studio `--coverage` | 156.9s | 146.4s (-7%) |
| ui-patterns | 6.27s | 5.07s (-19%) |
| ui `--coverage` | 3.35s | 2.14s (-36%) |
| www | 0.89s | 0.47s (-47%) |

Studio is dominated by jsdom environment setup per file, which v5
doesn't change. `vitest doctor` recommends keeping the current pool
config: the vm pools and `isolate: false` all break tests.

## To test

- `pnpm install --frozen-lockfile` succeeds with no
`minimumReleaseAgeExclude` entry for vitest.
- CI: Studio unit tests, ui, ui-patterns, www, docs, and typecheck/lint
should all be green. The lint ratchet was checked locally: warning
counts on touched Studio files are identical to master.
- `pnpm test:studio` locally passes with coverage (588 files, 6240
tests).
- Open a Studio test that uses `toBeInTheDocument` in your editor and
confirm no type errors on jest-dom matchers, in Studio and in
`packages/dev-tools`.
- Known pre-existing failures unrelated to this PR: one dev-tools test
(`getEventCountBadge` capped pill) fails on master too.


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Tests
- Improved test coverage for JSON validation and mobile navigation
behavior.
- Updated test setup, cleanup, environment configuration, and matcher
support across application and shared package suites.
- Removed obsolete coverage for alternate MCP transport selection.

## Chores
- Streamlined TypeScript path resolution and Vitest reporter output
handling.
- Updated testing libraries and Vitest tooling across documentation,
Studio, website, and shared packages.
- Added Vitest reporter output to ignored files.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Alaister Young <10985857+alaister@users.noreply.github.com>
Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com>
2026-09-10 16:45:54 +08:00

126 lines
4.4 KiB
TypeScript

import { render, screen } from '@testing-library/react'
import { describe, expect, it, vi } from 'vitest'
import { ErrorMatcher } from './ErrorMatcher'
import { ConnectionTimeoutError } from '@/types/api-errors'
import { ResponseError } from '@/types/base'
vi.mock('@/lib/telemetry/track', () => ({ useTrack: () => vi.fn() }))
vi.mock('@/state/ai-assistant-state', () => ({
useAiAssistantStateSnapshot: () => ({ newChat: vi.fn() }),
}))
vi.mock('@/state/sidebar-manager-state', () => ({
useSidebarManagerSnapshot: () => ({ openSidebar: vi.fn() }),
}))
vi.mock('@/components/layouts/ProjectLayout/LayoutSidebar/LayoutSidebarProvider', () => ({
SIDEBAR_KEYS: { AI_ASSISTANT: 'ai-assistant' },
}))
vi.mock('./RestartProjectDialog', () => ({
RestartProjectDialog: () => null,
}))
describe('ErrorMatcher', () => {
it('renders the provided title and error message', () => {
render(
<ErrorMatcher
title="Failed to load tables"
error="ERROR: FAILED TO RUN SQL QUERY: CONNECTION TERMINATED DUE TO CONNECTION TIMEOUT."
supportFormParams={{}}
/>
)
expect(screen.getByText('Failed to load tables')).toBeInTheDocument()
expect(
screen.getByText(
'ERROR: FAILED TO RUN SQL QUERY: CONNECTION TERMINATED DUE TO CONNECTION TIMEOUT.'
)
).toBeInTheDocument()
})
it('renders troubleshooting steps for classified errors', () => {
const error = new ConnectionTimeoutError('CONNECTION TERMINATED DUE TO CONNECTION TIMEOUT')
render(<ErrorMatcher title="Failed to load tables" error={error} supportFormParams={{}} />)
expect(screen.getByText('Try restarting your project')).toBeInTheDocument()
expect(screen.getByText('Try our troubleshooting guide')).toBeInTheDocument()
expect(screen.getByText('Debug with AI')).toBeInTheDocument()
})
it('renders fallback for plain ResponseError (not a classified subclass)', () => {
render(
<ErrorMatcher
title="Failed to load tables"
error={new ResponseError('CONNECTION TERMINATED DUE TO CONNECTION TIMEOUT')}
supportFormParams={{}}
/>
)
expect(screen.getByText('Failed to load tables')).toBeInTheDocument()
expect(screen.queryByText('Try restarting your project')).not.toBeInTheDocument()
})
it('renders fallback with provided title for unmatched errors', () => {
render(
<ErrorMatcher title="Failed to load tables" error="UNKNOWN ERROR" supportFormParams={{}} />
)
expect(screen.getByText('Failed to load tables')).toBeInTheDocument()
expect(screen.getByText('UNKNOWN ERROR')).toBeInTheDocument()
})
it('renders the caller-provided fallback when the error is unclassified', () => {
render(
<ErrorMatcher
title="Failed to load tables"
error="UNKNOWN ERROR"
supportFormParams={{}}
fallback={<div>Custom fallback</div>}
/>
)
expect(screen.getByText('Custom fallback')).toBeInTheDocument()
})
it('ignores the caller-provided fallback when the error is classified', () => {
const error = new ConnectionTimeoutError('CONNECTION TERMINATED DUE TO CONNECTION TIMEOUT')
render(
<ErrorMatcher
title="Failed to load tables"
error={error}
supportFormParams={{}}
fallback={<div>Custom fallback</div>}
/>
)
expect(screen.queryByText('Custom fallback')).not.toBeInTheDocument()
expect(screen.getByText('Try restarting your project')).toBeInTheDocument()
})
it('accepts error as object with message property', () => {
render(
<ErrorMatcher
title="Failed to load tables"
error={{ message: 'UNKNOWN ERROR' }}
supportFormParams={{}}
/>
)
expect(screen.getByText('UNKNOWN ERROR')).toBeInTheDocument()
})
it('builds support link with projectRef param', () => {
render(
<ErrorMatcher
title="Failed to load tables"
error="UNKNOWN ERROR"
supportFormParams={{ projectRef: 'my-project' }}
/>
)
expect(screen.getByRole('link', { name: /contact support/i })).toHaveAttribute(
'href',
'/support/new?projectRef=my-project'
)
})
it('builds support link with no params when supportFormParams is omitted', () => {
render(<ErrorMatcher title="Failed to load tables" error="UNKNOWN ERROR" />)
expect(screen.getByRole('link', { name: /contact support/i })).toHaveAttribute(
'href',
'/support/new'
)
})
})