mirror of
https://github.com/supabase/supabase.git
synced 2026-09-22 13:37:53 +08:00
Gildas Garcia
96d43099bb
## Problem Our `<Button>` component breaks the default `button` contract by redefining the `type` prop to set its variant (`primary`, `default`, etc) instead of the button type (`submit`, `button`, etc). This is confusing and forces to write more code when using it with shadcn components that expect/inject the standard button props. ## Solution - rename the `type` prop to `variant` - rename the `htmlType` prop to `type` - propagate the changes where necessary - format code ## How to test As this is just prop renaming, if it builds it's ok --------- Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com>
28 lines
712 B
TypeScript
28 lines
712 B
TypeScript
import { getChannelDisplayName } from '~/data/contribute'
|
|
import type { ThreadSource } from '~/types/contribute'
|
|
import { Button } from 'ui'
|
|
|
|
interface HelpOnPlatformButtonProps {
|
|
channel: ThreadSource
|
|
externalActivityUrl: string
|
|
type?: 'primary' | 'default'
|
|
className?: string
|
|
}
|
|
|
|
export function HelpOnPlatformButton({
|
|
channel,
|
|
externalActivityUrl,
|
|
type = 'primary',
|
|
className = 'w-full sm:w-fit',
|
|
}: HelpOnPlatformButtonProps) {
|
|
const platformName = getChannelDisplayName(channel)
|
|
|
|
return (
|
|
<Button asChild variant={type} className={className}>
|
|
<a href={externalActivityUrl} target="_blank" rel="noopener noreferrer">
|
|
Help on {platformName}
|
|
</a>
|
|
</Button>
|
|
)
|
|
}
|