Files
supabase__supabase/apps/studio/sentry.tanstack.test.ts
Alaister Young 1966209483 chore(deps): upgrade vitest to v5 (#49994)
Upgrades Vitest from 4.1.4 to 5.0.0 across the monorepo, fixes the
handful of things v5 turned into hard errors, and drops the
`vi.clearAllMocks()` boilerplate that v5's `clearMocks` default makes
redundant.

**Changed:**
- `vitest`, `@vitest/ui`, `@vitest/coverage-v8` 4.1.4 → 5.0.0 (catalog)
- `vi.mock` calls that lived inside `beforeAll`/`beforeEach`/test bodies
moved to module scope (v5 throws on nested calls). Affects the Studio
and docs setup files and four Studio tests.
- `detectBrowser` test restores `navigator` via `vi.unstubAllGlobals()`
instead of assigning `global.navigator`, which now reaches jsdom's
getter-only property.
- `RowEditor.utils.test.ts` restores its `JSON.stringify` spy. It used
to leak a throwing mock for the rest of the file, which v5's coverage
provider now trips over. A later test in the same file had been
asserting the leak's side effect (valid JSON reported as invalid) and
now asserts the correct behavior.
- `@testing-library/jest-dom` 6.6 → 7.0.1. Its vitest type augmentation
resolves through a peer now, so it lands on each package's own `vitest`
instead of whichever copy pnpm hoisted. Fixes `toBeInTheDocument` type
errors in dev-tools after the reshuffle.
- `@testing-library/react` 16.0.0 → 16.3.3 for the React 19 peer range.
- `vite: catalog:` added to dev-tools, www, and common. Without it they
resolved a newer vite than the catalog pin, which forked a second vitest
instance in the lockfile. There's now one.
- ai-commands custom matcher types use v5's `Matchers<R, T>` form.
- 110 test files: `vi.clearAllMocks()` removed from
`beforeEach`/`afterEach` hooks, along with hooks that only did that and
the imports they left unused. Calls that also reset/restore mocks are
untouched. Second commit, mechanical.

**Added:**
- `.vitest/` to the root gitignore (v5 writes JSON/JUnit/HTML reporter
output there)

**Removed:**
- `vite-tsconfig-paths` catalog entry and deps. Vitest 5 resolves
tsconfig paths itself.

Release-age note: this sat in draft with a temporary
`minimumReleaseAgeExclude` entry for `vitest` and `@vitest/*` while
5.0.0 was inside the workspace's 3-day `minimumReleaseAge` window. That
window has closed, so the exclusion is gone and nothing bypasses the
release-age gate.

**Perf** (local, medians of 3 runs, same machine):

| Suite | v4.1.4 | v5.0.0 |
|---|---|---|
| studio | 144.1s | 141.7s (-2%) |
| studio `--coverage` | 156.9s | 146.4s (-7%) |
| ui-patterns | 6.27s | 5.07s (-19%) |
| ui `--coverage` | 3.35s | 2.14s (-36%) |
| www | 0.89s | 0.47s (-47%) |

Studio is dominated by jsdom environment setup per file, which v5
doesn't change. `vitest doctor` recommends keeping the current pool
config: the vm pools and `isolate: false` all break tests.

## To test

- `pnpm install --frozen-lockfile` succeeds with no
`minimumReleaseAgeExclude` entry for vitest.
- CI: Studio unit tests, ui, ui-patterns, www, docs, and typecheck/lint
should all be green. The lint ratchet was checked locally: warning
counts on touched Studio files are identical to master.
- `pnpm test:studio` locally passes with coverage (588 files, 6240
tests).
- Open a Studio test that uses `toBeInTheDocument` in your editor and
confirm no type errors on jest-dom matchers, in Studio and in
`packages/dev-tools`.
- Known pre-existing failures unrelated to this PR: one dev-tools test
(`getEventCountBadge` capped pill) fails on master too.


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Tests
- Improved test coverage for JSON validation and mobile navigation
behavior.
- Updated test setup, cleanup, environment configuration, and matcher
support across application and shared package suites.
- Removed obsolete coverage for alternate MCP transport selection.

## Chores
- Streamlined TypeScript path resolution and Vitest reporter output
handling.
- Updated testing libraries and Vitest tooling across documentation,
Studio, website, and shared packages.
- Added Vitest reporter output to ignored files.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Alaister Young <10985857+alaister@users.noreply.github.com>
Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com>
2026-09-10 16:45:54 +08:00

133 lines
5.3 KiB
TypeScript

import type { AnyRouter } from '@tanstack/react-router'
import { afterEach, describe, expect, it, vi } from 'vitest'
const sentryMocks = vi.hoisted(() => ({
init: vi.fn(),
tanstackRouterBrowserTracingIntegration: vi.fn(() => ({
name: 'TanStackRouterBrowserTracing',
})),
// Imported at module scope by lib/sentry-client-options.ts, so the mock
// must provide it even though the TanStack init never enables it.
thirdPartyErrorFilterIntegration: vi.fn(() => ({ name: 'ThirdPartyErrorsFilter' })),
}))
vi.mock('@sentry/react', () => sentryMocks)
// The integration only needs a router reference to hook navigation events, and
// it is mocked here — a stub stands in for the real router at this boundary.
const fakeRouter = { subscribe: vi.fn() } as unknown as AnyRouter
// sentry.tanstack.ts keeps a module-level `initialized` flag, so each test
// imports a fresh copy of the module.
async function loadInitializer() {
vi.resetModules()
const { initSentryTanStackClient } = await import('./sentry.tanstack')
return initSentryTanStackClient
}
describe('initSentryTanStackClient', () => {
afterEach(() => {
vi.unstubAllGlobals()
vi.unstubAllEnvs()
})
it('does not initialize Sentry during SSR/prerender (no window)', async () => {
const initSentryTanStackClient = await loadInitializer()
vi.stubGlobal('window', undefined)
initSentryTanStackClient(fakeRouter)
expect(sentryMocks.init).not.toHaveBeenCalled()
})
it('initializes Sentry in the browser with the shared client options', async () => {
vi.stubEnv('NEXT_PUBLIC_SENTRY_DSN', 'https://public@sentry.example.com/1')
const initSentryTanStackClient = await loadInitializer()
initSentryTanStackClient(fakeRouter)
expect(sentryMocks.init).toHaveBeenCalledTimes(1)
expect(sentryMocks.init).toHaveBeenCalledWith(
expect.objectContaining({
dsn: 'https://public@sentry.example.com/1',
tracesSampleRate: 0.02,
})
)
})
it('passes an undefined dsn when NEXT_PUBLIC_SENTRY_DSN is unset (disabled-client no-op)', async () => {
vi.stubEnv('NEXT_PUBLIC_SENTRY_DSN', undefined)
const initSentryTanStackClient = await loadInitializer()
initSentryTanStackClient(fakeRouter)
// `Sentry.init` without a dsn creates a disabled client, so calling init
// unconditionally is safe for local/self-hosted builds.
expect(sentryMocks.init).toHaveBeenCalledTimes(1)
expect(sentryMocks.init).toHaveBeenCalledWith(expect.objectContaining({ dsn: undefined }))
})
it('only initializes once across repeated calls', async () => {
const initSentryTanStackClient = await loadInitializer()
initSentryTanStackClient(fakeRouter)
initSentryTanStackClient(fakeRouter)
expect(sentryMocks.init).toHaveBeenCalledTimes(1)
})
it('still initializes in the browser after an earlier SSR call', async () => {
const initSentryTanStackClient = await loadInitializer()
// An SSR call must not trip the idempotency guard for the browser call.
vi.stubGlobal('window', undefined)
initSentryTanStackClient(fakeRouter)
expect(sentryMocks.init).not.toHaveBeenCalled()
vi.unstubAllGlobals()
initSentryTanStackClient(fakeRouter)
expect(sentryMocks.init).toHaveBeenCalledTimes(1)
})
it('wires the TanStack Router browser tracing integration for the given router', async () => {
const initSentryTanStackClient = await loadInitializer()
initSentryTanStackClient(fakeRouter)
expect(sentryMocks.tanstackRouterBrowserTracingIntegration).toHaveBeenCalledWith(fakeRouter)
const [options] = sentryMocks.init.mock.calls[0]
// `integrations` is the function form: Sentry.init calls it with the
// default integrations (browserSession, globalHandlers, …) and installs
// whatever it returns, so the defaults must survive the merge.
expect(options.integrations).toBeTypeOf('function')
const defaultIntegrations = [{ name: 'BrowserSession' }, { name: 'GlobalHandlers' }]
const integrations = options.integrations(defaultIntegrations)
// Defaults passed in by Sentry.init survive the merge.
expect(integrations).toContainEqual({ name: 'BrowserSession' })
expect(integrations).toContainEqual({ name: 'GlobalHandlers' })
expect(integrations).toContainEqual({ name: 'TanStackRouterBrowserTracing' })
// The Vite build runs no Sentry bundler plugin, so frames carry no
// applicationKey metadata — the third-party filter must stay off or every
// event would be tagged third_party_code=true and dropped by beforeSend.
expect(sentryMocks.thirdPartyErrorFilterIntegration).not.toHaveBeenCalled()
expect(integrations).not.toContainEqual({ name: 'ThirdPartyErrorsFilter' })
})
it('passes the Vercel commit SHA as the release so session envelopes are sent', async () => {
// The SDK silently drops session envelopes when the client has no release
// (`Client.sendSession` early-returns) — without this, Release Health
// sends no /envelope traffic at all on the TanStack build. The Next build
// instead gets its release injected at build time by withSentryConfig.
vi.stubEnv('NEXT_PUBLIC_VERCEL_GIT_COMMIT_SHA', 'abc123commit')
const initSentryTanStackClient = await loadInitializer()
initSentryTanStackClient(fakeRouter)
expect(sentryMocks.init).toHaveBeenCalledWith(
expect.objectContaining({ release: 'abc123commit' })
)
})
})