mirror of
https://github.com/supabase/supabase.git
synced 2026-09-22 13:37:53 +08:00
1966209483
Upgrades Vitest from 4.1.4 to 5.0.0 across the monorepo, fixes the handful of things v5 turned into hard errors, and drops the `vi.clearAllMocks()` boilerplate that v5's `clearMocks` default makes redundant. **Changed:** - `vitest`, `@vitest/ui`, `@vitest/coverage-v8` 4.1.4 → 5.0.0 (catalog) - `vi.mock` calls that lived inside `beforeAll`/`beforeEach`/test bodies moved to module scope (v5 throws on nested calls). Affects the Studio and docs setup files and four Studio tests. - `detectBrowser` test restores `navigator` via `vi.unstubAllGlobals()` instead of assigning `global.navigator`, which now reaches jsdom's getter-only property. - `RowEditor.utils.test.ts` restores its `JSON.stringify` spy. It used to leak a throwing mock for the rest of the file, which v5's coverage provider now trips over. A later test in the same file had been asserting the leak's side effect (valid JSON reported as invalid) and now asserts the correct behavior. - `@testing-library/jest-dom` 6.6 → 7.0.1. Its vitest type augmentation resolves through a peer now, so it lands on each package's own `vitest` instead of whichever copy pnpm hoisted. Fixes `toBeInTheDocument` type errors in dev-tools after the reshuffle. - `@testing-library/react` 16.0.0 → 16.3.3 for the React 19 peer range. - `vite: catalog:` added to dev-tools, www, and common. Without it they resolved a newer vite than the catalog pin, which forked a second vitest instance in the lockfile. There's now one. - ai-commands custom matcher types use v5's `Matchers<R, T>` form. - 110 test files: `vi.clearAllMocks()` removed from `beforeEach`/`afterEach` hooks, along with hooks that only did that and the imports they left unused. Calls that also reset/restore mocks are untouched. Second commit, mechanical. **Added:** - `.vitest/` to the root gitignore (v5 writes JSON/JUnit/HTML reporter output there) **Removed:** - `vite-tsconfig-paths` catalog entry and deps. Vitest 5 resolves tsconfig paths itself. Release-age note: this sat in draft with a temporary `minimumReleaseAgeExclude` entry for `vitest` and `@vitest/*` while 5.0.0 was inside the workspace's 3-day `minimumReleaseAge` window. That window has closed, so the exclusion is gone and nothing bypasses the release-age gate. **Perf** (local, medians of 3 runs, same machine): | Suite | v4.1.4 | v5.0.0 | |---|---|---| | studio | 144.1s | 141.7s (-2%) | | studio `--coverage` | 156.9s | 146.4s (-7%) | | ui-patterns | 6.27s | 5.07s (-19%) | | ui `--coverage` | 3.35s | 2.14s (-36%) | | www | 0.89s | 0.47s (-47%) | Studio is dominated by jsdom environment setup per file, which v5 doesn't change. `vitest doctor` recommends keeping the current pool config: the vm pools and `isolate: false` all break tests. ## To test - `pnpm install --frozen-lockfile` succeeds with no `minimumReleaseAgeExclude` entry for vitest. - CI: Studio unit tests, ui, ui-patterns, www, docs, and typecheck/lint should all be green. The lint ratchet was checked locally: warning counts on touched Studio files are identical to master. - `pnpm test:studio` locally passes with coverage (588 files, 6240 tests). - Open a Studio test that uses `toBeInTheDocument` in your editor and confirm no type errors on jest-dom matchers, in Studio and in `packages/dev-tools`. - Known pre-existing failures unrelated to this PR: one dev-tools test (`getEventCountBadge` capped pill) fails on master too. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Tests - Improved test coverage for JSON validation and mobile navigation behavior. - Updated test setup, cleanup, environment configuration, and matcher support across application and shared package suites. - Removed obsolete coverage for alternate MCP transport selection. ## Chores - Streamlined TypeScript path resolution and Vitest reporter output handling. - Updated testing libraries and Vitest tooling across documentation, Studio, website, and shared packages. - Added Vitest reporter output to ignored files. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Alaister Young <10985857+alaister@users.noreply.github.com> Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com>
186 lines
6.1 KiB
TypeScript
186 lines
6.1 KiB
TypeScript
import * as Sentry from '@sentry/nextjs'
|
|
import { describe, expect, it, vi } from 'vitest'
|
|
|
|
import { captureCriticalError } from './error-reporting'
|
|
import { ResponseError } from '@/types'
|
|
|
|
vi.mock('@sentry/nextjs', () => ({
|
|
captureException: vi.fn(),
|
|
withScope: vi.fn((cb: (scope: any) => void) => {
|
|
const scope = { setTag: vi.fn() }
|
|
cb(scope)
|
|
}),
|
|
}))
|
|
|
|
describe('error-reporting', () => {
|
|
describe('captureCriticalError', () => {
|
|
it('should not capture error if message is empty', () => {
|
|
const error = { message: '' }
|
|
captureCriticalError(error, 'test context')
|
|
|
|
expect(Sentry.captureException).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('should capture regular Error objects', () => {
|
|
const error = new Error('Something went wrong')
|
|
captureCriticalError(error, 'test action')
|
|
|
|
expect(Sentry.captureException).toHaveBeenCalledWith(
|
|
expect.objectContaining({ message: 'Something went wrong', name: 'CriticalError' })
|
|
)
|
|
})
|
|
|
|
it('should not capture whitelisted error messages', () => {
|
|
const error = new Error('email must be an email')
|
|
captureCriticalError(error, 'validation')
|
|
|
|
expect(Sentry.captureException).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('should not capture errors with partial whitelisted message', () => {
|
|
const error = new Error('User error: A user with this email already exists in the system')
|
|
captureCriticalError(error, 'sign up')
|
|
|
|
expect(Sentry.captureException).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('should capture errors that are not whitelisted', () => {
|
|
const error = new Error('Database connection failed')
|
|
captureCriticalError(error, 'database')
|
|
|
|
expect(Sentry.captureException).toHaveBeenCalledWith(
|
|
expect.objectContaining({ message: 'Database connection failed', name: 'CriticalError' })
|
|
)
|
|
})
|
|
|
|
it('should capture 5XX ResponseError', () => {
|
|
const error = new ResponseError(
|
|
'Internal server error',
|
|
500,
|
|
undefined,
|
|
undefined,
|
|
'/api/test'
|
|
)
|
|
captureCriticalError(error, 'api call')
|
|
|
|
expect(Sentry.captureException).toHaveBeenCalledWith(
|
|
expect.objectContaining({
|
|
message: 'requestPathname /api/test w/ message: Internal server error',
|
|
name: 'CriticalError',
|
|
})
|
|
)
|
|
})
|
|
|
|
it('should not capture 4XX ResponseError', () => {
|
|
const error = new ResponseError('Not found', 404, undefined, undefined, '/api/test')
|
|
captureCriticalError(error, 'api call')
|
|
|
|
expect(Sentry.captureException).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('should capture ResponseError with 5XX status code', () => {
|
|
const error = new ResponseError('Gateway timeout', 504, undefined, undefined, '/api/gateway')
|
|
captureCriticalError(error, 'gateway request')
|
|
|
|
expect(Sentry.captureException).toHaveBeenCalledWith(
|
|
expect.objectContaining({
|
|
message: 'requestPathname /api/gateway w/ message: Gateway timeout',
|
|
name: 'CriticalError',
|
|
})
|
|
)
|
|
})
|
|
|
|
it('should capture ResponseError without code or requestPathname', () => {
|
|
const error = new ResponseError('Unknown error')
|
|
captureCriticalError(error, 'unknown')
|
|
|
|
expect(Sentry.captureException).toHaveBeenCalledWith(
|
|
expect.objectContaining({
|
|
message: 'Response Error (no code or requestPathname) w/ message: Unknown error',
|
|
name: 'CriticalError',
|
|
})
|
|
)
|
|
})
|
|
|
|
it('should capture unknown error objects with message property', () => {
|
|
const error = { message: 'Custom error object' }
|
|
captureCriticalError(error, 'custom')
|
|
|
|
expect(Sentry.captureException).toHaveBeenCalledWith(
|
|
expect.objectContaining({ message: 'Custom error object', name: 'CriticalError' })
|
|
)
|
|
})
|
|
|
|
it('should not capture unknown error without message', () => {
|
|
const error = { foo: 'bar' }
|
|
captureCriticalError(error as any, 'no message')
|
|
|
|
expect(Sentry.captureException).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('should not capture whitelisted password validation error', () => {
|
|
const error = new Error(
|
|
'Password is known to be weak and easy to guess, please choose a different one'
|
|
)
|
|
captureCriticalError(error, 'password update')
|
|
|
|
expect(Sentry.captureException).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('should not capture whitelisted TOTP error', () => {
|
|
const error = new Error('Invalid TOTP code entered')
|
|
captureCriticalError(error, 'mfa verification')
|
|
|
|
expect(Sentry.captureException).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('should not capture whitelisted project name error', () => {
|
|
const error = new Error('name should not contain a . string')
|
|
captureCriticalError(error, 'create project')
|
|
|
|
expect(Sentry.captureException).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('should capture non-whitelisted errors even if similar to whitelisted ones', () => {
|
|
const error = new Error('email format is invalid')
|
|
captureCriticalError(error, 'validation')
|
|
|
|
expect(Sentry.captureException).toHaveBeenCalledWith(
|
|
expect.objectContaining({ message: 'email format is invalid', name: 'CriticalError' })
|
|
)
|
|
})
|
|
|
|
it('should handle Error objects with empty message', () => {
|
|
const error = new Error('')
|
|
captureCriticalError(error, 'empty error')
|
|
|
|
expect(Sentry.captureException).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('should handle ResponseError at boundary of 4XX/5XX (499)', () => {
|
|
const error = new ResponseError(
|
|
'Client closed request',
|
|
499,
|
|
undefined,
|
|
undefined,
|
|
'/api/test'
|
|
)
|
|
captureCriticalError(error, 'request')
|
|
|
|
expect(Sentry.captureException).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('should handle ResponseError at boundary of 4XX/5XX (500)', () => {
|
|
const error = new ResponseError('Internal error', 500, undefined, undefined, '/api/test')
|
|
captureCriticalError(error, 'request')
|
|
|
|
expect(Sentry.captureException).toHaveBeenCalledWith(
|
|
expect.objectContaining({
|
|
message: 'requestPathname /api/test w/ message: Internal error',
|
|
name: 'CriticalError',
|
|
})
|
|
)
|
|
})
|
|
})
|
|
})
|