mirror of
https://github.com/supabase/supabase.git
synced 2026-09-22 13:37:53 +08:00
Joshen Lim
b1a9e072ec
### Context For table editor - the `ilike` related comparators expect users to input a `%` in the filter string, which for non-developers might not be intuitive. Hence opting to implicitly wrap the filter string with `%` in the query when filtering if non provided <img width="1182" height="755" alt="image" src="https://github.com/user-attachments/assets/819c39f5-fcbf-4213-95b3-3ad1ee901f47" /> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Improved pattern-match filters so bare text values perform contains matching by automatically wrapping them with wildcards. * Preserved explicit wildcard patterns using `%` or `_` without adding additional wildcards. * Improved handling of empty values for non-text filters while retaining existing numeric filter validation. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
76 lines
2.8 KiB
TypeScript
76 lines
2.8 KiB
TypeScript
import { describe, expect, it } from 'vitest'
|
|
|
|
import { formatFilterValue } from './utils'
|
|
import type { Filter } from '@/components/grid/types'
|
|
|
|
const table = {
|
|
columns: [
|
|
{ name: 'id', format: 'int8' },
|
|
{ name: 'count', format: 'int4' },
|
|
{ name: 'name', format: 'text' },
|
|
{ name: 'price', format: 'numeric' },
|
|
],
|
|
}
|
|
|
|
const makeFilter = (column: string, value: any, operator: Filter['operator'] = '='): Filter => ({
|
|
column,
|
|
operator,
|
|
value,
|
|
})
|
|
|
|
describe('formatFilterValue', () => {
|
|
it('returns the value untouched for non-numerical columns', () => {
|
|
expect(formatFilterValue(table, makeFilter('name', '123'))).toBe('123')
|
|
})
|
|
|
|
it('coerces in-range numerical values to a number', () => {
|
|
expect(formatFilterValue(table, makeFilter('count', '42'))).toBe(42)
|
|
expect(formatFilterValue(table, makeFilter('id', '-42'))).toBe(-42)
|
|
})
|
|
|
|
it('returns the original string when the value is not a valid number', () => {
|
|
expect(formatFilterValue(table, makeFilter('count', 'abc'))).toBe('abc')
|
|
})
|
|
|
|
it('preserves large positive bigints as strings to avoid precision loss', () => {
|
|
const int8Max = '9223372036854775807'
|
|
expect(formatFilterValue(table, makeFilter('id', int8Max))).toBe(int8Max)
|
|
})
|
|
|
|
// Regression: the previous implementation only guarded the upper bound
|
|
// (numberValue > MAX_SAFE_INTEGER), so large negative bigints were converted
|
|
// through Number() and silently rounded, producing a wrong filter value.
|
|
it('preserves large negative bigints as strings to avoid precision loss', () => {
|
|
const int8Min = '-9223372036854775808'
|
|
expect(formatFilterValue(table, makeFilter('id', int8Min))).toBe(int8Min)
|
|
|
|
const justBelowSafe = '-9007199254740993'
|
|
expect(formatFilterValue(table, makeFilter('id', justBelowSafe))).toBe(justBelowSafe)
|
|
})
|
|
|
|
it('keeps the exact safe-integer bounds as numbers', () => {
|
|
expect(formatFilterValue(table, makeFilter('id', String(Number.MAX_SAFE_INTEGER)))).toBe(
|
|
Number.MAX_SAFE_INTEGER
|
|
)
|
|
expect(formatFilterValue(table, makeFilter('id', String(Number.MIN_SAFE_INTEGER)))).toBe(
|
|
Number.MIN_SAFE_INTEGER
|
|
)
|
|
})
|
|
|
|
it.each(['~~', '~~*', '!~~', '!~~*'] as const)(
|
|
'wraps the value in %%...%% for the %s operator when no wildcard is present',
|
|
(operator) => {
|
|
expect(formatFilterValue(table, makeFilter('name', 'al', operator))).toBe('%al%')
|
|
}
|
|
)
|
|
|
|
it.each(['~~', '~~*', '!~~', '!~~*'] as const)(
|
|
'leaves the value untouched for the %s operator when it already contains a % or _ wildcard',
|
|
(operator) => {
|
|
expect(formatFilterValue(table, makeFilter('name', 'al%', operator))).toBe('al%')
|
|
expect(formatFilterValue(table, makeFilter('name', '%al', operator))).toBe('%al')
|
|
expect(formatFilterValue(table, makeFilter('name', 'j_hn', operator))).toBe('j_hn')
|
|
}
|
|
)
|
|
})
|