Files
Danny White 476d4a5851 refactor(ui): drop redundant Button variant="default" props (#50161)
## What kind of change does this PR introduce?

Mechanical cleanup on top of the Button default-variant change (#50160).

## What is the current behavior?

Many callsites still pass `variant="default"` even though that is now
the component default.

## What is the new behavior?

Removes redundant static `variant="default"` from legacy `Button` and
`ButtonTooltip` callsites. Keeps explicit defaults where they document
the API:

- `button-default.tsx` and `button-sizes.tsx` demos
- `DocsButton`, which pins neutral styling at the wrapper boundary

## To test

Studio:

- [Auth → Rate
Limits](https://studio-staging-2s957kwc4-supabase.vercel.app/dashboard/project/_/auth/rate-limits):
dirty the form so Cancel appears; Cancel stays neutral, Save stays green
- [Project Settings → API
Keys](https://studio-staging-2s957kwc4-supabase.vercel.app/dashboard/project/_/settings/api-keys):
`DocsButton` in the header actions stays neutral

Design system:

- [Design system →
Button](https://design-system-git-dnywh-dc924ac1-supabase.vercel.app/design-system/docs/components/button):
`button-default` / `button-sizes` still show explicit default styling;
Primary (green) is restricted to the Primary section (and `asChild`)

WWW:

- [www → Brand
assets](https://zone-www-dot-com-git-dnywh-dc924ac1-supabase.vercel.app/brand-assets):
Download logo kit / Download button kit stay neutral
2026-09-11 17:05:26 +10:00

151 lines
4.2 KiB
TypeScript

import { zodResolver } from '@hookform/resolvers/zod'
import { useParams } from 'common'
import { useEffect } from 'react'
import { SubmitHandler, useForm } from 'react-hook-form'
import { toast } from 'sonner'
import {
Button,
Dialog,
DialogContent,
DialogFooter,
DialogHeader,
DialogSection,
DialogSectionSeparator,
DialogTitle,
Form,
FormControl,
FormField,
Input,
Textarea,
} from 'ui'
import { FormItemLayout } from 'ui-patterns/form/FormItemLayout/FormItemLayout'
import * as z from 'zod'
import { ContentOfType } from '@/data/content/content-query'
import { useContentUpsertMutation } from '@/data/content/content-upsert-mutation'
const formSchema = z.object({
name: z.string().min(1, 'Required'),
description: z.string().optional(),
})
type CustomReport = z.infer<typeof formSchema>
export interface UpdateCustomReportProps {
selectedReport?: ContentOfType<'report'>
initialValues: CustomReport
onCancel: () => void
}
export const UpdateCustomReportModal = ({
selectedReport,
initialValues,
onCancel,
}: UpdateCustomReportProps) => {
const { ref } = useParams()
const { mutate: updateReport, isPending: isUpdating } = useContentUpsertMutation({
onSuccess: () => {
toast.success('Successfully updated report')
onCancel()
},
onError: (error) => {
toast.error(`Failed to update report: ${error.message}`)
},
})
const onConfirmUpdateReport: SubmitHandler<CustomReport> = (newVals) => {
if (!ref) return console.error('Project ref is required')
if (!selectedReport) return
if (!selectedReport.id) return
if (!selectedReport.project_id) return
updateReport({
projectRef: ref,
payload: {
...selectedReport,
owner_id: selectedReport.owner_id!,
project_id: selectedReport.project_id,
id: selectedReport.id,
name: newVals.name,
description: newVals.description || '',
},
})
}
const handleCancel = () => {
onCancel()
form.reset()
}
const form = useForm<CustomReport>({
resolver: zodResolver(formSchema),
defaultValues: initialValues,
})
const { formState, reset } = form
const { isDirty } = formState
useEffect(() => {
if (isDirty) return
reset(initialValues)
}, [initialValues, isDirty, reset])
return (
<Dialog open={selectedReport !== undefined} onOpenChange={handleCancel}>
<DialogContent size="small">
<DialogHeader>
<DialogTitle>Update custom report</DialogTitle>
</DialogHeader>
<DialogSectionSeparator />
<Form {...form}>
<form onSubmit={form.handleSubmit(onConfirmUpdateReport)} noValidate>
<DialogSection>
<FormField
control={form.control}
name="name"
render={({ field }) => (
<FormItemLayout layout="vertical" label="Name">
<FormControl>
<Input {...field} />
</FormControl>
</FormItemLayout>
)}
/>
</DialogSection>
<DialogSection>
<FormField
control={form.control}
name="description"
render={({ field }) => (
<FormItemLayout layout="vertical" label="Description">
<FormControl>
<Textarea
{...field}
rows={4}
placeholder="Describe your custom report"
className="resize-none"
/>
</FormControl>
</FormItemLayout>
)}
/>
</DialogSection>
<DialogFooter>
<Button type="reset" onClick={handleCancel} disabled={isUpdating}>
Cancel
</Button>
<Button
variant="primary"
type="submit"
loading={isUpdating}
disabled={isUpdating || !isDirty}
>
Save custom report
</Button>
</DialogFooter>
</form>
</Form>
</DialogContent>
</Dialog>
)
}