Destroying a host while its overlay/dialog is open ran the onDestroy
forceClose(), which emits on closed$/stateChanged$. The subscriptions
forwarded those to the component outputs after the directive was destroyed,
logging NG0953 in dev mode. Set a destroyed flag (registered before the
forceClose teardown) and skip the emits once it is set.
Resolve brn-dialog.service.ts conflict: drop the deprecated injectBrnDialogCtx
alias (removed on main during the pre-1.0 audit) and keep the typed
injectBrnDialogContext with the unknown default.
Drop the deprecated `injectBrnDialogCtx` in favour of `injectBrnDialogContext`, which the helm
dialog, docs app and storybook already use exclusively. Removing it before 1.0 avoids carrying the
alias on the stable line. The `BrnDialogContext` type it returned stays - it is still used inside
the service.
Replace fixed close delays with lifecycle-driven disposal so overlays remain responsive.
Wait only for exit animations that actually start and centralize Escape, backdrop, and
outside-pointer dismissal.
BREAKING CHANGE: remove the closeDelay input and configuration option. Remove explicit delay
values; closed-state exit animations are now detected automatically.
* fix(dialog): set default backdrop/panelClasses through options correctly
* fix(dialog): allow set state open directly and open only in browser
* avoids "Error: Expecting instance of DOM Element"
* feat(dialog): store effect ref
* feat(dialog): call cssClassesToArray only once
* feat(dialog): don't store ref off effect, clean up automatically
* feat(dialog): update styles and sort classes
# Conflicts:
# libs/helm/dialog/src/lib/hlm-dialog-close.ts
# libs/helm/dialog/src/lib/hlm-dialog-content.ts
* fix(dialog): control dialog close button height w/ flex
* button size was 16x24px w/ an icon of 16x16px
* using flex changes the sizes of the button to 16x16px
* feat(dialog): add --radiux-xs styles used by shadcn/ui
* fix(dialog): use outline-none for close button again
* docs(dialog): update example headings, form field and preview
# Conflicts:
# apps/app/src/app/pages/(components)/components/(dialog)/dialog.preview.ts
* docs(dialog): update bottom nav
* feat(dialog): replace mutable state using computed + signal w/ linkedSignal
* fix(dialog): remove [&_ng-icon]:pointer-events-none to fix e2e tests
* fix(dialog): use duration-200 for state open and closed
* fix(dialog): apply same styles like hlm-alert-dialog-content
* fix(dialog): center dialog on mobile using mx-auto
* justify-self-center is not applied in firefox/safari - parent container needs to be display grid
* feat: remove standalone property from various directives and components in the Helm UI library
* feat: enable strictStandalone option in Angular compiler settings
* feat(date-picker): autoCloseOnSelect option and open/close programmatically, closes#597
* feat(date-picker): hlm to cli
* feat(date-picker): transform autoCloseOnSelect, add to date-picker form example
* feat(dialog): add more dialog options to BrnDialogDefaultOptions
* change closeDelay to 100 default
* use closeDelay input value
* use defaultOptions values for input signal defaults
* feat(dialog): remove state from default options
* state open w/ initial page load throws errors with OutputRef and dialog position is wrong
* feat(dialog): replace mutable signals with default options
* fix default options scrollStrategy type
* expose default options for alert dialog and popover
* refactor(dialog): remove closeDelay 100 as it is the default value
* remove unused imports
* refactor(dialog): copy hlm changes to cli
Ashley Hunter