mirror of
https://github.com/software-mansion/argent.git
synced 2026-09-14 19:27:14 +08:00
Hubert Gancarczyk
bb97035f30
Two fixes to the settle-cap guards this PR added.
The "<= 3s" invariant classified open-url as an in-app-transition tool, but
open-url launches an app (deep link / custom scheme) or the browser (web URL
fallback) -- a real cold start that can legitimately exceed 3s. That is the
same reason launch-app/restart-app are exempt, so rename the exempt set to
APP_LAUNCH_TOOLS and include open-url. Otherwise a future, legitimate raise of
open-url's cap for a slow deep-link launch would trip a guard aimed at in-app
dead wait, not at launch headroom. No current value changes (open-url is 2000).
The run-sequence pin also asserted getAutoScreenshotDelayMs("run-sequence") ===
3000 on top of the map-constant assertion. That accessor assertion is redundant
-- the self-referential "returns configured delay" loop test already covers the
accessor for every tool -- and was the only new assertion coupled to the
ARGENT_AUTO_SCREENSHOT_DELAY_MS floor, so it failed when that var was set above
3000. Drop it; keep the env-immune map-constant pin.