mirror of
https://github.com/software-mansion/argent.git
synced 2026-09-14 19:27:14 +08:00
5d76ed4d66
Fresh, from-current-main take on the artifact-kind idea from #398 / #466. Knowing what an artifact *represents* (not just its MIME type) is what a UI needs to group and name artifacts (e.g. in EAS); this PR delivers exactly that — the tagged handle — without the declared-output-map machinery. ## Summary - Adds a closed `ArtifactKind` union to the artifact wire contract; `kind` is carried on `ArtifactHandle`, `ArtifactEntry`, and the `/artifacts` inventory items. - `ArtifactStore.register` now takes a single `{ hostPath, kind, ... }` options object, so the compiler forces every producer — current and future — to declare what it is emitting. - Tags **all** producers on main today, including the ones #398/#466 predate: screenshot (all four capture paths), screenshot-diff, **flow snapshot baselines/diffs** (`screenshot` / `screenshot-diff-context`), **screen recordings** (new `screen-recording` kind), and the native/React profiler exports and reports. - Types the native-profiler export keys at their source (`IosExportKey` from the `EXPORTS` table, `AndroidExportKey`) and maps them through a kind table that is **total over both unions** — a newly added export key fails to compile until classified, replacing the previous stringly-keyed loop (and the `?? "native-profile-trace"` silent-default this design would otherwise need). - Client-side (`@argent/tools-client`), the mirrored handle type keeps `kind` **optional and widened** (`ArtifactKind | (string & {})`): an older, already-running tool-server sends no kind, and a newer server may send kinds this client build predates. Consumers treat it as advisory metadata; unknown kinds are opaque, never an error. ## Differences from #398 / #466 (deliberate) - No `@argent/artifacts` package, no third `ToolDefinition` generic, no per-tool output-name registrar, no runtime throw for “undeclared output” — the kind is plain data at the registration call site, checked at compile time where it can be, and a wrong label can never fail a tool at runtime. If a pre-invocation `artifacts` declaration in tool-listing metadata is ever needed (an actual EAS consumer), it can be layered on later without changing this wire contract. - The two `ArtifactKind` definitions (registry / tools-client) stay deliberately separate — same as the existing `ARTIFACT_MARKER` must-match convention — because the client-side type is intentionally *looser* (optional + open) than the server-side one for version skew. - Extending the union stays backward-compatible on the wire. ## 2026-08-24 update Merged current main (0.22.0) into the branch. The flow-visual rewrite that landed since (cropOn crops, per-app snapshot-key dedupe, diff scratch-dir hygiene) is preserved verbatim; its five registration sites now carry kinds (`screenshot` for baseline/current, `screenshot-diff-context` for the annotated diff — the cropped `current` included). No producer added since the PR was opened needed a new kind: `paste`, `shake`, and the other new tools emit no file artifacts, and every register call site in the tree now goes through the typed options object. No docs update is needed: the docs site (added since this PR) does not document the artifact handle wire contract; `kind` is advisory wire metadata with no user-facing surface. ## Validation At the merge with main (0.22.0), 2026-08-24: - `npm run build` (full `tsc --build`) — clean - `npm run typecheck:tests` in registry, tools-client, tool-server, mcp, cli — clean - Full suites green: registry 90, tools-client 191, tool-server 4495 (+1 skipped), mcp 80, cli 472 - `prettier --check .`, `eslint . --max-warnings 0`, and the knip gate — all pass 🤖 Generated with [Claude Code](https://claude.com/claude-code)
53 lines
1.8 KiB
TypeScript
53 lines
1.8 KiB
TypeScript
import { afterEach, describe, expect, it, vi } from "vitest";
|
|
import { ArtifactStore } from "@argent/registry";
|
|
import { createScreenshotTool } from "../src/tools/screenshot";
|
|
|
|
describe("screenshot tool", () => {
|
|
afterEach(() => {
|
|
vi.unstubAllGlobals();
|
|
});
|
|
|
|
it("returns an image artifact handle; includeImageInContext is an input-only flag handled by the MCP adapter", async () => {
|
|
vi.stubGlobal(
|
|
"fetch",
|
|
vi.fn().mockResolvedValue({
|
|
ok: true,
|
|
status: 200,
|
|
json: async () => ({
|
|
url: "http://localhost/screenshot.png",
|
|
path: "/tmp/screenshot.png",
|
|
}),
|
|
})
|
|
);
|
|
|
|
// The tool resolves its backend lazily via the registry rather than taking
|
|
// an eagerly-declared service, so a tvOS udid can branch away from the
|
|
// simulator-server it can't drive. A non-iOS-shaped udid ("ABC") skips the
|
|
// tvOS runtime probe and goes straight to simulator-server.
|
|
const registry = {
|
|
resolveService: vi.fn().mockResolvedValue({ apiUrl: "http://localhost:4949" }),
|
|
} as unknown as import("@argent/registry").Registry;
|
|
const screenshotTool = createScreenshotTool(registry);
|
|
|
|
const params = {
|
|
udid: "ABC",
|
|
includeImageInContext: false,
|
|
};
|
|
screenshotTool.zodSchema!.parse(params);
|
|
|
|
const result = await screenshotTool.execute({}, params, { artifacts: new ArtifactStore() });
|
|
|
|
// The PNG is returned as an artifact handle the MCP client materializes —
|
|
// the unreachable `127.0.0.1` media URL is no longer surfaced.
|
|
expect(result.image).toMatchObject({
|
|
__argentArtifact: true,
|
|
kind: "screenshot",
|
|
filename: "screenshot.png",
|
|
mimeType: "image/png",
|
|
hostPath: "/tmp/screenshot.png",
|
|
});
|
|
expect(result).not.toHaveProperty("includeImageInContext");
|
|
expect(result).not.toHaveProperty("url");
|
|
});
|
|
});
|