Files
software-mansion__argent/packages/tool-server/test/native-devtools-env.test.ts
filip131311 c990e98839 fix: use launchctl getenv to avoid simctl 127-byte truncation of DYLD_INSERT_LIBRARIES (#127)
`xcrun simctl getenv` silently truncates return values at 127 bytes.
The code was reading with `simctl getenv` but writing with
`simctl spawn ... launchctl setenv`, causing each ensureEnv() cycle to
read a truncated value, fail to recognize the truncated argent path
fragments, preserve them, and append a fresh bootstrap — corrupting
the variable and clobbering third-party dylibs like SimCam.

Fix:
- Read via `simctl spawn <udid> launchctl getenv` (same store, no limit)
- Restore fs.existsSync guard to strip truncated/stale entries while
  keeping third-party dylibs that exist on disk (e.g. SimCam)
- Bump mcp version to 0.4.4
2026-04-16 00:16:10 +02:00

91 lines
3.5 KiB
TypeScript

import * as fs from "node:fs";
import * as os from "node:os";
import * as path from "node:path";
import { afterEach, describe, expect, it } from "vitest";
import { buildDyldInsertLibraries } from "../src/blueprints/native-devtools";
describe("buildDyldInsertLibraries", () => {
const tempDirs: string[] = [];
afterEach(() => {
for (const dir of tempDirs.splice(0)) {
fs.rmSync(dir, { recursive: true, force: true });
}
});
function makeTempFile(name: string): string {
const dir = fs.mkdtempSync(path.join(os.tmpdir(), "native-devtools-env-"));
tempDirs.push(dir);
const filePath = path.join(dir, name);
fs.writeFileSync(filePath, "");
return filePath;
}
it("strips stale bootstrap entries and non-existent paths, keeps files present on disk", () => {
const currentBootstrap = makeTempFile("libArgentInjectionBootstrap.dylib");
const unrelated = makeTempFile("libOtherInspector.dylib");
const staleBootstrap = "/tmp/old/location/libArgentInjectionBootstrap.dylib";
const truncatedEntry = "/Users/filip/.nvm/versi";
const result = buildDyldInsertLibraries(
[staleBootstrap, truncatedEntry, unrelated].join(":"),
currentBootstrap
);
// staleBootstrap stripped (argent basename); truncatedEntry stripped (not on disk)
expect(result).toBe([unrelated, currentBootstrap].join(":"));
});
it("preserves valid non-bootstrap loader entries while deduplicating the active bootstrap", () => {
const currentBootstrap = makeTempFile("libArgentInjectionBootstrap.dylib");
const unrelated = makeTempFile("libCustomTracing.dylib");
const result = buildDyldInsertLibraries(
[currentBootstrap, "@loader_path/Other.dylib", unrelated].join(":"),
currentBootstrap
);
expect(result).toBe(["@loader_path/Other.dylib", unrelated, currentBootstrap].join(":"));
});
it("strips legacy libInjectionBootstrap.dylib paths when merging with the renamed bootstrap", () => {
const currentBootstrap = makeTempFile("libArgentInjectionBootstrap.dylib");
const legacyBootstrap = "/tmp/old/libInjectionBootstrap.dylib";
const thirdParty = makeTempFile("libSimCamLoader.dylib");
const result = buildDyldInsertLibraries(
[legacyBootstrap, thirdParty].join(":"),
currentBootstrap
);
expect(result).toBe([thirdParty, currentBootstrap].join(":"));
});
it("is idempotent when called with its own output", () => {
const currentBootstrap = makeTempFile("libArgentInjectionBootstrap.dylib");
const thirdParty = makeTempFile("libSimCamLoader.dylib");
const first = buildDyldInsertLibraries(thirdParty, currentBootstrap);
const second = buildDyldInsertLibraries(first, currentBootstrap);
expect(second).toBe(first);
});
it("cleans up truncated entries from simctl getenv 127-byte corruption", () => {
const currentBootstrap = makeTempFile("libArgentInjectionBootstrap.dylib");
const thirdParty = makeTempFile("libSimCamLoader.dylib");
// Simulate the truncated entries that accumulate from the simctl getenv bug
const truncated1 = "/Users/mdk/.nvm/versions/node/v24.5.0/lib/nod";
const truncated2 =
"/Users/mdk/.nvm/versions/node/v24.5.0/lib/node_modules/@swmansion/argent/dylibs/l";
const result = buildDyldInsertLibraries(
[truncated1, truncated2, currentBootstrap, thirdParty].join(":"),
currentBootstrap
);
// Both truncated entries stripped (not on disk), bootstrap deduped, thirdParty preserved
expect(result).toBe([thirdParty, currentBootstrap].join(":"));
});
});