mirror of
https://github.com/software-mansion/argent.git
synced 2026-09-14 19:27:14 +08:00
Filip131311
084ad14719
On Linux the missing-adb error told the user to run `brew install --cask android-platform-tools`. These messages are handed to an agent as remediation and it runs what they say, so an unlabelled command reads as the instruction on a machine that has no Homebrew — a wasted turn at best, and Windows had the same problem silently. Each hint now leads with a route that works anywhere — the SDK Manager, or the standalone download — and any package-manager command says which platform it is for. The brew cask stays, labelled: for the tools `adb` actually gates (a USB phone, an already-running emulator) it is still a complete one-command fix on macOS, so removing it would have traded one platform's wrong advice for another's missing advice. `sdkmanager` is qualified too, since it ships inside the SDK command-line tools and is not available to the reader who has no SDK at all. The ffmpeg hint had the same defect and gets the same treatment. It also warns that the build needs libx264: Fedora's default `ffmpeg-free` package omits it, and the encoder is hardcoded, so that install would fail later with a message about an exit code rather than a missing codec. The `xcrun` hint now leads with the requirement a reader on another platform cannot satisfy — a device id is classified by its shape, so an iOS tool can be reached from a Linux host, where "run xcode-select" was the first thing it said. Following the adb hint via `sdkmanager` left the tool still failing, because the SDK root the Homebrew command-line-tools cask uses was not among the probed locations. Added, so the remediation actually unblocks. Fixes #641