mirror of
https://github.com/software-mansion/argent.git
synced 2026-09-14 19:27:14 +08:00
Ignacy Łątka
261e836bdf
Comment/doc accuracy fixes from review; no behaviour change. - reaped-sessions.ts: an unscoped stop-all reaps every device-owned service, a scoped one only the named devices'; the services holding captured output are four, not three (ChromiumJsRuntimeDebugger reuses the js-runtime-debugger kind); and `react-profiler-start`'s breadcrumb comes from disposing a stale debugger during takeover, not from `force` (which only stops the in-app profiler and disposes nothing). - DISPOSE_SERVER_STOP_MS bounds how long dispose WAITS on the salvage stop, not how long the stop runs — the request keeps its own 60s abort. - capture.ts host-stop: the real contrast is the server path (which recovers on a finalize timeout), not a non-existent "device-side capture". - failure-codes.ts: iOS/Android now share two capture paths, not "frames into ffmpeg". - docs feature page: ffmpeg is needed only on the host-encoding build and the failure names it — matching the tool description, not "install before the first recording". - SKILL.md: the host fallback encodes during capture and closes the container at stop (not "finalizes during capture"); adds how to read a failed stop (retry a timeout/hand-over failure, retry a copy-out failure promptly, start fresh otherwise). - Tool description / SKILL: name ffmpeg as a requirement the failure surfaces rather than commanding the agent to install it.