mirror of
https://github.com/software-mansion/argent.git
synced 2026-09-14 19:27:14 +08:00
filip131311
f288a461b0
## Summary The Electron support added in #247 is **generic Chromium/CDP under the hood**. The discovery layer probes the Chromium-default CDP port (`9222`) and any `ARGENT_*_PORTS` entries; the connection picks the first non-devtools page target; describe is a plain in-page DOM walker; input/screenshot/screencast/navigation/JS-debugger are all straight CDP. Nothing in that path is Electron-specific — the only Electron-specific piece is the *launcher* (`boot-electron.ts`, which resolves and spawns an Electron binary). So any Chromium-family runtime exposing a CDP endpoint — an Electron app, **or** Chrome/Brave/Edge/WebView2 launched with `--remote-debugging-port` — is discoverable and drivable through the same tool surface. This PR renames the platform discriminator (and everything keyed off it) from `electron` to `chromium` so the naming matches reality. ## What changed **Public/contract surface (clean hard rename, no back-compat aliases):** - Platform discriminator `"electron"` → `"chromium"`; device id `electron-cdp-<port>` → `chromium-cdp-<port>`. - `ToolCapability.electron` → `.chromium`; the capability-gate rejection now reads `Tool 'X' is not supported on chromium app`. - Env `ARGENT_ELECTRON_PORTS`(`_FILE`) → `ARGENT_CHROMIUM_PORTS`(`_FILE`); ports cache `~/.argent/electron-cdp-ports.json` → `chromium-cdp-ports.json`; HTTP surface `/electron-server/` → `/chromium-server/`. **Files / dirs / symbols:** - `src/electron-server/` → `src/chromium-server/`; blueprints `electron-cdp` / `electron-js-runtime-debugger` → `chromium-*`; `describe`/`open-url`/`launch-app` `platforms/electron.ts` → `chromium.ts`; `keyboard/electron-keys` → `chromium-keys`; `utils/electron-discovery` → `chromium-discovery`. - `ElectronServer`/`ElectronCdpApi`/`ElectronJsRuntimeDebugger`/`describeElectron`/`discoverElectronDevices`/`ELECTRON_ID_PREFIX`/… → `Chromium*` / `CHROMIUM_*`. Tests renamed to match. **Stays "electron" (the Electron-specific launcher):** - `boot-device` keeps the `electronAppPath` / `electronPort` / `electronArgs` inputs, and `boot-electron.ts` still resolves & spawns an Electron binary. It just yields a `chromium` device now (an Electron app *is* a Chromium/CDP runtime). **Skills:** `argent-device-interact`, `argent-metro-debugger`, `rules/argent.md`, and the RN-workflow reference were reframed to describe **Chromium (CDP)** availability — Electron apps *plus* any Chromium browser over CDP (auto-discovered on `9222` / `ARGENT_CHROMIUM_PORTS`) — instead of Electron only. ## Test plan - [x] `tsc --build` clean - [x] `typecheck:tests` clean - [x] **1116 vitest cases pass (126 files)** - [x] prettier clean on all changed/renamed files - [x] Full-repo sweep: every remaining "electron" mention is intentional (the launcher path + skill prose explaining Electron as one kind of Chromium/CDP app); `electronic` in LICENSE/COC untouched.
47 lines
1.4 KiB
TypeScript
47 lines
1.4 KiB
TypeScript
import { describe, it, expect } from "vitest";
|
|
import { formatDescribeTree } from "../src/tools/describe/format-tree";
|
|
import type { DescribeNode } from "../src/tools/describe/contract";
|
|
|
|
const tree: DescribeNode = {
|
|
role: "html",
|
|
frame: { x: 0, y: 0, width: 1, height: 1 },
|
|
children: [
|
|
{
|
|
role: "body",
|
|
frame: { x: 0, y: 0, width: 1, height: 1 },
|
|
children: [
|
|
{
|
|
role: "h1",
|
|
frame: { x: 0, y: 0, width: 1, height: 0.1 },
|
|
children: [],
|
|
value: "Hello World",
|
|
identifier: "title",
|
|
},
|
|
{
|
|
role: "button",
|
|
frame: { x: 0, y: 0.2, width: 0.2, height: 0.05 },
|
|
children: [],
|
|
label: "Click me",
|
|
identifier: "go",
|
|
clickable: true,
|
|
},
|
|
],
|
|
},
|
|
],
|
|
};
|
|
|
|
describe("formatDescribeTree (cdp-dom)", () => {
|
|
it("renders nested mode and shows descendants beyond depth 1", () => {
|
|
const out = formatDescribeTree(tree, { source: "cdp-dom" });
|
|
expect(out).toContain("Mode: nested");
|
|
// Body, h1, and button must all appear — flat mode would only emit body.
|
|
expect(out).toContain("body");
|
|
expect(out).toContain("h1");
|
|
expect(out).toContain('"Click me"');
|
|
expect(out).toContain('id="go"');
|
|
expect(out).toContain("clickable");
|
|
// The h1 has value "Hello World" — must surface in the rendering.
|
|
expect(out).toContain("Hello World");
|
|
});
|
|
});
|