Files
software-mansion__argent/packages/tool-server/test/external-native-devtools.test.ts
Mateusz Aliyev 6e9e45c9f0 feat: attach to devices offered by external providers (#735)
This pull request lets Argent drive a simulator or emulator another
process is already running, attaching to its simulator-server rather
than spawning a second one.

A provider writes a JSON descriptor to `~/.argent/providers/` listing
the devices it offers and the mechanisms Argent may use on each. They
appear in `list-devices` with an `ext:` id and work with the existing
tools. The file is re-read on every call, so a withdrawal or a narrowed
grant applies immediately.

`ios.additionalDeviceSets` (#600) already makes such a simulator
reachable by UDID. What changes is ownership. `boot-device` and
`stop-simulator-server` refuse these devices, anything the provider did
not grant is refused with a message naming it and Argent uses only the
endpoints its own simulator-server build serves. A grant binds to the
device rather than to one of its names, so the real udid or serial is
gated exactly like the `ext:` id. Android emulators are covered too and
a device visible to both a provider and `adb`/`simctl` is listed once.

The contract ships as `schemas/device-provider-v1.json`, validated by
`argent providers check`, and is documented in
`docs/reference/device-providers.mdx`. Includes unit tests and an e2e
phase where the harness acts as its own provider.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **New Features**
* Added support for discovering and connecting to externally managed
devices.
* Added `argent providers` commands for listing, validating, publishing,
withdrawing, and pruning providers.
* Added provider-aware simulator, debugger, profiler, native tools, and
device listings.
* Added capability controls, endpoint validation, revocation handling,
and provider-specific diagnostics.
  * Added automatic CLI discovery for provider integrations.
* **Bug Fixes**
  * Improved service recovery and paused-runtime error reporting.
  * Improved simulator keyboard and paste command reliability.
* **Documentation**
* Documented provider descriptors, capabilities, lifecycle rules, and
CLI usage.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2026-09-04 22:02:57 +02:00

340 lines
11 KiB
TypeScript

import * as fs from "node:fs";
import * as net from "node:net";
import * as os from "node:os";
import * as path from "node:path";
import * as readline from "node:readline";
import { afterEach, beforeEach, describe, expect, it } from "vitest";
import { nativeDevtoolsBlueprint } from "../src/blueprints/native-devtools";
import { __primeDepCacheForTests, __resetDepCacheForTests } from "../src/utils/check-deps";
import { resolveDevice } from "../src/utils/device-info";
import {
__resetExternalDeviceCacheForTesting,
__resetProviderWarningsForTesting,
makeExternalId,
} from "../src/utils/external-devices";
/**
* `DYLD_INSERT_LIBRARIES` and the agent's endpoint are simulator-wide launchd
* values, so two products arming their own injection overwrite each other, and
* two builds of the same agent in one process would duplicate its classes and
* swizzles.
*
* A provider that already injects lends us its agent connection instead. These
* assert that we attach to what it published, drive the app through it and
* arm nothing of our own.
*/
const BUNDLE_ID = "com.example.app";
const IOS_UDID = "1A2B3C4D-5E6F-7081-92A3-B4C5D6E7F809";
const PROVIDER_ID = "acme-3f2a9c";
const DEVICE_ID = makeExternalId(PROVIDER_ID, IOS_UDID);
let temporaryDirectory: string;
/**
* Stands in for the provider: serves the agent's side of the wire, opening
* with the `Control` frame that names the app it is lending.
*/
type LentAgent = {
close: () => Promise<void>;
hangUp: () => void;
received: Array<{ type: string; payload: Record<string, unknown> }>;
socketPath: string;
};
async function startLentAgent(): Promise<LentAgent> {
const socketPath = path.join(temporaryDirectory, "agent.sock");
const received: LentAgent["received"] = [];
const sockets: net.Socket[] = [];
const server = net.createServer((socket) => {
sockets.push(socket);
socket.write(JSON.stringify({ payload: { bundleId: BUNDLE_ID }, type: "Control" }) + "\n");
readline.createInterface({ input: socket }).on("line", (raw) => {
const message = JSON.parse(raw);
received.push(message);
/** Answer `ViewInspector` RPCs the way the agent in the app would. */
if (message.type === "ViewInspector") {
socket.write(
JSON.stringify({
payload: { id: message.payload.id, result: { role: "AXWindow" } },
type: "ViewInspector",
}) + "\n"
);
}
});
});
await new Promise<void>((resolve) => server.listen(socketPath, resolve));
return {
close: () => new Promise<void>((resolve) => server.close(() => resolve())),
/** What a provider does when the app it was lending goes away. */
hangUp: () => {
for (const socket of sockets.splice(0)) socket.destroy();
},
received,
socketPath,
};
}
function publishDescriptor(options: { socketPath?: string } = {}): void {
const descriptorPath = path.join(temporaryDirectory, "acme.json");
fs.writeFileSync(
descriptorPath,
JSON.stringify({
devices: [
{
capabilities: ["native-devtools", "simctl"],
kind: "simulator",
name: "iPhone 16 Pro",
...(options.socketPath ? { nativeDevtools: { socketPath: options.socketPath } } : {}),
nativeId: IOS_UDID,
platform: "ios",
state: "Booted",
},
],
id: PROVIDER_ID,
name: "Acme IDE",
schemaVersion: 1,
})
);
process.env.ARGENT_DEVICE_PROVIDERS = descriptorPath;
}
function instantiate(deviceId = DEVICE_ID) {
const device = resolveDevice(deviceId);
return nativeDevtoolsBlueprint.factory({}, device, { device });
}
/** The handshake lands a tick after connect. Wait for the app to show up. */
async function waitForConnectedBundle(api: {
listConnectedBundleIds: () => string[];
}): Promise<void> {
for (let attempt = 0; attempt < 50; attempt++) {
if (api.listConnectedBundleIds().length > 0) return;
await new Promise((resolve) => setTimeout(resolve, 10));
}
/**
* Without this the tests that assert an absence (no injection armed, no
* termination) would pass on an attach that never happened.
*/
throw new Error("the lent agent never reported a connected bundle");
}
beforeEach(() => {
temporaryDirectory = fs.mkdtempSync(path.join(os.tmpdir(), "argent-native-devtools-"));
delete process.env.ARGENT_DISABLE_DEVICE_PROVIDERS;
__resetExternalDeviceCacheForTesting();
__resetProviderWarningsForTesting();
/**
* The tools check for `xcrun` first and Linux CI has none. Nothing runs it.
*/
__primeDepCacheForTests(["xcrun"]);
});
afterEach(() => {
delete process.env.ARGENT_DEVICE_PROVIDERS;
__resetDepCacheForTests();
fs.rmSync(temporaryDirectory, { force: true, recursive: true });
});
describe("a provider that lends its native-devtools agent", () => {
it("attaches to the published socket and adopts the app it is serving", async () => {
const agent = await startLentAgent();
publishDescriptor({ socketPath: agent.socketPath });
const instance = await instantiate();
await waitForConnectedBundle(instance.api);
expect(instance.api.listConnectedBundleIds()).toEqual([BUNDLE_ID]);
expect(instance.api.isConnected(BUNDLE_ID)).toBe(true);
expect(instance.api.socketPath).toBe(agent.socketPath);
await instance.dispose();
await agent.close();
});
it("queries the view hierarchy over the lent connection", async () => {
const agent = await startLentAgent();
publishDescriptor({ socketPath: agent.socketPath });
const instance = await instantiate();
await waitForConnectedBundle(instance.api);
await expect(
instance.api.queryViewHierarchy(BUNDLE_ID, "ViewHierarchy.describeScreen")
).resolves.toEqual({ role: "AXWindow" });
expect(agent.received).toContainEqual(
expect.objectContaining({
payload: expect.objectContaining({ method: "ViewHierarchy.describeScreen" }),
type: "ViewInspector",
})
);
await instance.dispose();
await agent.close();
});
/**
* The provider armed the injection, so there is nothing of ours to set up
* and no reason to make the agent restart somebody else's app.
*/
it("arms no injection of its own and never asks for a restart", async () => {
const agent = await startLentAgent();
publishDescriptor({ socketPath: agent.socketPath });
const instance = await instantiate();
await waitForConnectedBundle(instance.api);
expect(instance.api.isEnvSetup()).toBe(true);
expect(instance.api.getInitFailure()).toBeNull();
await expect(instance.api.appConnectionState("com.example.other")).resolves.toBe(
"provider_attached"
);
await instance.dispose();
await agent.close();
});
/** Hanging up must not disturb what the provider is running. */
it("leaves the provider's socket in place when disposed", async () => {
const agent = await startLentAgent();
publishDescriptor({ socketPath: agent.socketPath });
const instance = await instantiate();
await waitForConnectedBundle(instance.api);
await instance.dispose();
expect(fs.existsSync(agent.socketPath)).toBe(true);
await agent.close();
});
/**
* `{count: 0}` reads as "the screen made no requests", which is a different
* thing from "nothing is capturing them".
*/
it("says the app is not connected rather than reporting an empty network log", async () => {
const agent = await startLentAgent();
publishDescriptor({ socketPath: agent.socketPath });
const instance = await instantiate();
await waitForConnectedBundle(instance.api);
const { nativeNetworkLogsTool } =
await import("../src/tools/native-devtools/native-network-logs");
await expect(
nativeNetworkLogsTool.execute(
{ nativeDevtools: instance.api },
{ bundleId: "com.example.gone", clear: false, limit: 50, udid: DEVICE_ID }
)
).rejects.toThrow(/not connected/);
await instance.dispose();
await agent.close();
});
/**
* We are the client on this path, so nothing re-dials on its own. Without a
* terminated signal the registry would keep serving this instance and its
* dead socket for the rest of the session, and an app relaunch would never
* come back.
*/
it("terminates when the provider hangs up, so the next call re-attaches", async () => {
const agent = await startLentAgent();
publishDescriptor({ socketPath: agent.socketPath });
const instance = await instantiate();
await waitForConnectedBundle(instance.api);
const terminated = new Promise<void>((resolve) =>
instance.events.on("terminated", () => resolve())
);
agent.hangUp();
await terminated;
/** A fresh resolve attaches again and re-adopts the app on offer. */
const reattached = await instantiate();
await waitForConnectedBundle(reattached.api);
expect(reattached.api.listConnectedBundleIds()).toEqual([BUNDLE_ID]);
await reattached.dispose();
await instance.dispose();
await agent.close();
});
/** Our own hang-up is not the provider dropping us. */
it("does not terminate when we are the one disposing", async () => {
const agent = await startLentAgent();
publishDescriptor({ socketPath: agent.socketPath });
const instance = await instantiate();
await waitForConnectedBundle(instance.api);
let terminated = false;
instance.events.on("terminated", () => {
terminated = true;
});
await instance.dispose();
await new Promise((resolve) => setTimeout(resolve, 50));
expect(terminated).toBe(false);
await agent.close();
});
it("refuses to inject when the provider granted the mechanism but lent no socket", async () => {
publishDescriptor();
await expect(instantiate()).rejects.toThrow(/published none/);
});
it("says so when the socket it published is not listening", async () => {
publishDescriptor({ socketPath: path.join(temporaryDirectory, "absent.sock") });
await expect(instantiate()).rejects.toThrow(/could not attach/);
});
/**
* The simulator watcher polls `simctl` and resolves this blueprint by raw
* UDID, with no tool call and no `ext:` id anywhere. A lookup keyed on the
* `ext:` spelling leaves `lentSocketPath` undefined there and the factory
* falls through to arming argent's own injection, overwriting the one the
* provider already has in the app, which is the exact clobber the lent-agent
* path exists to avoid.
*/
describe("addressed by the raw udid, as the simulator watcher does", () => {
it("attaches to the published socket", async () => {
const agent = await startLentAgent();
publishDescriptor({ socketPath: agent.socketPath });
const instance = await instantiate(IOS_UDID);
await waitForConnectedBundle(instance.api);
expect(instance.api.socketPath).toBe(agent.socketPath);
expect(instance.api.isEnvSetup()).toBe(true);
expect(instance.api.listConnectedBundleIds()).toEqual([BUNDLE_ID]);
await instance.dispose();
await agent.close();
});
it("refuses to inject when the provider lent no socket", async () => {
publishDescriptor();
await expect(instantiate(IOS_UDID)).rejects.toThrow(/published none/);
});
});
});