Files
software-mansion__argent/packages/tool-server/test/profiler-leak-stacks.test.ts
Ignacy Łątka a5c6730d05 feat(ios-profiler): attributable memory leaks via malloc_stack_logging (#351)
## What

Opt-in `malloc_stack_logging` flag on `native-profiler-start` that makes
iOS memory leaks **attributable** — they come back with a real
responsible frame + library instead of `<Call stack limit reached>`.

## Why

`native-profiler-start` attaches to the already-running app. iOS records
malloc allocation backtraces only when `MallocStackLogging` is set **at
process launch**, so an attached app has none: Instruments' Leaks
scanner finds the leaked blocks but can't attribute them and emits the
placeholder `<Call stack limit reached>` (that string is Instruments',
not ours).

## How

When `malloc_stack_logging: true`, the profiler cold-launches the app
**under** xctrace instead of attaching:

```
xctrace record --template <Argent.tracetemplate> --device <udid> \
  --env MallocStackLogging=1 --output <…> --no-prompt \
  --launch -- <App.app>
```

- `.app` path resolved via `simctl get_app_container`; the running
instance is terminated first for a clean cold start.
- The existing Leaks export / parser / render path is reused
**unchanged** — no parser changes.
- Default behaviour is untouched: attach to the running app (no
relaunch, no overhead). The flag is opt-in because it restarts the app
(loses state) and adds allocator overhead — for leak-attribution passes,
not CPU/hang work.
- The report relabels unattributable leaks with a hint to re-run with
`malloc_stack_logging: true`, instead of surfacing the raw placeholder.

## Evidence (real iPhone 16 sim, same scroll workload)

Before (attach) — every leak row:
```
responsible-frame="<Call stack limit reached>" responsible-library=""
```
After (`--env MallocStackLogging=1 --launch`) — same Leaks export:

| leaked-object | responsible-frame | library |
|---|---|---|
| Malloc 1008 B ×3 | `itanium_demangle::OutputBuffer::grow(...)` |
libc++abi |
| Malloc 48 B ×1 | `hermes::vm::JSTypedArrayBase::createBuffer(...)` |
hermes |

## Tests

- `test/ios-instruments/malloc-stack-logging.test.ts` — the malloc
launch argv (`--env MallocStackLogging=1`, `--launch -- <app>` last,
with and without `--notify-tracing-started`, `--no-prompt`) vs default
`--attach`; terminate-first / get_app_container ordering; failed-start
behavior; per-test `ARGENT_IOS_CAPTURE` scrubbing.
- `test/ios-instruments/leak-attribution-render.test.ts` —
unattributable vs attributed leak rendering, capture-mode-aware hints.
- `test/ios-instruments/load-freshness.test.ts` — per-capture residue
clearing on `profiler-load`, live/recovery-pending load refusals.
- `test/ios-instruments/stop-recovery.test.ts` — capture-mode pairing at
stop (clean and recovery paths).
- `test/profiler-combined-leaks.test.ts`,
`test/profiler-leak-stacks.test.ts`, `test/ios-leak-pipeline.test.ts` —
shared caveat line, evidence-first hints, attribution-normalized
grouping.
- Full `test/ios-instruments/` suite green (9 files / 70 tests); full
tool-server suite green; `tsc --noEmit` + `tsc -p tsconfig.test.json`
clean.

## Notes

E2E'd live twice during review (real iPhone 16 Pro / iPhone 17 Pro sims
on Xcode 26.6): guard refusals fire before the app is touched, the
`--device` cold launch's deadlock on degraded Xcode is confirmed (so the
guard is warranted), and the malloc argv/terminate/relaunch behavior
checked out on-device. Docs updated: `IOS_PROFILER_REFERENCE.md` and the
`argent-native-profiler` skill.

## Review follow-ups (post-approval hardening)

Later commits address the remaining review threads and several
subsequent multi-lens review passes:

- **Capture-mode is a real signal, end to end.** The session records the
mode of the in-flight recording at start
(`recordingMallocStackLogging`), pairs it with `exportedFiles` at stop
(`mallocStackLogging`), and freezes it into `parsedData` at analyze/load
— so the analyze report, the combined report, and the `leak_stacks`
drill-down all name the capture mode of the data they actually render
instead of inferring it (or mislabeling it after a newer capture
starts). One shared `renderUnattributedLeaksNote()` keeps the wording
identical across reports, and attribution evidence outranks the flag: a
resolved frame proves the target ran under malloc stack logging however
it was launched.
- **`profiler-load` restores a clean slate.** Loading clears all
per-capture residue (capture mode, `cpuFilterPid`, `wallClockStartMs`,
`traceFile`) so a loaded trace is never analyzed with a previous live
capture's PID filter, freshness anchor, or report path — and refuses to
load while a recording is in flight or a crashed capture awaits
`native-profiler-stop`'s partial-trace recovery, which the load would
otherwise orphan.
- **Failed starts are non-destructive.** Per-capture descriptors — and
the recovery flags that gate `native-profiler-stop`'s partial-trace
export — are stamped/reset only on a successful start, so a failed
attempt leaves the previous capture's still-loaded exports fully
described and a pending abnormal-end recovery intact.
- **Guards keep session state coherent.** `profiler-load`,
`native-profiler-analyze`, and `profiler-combined-report` all refuse
while a recording is in flight or a crashed capture awaits recovery, via
one shared `isCaptureInFlight`/`inFlightGuardMessage` helper whose
message distinguishes recording vs 10-min-cap timeout vs unexpected exit
(so the stated cause matches what `native-profiler-stop` reports next).
Proceeding would otherwise wedge the session (load) or render one
capture's frozen data under another's live fields (analyze/combined).
- **The combined report anchors on a frozen clock.** The recording's
start time is frozen into `parsedData` at analyze, and the iOS combined
report anchors its hangs to that frozen value rather than the live
session field — so a capture started after analyze can never shift a
real hang↔commit correlation into "unmatched". Android keeps its live
anchor (it re-derives hangs from the live trace). The combined-report
guard's recovery advice routes through `native-profiler-analyze`, the
only step that rebuilds `parsedData`.
- **Leak grouping is attribution-normalized.** `aggregateLeaks` keys on
`(objectType, frame-normalized-the-way-isLeakAttributed-matches)`, so
mixed unattributed spellings (`Unknown`, the sentinel, whitespace
variants) can't split one group per type.
- **The malloc launch target is unambiguous.** Since the cold launch
terminates the resolved app, `app_process` resolution prefers an exact
`CFBundleExecutable` match and, when builds still tie (dev + prod
sharing an executable/display name), refuses and points at the
globally-unique `CFBundleIdentifier` — which it also accepts as an
`app_process` — instead of killing whichever app the plist enumerates
first.
- **Report tables escape `|`.** Demangled C++ frames (`operator|`
included) are real headline content under malloc mode; every free-form
cell across the leak, CPU-hotspot, function caller/callee, and
thread-breakdown tables — symbol *and* thread/queue-name columns — is
escaped so a stray pipe can't shift the row's columns.
- **Android start is non-destructive too.** `startNativeProfilerAndroid`
now starts perfetto before mutating session state, mirroring iOS, so a
failed start no longer burns a prior capped capture's pending
partial-trace recovery.
2026-07-12 13:42:23 +02:00

153 lines
6.2 KiB
TypeScript

/**
* `leak_stacks` query rendering — attributed-first ordering under the top-N slice.
*
* `aggregateLeaks` hands leaks over attributed-first, but renderLeakStacksIos
* re-sorts before slicing to `top_n`. Under `xctrace --attach` the unattributed
* system noise is both far more numerous and individually larger than a real app
* leak, so a size-only sort + slice would truncate the one attributed leak out of
* the table entirely. These tests pin that the attributed leak always survives.
*/
import { describe, it, expect } from "vitest";
import { renderLeakStacksIos } from "../src/tools/profiler/query/profiler-stack-query";
import type { MemoryLeak } from "../src/utils/profiler-shared/types";
function leak(partial: Partial<MemoryLeak> & Pick<MemoryLeak, "objectType">): MemoryLeak {
const attributed = partial.attributed ?? false;
return {
type: "memory_leak",
platform: "ios",
objectType: partial.objectType,
totalSizeBytes: partial.totalSizeBytes ?? 16,
count: partial.count ?? 1,
responsibleFrame: partial.responsibleFrame ?? "<Call stack limit reached>",
responsibleLibrary: partial.responsibleLibrary ?? "",
attributed,
severity: partial.severity ?? (attributed ? "RED" : "YELLOW"),
};
}
const ATTRIBUTED_SMALL = leak({
objectType: "MyModel",
totalSizeBytes: 128,
count: 1,
responsibleFrame: "-[MyViewController loadData]",
responsibleLibrary: "MyApp",
attributed: true,
severity: "RED",
});
// Bigger-than-the-real-leak unattributed system noise — the kind of rows that
// dominate an `--attach` capture and would otherwise crowd the table.
function noise(i: number): MemoryLeak {
return leak({
objectType: `Malloc ${512 + i} Bytes`,
totalSizeBytes: 100_000 + i,
count: 5,
});
}
describe("renderLeakStacksIos — attributed-first ordering", () => {
it("keeps a small attributed leak in the table even when larger unattributed noise exceeds top_n", () => {
// Attributed leak handed in last (smallest), 20 larger unattributed groups.
const leaks = [...Array.from({ length: 20 }, (_, i) => noise(i)), ATTRIBUTED_SMALL];
const out = renderLeakStacksIos(leaks, undefined, 10);
// The real attributed leak must not be sliced out by larger system noise.
expect(out).toContain("`MyModel`");
expect(out).toContain("-[MyViewController loadData]");
});
it("renders the attributed leak as the first table row", () => {
const leaks = [noise(0), noise(1), ATTRIBUTED_SMALL];
const rows = renderLeakStacksIos(leaks, undefined, 10)
.split("\n")
.filter((l) => l.startsWith("| `"));
expect(rows[0]).toContain("`MyModel`");
});
it("orders by size within the attributed and unattributed groups", () => {
const bigAttributed = leak({
objectType: "BigModel",
totalSizeBytes: 4096,
responsibleFrame: "-[Other thing]",
responsibleLibrary: "MyApp",
attributed: true,
severity: "RED",
});
const leaks = [ATTRIBUTED_SMALL, bigAttributed, noise(0)];
const rows = renderLeakStacksIos(leaks, undefined, 10)
.split("\n")
.filter((l) => l.startsWith("| `"));
// Both attributed leaks come before the noise, larger one first.
expect(rows[0]).toContain("`BigModel`");
expect(rows[1]).toContain("`MyModel`");
expect(rows[2]).toContain("Malloc");
});
});
describe("renderLeakStacksIos — capture-mode-aware unattributed note", () => {
// Same contract as the analyze/combined reports: the "captured under
// `xctrace --attach`" framing is only apt when the capture actually attached.
// A malloc_stack_logging capture (flag threaded from the session) or a
// capture that attributed ANY group (a frame is only ever recorded under
// malloc stack logging) must not blame --attach for the unattributed rest.
it("does not claim --attach for a malloc capture with zero attributed groups", () => {
const out = renderLeakStacksIos([noise(0)], undefined, 10, true);
expect(out).toContain("unattributed");
expect(out).not.toContain("--attach");
expect(out).toContain("malloc stack logging");
});
it("infers malloc mode from attributed groups when the capture mode is unknown", () => {
const out = renderLeakStacksIos([ATTRIBUTED_SMALL, noise(0)], undefined, 10, null);
expect(out).not.toContain("--attach");
});
it("infers from the FULL capture, not the filtered slice", () => {
// The filter matches only unattributed noise, but the capture DID attribute
// MyModel — so malloc logging was on and --attach must not be blamed.
const out = renderLeakStacksIos([ATTRIBUTED_SMALL, noise(0)], "Malloc", 10, null);
expect(out).toContain("unattributed");
expect(out).not.toContain("--attach");
});
it("keeps the --attach note for an attach capture", () => {
const out = renderLeakStacksIos([noise(0)], undefined, 10, false);
expect(out).toContain("xctrace --attach");
});
it("attribution evidence outranks an explicit attach flag", () => {
// The flag says how ARGENT captured; a recorded frame proves the target
// process itself ran under malloc stack logging (e.g. launched with the
// Xcode scheme diagnostic, then attached to). The note must not claim "no
// malloc-stack history" right above a row with a full responsible frame.
const out = renderLeakStacksIos([ATTRIBUTED_SMALL, noise(0)], undefined, 10, false);
expect(out).toContain("unattributed");
expect(out).not.toContain("--attach");
});
it("escapes '|' in table cells so demangled operator frames can't break the row", () => {
const pipeLeak = leak({
objectType: "LeakySpan",
totalSizeBytes: 3072,
count: 3,
responsibleFrame: "folly::operator|(folly::Range<char const*>, folly::Range<char const*>)",
responsibleLibrary: "folly",
attributed: true,
severity: "RED",
});
const out = renderLeakStacksIos([pipeLeak], undefined, 10, true);
const header = out.split("\n").find((l) => l.startsWith("| Object Type"));
const row = out.split("\n").find((l) => l.includes("folly::operator"));
expect(row).toBeDefined();
expect(row).toContain("operator\\|");
const unescapedPipes = (s: string) => s.split(/(?<!\\)\|/).length;
expect(unescapedPipes(row!)).toBe(unescapedPipes(header!));
});
});