mirror of
https://github.com/software-mansion/argent.git
synced 2026-09-14 19:27:14 +08:00
a92c859d07
## What Adds `argent lens` — open Argent Lens bound to a fresh `claude` session. ## Why The Lens preview window and the agent communicate through a shared, process-wide tool-server that carries **no per-agent identity** (only a coarse telemetry header). So when the user requests changes in the window, there's no reliable way to route them to the *specific* agent that opened it. `argent lens` sidesteps the problem by inverting ownership: the human launches Lens, and Lens spawns (and therefore owns) exactly one `claude` terminal. The binding is 1:1 by construction — no identity plumbing required. ## How it works 1. `argent lens` ensures a tool-server and **begins a CLI Lens session**, which opens the preview window up front (no `await_user_selection` needed) and keeps it open across rounds. 2. It spawns a tracked `claude` terminal in the current directory — a TypeScript port of the macOS applet's `osascript` spawn/track mechanism — seeded to propose variants without blocking. 3. A watcher polls `GET /preview/outcome`; on each submitted round it types a one-line feedback summary into that terminal, queuing it to the agent as its next prompt. Requesting changes therefore "talks back" to the bound agent instead of closing the window. macOS only (drives Terminal/iTerm via `osascript`); off-darwin it exits with a clear message. ## Changes - **CLI** `lens-terminal.ts` — `osascript` spawn/track + a new write-into-running-session path (the "outputting" channel; injects input into the running TUI, which a tty write cannot do). - **CLI** `lens.ts` — the command + feedback formatter. - **tool-server** — a `cliSession` flag in the variant store (opens the window, suppresses auto-close on submit); `POST /preview/cli-session` and `GET /preview/outcome` routes. - **UI** — relabels the submit action to "Request changes" while a CLI session is active. Behind the existing `argent-lens` feature flag. ## Verification - Build + typecheck across the workspace; ESLint (`--max-warnings 0`) + Prettier clean. - 34 new unit tests; full `@argent/cli` suite **118 passing**, tool-server variant/preview suites **46 passing**. - **E2E (observed on this machine):** - **tool-server HTTP** — `cli-session` toggles `cliSession` true/false; submitted feedback round-trips through `/preview/outcome`. - **terminal injection** — spawned a window running `cat`, confirmed `writeToSession` lands text in the running program's **stdin** (both iTerm and Terminal), with embedded newlines flattened. - **full relay** — the real `watchAndRelay` loop against a real tool-server typed two distinct submission rounds' feedback into a stand-in agent terminal (dedup on `completedAt` verified). - `argent lens --help` and the feature-flag gate (exit 1 with guidance, no spawn). Note: a real end-to-end with a live `claude` agent was not run (it would drive a paid interactive session); the agent-facing channel is proven by injecting into a stand-in process's stdin via the exact same code path. --------- Co-authored-by: Filip131311 <contact@filipkaminski.com>
91 lines
3.6 KiB
TypeScript
91 lines
3.6 KiB
TypeScript
import { describe, it, expect, vi, beforeEach } from "vitest";
|
|
import express from "express";
|
|
import request from "supertest";
|
|
import type { Registry } from "@argent/registry";
|
|
|
|
// Mock the device shutdown so no real `simctl`/`adb` runs in the suite; the
|
|
// route's own validation + ownership handling is what's under test.
|
|
const shutdownDevice = vi.fn();
|
|
vi.mock("../src/utils/device-shutdown", () => ({
|
|
shutdownDevice: (id: string) => shutdownDevice(id),
|
|
}));
|
|
|
|
// /shutdown is a lens-only route gated behind the argent-lens flag. Mock it ON
|
|
// by default so the suite is deterministic regardless of the machine's real
|
|
// flags.json; one test below flips it OFF to assert the gate.
|
|
vi.mock("@argent/configuration-core", () => ({ isFlagEnabled: vi.fn(() => true) }));
|
|
|
|
import { createPreviewRouter } from "../src/preview";
|
|
import { variantProposalStore } from "../src/utils/variant-proposals";
|
|
import { isFlagEnabled } from "@argent/configuration-core";
|
|
|
|
const mockFlag = vi.mocked(isFlagEnabled);
|
|
|
|
const IOS_UDID = "00000000-0000-0000-0000-000000000000";
|
|
const IOS_UDID_2 = "11111111-1111-1111-1111-111111111111";
|
|
|
|
// Registry answers list-devices with `devices` (used by the known-device guard).
|
|
function harness(devices: unknown[]) {
|
|
const invokeTool = vi.fn(async () => ({ devices }));
|
|
const registry = { invokeTool } as unknown as Registry;
|
|
const app = express();
|
|
app.use(express.json());
|
|
app.use(createPreviewRouter(registry));
|
|
return { app };
|
|
}
|
|
|
|
beforeEach(() => {
|
|
variantProposalStore.takeOwnedDevices(); // clear singleton ownership
|
|
shutdownDevice.mockReset();
|
|
mockFlag.mockReturnValue(true);
|
|
});
|
|
|
|
describe("POST /preview/shutdown/:udid", () => {
|
|
it("shuts down a known device and drops Lens ownership", async () => {
|
|
shutdownDevice.mockResolvedValue({ ok: true });
|
|
const { app } = harness([{ platform: "ios", udid: IOS_UDID, state: "Booted" }]);
|
|
variantProposalStore.markDeviceOwned(IOS_UDID);
|
|
|
|
const res = await request(app).post(`/shutdown/${IOS_UDID}`);
|
|
|
|
expect(res.status).toBe(200);
|
|
expect(res.body).toEqual({ ok: true });
|
|
expect(shutdownDevice).toHaveBeenCalledWith(IOS_UDID);
|
|
// No longer running → Lens must not try to kill it again at session end.
|
|
expect(variantProposalStore.isDeviceOwned(IOS_UDID)).toBe(false);
|
|
});
|
|
|
|
it("rejects an unknown udid without invoking shutdown (auth-exempt exec guard)", async () => {
|
|
const { app } = harness([{ platform: "ios", udid: IOS_UDID, state: "Booted" }]);
|
|
|
|
const res = await request(app).post(`/shutdown/${IOS_UDID_2}`);
|
|
|
|
expect(res.status).toBe(400);
|
|
expect(res.body.error).toContain("Unknown device");
|
|
expect(shutdownDevice).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("surfaces a shutdown failure as a 400 carrying the reason", async () => {
|
|
shutdownDevice.mockResolvedValue({ ok: false, error: "simctl: boom" });
|
|
const { app } = harness([{ platform: "ios", udid: IOS_UDID, state: "Booted" }]);
|
|
|
|
const res = await request(app).post(`/shutdown/${IOS_UDID}`);
|
|
|
|
expect(res.status).toBe(400);
|
|
expect(res.body.error).toBe("simctl: boom");
|
|
});
|
|
|
|
it("404s (route hidden) and never shuts down when the argent-lens flag is off", async () => {
|
|
mockFlag.mockReturnValue(false);
|
|
const { app } = harness([{ platform: "ios", udid: IOS_UDID, state: "Booted" }]);
|
|
variantProposalStore.markDeviceOwned(IOS_UDID);
|
|
|
|
const res = await request(app).post(`/shutdown/${IOS_UDID}`);
|
|
|
|
expect(res.status).toBe(404);
|
|
expect(shutdownDevice).not.toHaveBeenCalled();
|
|
// Ownership untouched — the gate rejected before any state change.
|
|
expect(variantProposalStore.isDeviceOwned(IOS_UDID)).toBe(true);
|
|
});
|
|
});
|