mirror of
https://github.com/software-mansion/argent.git
synced 2026-09-14 19:27:14 +08:00
Ignacy Łątka
a92c859d07
## What Adds `argent lens` — open Argent Lens bound to a fresh `claude` session. ## Why The Lens preview window and the agent communicate through a shared, process-wide tool-server that carries **no per-agent identity** (only a coarse telemetry header). So when the user requests changes in the window, there's no reliable way to route them to the *specific* agent that opened it. `argent lens` sidesteps the problem by inverting ownership: the human launches Lens, and Lens spawns (and therefore owns) exactly one `claude` terminal. The binding is 1:1 by construction — no identity plumbing required. ## How it works 1. `argent lens` ensures a tool-server and **begins a CLI Lens session**, which opens the preview window up front (no `await_user_selection` needed) and keeps it open across rounds. 2. It spawns a tracked `claude` terminal in the current directory — a TypeScript port of the macOS applet's `osascript` spawn/track mechanism — seeded to propose variants without blocking. 3. A watcher polls `GET /preview/outcome`; on each submitted round it types a one-line feedback summary into that terminal, queuing it to the agent as its next prompt. Requesting changes therefore "talks back" to the bound agent instead of closing the window. macOS only (drives Terminal/iTerm via `osascript`); off-darwin it exits with a clear message. ## Changes - **CLI** `lens-terminal.ts` — `osascript` spawn/track + a new write-into-running-session path (the "outputting" channel; injects input into the running TUI, which a tty write cannot do). - **CLI** `lens.ts` — the command + feedback formatter. - **tool-server** — a `cliSession` flag in the variant store (opens the window, suppresses auto-close on submit); `POST /preview/cli-session` and `GET /preview/outcome` routes. - **UI** — relabels the submit action to "Request changes" while a CLI session is active. Behind the existing `argent-lens` feature flag. ## Verification - Build + typecheck across the workspace; ESLint (`--max-warnings 0`) + Prettier clean. - 34 new unit tests; full `@argent/cli` suite **118 passing**, tool-server variant/preview suites **46 passing**. - **E2E (observed on this machine):** - **tool-server HTTP** — `cli-session` toggles `cliSession` true/false; submitted feedback round-trips through `/preview/outcome`. - **terminal injection** — spawned a window running `cat`, confirmed `writeToSession` lands text in the running program's **stdin** (both iTerm and Terminal), with embedded newlines flattened. - **full relay** — the real `watchAndRelay` loop against a real tool-server typed two distinct submission rounds' feedback into a stand-in agent terminal (dedup on `completedAt` verified). - `argent lens --help` and the feature-flag gate (exit 1 with guidance, no spawn). Note: a real end-to-end with a live `claude` agent was not run (it would drive a paid interactive session); the agent-facing channel is proven by injecting into a stand-in process's stdin via the exact same code path. --------- Co-authored-by: Filip131311 <contact@filipkaminski.com>
49 lines
1.9 KiB
TypeScript
49 lines
1.9 KiB
TypeScript
/**
|
|
* Regression test for the macOS-only registration gate on the Argent Lens
|
|
* tools. Unlike the feature-flag gate (which hides the tools at the HTTP
|
|
* exposure layer), the platform gate skips REGISTRATION entirely off-darwin —
|
|
* so on a non-macOS host the tools don't exist in the registry at all.
|
|
*
|
|
* `createRegistry` reads `process.platform` at construction, so each case
|
|
* overrides it and re-imports the module fresh (vi.resetModules).
|
|
*/
|
|
import { describe, it, expect, afterEach, vi } from "vitest";
|
|
|
|
const realPlatform = process.platform;
|
|
|
|
function setPlatform(value: NodeJS.Platform): void {
|
|
Object.defineProperty(process, "platform", { value, configurable: true });
|
|
}
|
|
|
|
afterEach(() => {
|
|
Object.defineProperty(process, "platform", { value: realPlatform, configurable: true });
|
|
vi.resetModules();
|
|
});
|
|
|
|
async function freshCreateRegistry() {
|
|
vi.resetModules();
|
|
return (await import("../src/utils/setup-registry")).createRegistry;
|
|
}
|
|
|
|
describe("Argent Lens tools — macOS-only registration gate", () => {
|
|
it("registers propose_variant / await_user_selection on darwin", async () => {
|
|
setPlatform("darwin");
|
|
const createRegistry = await freshCreateRegistry();
|
|
const registry = createRegistry();
|
|
expect(registry.getTool("propose_variant")).toBeDefined();
|
|
expect(registry.getTool("await_user_selection")).toBeDefined();
|
|
// Sanity: a cross-platform tool is registered regardless.
|
|
expect(registry.getTool("list-devices")).toBeDefined();
|
|
});
|
|
|
|
it("omits the Lens tools off-darwin (linux)", async () => {
|
|
setPlatform("linux");
|
|
const createRegistry = await freshCreateRegistry();
|
|
const registry = createRegistry();
|
|
expect(registry.getTool("propose_variant")).toBeUndefined();
|
|
expect(registry.getTool("await_user_selection")).toBeUndefined();
|
|
// The rest of the registry is unaffected.
|
|
expect(registry.getTool("list-devices")).toBeDefined();
|
|
});
|
|
});
|