2 Commits

Author	SHA1	Message	Date
Ignacy Łątka	7400179b5b	Windows support: Android + Chromium host control plane (#421) ... ## What Makes Argent run on Windows. iOS Simulator is macOS-only (Apple), so on Windows that means the **Android + Chromium** host control plane. The blocker was twofold: (1) no Windows `simulator-server` binary, and (2) POSIX-only assumptions in the tool-server. Companion radon PR builds the binary and runs the Android emulator E2E on Windows: software-mansion/radon#134. ## Changes **Windows-aware tool-server / resolver / bundling** - New shared `commandOnPath()` helper — `where` on Windows, `command -v` via `/bin/sh` on POSIX. `android-binary`, `check-deps`, and `vega-cli` previously hardcoded `/bin/sh`, which never matches on Windows. - `android-binary`: append `.exe` to `adb`/`emulator` in the `$ANDROID_HOME` fallback; probe `%LOCALAPPDATA%\Android\Sdk` (Android Studio's Windows default). - simulator-server resolver + dispatcher + `bundle-tools` + `download-simulator-server.sh`: ship and resolve `simulator-server.exe` on `win32` (new `simulatorServerBinaryName()`), add `win32` to the bundled host keys, add the `simulator-server-argent-windows.exe` download target with PE arch validation. - `stop-metro`: resolve listening PIDs via `netstat -ano` on Windows (`lsof` is POSIX-only and threw ENOENT). - `adb.ts`: AVD root resolution used `$HOME` + `startsWith("/")` (rejects `C:\…`); now `os.homedir()` + `path.isAbsolute()`. - **`boot-device`**: the emulator was spawned `detached` with `stdio:"ignore"`; on Windows a detached emulator with NUL stdout/stderr never reaches `sys.boot_completed` (verified on `windows-latest`: the identical flag set boots fine with real handles, hangs with NUL). Redirect the detached emulator's output to a temp log file on win32. POSIX keeps `"ignore"`. **Tests** — cross-platform unit coverage for `commandOnPath` (both branches), win32 `.exe` Android resolution, win32 `.exe` simulator-server resolution, and a win32 AVD drive-path case; dep-gate tests now mock at the `commandOnPath` boundary so they're platform-agnostic. **CI** — `windows-e2e.yml` (`windows-chromium` on `windows-latest`): runs the resolver/dep unit tests natively on Windows, confirms `adb.exe` resolution via the SDK root, then drives a **real headless Chrome over CDP** through the tool-server (discover → screenshot → describe → tap → observe the DOM mutation). Flow in `scripts/ci/windows-chromium-e2e.mjs` (also runnable locally / in Docker). The `simulator-server.exe` build + the full **Android-emulator E2E on Windows** live in radon CI (the binary's source is the private radon repo). ## Verification (all green) - **Chromium control plane on real Windows** (`windows-latest`): `✓ discovered chromium-cdp-9222 → ✓ screenshot → ✓ describe → ✓ gesture-tap → ✓ DOM mutation observed`. Resolver/dep unit tests run natively; `adb.exe` resolves via the SDK root (it's *not* on PATH on the runner — the gap the resolver closes). - **Android emulator on real Windows** (radon#134, `windows-latest` / WHPX): the real Argent path — `boot-device` → `{ booted: true }` → screenshot via `simulator-server.exe` → gesture-tap — all green. (The boot-device fix above is what makes the detached emulator reach `boot_completed`.) - **Local clean-room E2E**: the Chromium flow runs green in a headless Linux Docker container (fresh `npm ci`, no host pollution). - **No regressions**: full tool-server suite (1624) + native-devtools-ios (16); ESLint/Prettier/typecheck clean; **Wayland E2E** (Linux AVD boot) and **Vega VVD E2E** still pass (they exercise the changed `adb.ts` / `boot-device.ts` / `vega-cli.ts` paths). ## Notes Android-emulator E2E needs WHPX nested virtualization — confirmed available on the current hosted `windows-latest` image (Server 2025); the emulator boots hardware-accelerated in ~3 min. --------- Co-authored-by: Ignacy Łątka <claude-hubert.gancarczyk@swmansion.com> Co-authored-by: Ignacy Łątka <latekvo@users.noreply.github.com>	2026-07-22 13:53:32 +02:00
Piotr Krawiec	0bed3624a0	feat(vega): Amazon Vega (Fire TV) platform support (#366) ... ## Summary Adds **Vega (Amazon Fire TV)** as a third Argent platform alongside iOS and Android. Vega apps are React Native 0.72 + Hermes running on a QEMU **Virtual Device (VVD)**, driven by a **D-pad tv-remote rather than touch**. This PR extends Argent's platform abstraction so the existing tool surface gates correctly on `vega`, and adds the Vega-specific tools needed to actually drive a Fire TV app end to end. ### Platform abstraction - `Platform` gains `vega`; `DeviceKind` gains `vvd` (the QEMU VVD); `ToolCapability` gains a `vega { vvd, device }` block; `ToolDependency` gains `vega`. - `assertSupported()` selects the `vega` capability matrix for Vega devices; `dispatchByPlatform()` gains an optional `vega` branch, and a Vega dispatch with no branch throws `NotImplementedOnPlatformError` (501). - New `vega-cli` util (modeled on `adb.ts`) resolves `vega`/`kepler` from `PATH` or `~/vega/bin` with the same hardened exec/quoting; `check-deps` resolves and hints the `vega` dependency. - The `simulator-server` blueprint is never wired for `vega` (Vega uses `adb` + the `vega`/`kepler` CLI, not the proprietary binary). ### How Vega is wired - **Input / screenshot / describe** go over `adb` (input via `inputd-cli`, screenshots host-side via the Android emulator console, element tree via the on-device automation toolkit). - **App lifecycle** goes over the `vega`/`kepler` CLI. - v1 is **Virtual-Device-only**: every Vega capability is declared `vvd`. Physical Fire TV is out of scope and untested — the tool-server does not connect to or detect hardware, so `resolveDevice` classifies every `amazon-` serial as a VVD by shape. A physical device is therefore not classified as `device` and not rejected at the capability gate; supporting and gating real hardware is deferred to a version where it can be tested. - Vega runs **React Native 0.72**, which predates the new React Native DevTools. The CDP/Hermes debugger surface (`debugger-*`, React/native profilers) depends on integration points the new DevTools provides, so **debugging and profiling are out of scope for this PR** — Vega profiling/crash analysis is handled by the `amazon-devices-buildertools-mcp` server instead. ### Also includes - `argent-vega` skill documenting the full Vega workflow (target discovery, the describe → compute-path → `tv-remote` navigation loop, text injection). - Vega VVD end-to-end CI workflow. ## Feature support by platform Legend: ✅ supported · ❌ not supported · ⚠️ degraded / conditional · — not applicable | Feature (tool) | iOS | Android | Chromium | **Vega (VVD)** | Vega notes | |---|:---:|:---:|:---:|:---:|---| | **Device discovery** (`list-devices`) | ✅ | ✅ | ✅ | **✅** | Tagged `platform:"vega"`, `kind:"vvd"`; pass `serial` as `udid` | | **Boot / start device** | ✅ | ✅ | — | ✅ | | | **Launch app** (`launch-app`) | ✅ | ✅ | ✅ | **✅** | `bundleId` = interactive-component app id from `manifest.toml` | | **Restart app** (`restart-app`) | ✅ | ✅ | ✅ | **✅** | Terminate + relaunch | | **Reinstall app** (`reinstall-app`) | ✅ | ✅ | ❌ | **✅** | Uninstall + install a `.vpkg` | | **Screenshot** (`screenshot`) | ✅ | ✅ | ✅ | **✅** | Host-side via emulator console (needs `adb`); rotation ignored (fixed landscape) | | **Describe / element tree** (`describe`) | ✅ | ✅ | ✅ | **✅** | On-device automation toolkit; surfaces `[focused]`/`[selected]` + normalized frames | | **Touch gestures** (`gesture-tap`/`swipe`/`scroll`/`drag`/`custom`) | ✅ | ✅ | ✅ | **❌** | Vega is tv-remote-driven; gestures error — use `tv-remote` | | **Pinch / rotate gesture** (`gesture-pinch`/`gesture-rotate`) | ✅ | ❌ | ⚠️ | **❌** | N/A on a TV | | **Remote / D-pad** (`tv-remote`) | — | — | — | **✅** | Vega-only tool; single key, repeat, or a whole path in one call | | **Hardware buttons** (`button`) | ✅ | ✅ | — | **❌** | Remote keys live in `remote` instead | | **Text input** (`keyboard`) | ✅ | ✅ | ✅ | **✅** | Whole-string injection via `inputd-cli send_text` | | **Rotate orientation** (`rotate`) | ✅ | ✅ | — | **❌** | TV framebuffer is fixed landscape | | **Open URL / deep link** (`open-url`) | ✅ | ✅ | ✅ | **❌** | Not wired on Vega | | **JS debugger** (`debugger-*`) | ✅ | ✅ | ✅ | **❌** | RN 0.72 predates the new RN DevTools — out of scope for this PR | | **Native devtools / AX** (`native-describe-screen`, etc.) | ✅ | ❌ | — | **❌** | iOS-only | | **Native profiler** (`native-profiler-*`) | ✅ | ✅ | — | **❌** | Use `amazon-devices-buildertools-mcp` (Perfetto) instead | | **React profiler** (`react-profiler-*`) | ✅ | ✅ | — | **❌** | Out of scope; RN 0.72 / new RN DevTools not supported | | **Screenshot diff** (`screenshot-diff`) | ✅ | ✅ | ✅ | **✅** | Host-side image comparison; platform-agnostic | | **Flows record/replay** (`flow-*`) | ✅ | ✅ | ✅ | **✅** | Records any tool-call sequence | ## Test plan - [x] `list-devices` surfaces connected Vega devices (`platform:"vega"`, `kind:"vvd"`) - [x] `launch-app`, `restart-app`, `reinstall-app`, `list-installed-apps` work on Vega - [x] `tv-remote` drives focus (single key, `repeat`, and multi-key path) and `keyboard` injects whole strings - [x] `screenshot` returns a frame via the host-side VVD path - [x] `describe` returns the on-screen element tree with `[focused]` state and normalized coordinates - [x] Vega VVD e2e CI workflow passes - [ ] Test multiple platforms being driven at the same time - [x] Android + Vega - [ ] iOS + Vega - [ ] chrome + Vega --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>	2026-06-22 20:31:45 +02:00