mirror of
https://github.com/sbroenne/mcp-server-excel.git
synced 2026-09-19 07:53:08 +08:00
Stefan Broenner
e512204732
* feat: Add comprehensive Chart operations support (Regular Charts and PivotCharts) Implements complete chart management functionality across all three layers: - Core Commands: 15 methods for chart lifecycle, data source, and appearance operations - MCP Server Tool: excel_chart with 15 actions exposed to LLM agents - CLI Commands: chart command with 15 actions for command-line automation Core Implementation (940+ lines): - IChartCommands.cs: Interface defining 15 chart operations - ChartCommands.Lifecycle.cs (500+ lines): List, Read, CreateFromRange, CreateFromPivotTable, Delete, Move - ChartCommands.DataSource.cs (200+ lines): SetSourceRange, AddSeries, RemoveSeries - ChartCommands.Appearance.cs (240+ lines): SetChartType, SetTitle, SetAxisTitle, ShowLegend, SetStyle - Strategy Pattern: RegularChartStrategy and PivotChartStrategy (220+ lines each) - ChartType.cs: 70+ chart type enum values (Column, Bar, Line, Pie, Area, Scatter, etc.) - ChartResults.cs: 4 result classes (ChartListResult, ChartInfoResult, ChartCreateResult, ChartUpdateResult) MCP Server Integration (473 lines): - ExcelChartTool.cs: Main tool with 15 actions - ChartAction enum: 15 values (List, Read, CreateFromRange, CreateFromPivotTable, Delete, Move, SetSourceRange, AddSeries, RemoveSeries, SetChartType, SetTitle, SetAxisTitle, ShowLegend, SetStyle) - ToActionString() extension: Maps ChartAction to kebab-case strings CLI Integration (368 lines): - ChartCommand.cs: Command<Settings> pattern with 15 actions - Registered in Program.cs with DI support Testing (27 tests + smoke test): - ChartCommandsTests.Lifecycle.cs: 9 tests covering chart creation and management - ChartCommandsTests.Appearance.cs: 10 tests covering appearance customization - ChartCommandsTests.DataSource.cs: 8 tests covering data source operations - CoreCommandsCoverageTests.cs: Automated verification of enum/method coverage - McpServerSmokeTests.cs: End-to-end smoke test for excel_chart tool (now includes Chart!) - ToolDiscoveryTests.cs: Discovery verification for excel_chart Features: - Regular Charts: Static charts from Excel ranges (A1:D10) - PivotCharts: Dynamic charts linked to PivotTables - 70+ chart types supported (Column, Bar, Line, Pie, Area, Scatter, Bubble, Stock, Surface, Radar, etc.) - Full positioning control (left, top, width, height in points) - Series management (add/remove data series) - Appearance customization (titles, axes, legends, styles) - Round-trip validation in all tests Architecture: - Strategy Pattern: Separates Regular vs PivotChart logic - Batch-aware: All operations use IExcelBatch for performance - COM-safe: Proper resource cleanup with try/finally blocks - Range object fix: SetSourceData requires Range object, not string Documentation: - specs/CHART-API-SPECIFICATION.md: 400+ line comprehensive specification - All methods fully documented with XML comments - Examples provided for all operation types Builds successfully with 0 warnings, 0 errors. All 27 Core tests pass. Smoke test passes (validates end-to-end workflow with all 13 tools). 100% Core method coverage verified. MCP tool discoverable and functional. * fix: Update Chart test assertions to match Excel SERIES formula behavior - SetSourceRange tests now check for Sheet1 + column references ($D$, $E$, $A$, $B$) instead of simple ranges - AddSeries_InvalidSeriesIndex now expects COMException for invalid index instead of Success=false - All 26 Chart integration tests now pass (9 lifecycle, 8 data source, 9 appearance) - Fixes #229 * refactor: Rewrite Connection tests to accurately document Excel COM behavior - TEXT/WEB connections: Create works successfully - OLEDB connections: Fail with ArgumentException (Excel COM Add2() limitation) - ODBC connections: Create succeeds even without valid DSN - Duplicate names: Excel handles gracefully (prevents or auto-renames) - Removed confusing 'test always passes' logic - Added clear documentation about connection type support - Fixed exception propagation in CreateConnection helper (removed InvalidOperationException wrapping) All 21 Connection tests now pass (1 skipped). * feat(connection): Add ODC import and enhance SetProperties with connection string/command text/description updates FEATURE ENHANCEMENTS: - Add ImportFromOdc action to import Office Data Connection (.odc) files - Expose connectionString, commandText, description parameters in SetProperties (was behavior-only) - Add exception handler for Excel 0x800A03EC error (ODC connection string updates blocked) - Block TEXT/WEB connection creation via Create (redirect to Power Query) - Add import-odc action to CLI with --odc-file parameter IMPLEMENTATION: - New ConnectionCommands.ImportOdc.cs with AddFromFile COM API - Enhanced UpdateConnectionProperties to handle all 7 properties (connection string, command text, description + 4 behavior properties) - MCP Tool: SetProperties accepts newConnectionString, newCommandText, newDescription parameters - CLI: ExecuteImportOdc method with OdcFilePath setting - Exception scoping: Only catches 0x800A03EC when updating connection string TESTING (13 new tests): - ConnectionCommandsTests.ImportOdc.cs: * ImportFromOdc_ValidFile_ImportsConnection * ImportFromOdc_MissingFile_ReturnsError * ImportFromOdc_DuplicateImport_AddsSecondConnection * ImportFromOdc_ThenUpdateCommandText_RefreshSucceeds (proves functional query change) * ImportFromOdc_ThenUpdateCommandText_ConnectionUpdated * ImportFromOdc_ThenUpdateDescription_ConnectionUpdated * CreateConnection_ThenUpdateConnectionString_Succeeds (proves ODBC connections allow updates) - ConnectionCommandsTests.Create.cs: * Create_TextConnection_ThrowsNotSupportedException (TEXT blocked) * Create_WebConnection_ThrowsNotSupportedException (WEB blocked) * Create_OleDbConnection_ThrowsArgumentException (Excel COM limitation) * Create_OdbcConnection_ReturnsSuccess (ODBC works) * Updated Create_DuplicateName and Create_WithDescription to use ODBC - Helper: SQLiteDatabaseHelper for reliable OLEDB testing DOCUMENTATION: - Updated README tool counts: 10 actions (was 9) - Updated architecture-patterns.instructions.md: 11 tools (corrected from 12) - Updated excel_connection tool description: ODC import, TEXT/WEB removal guidance - Added Directory.Packages.props: Microsoft.Data.Sqlite package - Removed outdated vscode-extension/INSTALL.md (content merged to main README) KEY FINDINGS: - ODC-imported connections: Connection string updates blocked (0x800A03EC) - Programmatically-created ODBC connections: Connection string updates work - Command text updates are functional (refresh executes new query, not cosmetic) - TEXT/WEB connections now blocked from Create (use Power Query or ODC import) * refactor: Remove ODC import functionality (blocked by Windows Defender ASR) - Removed ImportFromOdc action from ConnectionAction enum and all implementations - Deleted ConnectionCommands.ImportOdc.cs (implementation file) - Deleted ConnectionCommandsTests.ImportOdc.cs (all test files) - Removed import-odc from MCP tool, CLI, and interface - Removed OdcFilePath CLI parameter - Fixed Delete and View tests to use ODBC connections instead of TEXT - Updated Refresh tests to use simpler ODBC connections - Updated all READMEs: connection count 10→9 actions, 155→154 total actions REASON: Excel's AddFromFile() COM API creates .lnk shortcuts in 'My Data Sources' folder, triggering Windows Defender Attack Surface Reduction (ASR) rule 'Block Office applications from creating executable content'. This blocks all users with default Defender policies (common in enterprise). ALTERNATIVE APPROACH: Users can manually create connections via excel_connection create action with connection strings, or use Power Query (excel_powerquery) for data imports. * feat: Enhance Excel tools with timeout safeguards and error handling - Added timeout safeguards to `ExcelPivotTableTool` and `ExcelPowerQueryTool` to handle long-running operations, returning suggested next actions on timeout. - Updated `CreateFromDataModel` and `LoadToPowerQueryAsync` methods to include detailed error messages and operation context in case of timeouts. - Removed unused SQLite database helper class and replaced it with ACE OLEDB helper functions for better integration testing. - Updated connection tests to utilize the new ACE OLEDB helper methods, ensuring proper creation and refreshing of connections. - Adjusted README to reflect the current number of supported operations (154) in the Excel MCP Server.
39 lines
2.2 KiB
XML
39 lines
2.2 KiB
XML
<Project>
|
|
<!-- Central Package Management for consistent versions across solution -->
|
|
<PropertyGroup>
|
|
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
|
|
<CentralPackageTransitivePinningEnabled>true</CentralPackageTransitivePinningEnabled>
|
|
</PropertyGroup>
|
|
<ItemGroup>
|
|
<PackageVersion Include="Microsoft.AnalysisServices" Version="19.106.1" />
|
|
<!-- UI Framework -->
|
|
<PackageVersion Include="Spectre.Console" Version="0.54.0" />
|
|
<PackageVersion Include="Spectre.Console.Cli" Version="0.53.0" />
|
|
<!-- Microsoft Extensions for MCP Server -->
|
|
<PackageVersion Include="Microsoft.Extensions.Hosting" Version="9.0.10" />
|
|
<PackageVersion Include="Microsoft.Extensions.Logging" Version="9.0.10" />
|
|
<PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="10.0.0" />
|
|
<PackageVersion Include="Microsoft.Extensions.Resilience" Version="10.0.0" />
|
|
<PackageVersion Include="Microsoft.Extensions.Configuration" Version="9.0.10" />
|
|
<PackageVersion Include="Microsoft.Extensions.DependencyInjection" Version="9.0.10" />
|
|
<PackageVersion Include="Microsoft.Extensions.ObjectPool" Version="10.0.0" />
|
|
<PackageVersion Include="System.Text.Json" Version="9.0.10" />
|
|
<!-- NuGet API Client -->
|
|
<PackageVersion Include="NuGet.Protocol" Version="6.12.1" />
|
|
<PackageVersion Include="NuGet.Versioning" Version="6.12.1" />
|
|
<!-- MCP SDK -->
|
|
<PackageVersion Include="ModelContextProtocol" Version="0.4.0-preview.3" />
|
|
<!-- Testing Framework -->
|
|
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />
|
|
<PackageVersion Include="System.Net.Http" Version="4.3.5" />
|
|
<PackageVersion Include="System.Text.RegularExpressions" Version="4.3.2" />
|
|
<PackageVersion Include="xunit" Version="2.9.3" />
|
|
<PackageVersion Include="xunit.runner.visualstudio" Version="3.1.5" />
|
|
<PackageVersion Include="coverlet.collector" Version="6.1.0" />
|
|
<PackageVersion Include="MartinCostello.Logging.XUnit" Version="0.5.1" />
|
|
<!-- Code Analysis and Security -->
|
|
<PackageVersion Include="Microsoft.CodeAnalysis.Analyzers" Version="3.3.5" />
|
|
<PackageVersion Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="10.0.100" />
|
|
</ItemGroup>
|
|
</Project>
|