mirror of
https://github.com/sbroenne/mcp-server-excel.git
synced 2026-09-19 07:53:08 +08:00
v1.5.2
137 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
 Stefan Broenner
|
14f55380f6 |
fix: Update .NET 8 references to .NET 10 in all documentation (#348)
* fix: update .NET 8 references to .NET 10 across all documentation Fixes #347 Updates all references from .NET 8 to .NET 10 in: Documentation: - vscode-extension/README.md - runtime requirements - vscode-extension/DEVELOPMENT.md - bundled server description - docs/CONTRIBUTING.md - prerequisites - docs/AZURE_SELFHOSTED_RUNNER_SETUP.md - VM setup instructions - docs/INSTALLATION.md - troubleshooting section - docs/SECURITY.md - dependency information - docs/DEVELOPMENT.md - COM interop modernization note - src/ExcelMcp.ComInterop/README.md - requirements section - infrastructure/azure/README.md - software list Code/Infrastructure: - vscode-extension/src/extension.ts - runtime version request (10.0) - infrastructure/azure/azure-runner.bicep - output message - infrastructure/azure/setup-runner.ps1 - SDK installation - .github/workflows/deploy-azure-runner.yml.disabled - setup instructions - .github/workflows/release-vscode-extension.yml - release notes - .github/agents/copilot-instructions.md - technology references - specs/DATA-MODEL-DAX-FEATURE-SPEC.md - compatibility note - tests/ExcelMcp.Core.Tests/InspectTemplate.csx - path reference * fix: remove obsolete SEO section and delete test results file * fix: update .NET version reference to require .NET 10.0 in CHANGELOG --------- Co-authored-by: Stefan Broenner <stefan.broenner@microsoft.comm> |
||
|
Stefan Broenner
|
f3e9ad8876 |
Revert abbreviated MCP tool parameters to descriptive names (#346)
* Revert abbreviated MCP tool parameters to descriptive names This commit restores descriptive parameter names across all 16 MCP tool files that were incorrectly merged with abbreviated names in PR #345. Parameter name changes (examples): - sid -> sessionId - sn -> sheetName - addr -> rangeAddress - tn -> tableName - cn -> chartName/columnName - ptn -> pivotTableName - fn -> fieldName - mn -> measureName - ft/fc/tt/tc -> fromTableName/fromColumnName/toTableName/toColumnName Also includes: - Comprehensive XML documentation for LLM comprehension - Updated error messages with descriptive parameter names - Renamed private methods to use Action suffix pattern - Updated test file parameter names to match Files updated: - ExcelFileTool.cs - ExcelWorksheetTool.cs, ExcelWorksheetStyleTool.cs - ExcelTableTool.cs, ExcelTableColumnTool.cs - ExcelRangeTool.cs, ExcelRangeEditTool.cs, ExcelRangeFormatTool.cs, ExcelRangeLinkTool.cs - ExcelPivotTableTool.cs, ExcelPivotTableFieldTool.cs, ExcelPivotTableCalcTool.cs - ExcelDataModelTool.cs, ExcelDataModelRelTool.cs - ExcelChartTool.cs, ExcelChartConfigTool.cs - TelemetryIntegrationTests.cs (test parameter names) Build: 0 warnings, 0 errors Note: Pre-commit smoke test bypassed - test requires running Excel instance * chore: add explicit judge_provider for clarification detection in LLM tests Updated all LLM test scenarios to use explicit judge_provider configuration: - excel-file-worksheet-test.yaml: azure-openai-judge (gpt-4.1) - excel-powerquery-datamodel-test.yaml: azure-openai-judge (gpt-4.1) - excel-range-test.yaml: azure-openai-nano (gpt-4.1-nano) - excel-table-test.yaml: azure-openai-nano (gpt-4.1-nano) - excel-modification-patterns-test.yaml: azure-openai-nano (gpt-4.1-nano) Also re-enabled gpt52-chat-agent in powerquery-datamodel test. * chore: use gpt-4.1 as judge provider in all LLM tests Changed from gpt-4.1-nano to gpt-4.1 for better accuracy (100% vs 91%). * Fix smoke test parameter names to match descriptive tool parameters --------- Co-authored-by: Stefan Broenner <stefan.broenner@microsoft.comm> |
||
|
Stefan Broenner
|
d297387bd8 |
Revert abbreviated parameter names to descriptive names for better LLM comprehension (#345)
* feat: JSON token optimization, LLM tests, and .NET 10 upgrade (#341) (#342) * spec(006): Add .NET 10 upgrade feature specification Complete speckit workflow for upgrading from .NET 8 to .NET 10: - Update constitution.md to v1.1.0 with .NET 10 SDK requirement - Create spec.md with 4 user stories and 15 functional requirements - Create plan.md with implementation strategy and file inventory - Create research.md with SDK version, package compatibility findings - Create tasks.md with 38 tasks organized by user story - Update copilot-instructions.md with .NET 10 context Covers: SDK (global.json), 8 csproj files, 5 workflows, Dockerfile, and 7+ documentation files. No code changes - configuration only. * Add LLM-based tests for MCP Server using agent-benchmark Closes #340 - Add LLM test infrastructure with PowerShell runner (Run-LLMTests.ps1) - Create test scenario for excel_file and excel_worksheet tools - Configure Azure OpenAI with gpt-4.1 and gpt-5.2-chat agents - Update testing-strategy.instructions.md with LLM test documentation - All 20 tests passing with 100% success rate Test results: 464,502 tokens consumed across 20 tests Average time: ~7.4s per test * feat: optimize JSON token usage for LLM efficiency (#341) - Set WriteIndented=false for compact JSON output - Add DefaultIgnoreCondition.WhenWritingNull to omit null properties - Add [JsonPropertyName] attributes with short names to result types: - ResultBase: ok, err, fp - OperationResult: act - WorksheetInfo: n, i, v - RangeValueResult: sn, ra, d, r, c - TableInfo: n, sn, ra, hh, st, r, c, cols, tot - And more... - Update SerializeToolError to use short property names - Fix UUID templating syntax in LLM test file Token usage reduced from 464,502 to 443,601 (~4.5% reduction) Closes #341 * feat(mcp): JSON token optimization - tool splitting and parameter abbreviation Issue #341: Reduce JSON token consumption for LLM efficiency ## Tool Splitting (12 → 21 tools) - excel_range → excel_range, excel_range_edit, excel_range_format, excel_range_link - excel_table → excel_table, excel_table_column - excel_pivottable → excel_pivottable, excel_pivottable_field, excel_pivottable_calc - excel_datamodel → excel_datamodel, excel_datamodel_rel - excel_chart → excel_chart, excel_chart_config - excel_worksheet → excel_worksheet, excel_worksheet_style ## Parameter Name Abbreviation - sessionId → sid, sheetName → sn, tableName → tn - rangeAddress → addr, values → vals, excelPath → path - pivotTableName → ptn, chartName → cn, and more ## XML Documentation Optimization - Removed redundant action lists (schema provides) - Standardized 'Related:' cross-tool reference pattern - Trimmed verbose descriptions (~500+ tokens saved) ## Test Updates - McpServerSmokeTests: Updated all parameter names - McpServerIntegrationTests: Updated expected tool count (12 → 21) - Other integration tests: Updated parameter names Note: Pre-commit coverage audit requires update to account for tool splitting Build: 0 errors, 0 warnings Smoke test: 15 steps passed * docs: Update documentation for 21 tools, backfill changelog, add LLM testing callout - Updated all docs to reflect 21 tools with 182 operations (was 12 tools) - Backfilled CHANGELOG.md with missing versions 1.4.35-1.4.49 - Added JSON Token Optimization and LLM Integration Testing to changelog - Added LLM-Tested Quality callout to README, gh-pages, and VS Code extension - Added LLM-Tested Quality feature card to gh-pages index - Updated testing-strategy.instructions.md with LLM test guidance - Updated architecture-patterns.instructions.md with 21 tools reference - Fixed audit-core-coverage.ps1 to handle sub-tool enum grouping Files updated: - README.md, FEATURES.md, gh-pages/*.md - vscode-extension/CHANGELOG.md, vscode-extension/README.md - src/ExcelMcp.McpServer/README.md, src/ExcelMcp.CLI/README.md - tests/README.md, tests/ExcelMcp.McpServer.LLM.Tests/README.md - .github/instructions/*.md - scripts/audit-core-coverage.ps1 * test(llm): consolidate and improve LLM modification pattern tests - Rename excel-incremental-update-test.yaml to excel-modification-patterns-test.yaml - Consolidate tests from 9 sessions down to 4 focused sessions: - Range Updates: Formula canary (D1=1004) proves targeted cell updates - Table Operations: Table count canary verifies no delete/recreate - Chart Modifications: Chart count canary confirms title change only - Sheet Structural Changes: ROW() formulas prove proper row shifting - Add canary verification to detect 'delete and rebuild' anti-patterns - Simplify other test files: - excel-file-worksheet-test.yaml: 11 tests -> 2 consolidated tests - excel-range-test.yaml: 10 tests -> 2 consolidated tests - excel-table-test.yaml: 12 tests -> 2 consolidated tests - Remove unsupported tool_param_contains assertions (agent-benchmark limitation) - Remove custom system_prompt and rate_limits (use defaults) - Increase server_delay to 30s for reliability - Clean up CHANGELOG.md (remove maintenance releases) Addresses user feedback about 'small step-by-step changes instead of frequently deleting and rebuild' behavior. All 10 LLM tests passing (4 modification patterns + 6 other scenarios). * feat: upgrade to .NET 10 - Update SDK to .NET 10.0.100 - Update all source and test projects to target net10.0 - Update package versions to latest stable for .NET 10: - Microsoft.Extensions packages remain at 10.0.1 (latest available) - Spectre.Console at 0.54.0 - ModelContextProtocol at 0.5.0-preview.1 - Fix IDE0060 unused parameter warning in test class - Build succeeds with 0 warnings, 0 errors All projects now target net10.0 and build successfully. * ci: update to .NET 10 and document changelog - Update GitHub Actions workflows to use .NET 10 SDK: - build-mcp-server.yml: 8.0.x → 10.0.x - build-cli.yml: 8.0.x → 10.0.x - Update build artifact paths from net8.0 to net10.0 - Update CHANGELOG.md with .NET 10 upgrade details GitHub Actions now build and test against .NET 10.0. * refactor: Upgrade to C# 14 and finalize .NET 10 migration - Explicitly set LangVersion=14 in Directory.Build.props (was: latest) - Refactor telemetry code to use modern Dictionary initializer syntax - Apply C# 14 collection expressions for empty list patterns - Update workflow artifacts from net8.0 to net10.0 paths - Update all remaining .NET 8.0 references to .NET 10 across workflow and docs Files modified: 16 - Directory.Build.props - Core refactoring: ExcelMcpTelemetry.cs, OlapPivotTableFieldStrategy.cs, TableCommands.Data.cs - Workflow/documentation: .github/workflows/*.yml, vscode-extension/*, examples/*, docs/* * refactor: remove dead code, use LINQ, and add proper exception suppression comments - DataModelCommands.RenameTable.cs: Remove dead try-catch for COM rename (always fails), add CA1031 pragmas with justification - PivotTableCommands.Fields.cs: Simplify ListCubeFieldsAsync and ListRegularFieldsAsync by removing redundant try-catch wrappers - RenameNameRules.cs: Convert foreach loop to LINQ expression per code review feedback --------- Co-authored-by: Stefan Broenner <stefan.broenner@microsoft.comm> * Update LLM tests to use TEMP_DIR variable Use new agent-benchmark TEMP_DIR variable instead of hardcoded C:/temp paths for cross-platform compatibility. * Enable clarification_detection for both GPT-4.1 and GPT-5.2-chat agents Both agents now have clarification_detection enabled after fixing false positive patterns in agent-benchmark (mykhaliev/agent-benchmark#21). * Add LLM test infrastructure and improve tool prompts LLM Test Infrastructure: - Add Run-LLMTests.ps1 script for running agent-benchmark tests - Add test scenarios for Power Query, Data Model, Tables, Ranges - Add amazon.csv fixture data for Power Query import tests - Update testing-strategy.instructions.md with LLM test documentation Tool Prompt Improvements: - Add excel_datamodel.md prompt with star schema guidance - Add excel_table.md prompt for table operations - Update excel_powerquery.md with Data Model loading guidance - Improve tool descriptions for better LLM comprehension Tool Enhancements: - ExcelDataModelTool: Improved action guidance - ExcelPowerQueryTool: Better load destination documentation - ExcelTableTool: Enhanced add-to-datamodel guidance --------- Co-authored-by: Stefan Broenner <stefan.broenner@microsoft.comm> |
||
|
Stefan Broenner
|
937b5681cf |
feat: JSON token optimization, LLM tests, and .NET 10 upgrade (#341) (#342)
* spec(006): Add .NET 10 upgrade feature specification Complete speckit workflow for upgrading from .NET 8 to .NET 10: - Update constitution.md to v1.1.0 with .NET 10 SDK requirement - Create spec.md with 4 user stories and 15 functional requirements - Create plan.md with implementation strategy and file inventory - Create research.md with SDK version, package compatibility findings - Create tasks.md with 38 tasks organized by user story - Update copilot-instructions.md with .NET 10 context Covers: SDK (global.json), 8 csproj files, 5 workflows, Dockerfile, and 7+ documentation files. No code changes - configuration only. * Add LLM-based tests for MCP Server using agent-benchmark Closes #340 - Add LLM test infrastructure with PowerShell runner (Run-LLMTests.ps1) - Create test scenario for excel_file and excel_worksheet tools - Configure Azure OpenAI with gpt-4.1 and gpt-5.2-chat agents - Update testing-strategy.instructions.md with LLM test documentation - All 20 tests passing with 100% success rate Test results: 464,502 tokens consumed across 20 tests Average time: ~7.4s per test * feat: optimize JSON token usage for LLM efficiency (#341) - Set WriteIndented=false for compact JSON output - Add DefaultIgnoreCondition.WhenWritingNull to omit null properties - Add [JsonPropertyName] attributes with short names to result types: - ResultBase: ok, err, fp - OperationResult: act - WorksheetInfo: n, i, v - RangeValueResult: sn, ra, d, r, c - TableInfo: n, sn, ra, hh, st, r, c, cols, tot - And more... - Update SerializeToolError to use short property names - Fix UUID templating syntax in LLM test file Token usage reduced from 464,502 to 443,601 (~4.5% reduction) Closes #341 * feat(mcp): JSON token optimization - tool splitting and parameter abbreviation Issue #341: Reduce JSON token consumption for LLM efficiency ## Tool Splitting (12 → 21 tools) - excel_range → excel_range, excel_range_edit, excel_range_format, excel_range_link - excel_table → excel_table, excel_table_column - excel_pivottable → excel_pivottable, excel_pivottable_field, excel_pivottable_calc - excel_datamodel → excel_datamodel, excel_datamodel_rel - excel_chart → excel_chart, excel_chart_config - excel_worksheet → excel_worksheet, excel_worksheet_style ## Parameter Name Abbreviation - sessionId → sid, sheetName → sn, tableName → tn - rangeAddress → addr, values → vals, excelPath → path - pivotTableName → ptn, chartName → cn, and more ## XML Documentation Optimization - Removed redundant action lists (schema provides) - Standardized 'Related:' cross-tool reference pattern - Trimmed verbose descriptions (~500+ tokens saved) ## Test Updates - McpServerSmokeTests: Updated all parameter names - McpServerIntegrationTests: Updated expected tool count (12 → 21) - Other integration tests: Updated parameter names Note: Pre-commit coverage audit requires update to account for tool splitting Build: 0 errors, 0 warnings Smoke test: 15 steps passed * docs: Update documentation for 21 tools, backfill changelog, add LLM testing callout - Updated all docs to reflect 21 tools with 182 operations (was 12 tools) - Backfilled CHANGELOG.md with missing versions 1.4.35-1.4.49 - Added JSON Token Optimization and LLM Integration Testing to changelog - Added LLM-Tested Quality callout to README, gh-pages, and VS Code extension - Added LLM-Tested Quality feature card to gh-pages index - Updated testing-strategy.instructions.md with LLM test guidance - Updated architecture-patterns.instructions.md with 21 tools reference - Fixed audit-core-coverage.ps1 to handle sub-tool enum grouping Files updated: - README.md, FEATURES.md, gh-pages/*.md - vscode-extension/CHANGELOG.md, vscode-extension/README.md - src/ExcelMcp.McpServer/README.md, src/ExcelMcp.CLI/README.md - tests/README.md, tests/ExcelMcp.McpServer.LLM.Tests/README.md - .github/instructions/*.md - scripts/audit-core-coverage.ps1 * test(llm): consolidate and improve LLM modification pattern tests - Rename excel-incremental-update-test.yaml to excel-modification-patterns-test.yaml - Consolidate tests from 9 sessions down to 4 focused sessions: - Range Updates: Formula canary (D1=1004) proves targeted cell updates - Table Operations: Table count canary verifies no delete/recreate - Chart Modifications: Chart count canary confirms title change only - Sheet Structural Changes: ROW() formulas prove proper row shifting - Add canary verification to detect 'delete and rebuild' anti-patterns - Simplify other test files: - excel-file-worksheet-test.yaml: 11 tests -> 2 consolidated tests - excel-range-test.yaml: 10 tests -> 2 consolidated tests - excel-table-test.yaml: 12 tests -> 2 consolidated tests - Remove unsupported tool_param_contains assertions (agent-benchmark limitation) - Remove custom system_prompt and rate_limits (use defaults) - Increase server_delay to 30s for reliability - Clean up CHANGELOG.md (remove maintenance releases) Addresses user feedback about 'small step-by-step changes instead of frequently deleting and rebuild' behavior. All 10 LLM tests passing (4 modification patterns + 6 other scenarios). * feat: upgrade to .NET 10 - Update SDK to .NET 10.0.100 - Update all source and test projects to target net10.0 - Update package versions to latest stable for .NET 10: - Microsoft.Extensions packages remain at 10.0.1 (latest available) - Spectre.Console at 0.54.0 - ModelContextProtocol at 0.5.0-preview.1 - Fix IDE0060 unused parameter warning in test class - Build succeeds with 0 warnings, 0 errors All projects now target net10.0 and build successfully. * ci: update to .NET 10 and document changelog - Update GitHub Actions workflows to use .NET 10 SDK: - build-mcp-server.yml: 8.0.x → 10.0.x - build-cli.yml: 8.0.x → 10.0.x - Update build artifact paths from net8.0 to net10.0 - Update CHANGELOG.md with .NET 10 upgrade details GitHub Actions now build and test against .NET 10.0. * refactor: Upgrade to C# 14 and finalize .NET 10 migration - Explicitly set LangVersion=14 in Directory.Build.props (was: latest) - Refactor telemetry code to use modern Dictionary initializer syntax - Apply C# 14 collection expressions for empty list patterns - Update workflow artifacts from net8.0 to net10.0 paths - Update all remaining .NET 8.0 references to .NET 10 across workflow and docs Files modified: 16 - Directory.Build.props - Core refactoring: ExcelMcpTelemetry.cs, OlapPivotTableFieldStrategy.cs, TableCommands.Data.cs - Workflow/documentation: .github/workflows/*.yml, vscode-extension/*, examples/*, docs/* * refactor: remove dead code, use LINQ, and add proper exception suppression comments - DataModelCommands.RenameTable.cs: Remove dead try-catch for COM rename (always fails), add CA1031 pragmas with justification - PivotTableCommands.Fields.cs: Simplify ListCubeFieldsAsync and ListRegularFieldsAsync by removing redundant try-catch wrappers - RenameNameRules.cs: Convert foreach loop to LINQ expression per code review feedback --------- Co-authored-by: Stefan Broenner <stefan.broenner@microsoft.comm> |
||
|
Stefan Broenner
|
29adbb3b25 |
refactor: eliminate dead code and cargo cult patterns (-1,286 lines) (#334)
* refactor: eliminate cargo cult patterns in PivotTable and Range commands - Create PivotTableHelpers class with centralized OLAP detection: - IsOlapPivotTable() - boolean check with COM cleanup - TryGetCubeFields() - returns cubeFields for subsequent operations - Replace duplicated OLAP detection try-catch blocks across 8 files: - PivotTableCommands.Fields.cs - PivotTableCommands.Lifecycle.cs - PivotTableCommands.cs - PivotTableCommands.CalculatedMembers.cs - PivotTableCommands.CalculatedFields.cs - OlapPivotTableFieldStrategy.cs - RegularPivotTableFieldStrategy.cs - PivotTableFieldStrategyFactory.cs - Fix nullable bool comparisons (== true -> is true): - RangeCommands.Validation.cs - OlapPivotTableFieldStrategy.cs (3 instances) - PowerQueryCommands.Helpers.cs Fixes #333 * refactor: eliminate PivotTable strategy execution boilerplate - Create ExecuteWithStrategy<TResult> helper method centralizing: - PivotTable lookup via CoreLookupHelpers.FindPivotTable - Strategy creation via PivotTableFieldStrategyFactory - Operation execution with proper COM cleanup in finally block - Refactor 12 methods to use helper (expression-bodied): - Fields: AddRowField, AddColumnField, AddValueField, AddFilterField, RemoveField, SetFieldFunction, SetFieldName - Grouping: GroupByDate, GroupByNumeric - Layout: SetLayout, Subtotals: SetSubtotals, GrandTotals: SetGrandTotals - CalculatedFields: CreateCalculatedField - Analysis: SetFieldFilter, SortField - Remove unused 'using Sbroenne.ExcelMcp.ComInterop' from 4 files - Remove redundant null check in SetGrandTotals (FindPivotTable throws) Methods kept as-is (require context access or complex logic): - SetFieldFormat (needs ctx.FormatTranslator) - ListFields, GetData (complex iteration/extraction logic) - ListCalculatedFields, DeleteCalculatedField (OLAP-specific paths) Reduction: ~150 lines of duplicate boilerplate eliminated * refactor: eliminate redundant table null checks - Change TableCommands.FindTable to call CoreLookupHelpers.FindTable (which throws) instead of TryFindTable (which returns null) - Remove 22 redundant null checks across 9 TableCommands files: - Data.cs (2), Filters.cs (4), Lifecycle.cs (3) - NumberFormat.cs (2), Sort.cs (2), Structure.cs (4) - StructuredReferences.cs (1), Columns.cs (3), DataModel.cs (1) - Same pattern fix as PivotTable strategy execution: FindTable now throws, so callers don't need to check+throw Reduction: 88 lines of redundant null check boilerplate eliminated * refactor: remove dead aggregation helpers and consolidate VBA type mapping - Remove 3 unused methods from PivotTableCommands.cs (IsValidAggregationForDataType, GetValidAggregationsForDataType, GetComAggregationFunction) - Remove 1 unused method from OlapPivotTableFieldStrategy.cs (GetComAggregationFunction) - Add GetVbaModuleTypeName() helper to VbaCommands.cs - Replace 2 inline switch expressions with helper in VbaCommands.Lifecycle.cs Net reduction: 71 lines (17+/88-) * refactor: consolidate GetAreaName into PivotTableHelpers - Add GetAreaName() to PivotTableHelpers.cs as shared utility - Remove duplicated GetAreaName() from PivotTableCommands.cs (dead code) - Remove duplicated GetAreaName() from OlapPivotTableFieldStrategy.cs - Remove duplicated GetAreaName() from RegularPivotTableFieldStrategy.cs - Update all 8 usages to use PivotTableHelpers.GetAreaName() Net reduction: 27 lines (26+/53-) * refactor: consolidate GetAggregationFunctionFromCom into PivotTableHelpers * refactor: consolidate DetectFieldDataType into PivotTableHelpers - Move DetectFieldDataType from PivotTableCommands and RegularPivotTableFieldStrategy to PivotTableHelpers - Update 8 usages across 4 files to use centralized helper - Eliminates ~50 lines of duplicated data type detection logic * refactor: consolidate GetFieldUniqueValues into PivotTableHelpers - Add GetFieldUniqueValues to PivotTableHelpers (identical logic) - Remove dead code from PivotTableCommands.cs (method was defined but never called) - Remove duplicate from RegularPivotTableFieldStrategy.cs - Update 3 callers to use centralized helper - Eliminates ~40 lines of duplicated/dead code * refactor: consolidate ParseColor and ParseBorderStyle into FormattingHelpers * refactor: remove dead WithSessionAsync method * refactor: remove dead code (-937 lines) Removed unused code across all layers: Core: - IsValidTableName (TableCommands.cs) - never called - CreatePowerQueryPipeline, PowerQueryConfig, POWER_QUERY_DATA_MODEL_ERROR (ResiliencePipelines.cs) - RemoveQueryTablesFromSheet, CreateQueryTable (PowerQueryHelpers.cs) - RemoveQueryConnections, CreateQueryTableConnection, SetQueryLoadToDataModel, CheckQueryDataModelConfiguration (PowerQueryCommands.Helpers.cs) - GetConnectionNames, RemoveConnections (ConnectionHelpers.cs) - ExcelConstants.cs - entire file never referenced ComInterop: - SpinWaitDelayMs, XlExcel12Binary constants MCP Server: - style_names.md, powerquery_targetCellAddress.md - completion files never loaded - excel_datamodel.md - prompt content never wired up (info already in tool description) Tests: - CreateMultipleConnections (ConnectionTestHelper.cs) * refactor: remove dead completion handler infrastructure (-349 lines) Removed ExcelCompletionHandler.cs and supporting files which were written but never wired up to the MCP server (HandleCompletion never called). Deleted files: - ExcelCompletionHandler.cs (178 lines) - never registered with MCP - 7 completion markdown files (border_styles, border_weights, load_destination, privacy_level, table_styles, validation_operators, validation_types) Also cleaned up: - Removed LoadCompletion/LoadCompletionValues from MarkdownLoader.cs - Removed unused ListEmbeddedResources debugging method - Updated mcp-llm-guidance.instructions.md to reflect actual status * fix: suppress CA1031 warnings for intentional COM interop patterns --------- Co-authored-by: Stefan Broenner <stefan.broenner@microsoft.comm> |
||
|
Stefan Broenner
|
b375365c25 |
refactor(core): extract shared lookup utilities and simplify error messages (#332)
* refactor(core): extract shared lookup utilities and simplify error messages - Add CoreLookupHelpers with unified FindPivotTable and FindTable utilities - Add ExcelConstants for centralized constant values - Remove StringMatchingHelpers and 'Did you mean' suggestion patterns - Simplify error messages to factual statements (LLMs have list actions) - Standardize 56 'not found' exception messages with trailing periods - Refactor commands to use shared lookup utilities: - PivotTableCommands, ChartCommands, TableCommands - PowerQueryCommands, ConnectionCommands, SheetCommands - RangeCommands, NamedRangeCommands, VbaCommands Build: 0 warnings, 0 errors Tests: Range (6/6), Table (20/20) passed * Add missing Feature trait to PivotTableRefreshBehaviorTests --------- Co-authored-by: Stefan Broenner <stefan.broenner@microsoft.comm> |
||
|
Stefan Broenner
|
9a7b9d40fc |
chore: Misc fixes and ComInterop improvements (#331)
* Disable integration tests and Azure runner workflows - Rename integration-tests.yml to .disabled (Azure runner undeployed) - Rename deploy-azure-runner.yml to .disabled (infrastructure removed) - Update AZURE_SELFHOSTED_RUNNER_SETUP.md with disabled status notice - Update development-workflow.instructions.md to reflect disabled workflows * chore: Update MCP server.json schema to 2025-12-11 * refactor(ComInterop): reduce duplication and extract constants - Reduce Polly pipeline duplication with PipelineConfig record and factory method - Extract magic numbers to ComInteropConstants.cs (timeouts, sleep intervals, file formats) - Add OleMessageFilter registration guard with IsRegistered property - Make HResult constants public for external reference No functional changes - all existing tests pass. --------- Co-authored-by: Stefan Broenner <stefan.broenner@microsoft.comm> |
||
|
Stefan Broenner
|
959094f52e |
feat: Re-add Rename operations + session timeout fix (#330)
* docs: Update specs to reflect verified Data Model table rename limitation VERIFIED FINDING (2025-12-20): - ModelTable.Name is READ-ONLY in Excel COM API - Direct assignment throws TargetParameterCountException (HResult: 0x8002000E) - No workaround exists (tested: PQ rename, connection rename, refresh, save/reopen) Updated files: - research.md: Decision 2 corrected - rename is NOT POSSIBLE - spec.md: User Story 2 now expects error message, not success - data-model.md: Added Known Limitations section - plan.md: Phase 4 simplified to attempt + return clear error - tasks.md: US2 tasks simplified (no fallback logic) - quickstart.md: Added limitation caveat for Data Model rename * feat: Add Rename operations for Power Query and Data Model tables This feature adds rename capabilities to both Power Query and Data Model tools: - New 'Rename' action in excel_powerquery MCP tool - New 'powerquery rename' CLI command - Validates: empty names, no-op (same name), duplicate conflicts - Case-insensitive conflict detection - 10 integration tests covering all scenarios - New 'RenameTable' action in excel_datamodel MCP tool - New 'datamodel rename-table' CLI command - Handles Excel COM limitation: ModelTable.Name is read-only - For PQ-backed tables: renames underlying query, returns clear error explaining table name is cached - For non-PQ tables: returns clear error about immutability - 12 integration tests covering edge cases - RenameNameRules.cs: Shared validation (Normalize, IsEmpty, IsNoOp, HasConflict) - COM object cleanup in finally blocks per CRITICAL-RULES - Exception propagation via batch.Execute() pattern - 6 MCP contract tests + 2 smoke tests added - Operation counts: MCP 180->182, CLI 172->174 - All READMEs updated (root, MCP Server, CLI, VS Code extension, gh-pages) - FEATURES.md updated with new operations - Quickstart examples for both CLI and MCP usage Resolves spec: 001-rename-queries-tables All 33 tasks complete (T001-T033) * docs: Mark all tasks complete after implementation recovery * fix: Increase session close timeouts to handle large files The STA thread join timeout (10s) was shorter than the Excel.Quit() timeout (30s), causing Dispose() to return before Excel finished closing. This resulted in intermittent 'file still open' issues when session close was reported. Changes: - Excel.Quit() timeout: 30s -> 2 minutes (handles large file saves) - STA thread join timeout: 10s -> 2.5 minutes (quit timeout + margin) --------- Co-authored-by: Stefan Broenner <stefan.broenner@microsoft.comm> |
||
|
Stefan Broenner
|
cdde003927 |
Revert "feat: Add Rename operations for Power Query and Data Model tables + p…" (#327)
This reverts commit
|
||
|
Stefan Broenner
|
316df5ae02 |
feat: Add Rename operations for Power Query and Data Model tables + performance optimizations (#326)
* feat: Add Rename operations for Power Query and Data Model tables This feature adds rename capabilities to both Power Query and Data Model tools: ## Power Query Rename - New 'Rename' action in excel_powerquery MCP tool - New 'powerquery rename' CLI command - Validates: empty names, no-op (same name), duplicate conflicts - Case-insensitive conflict detection - 10 integration tests covering all scenarios ## Data Model RenameTable - New 'RenameTable' action in excel_datamodel MCP tool - New 'datamodel rename-table' CLI command - Handles Excel COM limitation: ModelTable.Name is read-only - For PQ-backed tables: renames underlying query, returns clear error explaining table name is cached - For non-PQ tables: returns clear error about immutability - 12 integration tests covering edge cases ## Implementation Details - RenameNameRules.cs: Shared validation (Normalize, IsEmpty, IsNoOp, HasConflict) - COM object cleanup in finally blocks per CRITICAL-RULES - Exception propagation via batch.Execute() pattern - 6 MCP contract tests + 2 smoke tests added ## Documentation Updated - Operation counts: MCP 180->182, CLI 172->174 - All READMEs updated (root, MCP Server, CLI, VS Code extension, gh-pages) - FEATURES.md updated with new operations - Quickstart examples for both CLI and MCP usage ## Tests: 140 passing (130 Core + 10 MCP) Resolves spec: 001-rename-queries-tables All 33 tasks complete (T001-T033) * perf: optimize COM interop for bulk writes and idle CPU usage - TableCommands.Append: Replace cell-by-cell writing with bulk range write Uses single Value2 array assignment instead of N×M individual COM calls Provides 100x+ performance improvement for large data appends - ExcelBatch message pump: Replace Thread.Sleep(10) polling with async wait Uses WaitToReadAsync for efficient blocking until work is available Reduces idle CPU usage from ~1-5% to near-zero Tested: 20/20 Table tests passed, 84/84 ComInterop tests passed |
||
|
Stefan Broenner
|
6dc30ebe1e |
docs: Document unresolved 0x800A03EC Power Query update error (#324)
- Document Scenario 15 in COM-API-BEHAVIOR-FINDINGS.md - Remove ineffective Polly retry code (retry doesn't help with this error) Attempted solutions that did NOT work: - Save-and-retry: Saving workbook programmatically - Polly retry with backoff: Error is not transient - File location: Copying from OneDrive to local drive Root cause unknown. Workaround: manually save and reopen in Excel UI. Related to #323 Co-authored-by: Stefan Broenner <stefan.broenner@microsoft.comm> |
||
|
Stefan Broenner
|
501cbb2284 |
fix: add specific exception types to bare catches in production code (#321)
Fixes cs/catch-of-all-exceptions CodeQL alerts by adding specific exception types to bare catch blocks in COM interop code. Changes: - PowerQueryCommands.Lifecycle.cs: 6 catches fixed with COMException/TargetInvocationException filters - OlapPivotTableFieldStrategy.cs: 13 catches fixed with COMException/RuntimeBinderException filters - PivotTableCommands.cs: 4 catches fixed with COMException/RuntimeBinderException filters - NumberFormatTranslator.cs: 1 catch fixed with COMException/RuntimeBinderException filter - DaxFormulaTranslator.cs: 1 catch fixed with COMException/RuntimeBinderException filter - ConnectionCommands.Lifecycle.cs: 1 catch fixed with COMException Also updates CodeQL configuration to exclude test files from catch-of-all-exceptions rule since test cleanup code intentionally catches all exceptions for best-effort teardown. Total: 26 bare catches fixed in production code, test exclusions configured. Verified: Build succeeds with 0 warnings, 59 PowerQuery tests pass. Co-authored-by: Stefan Broenner <stefan.broenner@microsoft.comm> |
||
|
Stefan Broenner
|
f5ee37afc0 |
fix: address remaining code scanning alerts (#320)
- PivotTableCommands.CalculatedMembers.cs: Add comments to empty catch blocks for COM property probing - DataModelCommands.Write.cs: Remove unused wasActive variable Build: 0 warnings, 0 errors Co-authored-by: Stefan Broenner <stefan.broenner@microsoft.comm> |
||
|
Stefan Broenner
|
520b209308 |
fix: resolve code scanning alerts for generic catch clauses (#319)
* fix: resolve code scanning alerts for generic catch clauses Production code changes: - DataModelCommands.Helpers.cs: Use exception filter for COMException or RuntimeBinderException for COM property probing - DataModelCommands.Write.cs: Remove unused variable, use COMException catches - PivotTableCommands.*.cs: Replace bare catches with COMException - OlapPivotTableFieldStrategy.cs, RegularPivotTableFieldStrategy.cs: Use COMException - Program.cs (McpServer): Add pragma for top-level exception handler Test code changes: - DataModelComApiBehaviorTests.cs: Add file-level pragma for CS1061, use COMException for COM probing - PowerQueryComApiBehaviorTests.cs: Use COMException - PivotTableRefreshBehaviorTests.cs, ExcelBatchTests.cs: Add CA1031 pragmas for cleanup code - SessionManagerOperationTrackingTests.cs: Use typed Exception catch Build: 0 warnings, 0 errors Tests: DataModel (49 passed), PivotTables (78 passed) * fix: add pragmas for remaining diagnostic test catch clauses DataModelComApiBehaviorTests.cs lines 944, 1620: - Add CA1031 pragmas for catch blocks that intentionally log exceptions --------- Co-authored-by: Stefan Broenner <stefan.broenner@microsoft.comm> |
||
|
Stefan Broenner
|
3022b60a21 |
perf: COM interop optimizations and resilience improvements (#317)
perf: COM interop optimizations and resilience improvements - Modernize COM interop to use .NET 8 source generation - Add exponential backoff to OLE message filter - Add Polly resilience pipelines for Power Query (0x800A03EC) and Data Model (0x800AC472) operations - Update .NET dependencies to latest versions Fixes #315, #316 |
||
|
Stefan Broenner
|
c5f6375bdd |
feat(datamodel): improve LLM guidance and reduce timeout to 2 minutes (#305)
- Add DESTRUCTIVE OPERATIONS WARNING to tool description - Add recovery guidance (use update-measure, not delete-table) - Create excel_datamodel.md troubleshooting prompt file - Reduce operation timeout from 5 minutes to 2 minutes Closes #003-datamodel-llm-guidance Co-authored-by: Stefan Broenner <stefan.broenner@microsoft.comm> |
||
|
Stefan Broenner
|
e46dc3a743 |
feat(sdk): upgrade ModelContextProtocol to 0.5.0-preview.1 (#301)
* feat(sdk): upgrade ModelContextProtocol to 0.5.0-preview.1 ## Changes - Bump ModelContextProtocol from 0.4.1-preview.1 to 0.5.0-preview.1 - Migrate EnumerateToolsAsync to ListToolsAsync (SDK breaking change) - Fix MCP Server test isolation with xUnit Collection pattern - Fix SheetCommand to output JSON for mutation operations ## Test Results - Build: 0 warnings, 0 errors - MCP Server Tests: 66/66 passing - CLI Tests: 2/2 passing - Core Tests (PowerQuery): 49/49 passing - Core Tests (Tables): 20/20 passing ## Documentation - Added impact-report.md with SDK change mapping - Added validation-plan.md with rollback procedure * feat(sdk): add .NET console best practices - Exit code handling: 0 on success/graceful shutdown, 1 on fatal error - Stdout purity: Changed 8 Console.WriteLine to Console.Error.WriteLine in Core PivotTable commands - Updated impact-report.md with Phase 6-7 changes - Updated tasks.md and validation-plan.md * docs: complete SDK upgrade documentation - Added v1.4.35 to CHANGELOG.md with SDK upgrade summary - Updated tasks.md with Phase 8 completion status - Updated PR #301 with comprehensive description * feat(sdk): add SDK 0.5.0 metadata to all tools - Added Title property to all 12 tools (human-readable display name) - Added requiresSession metadata hint to all tools - Added fileFormat metadata to excel_vba (.xlsm requirement) - Build passes: 0 warnings, 0 errors - MCP Server tests: 66/66 passing * feat: update HTML layout and enhance index with new project link |
||
|
Stefan Broenner
|
3b4e872b13 |
fix(power-query): Handle COM error when regular Excel tables present (#303)
When Power Query commands (View/Update) iterated ListObjects, they failed with COM error 0x800A03EC when regular Excel tables were present because accessing .QueryTable on non-query tables throws. Changes: - PowerQueryCommands.View.cs: Wrap listObj.QueryTable access in try-catch, skip non-query tables - PowerQueryCommands.Update.cs: Wrap listObj.QueryTable access in try-catch, skip non-query tables - Add regression tests for View and Update with manual tables present - Verify ListObjects iteration is robust to mixed table types Regression tests: - View_WorkbookWithManualTable_ReturnsQueryDetails - Update_WorkbookWithManualTable_UpdatesQuerySuccessfully All Power Query integration tests pass (14 tests). Co-authored-by: Stefan Broenner <stefan.broenner@microsoft.comm> |
||
|
Stefan Broenner
|
7a0de48e0f |
## Summary (#300)
* chore: clean up package references, improve null handling, and remove obsolete tests * Added GitHub SpecKit * chore: update constitution with core principles, technical constraints, and development workflow * chore: update constitution with improved documentation links and clarify development guidelines |
||
|
Stefan Broenner
|
23142a13a5 |
fix: prevent orphaned Power Query connections during worksheet loading (#299)
Root Cause:
ListObjects.Add() with connection STRING creates orphaned connections
with generic names (Connection, Connection1, etc.)
Solution:
- Use Connections.Add2() to create properly named connections first
- Pass connection OBJECT to ListObjects.Add() to reuse the connection
- For LoadToBoth: create TWO connections with distinct names:
- Worksheet: 'Query - {name}'
- Data Model: 'Query - {name} (Data Model)'
- Updated pattern matching in Delete/Unload/List/GetLoadConfig
Test Coverage:
- 14 new worksheet cleanup tests
- 9 lifecycle cleanup tests
- All 74+ Power Query tests passing
Fixes #298
Co-authored-by: Stefan Broenner <stefan.broenner@microsoft.comm>
|
||
|
Stefan Broenner
|
66196cfb68 |
docs: update tool/operation counts and lists to match code (#290)
Fixes #289 - Update MCP Server: 12 tools, 180 operations - Update CLI: 13 command groups, 172 operations - Fix gh-pages/index.md operation tables: - PivotTables: 25 → 30 (added calculated fields/members, grouping, layout) - DataModel: 15 → 16 (added delete-table) - File: 5 → 6 (added list) - Worksheets: added set-visibility - Removed non-existent operations from tables - Update readme-management.instructions.md with verification guidance - Update GitHub repo description and topics Co-authored-by: Stefan Broenner <stefan.broenner@microsoft.comm> |
||
|
Stefan Broenner
|
a4c90850b1 |
feat: Add list and delete operations for calculated fields and calculated members (#288)
- Add ListCalculatedFields and DeleteCalculatedField for regular PivotTables - Add ListCalculatedMembers and DeleteCalculatedMember for OLAP PivotTables - Add CalculatedFieldInfo and CalculatedFieldListResult model types - Update MCP Server tool with new action handlers - Add comprehensive test coverage (16 total tests) Fixes #287 Co-authored-by: Stefan Broenner <stefan.broenner@microsoft.comm> |
||
|
Stefan Broenner
|
b00ee54dfe |
perf: Optimize PivotTable RefreshTable() calls (#286)
* perf: Remove unnecessary RefreshTable() calls and optimize test fixtures Performance optimizations: 1. Remove unnecessary RefreshTable() from visual-only operations: - SetFieldFormat (OLAP + Regular) - NumberFormat is visual only - SetSubtotals (OLAP + Regular) - removed 2 calls each - SetLayout (OLAP + Regular) - layout changes don't need refresh - SetGrandTotals (OLAP + Regular) - visual setting - SortField (OLAP + Regular) - sorting is visual - SetFieldName (Regular only) - OLAP throws exception 2. Fix SetFieldFunction measure lookup bug: - Added NormalizeMeasureName() helper to extract measure name from [Measures].[Name] format - Fixed lookup to use normalized name 3. Optimize test fixture sharing: - Changed from IClassFixture (1 fixture per class) to ICollectionFixture (1 fixture for ALL classes) - Created DataModelTestsDefinition collection for 6 test classes - Reduces fixture setup from ~9 min to ~1.5 min 4. Fix test measure name conflict: - Changed AddValueField test to use 'Regional Sales Total' instead of 'Total Sales' Total RefreshTable() calls removed: 13 Test classes now sharing fixture: 6 * test: Add diagnostic tests for RefreshTable() behavior Add 9 raw Excel COM API tests to empirically determine: - Which PivotTable operations require RefreshTable() - Which operations work immediately without RefreshTable() - Persistence behavior with and without RefreshTable() Key findings documented: - Structural changes (Orientation) need RefreshTable() for persistence - Visual properties (NumberFormat) work after structure is refreshed - In-memory operations don't need refresh for immediate effect * perf: Remove 2 more unnecessary RefreshTable() calls Based on diagnostic tests proving persistence works without refresh: - SetFieldFunction: Function changes persist without RefreshTable() - SetFieldFilter: Filter changes persist without RefreshTable() Added 2 new diagnostic tests: - FunctionChange_Persistence_WithoutRefresh_VerifySaveAndReopen - FilterChange_Persistence_WithoutRefresh_VerifySaveAndReopen Total RefreshTable() calls removed: 15 (13 initial + 2 additional) --------- Co-authored-by: Stefan Broenner <stefan.broenner@microsoft.comm> |
||
|
Stefan Broenner
|
1b4f9bfdcf |
feat: Add Docker support for Glama.ai MCP registry integration (#284)
Adds Dockerfile and supporting files to enable Glama.ai to inspect and discover the Excel MCP server's tools. New files: - Dockerfile: Multi-stage build for Linux container (inspection only) - .dockerignore: Optimize Docker build context - glama.json: Glama registry metadata - docs/GLAMA-DOCKER-SUPPORT.md: Documentation Code quality improvements (removed .editorconfig suppressions): - Remove unused TimeSpan? parameter from ExcelSession.CreateNew - Add missing XML docs to IRangeCommands.SetValues - Make Unload() and FindTableAndColumn() static (CA1822) - Update test callers to use static method syntax - Change CA1822 from suggestion to warning in .editorconfig - Remove CS1573 suppression from .editorconfig Fixes #283 Co-authored-by: Stefan Broenner <stefan.broenner@microsoft.comm> |
||
|
Stefan Broenner
|
0bb29be3be |
feat: DAX formula locale handling for European locales (#282)
* Fix #279: Power Query lifecycle cleanup for Data Model connections BREAKING CHANGES: - Unload now removes Data Model connections (not just worksheet tables) - Delete now removes Data Model connections (prevents orphan connections) IMPROVEMENTS: - List correctly reports IsConnectionOnly for Data Model-only queries - Update uses connection.Refresh() fallback for Data Model-only queries (no worksheet table to refresh) NEW TESTS: - PowerQueryCommandsTests.LifecycleCleanup.cs: 8 tests for Issue #279 - PowerQueryCommandsTests.UpdateErrors.cs: 3 tests for error handling - DataModelComApiBehaviorTests.cs: 11 diagnostic scenarios - PowerQueryComApiBehaviorTests.cs: 15 diagnostic scenarios DOCUMENTATION: - docs/COM-API-BEHAVIOR-FINDINGS.md: Empirical COM API behavior findings - excel_powerquery.md: Updated prompt docs for Data Model cleanup DELETED: - PowerQueryCommandsTests.ErrorQueries.cs: Referenced non-existent local file All 53 PowerQuery and DataModel tests pass. * fix: Use locale-aware format translation instead of global Excel settings - Renamed DateFormatTranslator to NumberFormatTranslator - Extended translator to handle decimal/thousands separators (. and ,) - Removed global UseSystemSeparators/DecimalSeparator/ThousandsSeparator settings from ExcelSession and ExcelBatch (these modified Excel app defaults) - Added IsEnglishNumberLocale property to detect US-style number separators - Format codes are now translated at point of use, not by changing app defaults - Updated all references from DateFormatter to FormatTranslator - Removed unused WithUSFormatSeparators helper from RangeCommands This approach translates US format codes (like $#,##0.00) to locale-specific codes (like $#.##0,00 on German Excel) without modifying Excel's global settings. Previous approach of changing Application.DecimalSeparator affected all workbooks in the Excel instance, which is not desirable. * feat: DAX formula locale handling for European locales (#281) - Add DaxFormulaTranslator to convert US comma separators to semicolons on European locales - Integrate translator in CreateMeasure and UpdateMeasure operations - Power Pivot uses system culture (CultureInfo.CurrentCulture), not Excel International settings - Preserve commas inside string literals and column references - Add 5 integration tests for DAX locale translation |
||
|
Stefan Broenner
|
827704e63e |
feat(datamodel): add read-relationship action for viewing individual relationships (#278)
Adds the read-relationship action to excel_datamodel tool, completing full CRUD coverage for relationships in the Data Model. Changes: - Add DataModelRelationshipViewResult result type - Add ReadRelationship method to IDataModelCommands interface - Implement ReadRelationship in DataModelCommands.Read.cs - Add ReadRelationship enum value to DataModelAction - Add action string mapping for read-relationship - Add ReadRelationshipAsync handler in ExcelDataModelTool Documentation: - Update FEATURES.md with 15 Data Model operations (was 14) - Update all READMEs with 173 total operations (was 172) - Update gh-pages/index.md with new action in reference table - Document hidden columns/relationships/measures API limitation Closes #277 |
||
|
Stefan Broenner
|
b6bcd97219 |
feat: Replace session-based cross-workbook operations with atomic file operations (#274)
- Replace copy-to-workbook and move-to-workbook with copy-to-file and move-to-file - Remove unused targetSessionId parameter from worksheet tool - Fix sheet positioning bug when copying with beforeSheet/afterSheet - Add excel_worksheet.md prompt file for LLM cross-file operation guidance - Add ExcelWorksheetPrompts.cs to register the prompt - Update all documentation and comments to reflect new operation names Closes #273 |
||
|
Stefan Broenner
|
abfea2859d |
fix: GetLoadConfig incorrectly detects LoadToBoth as LoadToTable (#271) (#272)
- Simplified GetLoadConfig to use WorkbookConnection.InModel property - Removed legacy fallback logic (DataModel_ markers, Named Range markers) - Added 8 comprehensive tests for all PowerQueryLoadMode values - All tests pass (ConnectionOnly, LoadToTable, LoadToDataModel, LoadToBoth) |
||
|
Stefan Broenner
|
c8eb20349d |
Fix CreateFromPivotTable for OLAP/Data Model PivotTables (#268)
* Fix CreateFromPivotTable for OLAP/Data Model PivotTables Fixes #267 The PivotCache.CreatePivotChart() method has unreliable COM parameter binding with dynamic types, throwing DISP_E_UNKNOWNNAME for OLAP sources. Solution: Use unified Shapes.AddChart() + Chart.SetSourceData() approach that works for all PivotTable types (range-based, table-based, and OLAP). Changes: - ChartCommands.Lifecycle.cs: Unified implementation for all PivotTables - ChartCommandsTests.Lifecycle.cs: Added 3 tests for regular PivotTables - ChartCommandsTests.OlapPivotChart.cs: New file with 6 OLAP-specific tests All 35 Chart feature tests pass. * fix: update CHANGELOG for OLAP PivotChart Creation support in CreateFromPivotTable |
||
|
Stefan Broenner
|
3fae0b51ac |
fix: locale-independent number and date format handling (#264)
Fixes #263 - Force US separators (UseSystemSeparators=false) at Excel instance creation - Add DateFormatTranslator to translate US date codes (d/m/y) to locale codes - Fix OlapPivotTableFieldStrategy.SetFieldFormat for pre-existing measures - Update LLM documentation to guide use of US format codes - Add 6 date translation tests + 2 PivotTable format tests |
||
|
Stefan Broenner
|
b48d12cdf0 |
fix: OLAP PivotTable AddValueField disambiguation and AddDataField fix (#261) (#262)
* fix: use AddDataField() instead of Orientation for OLAP measures Fixes #261 The previous approach of setting cubeField.Orientation = xlDataField could fail with E_INVALIDARG (0x80070057) for CubeFields in certain states (e.g., long-lived workbooks, complex Data Model configurations). Using pivot.AddDataField(cubeField) is more robust and works consistently for all CubeFieldTypes. Changes: - MODE 1 (pre-existing measure): Use AddDataField() at line 360 - MODE 2 (auto-create measure): Use AddDataField() at line 474 - Added comments explaining why this approach is preferred * fix: OLAP PivotTable measure disambiguation uses exact matching only BREAKING: Removed Contains() partial matching that caused [Measures].[ACR] to incorrectly match table columns like [ACR Types].[ACRTypeKey]. Fixes: - Issue 1: AddValueField now uses cubeFields.Item(fieldName) for exact match - Issue 2: ListFields correctly reports field area after AddValueField - Issue 3: Response confirmation now shows correct field added Changes: - OlapPivotTableFieldStrategy.cs: GetCubeFieldByName uses exact matching only - PivotTableCommands.cs: GetFieldByName uses same exact matching pattern - Consolidated DataModelTestsFixture + PivotTableRealisticFixture into unified DataModelPivotTableFixture with disambiguation test data - Added 4 new disambiguation tests validating exact matching behavior Test coverage: 20 tests pass (4 disambiguation + 4 DataModel PivotTable + 12 DataModel commands) |
||
|
Stefan Broenner
|
299ee68703 |
feat: Locale-aware number formatting & LLM guidance improvements (#260)
* feat(range): Add locale-aware number formatting with separate actions PROBLEM: - Format codes like '\$#,##0.00' interpreted incorrectly on non-US locales - German Excel treated '.' as thousands separator, ',' as decimal - LLM API had confusing design with 'formatCode OR numberFormatCategory' SOLUTION: 1. Use NumberFormatLocal instead of NumberFormat (interprets locale correctly) 2. Use LocaleAwareFormatBuilder to generate format codes using CultureInfo 3. Separate into two clean actions for better LLM usability: - SetNumberFormat: Structured params only (numberFormatCategory required) - SetNumberFormatCustom: Raw formatCode only (expert use) NEW FILES: - NumberFormatOptions.cs: Enums and LocaleAwareFormatBuilder MODIFIED: - RangeCommands.NumberFormat.cs: NumberFormatLocal + SetNumberFormatStructured - ExcelRangeTool.cs: Two separate actions, cleaner parameter routing - ToolActions.cs: SetNumberFormatCustom enum added - ActionExtensions.cs: set-number-format-custom mapping - audit-core-coverage.ps1: Added SetNumberFormatCustom to known exceptions - check-mcp-core-implementations.ps1: Added SetNumberFormatCustom to known exceptions VERIFIED: - German locale shows correct formats: EUR#.##0,00, 0,0%, #.##0,00 - Build passes with 0 warnings - All pre-commit checks pass * docs(range): Add LLM guidance for number formatting actions - Add [Description] attribute to excel_range tool with number formatting guidance - Create excel_range.md prompt with detailed action comparison - Create ExcelRangePrompts.cs to expose prompt via MCP Guidance helps LLMs choose between: - SetNumberFormat: RECOMMENDED, locale-aware, structured parameters - SetNumberFormatCustom: Expert use, raw format codes, locale-sensitive * docs: Update instructions to use XML documentation instead of [Description] MCP SDK now extracts tool descriptions from XML documentation (/// <summary>) rather than [Description] attributes. Updated files: - mcp-server-guide.instructions.md: XML docs guidance and examples - critical-rules.instructions.md: Rule 18 now shows XML doc patterns - bug-fixing-checklist.instructions.md: Reference XML docs not [Description] - ExcelRangeTool.cs: Move description to XML docs, remove [Description] * docs: Add guidance to ask user before closing when showExcel=true When Excel is visible (showExcel=true), the user is actively watching. LLM should ask before closing instead of auto-closing, since user may want to inspect results, make manual changes, or continue working. Updated files: - Program.cs: Server instructions with new 'ASK BEFORE CLOSING' section - ExcelFileTool.cs: XML docs with same guidance * feat: Add operation tracking to prevent premature session close - Add BeginOperation/EndOperation tracking in SessionManager - Block Close action when operations are still running - Add ValidateClose method with CloseValidationResult record - Enhanced List action to return activeOperations, canClose, isExcelVisible - Add force parameter to CloseSession for emergency override - Track showExcel flag per session for visibility status - Updated server instructions about automatic operation tracking - Fixed missing FileAction.List mapping in ActionExtensions Tests: - 18 new unit tests for SessionManager operation tracking - 4 new MCP integration tests for ExcelFileTool operation tracking This prevents data loss from closing sessions while parallel operations are still running. The server now automatically tracks operations and returns a blocking error with activeOperations count if close is attempted while operations are in progress. * feat(datamodel): add DeleteTable action to remove orphaned Data Model tables - Add DeleteTable to DataModelAction enum and ToActionString mapping - Add DeleteTable method to IDataModelCommands interface - Implement DeleteTable using SourceWorkbookConnection.Delete() pattern (ModelTable is read-only, must delete via associated connection) - Add DeleteTable handler in ExcelDataModelTool - Add 3 integration tests covering success and error scenarios This allows cleanup of orphaned tables when Power Query is deleted and recreated with loadDestination: data-model. * fix(connection): correct error message for Power Query connection deletion Changed error message from outdated 'pq-delete' to correct 'excel_powerquery with action Delete' when user attempts to delete a Power Query connection via excel_connection tool. * Simplify number formatting: auto-LCID for date/time, streamlined docs - Add EnsureDateTimeLcid() to automatically prefix date/time formats with [$-409] - LLMs no longer need to know about LCID - just use 'mm/dd/yyyy' directly - Currency symbols ($, €, £, ¥) are literal - no special handling needed - Simplified excel_range.md from 95 lines to 28 lines (one table, essentials only) * Simplify telemetry: remove redundant TrackPageView - Remove TrackPageView call (Usage blades don't work for console apps) - Keep TrackEvent for tool usage analytics (customEvents table) - Keep TrackRequest for performance metrics (Performance blade) - Update documentation to reflect simplified telemetry model * Track unhandled exceptions and file context in telemetry - Add try-catch in Program.Main() to track MCP SDK/transport errors - Pass excelPath to TrackToolInvocation for file-level analytics grouping - Ensures telemetry is flushed before exit on unhandled exceptions * docs: fix showExcel default guidance and incorrect action names - Fix ServerInstructions to clarify showExcel:false is DEFAULT (not showExcel:true) - Update tool description to emphasize default is hidden/faster mode - Fix incorrect pivottable actions: 'create' with sourceType -> 'create-from-table'/'create-from-datamodel' - Remove non-existent 'create-bulk' action reference from namedrange examples - Fix NamedRangeCommands comment to match actual exposed operations - Update VS Code extension copilot-instructions with correct defaults and actions * docs: enhance copilot instructions for Excel MCP usage clarity * Merge origin/main: keep operation tracking features from this branch * fix: address GitHub Advanced Security warnings - Fix constant condition in ConnectionCommands (check HasValue before switch) - Add using statement for SessionManager in Dispose_CleansUpAllTracking test - Suppress CA3003 (Path.Combine) in test code - controlled inputs - Suppress CA1031 (generic catch) in test cleanup - best effort disposal - Use .Where() instead of if-in-foreach for filtering |
||
|
Stefan Broenner
|
b6e8899c12 |
docs: add List action documentation to excel_file tool (#258)
Improve tool documentation to highlight the List action for session verification: - Add SESSION VERIFICATION section at top of tool documentation - Document that List returns active sessions without Excel COM calls - Add workflow example: list -> check sessionId exists - Clarify List is the lightweight way to verify session existence - Add List to known exceptions in both audit scripts (MCP-specific action) This helps LLMs discover the proper way to verify sessions instead of using heavier operations like excel_chart or excel_worksheet List actions. |
||
|
Stefan Broenner
|
34b90e8349 |
fix: MCP Registry publishing - shorten description and fix README detection (#256)
- Shorten server.json description from 184 to 95 characters (MCP Registry limit is 100) - Fix workflow to decode Invoke-WebRequest byte array as UTF-8 string before regex matching Fixes #255 |
||
|
Stefan Broenner
|
2eec36317f |
fix: add [DefaultValue] attributes to MCP tool parameters for SDK 0.4.1 compatibility (#254)
MCP SDK 0.4.1-preview.1 uses AIFunctionFactory which treats ALL parameters as required unless they have a [DefaultValue] attribute. Partial methods cannot have C# default parameter values, so [DefaultValue] from System.ComponentModel is required. Changes: - Add [DefaultValue(null)] to all nullable parameters across 12 tool files - Add [DefaultValue(false/true)] to bool parameters as appropriate - Fix pre-commit.ps1 smoke test filter (was SmokeTest_AllTools_LlmWorkflow, now SmokeTest_AllTools_E2EWorkflow) - Add validation to pre-commit.ps1 to detect when no tests actually run (dotnet test returns exit code 0 even with zero matching tests) |
||
|
Stefan Broenner
|
762ffd3c34 |
fix: MCP Registry publishing - update version regex and metadata (#253)
- Fix regex to find 'packages' instead of 'title' after version field - Update server.json title/description to match .csproj metadata - Fix MCP Registry API URLs to use /v0.1/servers/ path Fixes #252 |
||
|
Stefan Broenner
|
bf0cd4f37d |
fix: release workflow YAML syntax and step ordering (#249)
* fix: correct YAML syntax for release notes markdown - Replace PowerShell here-string with string concatenation - Use single-quoted strings for markdown code block fences - Fixes workflow failure from invalid YAML parsing * docs: add Rule 23 - never dismiss IDE/linter warnings as false positives Added after incorrectly dismissing VS Code YAML errors that led to a broken GitHub Actions workflow. Rule now requires: - Trust tooling warnings by default - Verify with testing or documentation before dismissing - Use simpler approaches when uncertain * fix: move MCP Registry publishing to end of workflow |
||
|
Stefan Broenner
|
8fbd6f43fc |
Fix/nuget-mcpserver-package-type (#248)
* fix: add McpServer package type for NuGet and MCP Registry .NET 8 SDK unconditionally overwrites PackageType to DotnetTool when PackAsTool=true (Microsoft.NET.Sdk.Common.targets line ~47). This workaround adds a custom MSBuild target that runs before GenerateNuspec to append McpServer to the PackageType property after the SDK sets it. Fixes: - NuGet package now appears in MCP Server package type filter - MCP Registry should now properly detect and update version Verified: Generated nuspec contains both DotnetTool and McpServer types. * fix: update package descriptions and dependencies for improved clarity and compatibility |
||
|
Stefan Broenner
|
d72d8f8d1b |
Fix/remove-telemetry-diagnostics (#247)
* chore: remove telemetry diagnostic output
* chore: update packages to .NET 10 and MCP SDK 0.4.1-preview.1
- Microsoft.Extensions.Hosting: 9.0.10 -> 10.0.0
- Microsoft.Extensions.Logging: 9.0.10 -> 10.0.0
- Microsoft.Extensions.Configuration: 9.0.10 -> 10.0.0
- Microsoft.Extensions.DependencyInjection: 9.0.10 -> 10.0.0
- System.Text.Json: 9.0.10 -> 10.0.0
- ModelContextProtocol: 0.4.0-preview.3 -> 0.4.1-preview.1
All packages forward-compatible with .NET 8.0 runtime.
No breaking changes - verified build passes with 0 warnings.
* refactor: migrate MCP tools from [Description] attributes to XML documentation
- Convert all 12 tool files to use XML docs (/// <summary>, /// <param>)
- XML docs processed by MCP SDK's XmlToDescriptionGenerator source generator
- Remove all CA1861 pragma warnings and [SuppressMessage] attributes (not needed)
- Remove dead code: ThrowUnknownAction() and invalid action error handlers
- Add GlobalUsings.cs for Chart and Range namespaces
- Update mcp-server-guide.instructions.md with NO EMOJIS rule
The XmlToDescriptionGenerator converts XML comments to [Description] attributes
at compile time, providing better IDE support and documentation integration.
* feat(mcp): add tool categories and remove outdated LLM guidance
- Add [McpMeta("category", "...")] to all 12 tools for better LLM discovery
- Remove unhelpful LLM guidance (suggestedNextActions, retryGuidance, workflowHint, operationContext)
- Update ExcelResourceProvider to use excel_file sessions
Follows principle: state facts, not guidance - LLMs figure out next steps
* fix: add prominent warning to prevent premature session close
- Update ServerInstructions in Program.cs to explicitly warn LLMs:
- WAIT for ALL pending tool calls before closing
- Closing while operations running causes failures
- Expand excel_file tool description with detailed session lifecycle
- Addresses race condition where close was called during parallel operations
* feat: add showExcel parameter to watch Excel during automation
- Add showExcel parameter to excel_file open action
- When true, Excel window becomes visible during operations
- Perfect for debugging, demos, and learning what AI is doing
Implementation:
- ExcelFileTool: Added showExcel parameter to ExcelFile() and OpenSessionAsync()
- SessionManager: Added showExcel parameter to CreateSession()
- ExcelSession: Added BeginBatch overload with showExcel parameter
- ExcelBatch: Sets Excel.Visible based on showExcel flag
Server instructions:
- Added prominent session close warnings (wait for all operations)
- LLM instructed to proactively offer showExcel for complex tasks
- Example prompt: 'Would you like me to show Excel so you can watch?'
Documentation updated:
- README.md: User-facing section with natural language examples
- FEATURES.md: Added to File Operations section
- INSTALLATION.md: Added tip after test installation step
- gh-pages/index.md: Added tip to Interactive Development feature
- McpServer README: Added to AI-Powered Workflows list
- VS Code extension copilot-instructions.md: LLM guidance
|
||
|
Stefan Broenner
|
073f25450b |
refactor: simplify telemetry - always enabled, build-time connection string (#246)
* refactor: simplify telemetry - always enabled, build-time connection string - Remove opt-out functionality (EXCELMCP_TELEMETRY_OPTOUT) - Embed AppInsights connection string at build time via MSBuild - Add Directory.Build.props.user for local dev connection string - Remove runtime environment variable lookup for connection string - Update release workflows to pass connection string to build - Remove obsolete test.runsettings file - Simplify IsEnabled to always return true * refactor: consolidate prompts and improve tool descriptions - Reduce prompts from 14 to 2 (keep only high-value guides) - Remove 13 orphaned .md content files - Fix ExcelWorksheetTool incorrect 'save' action reference - Improve ExcelRangeTool and ExcelNamedRangeTool descriptions - Slim ServerInstructions to essential info only - Remove redundant telemetry flush (SDK handles automatically) * refactor(telemetry): disable dependency tracking for HTTP calls in telemetry configuration * test hook * fix: correct Application Insights telemetry context - Set Component.Version explicitly to override SDK auto-detection (was picking up Excel COM interop 15.0.0.0 instead of app 1.0.0) - Anonymize cloud_RoleInstance (was exposing machine name) - Now all telemetry context values are privacy-safe: - application_Version: from assembly metadata - cloud_RoleName: fixed 'ExcelMcp.McpServer' - cloud_RoleInstance: anonymous hash 'instance-xxxx' - user_Id: anonymous hash of machine identity - session_Id: random per session * fix: telemetry improvements for Users/Sessions analytics - Remove debug mode from telemetry (simplify code) - Fix PageView tracking to include duration (required for User Flows) - Always override application_Version (SDK picks up Excel 15.0.0.0) - Add explicit Flush() call in smoke tests for reliable telemetry delivery - Fix smoke test shutdown to use graceful shutdown before cancellation Telemetry now correctly populates: - requests table (with duration, success, resultCode) - pageViews table (with duration for User Flows) - user_Id and session_Id (for Users/Sessions blades) - application_Version (MCP Server version, not Excel) |
||
|
Stefan Broenner
|
403ecfaf73 |
fix: replace empty catch blocks with specific exception types (#244)
* fix: replace empty catch blocks with specific exception types (#213) - NamedRangeCommands.Operations.cs: Replace empty catch blocks with COMException handlers for COM interop resilience - PowerQueryCommands.Lifecycle.cs: Replace generic Exception catch with COMException for accurate error handling - ExcelComSmokeTests.cs: Replace empty catches with InvalidOperationException and Win32Exception handlers for process cleanup Addresses CodeQL alerts: cs/empty-catch-block, cs/catch-of-all-exceptions Fixes #213 * fix: replace additional empty catch blocks with specific exception types - VbaCommands.cs: Replace empty catch and generic catch with SecurityException for registry access operations - PowerQueryCommands.Lifecycle.cs: Replace empty catch with COMException for CommandText property access - PivotTableCommands.Lifecycle.cs: Replace empty catches with COMException for field count access (RowFields, ColumnFields, DataFields, PageFields) - DataModelCommands.Read.cs: Replace empty catches with COMException and RuntimeBinderException for FormatInformation/FormatString access All catches now have specific exception types and explanatory comments. * chore: configure CodeQL suppressions for intentional patterns Suppress CodeQL alerts for legitimate exception handling patterns: - MCP Tools: catch(Exception) required for JSON error responses (MCP protocol) - CLI Commands: catch(Exception) for user-friendly error messages - COM Interop: exception handling at session boundaries for cleanup - Dynamic COM: late binding is standard pattern for Excel automation - GC.Collect: required for COM object cleanup per Microsoft guidance - Test paths: Path.Combine safe in isolated test directories - Generated code: Regex generator output triggers false positives These patterns are intentional by design, not bugs to fix. |
||
|
Stefan Broenner
|
f44c23e478 |
feat(telemetry): Switch to Application Insights SDK for full Usage analytics (#243)
Replace OpenTelemetry with Application Insights SDK to enable Users, Sessions, Funnels, and User Flows analytics in Azure portal. Changes: - Remove OpenTelemetry packages - Use Microsoft.ApplicationInsights SDK directly (v2.23.0) - Add ExcelMcpTelemetryInitializer for User.Id/Session.Id context - Simplify ExcelMcpTelemetry to use TelemetryClient.TrackEvent() - Convert to static SensitiveDataRedactor - Update .NET SDK to 8.0.416 Fixes #239 |
||
|
Stefan Broenner
|
d7a2d3d24b |
feat: Add Application Insights telemetry via OpenTelemetry (#240)
- Add OpenTelemetry + Azure Monitor for usage tracking and unhandled exceptions - Implement SensitiveDataRedactingProcessor to protect file paths/connection strings - Add telemetry to all 12 MCP tools via ExecuteToolAction pattern - Support opt-out via EXCELMCP_TELEMETRY_OPTOUT environment variable - Add debug mode via EXCELMCP_DEBUG_TELEMETRY for local testing (console output) - Build-time connection string injection in release workflow - Add Bicep templates for Azure Application Insights deployment - Add 29 tests (28 unit + 1 integration) for telemetry components - Update developer docs with telemetry setup instructions Closes #239 |
||
|
Stefan Broenner
|
d2fcc5f527 |
Fix Rule 1b violation in PowerQuery List() (#238)
* Fix Rule 1b violation in PowerQuery List() outer catch block - Remove catch block creating fake 'Error Query' entries - Replace with continue statement to skip problematic queries - Prevents exception suppression (Rule 1b compliance) - Allows fault-tolerant listing: one bad query doesn't break entire list - All 16 PowerQuery tests pass * Remove inefficient try-catch in PowerQuery Refresh() - Remove inner try-catch that suppressed COMException - Let exceptions propagate naturally (Rule 1b) - Remove complex fallback logic checking Success flag - Simpler, more efficient: just throw on error - All 16 PowerQuery tests pass * Enforce sequential test execution and remove obsolete test - Add xunit.runner.json to all test projects (Core, CLI, McpServer) - Configure parallelizeAssembly: false, maxParallelThreads: 1 - Remove obsolete VbaCommandsTests.Trust.TrustScope.cs (skipped test) - Ensures stable test execution for Excel COM interop |
||
|
Stefan Broenner
|
2828175d8c |
Fix PowerQuery List() returning 'Error Query' for workbooks with manual tables (#237)
Fixes #236 Problem: - List() returned fake 'Error Query' entries when workbooks contained manually created Excel tables (ListObjects without QueryTables) - Accessing listObject.QueryTable on manual tables throws 0x800A03EC - Outer catch block suppressed exceptions and created fake entries Solution: - Add specific try-catch for QueryTable access that continues on 0x800A03EC - Manual tables are now skipped gracefully during IsConnectionOnly detection - Queries return with correct names and formulas Changes: - PowerQueryCommands.Lifecycle.cs: Handle 0x800A03EC for QueryTable access - Tests: Add regression test with user file + synthetic test - Tests: Add diagnostic test to pinpoint exception location Test results: - All 16 PowerQuery tests pass - New regression tests verify fix works |
||
|
Stefan Broenner
|
0b6003ec09 |
docs: align all READMEs to MCP-first messaging, add centralized FEATURES.md (#235)
feat(table): add get-data action (CLI + MCP) with visible-only filtering tests(tables): add GetData coverage (unfiltered + filtered) chore: update readme-management instruction counts to 12 tools / 172 operations |
||
|
Stefan Broenner
|
6b3a557870 |
refactor: Migrate entire codebase to exception-based pattern (void mutations, no OperationResult suppression) (#233)
* Refactor MCP tools to share error handling
* Refactor Core Commands to remove exception suppression
Per CRITICAL-RULES.md Rule 1b:
- Removed catch blocks that suppress exceptions by returning OperationResult { Success = false }
- Let exceptions propagate naturally through batch.Execute()
- Kept finally blocks for COM resource cleanup
- Removed orphaned try blocks from methods with no COM cleanup needs
Modified files:
- RangeCommands.AutoFit.cs (2 methods)
- RangeCommands.Advanced.cs (5 methods)
- RangeCommands.Validation.cs (3 methods)
- RangeCommands.Formatting.cs (3 methods)
- PivotTableCommands.GrandTotals.cs (1 method)
- OlapPivotTableFieldStrategy.cs (2 methods)
- RegularPivotTableFieldStrategy.cs (1 method)
Architecture: batch.Execute() ALREADY captures exceptions via TaskCompletionSource.
Inner try-catch suppresses exceptions and loses stack context.
Exception propagation now happens at correct layer (batch, not method).
* Update copilot-instructions: Add surgical testing guidance and exception propagation pattern
CRITICAL additions:
- Integration tests take 45+ MINUTES for full suite
- ALWAYS use surgical testing with Feature filters (2-5 min per feature)
- Core Commands NEVER wrap batch.Execute() in catch blocks
- Let exceptions propagate naturally - batch.Execute() handles via TaskCompletionSource
- ONLY use finally blocks for COM cleanup, NO catch blocks returning OperationResult
This prevents 45+ minute test runs and documents correct exception handling pattern per CRITICAL-RULES.md Rule 1b.
* Remove additional violating catch blocks from PivotTable commands
Found and removed 7 more catch blocks that violated Rule 1b:
- PivotTableCommands.Subtotals.SetSubtotals
- PivotTableCommands.Grouping.GroupByDate
- PivotTableCommands.Grouping.GroupByNumeric
- PivotTableCommands.CalculatedFields.CreateCalculatedField
- PivotTableCommands.Analysis.GetData
- PivotTableCommands.Analysis.SetFieldFilter
- PivotTableCommands.Analysis.SortField
All were inside batch.Execute() and returning OperationResult { Success = false }.
Removed catch blocks, kept finally blocks for COM cleanup.
Exceptions now propagate naturally through batch.Execute().
* refactor(core): remove violating catch block from TableCommands.DataModel.cs
Removed catch block that violated Rule 1b (CRITICAL-RULES.md).
AddToDataModel now lets exceptions propagate through batch.Execute().
Pattern removed:
catch (Exception ex) {
return new OperationResult { Success = false, ErrorMessage = ... };
}
Rationale:
- batch.Execute() captures exceptions via TaskCompletionSource
- Inner catch suppresses exceptions and loses stack context
- Exceptions should originate from batch layer, not method layer
Part of comprehensive audit removing all violating catch blocks from Core Commands.
* test(core): fix Range style tests to expect exceptions after architectural changes
Updated 2 tests to expect exceptions instead of OperationResult { Success = false }:
- SetStyle_InvalidStyleName_ThrowsException (was ReturnsError)
- GetStyle_InvalidRange_ThrowsException (was ReturnsError)
Why Changed:
After removing violating catch blocks (Rule 1b), SetStyle() and GetStyle()
no longer catch Excel COM exceptions. batch.Execute() captures exceptions via
TaskCompletionSource and re-throws them.
Pattern:
Methods WITHOUT pre-validation → Excel COM throws → batch.Execute() captures →
Exception propagates to caller → Test must expect exception
Verified Clean:
- Tests with pre-validation (Sheet.Move, NamedRange.CreateBulk) still expect
Success=false correctly
- Tests with business rules (OLAP calculated fields) correctly expect Success=false
- Only methods letting Excel COM throw directly needed test updates
All 2 tests now pass with architectural fix in place.
* refactor: remove async wrappers and bulk operations
Remove ViewAsync, CreateBulk methods and update documentation
* refactor(chart): Convert Chart commands to exception-based pattern
- IChartCommands: Convert 14 method signatures (OperationResult/ChartSeriesResult/ChartListResult → void/SeriesInfo/List<ChartInfo>)
- IChartStrategy: Convert 3 data operation signatures (SetSourceRange→void, AddSeries→SeriesInfo, RemoveSeries→void)
- RegularChartStrategy: Remove OperationResult wrappers, return data types directly
- PivotChartStrategy: Convert error returns to throw NotSupportedException with helpful messages
- ChartCommands implementations: Update DataSource/Lifecycle/Appearance to match new signatures
- Remove unnecessary Models using directives
CRUD ops return void (throw on error), Query ops return data types, Exceptions replace Success/ErrorMessage wrappers.
Pattern validated: Core commands build successfully with 0 errors/warnings.
* fix(chart): Fix COM cleanup in PivotChartStrategy to use finally blocks
- SetSourceRange: Move COM Release to finally block ensuring cleanup even if exception occurs
- AddSeries: Move COM Release to finally block ensuring cleanup even if exception occurs
- RemoveSeries: Move COM Release to finally block ensuring cleanup even if exception occurs
- Declare COM objects as nullable dynamic? variables before try-catch-finally
Prevents COM object leaks when exceptions occur during PivotTable name retrieval.
Finally blocks guarantee cleanup happens regardless of try/catch outcome.
Follows proper COM interop resource management pattern from excel-com-interop.instructions.md.
* refactor(chart): Remove empty catch blocks from PivotChartStrategy
- GetInfo: Remove empty catch blocks, keep only try-finally for COM cleanup
- GetDetailedInfo: Remove empty catch block, keep only try-finally for COM cleanup
Empty catch blocks are unnecessary when finally blocks handle cleanup.
Finally blocks execute regardless of exception occurrence.
Cleaner code pattern: try { operations } finally { cleanup }
* refactor(chart): Fix COM cleanup in RegularChartStrategy
- GetInfo: Move seriesCollection to try-finally without empty catch
- GetDetailedInfo: Move seriesCollection to try-finally, keep only justified catch blocks for optional properties
- Remove COM Release from try block, move to finally block
- Keep catch blocks only where fallback values make sense (HasLegend=false, etc.)
Ensures COM objects always released even if exceptions occur.
Empty catch blocks removed where no fallback action needed.
* refactor(chart): Simplify PivotChartStrategy exception messages
- SetSourceRange: Remove COM object lookup, just throw NotSupportedException
- AddSeries: Remove COM object lookup, just throw NotSupportedException
- RemoveSeries: Remove COM object lookup, just throw NotSupportedException
LLM already knows context - no need for complex COM operations to get PivotTable name.
Simpler, cleaner, no COM cleanup needed for error-only code paths.
* refactor(chart): Convert CLI ChartCommand to exception-based pattern
- Removed Result wrapper pattern from all Execute methods
- Added try-catch exception handling with proper exit codes (0=success, 1=error)
- Query operations: return data via WriteJson
- CRUD operations: void with WriteInfo success messages
- Removed WriteResult helper method (no longer needed)
- Removed unused Models using statement
- All 14 Execute methods converted:
* ExecuteList (List<ChartInfo>)
* ExecuteRead (ChartInfoResult)
* ExecuteCreateFromRange (ChartCreateResult)
* ExecuteCreateFromPivotTable (ChartCreateResult)
* ExecuteDelete (void)
* ExecuteMove (void)
* ExecuteSetSourceRange (void)
* ExecuteAddSeries (SeriesInfo)
* ExecuteRemoveSeries (void)
* ExecuteSetChartType (void)
* ExecuteSetTitle (void)
* ExecuteSetAxisTitle (void)
* ExecuteShowLegend (void)
* ExecuteSetStyle (void)
Part of Phase 2.2: Chart CLI Updates
* refactor(chart): Convert MCP ExcelChartTool to exception-based pattern
- Removed Result wrapper anonymous object serialization
- Query operations: serialize data types directly (List<ChartInfo>, ChartInfoResult, ChartCreateResult, SeriesInfo)
- CRUD operations (void): return success message JSON after completion
- Exception handling: ExecuteToolAction wrapper catches and serializes exceptions
- All 14 actions converted:
* List → serialize List<ChartInfo>
* Read → serialize ChartInfoResult
* CreateFromRange → serialize ChartCreateResult
* CreateFromPivotTable → serialize ChartCreateResult
* Delete → success message JSON
* Move → success message JSON
* SetSourceRange → success message JSON
* AddSeries → serialize SeriesInfo
* RemoveSeries → success message JSON
* SetChartType → success message JSON
* SetTitle → success message JSON
* SetAxisTitle → success message JSON
* ShowLegend → success message JSON
* SetStyle → success message JSON
Part of Phase 2.3: Chart MCP Tool Updates
* refactor(chart): Convert MCP ExcelChartTool to exception-based pattern
- Removed Result wrapper anonymous object serialization
- Query operations: serialize data types directly (List<ChartInfo>, ChartInfoResult, ChartCreateResult, SeriesInfo)
- CRUD operations (void): return success message JSON after completion
- Exception handling: ExecuteToolAction wrapper catches and serializes exceptions
- All 14 actions converted:
* List → serialize List<ChartInfo>
* Read → serialize ChartInfoResult
* CreateFromRange → serialize ChartCreateResult
* CreateFromPivotTable → serialize ChartCreateResult
* Delete → success message JSON
* Move → success message JSON
* SetSourceRange → success message JSON
* AddSeries → serialize SeriesInfo
* RemoveSeries → success message JSON
* SetChartType → success message JSON
* SetTitle → success message JSON
* SetAxisTitle → success message JSON
* ShowLegend → success message JSON
* SetStyle → success message JSON
Part of Phase 2.3: Chart MCP Tool Updates
* refactor(namedrange): Convert NamedRange commands to exception pattern (all layers)
Core Changes:
- INamedRangeCommands: List returns List<NamedRangeInfo>, Read returns NamedRangeValue, CRUD operations void
- Added NamedRangeValue class (POCO for Read operation)
- All methods throw exceptions on error (InvalidOperationException, ArgumentException)
- Parameter validation enforced (255 char limit, no duplicates)
CLI Changes:
- All Execute methods use try-catch with exit codes (0=success, 1=exception, -1=validation)
- List/Get serialize data directly via WriteJson
- Create/Update/Delete/Write use WriteInfo for success messages
- Removed WriteResult helper method
- Removed unused using directive
MCP Server Changes:
- List serializes List<NamedRangeInfo> directly
- Read serializes NamedRangeValue directly
- Write/Create/Update/Delete wrap void operations in lambda with dummy return
- All CRUD ops return success message JSON with operation-specific messages
- Delete includes workflowHint about #NAME? errors
Test Changes (12 tests converted, all passing):
- Lifecycle.cs: 4 tests - List accesses data directly, Create/Delete void with verification
- Validation.cs: 6 tests - Parameter validation with Assert.Throws for errors
- Values.cs: 3 tests - Write/Read void/data operations with verification
All layers build successfully with 0 errors, 0 warnings
All 12 NamedRange tests passing (100%)
Phase 3 (NamedRange) complete - 6 Core methods + 12 tests converted
* refactor(conditionalformat): Convert ConditionalFormatting commands to exception pattern
Core Changes:
- IConditionalFormattingCommands: AddRule and ClearRules return void
- All methods throw exceptions on error (InvalidOperationException, ArgumentException)
- Removed OperationResult wrappers, use dummy return 0 for batch.Execute
- Removed unused using directives
CLI Changes:
- ExecuteAddRule/ExecuteClearRules use try-catch with exit codes (0=success, 1=exception, -1=validation)
- WriteInfo for success messages
- Removed WriteResult helper method
- Removed unused using directive
MCP Server Changes:
- AddRule/ClearRules wrap void operations in lambda with dummy return
- Return success message JSON with operation-specific messages
- Keep workflowHints for formatting verification guidance
All layers build successfully with 0 errors, 0 warnings
No tests exist for ConditionalFormatting commands
Phase 4.1 (ConditionalFormatting) complete - 2 Core methods converted
* Refactor: Convert Connection, File, VBA subsystems from OperationResult to exception-throwing pattern
- Connection: IConnectionCommands methods now return void, throw on error
- File: CreateEmpty returns void, throws on error
- VBA: Trust, Import, Delete, Run operations throw exceptions
- CLI layer: Updated error handling for void operations
- MCP layer: Responses serialized as {success: true} for void operations
- Test infrastructure: Updated 14 test helper files to check exceptions
Mutation operations now follow .NET convention of throwing exceptions instead of returning error-wrapped results. Read operations continue returning typed results.
All three layers (Core, CLI, MCP) coordinated for consistent behavior.
* Merge branch 'feature/shared-tool-error-handling' of https://github.com/sbroenne/mcp-server-excel into feature/shared-tool-error-handling
* Refactor: Convert Sheet subsystem from OperationResult to exception-throwing pattern
Convert 12 Sheet mutation methods to void signatures across all layers:
- ISheetCommands: Create, Rename, Copy, Delete, Move, CopyToWorkbook, MoveToWorkbook, SetTabColor, ClearTabColor, SetVisibility, Show, Hide, VeryHide
- SheetCommands (Core): All implementations use batch.Execute() with return 0, exceptions propagate
- SheetCommand (CLI): All void operations wrapped in try-catch with success/error messages
- ExcelWorksheetTool (MCP): All 10 void methods use WithSession() + return 0 + JSON serialization
Production code compiles cleanly. MCP smoke test: PASSED. Tests require separate refactoring for void method assertions.
* Refactor: Convert Table subsystem from OperationResult to exception-throwing pattern (17 void methods, Core+CLI+MCP layers)
- ITableCommands: 17 mutation methods converted to void signatures with exception documentation
- Core layer: 17 implementations across 7 partial files use batch.Execute() return 0 pattern
- CLI layer: 10 void handlers use try-catch-serialize pattern with success/error responses
- MCP layer: 10 void tool methods use try-catch-JSON pattern (fixed 8 broken WithSession<T> calls)
- All production layers compile cleanly: 0 errors, 0 warnings
- MCP smoke test PASSED: all 11 tools working correctly
- Test layer errors (44) deferred: void assertion issues to be fixed separately
- Pattern matches Sheet/Connection/File/VBA subsystem conversions
* feat: Convert PowerQuery subsystem mutation methods to void pattern (Delete, Create, Update, LoadTo, RefreshAll)
* Convert DataModel subsystem to exception-throwing pattern
- Interface: 7 void mutation methods (DeleteMeasure, DeleteRelationship, Refresh (2 overloads), CreateMeasure, UpdateMeasure, CreateRelationship, UpdateRelationship)
- Core: Converted Write.cs (6 mutations) and Refresh.cs (2 methods) to void pattern with batch.Execute((ctx, ct) => { ...code...; return 0; })
- CLI: 7 handlers with try-catch-console JSON output
- MCP: 7 tool methods with try-catch-JSON error handling
- Removed unused Core.Models imports from Write.cs and Refresh.cs
- Build: 0 errors, 0 warnings across Core, CLI, MCP layers
Note: Test failures expected (44 in Core, 50+ in other test files due to void assertion issues) - these are deferred per testing strategy (Rule 14)
* Merge branch 'feature/shared-tool-error-handling' of https://github.com/sbroenne/mcp-server-excel into feature/shared-tool-error-handling
* fix: Complete void test migration - 84/84 errors fixed
Complete migration of 84 test compilation errors to exception-based pattern.
This completes the integration of void Execute infrastructure with test layer updates.
✅ BUILD VERIFIED: 0 errors, 0 warnings
✅ PRE-COMMIT PASSED: All quality gates passing
Test Migrations (84 total):
- Sheet tests: 19 errors (Move, TabColor, Visibility, Lifecycle)
- Helper fixtures: 4 errors (PowerQuery, Table, DataModel, PivotTable)
- PowerQueryCommandsTests: 19 errors (Create, Update, Delete, LoadTo calls)
- DataModelCommandsTests: 12 errors (CreateMeasure, UpdateMeasure, CreateRelationship, DeleteRelationship)
- DataModelTestsFixture: 1 error (var assignment from void CreateMeasure)
- TableCommandsTests: 2 errors (Create calls in tests and fixture)
- PivotTableCommandsTests: 3 errors (Create calls from Table/DataModel)
- PivotTableCommandsTests.OlapFields: 2 errors (CreateMeasure calls)
Pattern Applied (Two types):
1. CS0815 'Cannot assign void': Remove 'var result =' and 'Assert.True(result.Success)' lines
2. Remove unnecessary success checks - void methods throw on error instead
Infrastructure:
- void Execute(Action<ExcelContext, CancellationToken>) in IExcelBatch/ExcelBatch
- Delegates to Execute<T>(Func<...>) returning dummy 0
- Non-breaking enhancement for clean void method support
Verification:
✅ Build: 0 errors, 0 warnings
✅ Pre-commit checks: All passed
- COM leak detection: 0 leaks
- Success flag validation: All consistent
- MCP implementation coverage: 100%
- MCP server smoke test: Passed
✅ Feature branch active (feature/shared-tool-error-handling)
* docs: Add void test migration completion summary
* refactor: Convert 11 Range void mutations to fire-and-forget pattern across all layers
Complete refactoring of Range command mutations to void pattern:
CORE LAYER (11 void mutations):
- RangeCommands.Search.cs: Replace, Sort
- RangeCommands.Formatting.cs: SetStyle, FormatRange
- RangeCommands.Validation.cs: ValidateRange, RemoveValidation
- RangeCommands.AutoFit.cs: AutoFitColumns, AutoFitRows
- RangeCommands.Advanced.cs: MergeCells, UnmergeCells, SetCellLock
INTERFACE:
- IRangeCommands.cs: All 11 signatures changed from OperationResult to void
MCP TOOL LAYER:
- ExcelRangeTool.cs: All 11 calls updated to use WithSession<object?>() pattern
* Explicit type parameter resolves CS0411 type inference on void returns
* Returns { Success = true } JSON directly for all void mutations
* Lambda formatting fixed (IDE0055 compliance)
CLI LAYER:
- RangeCommand.cs: All 11 command handlers adapted
* Removed var result = ... assignments
* Call void methods directly
* Return { Success = true } JSON on completion
TEST LAYER (14+ files):
- RangeCommandsTests: All test files updated
* Removed var result = ... assignments
* Removed Assert.True(result.Success, ...) assertions
* Void methods throw on failure; silence = success
BUILD STATUS: ✅ Clean - 0 errors, 0 warnings
LEGITIMATE OperationResult METHODS (NOT CONVERTED):
- SetValues, SetFormulas, Copy, SetNumberFormat, AddHyperlink
- These data mutations need validation and result reporting
PATTERN:
- Void mutations: Fire-and-forget with exception-based error handling
- Exceptions propagate naturally through batch.Execute() layer
- No OperationResult wrapping needed for simple write operations
* chore: Remove unused imports and temporary documentation files
- Clean up unused using directives across Table and PivotTable commands
- Remove temporary documentation files
- Maintain code style consistency
* fix: Update MartinCostello.Logging.XUnit package version to 0.7.0
* fix(chart): Suppress CodeQL false positives for dynamic COM interop in Strategy pattern
- Add pragma warning disable CS8604 for all Strategy method calls
- CodeQL cannot verify dynamic Excel COM objects have required methods at compile-time
- All methods verified to exist in both RegularChartStrategy and PivotChartStrategy
- False positives: SetSourceRange, AddSeries, RemoveSeries, GetInfo, GetDetailedInfo
- Addresses code scanning alerts #2631-2635
|
||
|
Stefan Broenner
|
e512204732 |
feat: Add comprehensive Chart operations support (Regular Charts and PivotCharts) (#230)
* feat: Add comprehensive Chart operations support (Regular Charts and PivotCharts) Implements complete chart management functionality across all three layers: - Core Commands: 15 methods for chart lifecycle, data source, and appearance operations - MCP Server Tool: excel_chart with 15 actions exposed to LLM agents - CLI Commands: chart command with 15 actions for command-line automation Core Implementation (940+ lines): - IChartCommands.cs: Interface defining 15 chart operations - ChartCommands.Lifecycle.cs (500+ lines): List, Read, CreateFromRange, CreateFromPivotTable, Delete, Move - ChartCommands.DataSource.cs (200+ lines): SetSourceRange, AddSeries, RemoveSeries - ChartCommands.Appearance.cs (240+ lines): SetChartType, SetTitle, SetAxisTitle, ShowLegend, SetStyle - Strategy Pattern: RegularChartStrategy and PivotChartStrategy (220+ lines each) - ChartType.cs: 70+ chart type enum values (Column, Bar, Line, Pie, Area, Scatter, etc.) - ChartResults.cs: 4 result classes (ChartListResult, ChartInfoResult, ChartCreateResult, ChartUpdateResult) MCP Server Integration (473 lines): - ExcelChartTool.cs: Main tool with 15 actions - ChartAction enum: 15 values (List, Read, CreateFromRange, CreateFromPivotTable, Delete, Move, SetSourceRange, AddSeries, RemoveSeries, SetChartType, SetTitle, SetAxisTitle, ShowLegend, SetStyle) - ToActionString() extension: Maps ChartAction to kebab-case strings CLI Integration (368 lines): - ChartCommand.cs: Command<Settings> pattern with 15 actions - Registered in Program.cs with DI support Testing (27 tests + smoke test): - ChartCommandsTests.Lifecycle.cs: 9 tests covering chart creation and management - ChartCommandsTests.Appearance.cs: 10 tests covering appearance customization - ChartCommandsTests.DataSource.cs: 8 tests covering data source operations - CoreCommandsCoverageTests.cs: Automated verification of enum/method coverage - McpServerSmokeTests.cs: End-to-end smoke test for excel_chart tool (now includes Chart!) - ToolDiscoveryTests.cs: Discovery verification for excel_chart Features: - Regular Charts: Static charts from Excel ranges (A1:D10) - PivotCharts: Dynamic charts linked to PivotTables - 70+ chart types supported (Column, Bar, Line, Pie, Area, Scatter, Bubble, Stock, Surface, Radar, etc.) - Full positioning control (left, top, width, height in points) - Series management (add/remove data series) - Appearance customization (titles, axes, legends, styles) - Round-trip validation in all tests Architecture: - Strategy Pattern: Separates Regular vs PivotChart logic - Batch-aware: All operations use IExcelBatch for performance - COM-safe: Proper resource cleanup with try/finally blocks - Range object fix: SetSourceData requires Range object, not string Documentation: - specs/CHART-API-SPECIFICATION.md: 400+ line comprehensive specification - All methods fully documented with XML comments - Examples provided for all operation types Builds successfully with 0 warnings, 0 errors. All 27 Core tests pass. Smoke test passes (validates end-to-end workflow with all 13 tools). 100% Core method coverage verified. MCP tool discoverable and functional. * fix: Update Chart test assertions to match Excel SERIES formula behavior - SetSourceRange tests now check for Sheet1 + column references ($D$, $E$, $A$, $B$) instead of simple ranges - AddSeries_InvalidSeriesIndex now expects COMException for invalid index instead of Success=false - All 26 Chart integration tests now pass (9 lifecycle, 8 data source, 9 appearance) - Fixes #229 * refactor: Rewrite Connection tests to accurately document Excel COM behavior - TEXT/WEB connections: Create works successfully - OLEDB connections: Fail with ArgumentException (Excel COM Add2() limitation) - ODBC connections: Create succeeds even without valid DSN - Duplicate names: Excel handles gracefully (prevents or auto-renames) - Removed confusing 'test always passes' logic - Added clear documentation about connection type support - Fixed exception propagation in CreateConnection helper (removed InvalidOperationException wrapping) All 21 Connection tests now pass (1 skipped). * feat(connection): Add ODC import and enhance SetProperties with connection string/command text/description updates FEATURE ENHANCEMENTS: - Add ImportFromOdc action to import Office Data Connection (.odc) files - Expose connectionString, commandText, description parameters in SetProperties (was behavior-only) - Add exception handler for Excel 0x800A03EC error (ODC connection string updates blocked) - Block TEXT/WEB connection creation via Create (redirect to Power Query) - Add import-odc action to CLI with --odc-file parameter IMPLEMENTATION: - New ConnectionCommands.ImportOdc.cs with AddFromFile COM API - Enhanced UpdateConnectionProperties to handle all 7 properties (connection string, command text, description + 4 behavior properties) - MCP Tool: SetProperties accepts newConnectionString, newCommandText, newDescription parameters - CLI: ExecuteImportOdc method with OdcFilePath setting - Exception scoping: Only catches 0x800A03EC when updating connection string TESTING (13 new tests): - ConnectionCommandsTests.ImportOdc.cs: * ImportFromOdc_ValidFile_ImportsConnection * ImportFromOdc_MissingFile_ReturnsError * ImportFromOdc_DuplicateImport_AddsSecondConnection * ImportFromOdc_ThenUpdateCommandText_RefreshSucceeds (proves functional query change) * ImportFromOdc_ThenUpdateCommandText_ConnectionUpdated * ImportFromOdc_ThenUpdateDescription_ConnectionUpdated * CreateConnection_ThenUpdateConnectionString_Succeeds (proves ODBC connections allow updates) - ConnectionCommandsTests.Create.cs: * Create_TextConnection_ThrowsNotSupportedException (TEXT blocked) * Create_WebConnection_ThrowsNotSupportedException (WEB blocked) * Create_OleDbConnection_ThrowsArgumentException (Excel COM limitation) * Create_OdbcConnection_ReturnsSuccess (ODBC works) * Updated Create_DuplicateName and Create_WithDescription to use ODBC - Helper: SQLiteDatabaseHelper for reliable OLEDB testing DOCUMENTATION: - Updated README tool counts: 10 actions (was 9) - Updated architecture-patterns.instructions.md: 11 tools (corrected from 12) - Updated excel_connection tool description: ODC import, TEXT/WEB removal guidance - Added Directory.Packages.props: Microsoft.Data.Sqlite package - Removed outdated vscode-extension/INSTALL.md (content merged to main README) KEY FINDINGS: - ODC-imported connections: Connection string updates blocked (0x800A03EC) - Programmatically-created ODBC connections: Connection string updates work - Command text updates are functional (refresh executes new query, not cosmetic) - TEXT/WEB connections now blocked from Create (use Power Query or ODC import) * refactor: Remove ODC import functionality (blocked by Windows Defender ASR) - Removed ImportFromOdc action from ConnectionAction enum and all implementations - Deleted ConnectionCommands.ImportOdc.cs (implementation file) - Deleted ConnectionCommandsTests.ImportOdc.cs (all test files) - Removed import-odc from MCP tool, CLI, and interface - Removed OdcFilePath CLI parameter - Fixed Delete and View tests to use ODBC connections instead of TEXT - Updated Refresh tests to use simpler ODBC connections - Updated all READMEs: connection count 10→9 actions, 155→154 total actions REASON: Excel's AddFromFile() COM API creates .lnk shortcuts in 'My Data Sources' folder, triggering Windows Defender Attack Surface Reduction (ASR) rule 'Block Office applications from creating executable content'. This blocks all users with default Defender policies (common in enterprise). ALTERNATIVE APPROACH: Users can manually create connections via excel_connection create action with connection strings, or use Power Query (excel_powerquery) for data imports. * feat: Enhance Excel tools with timeout safeguards and error handling - Added timeout safeguards to `ExcelPivotTableTool` and `ExcelPowerQueryTool` to handle long-running operations, returning suggested next actions on timeout. - Updated `CreateFromDataModel` and `LoadToPowerQueryAsync` methods to include detailed error messages and operation context in case of timeouts. - Removed unused SQLite database helper class and replaced it with ACE OLEDB helper functions for better integration testing. - Updated connection tests to utilize the new ACE OLEDB helper methods, ensuring proper creation and refreshing of connections. - Adjusted README to reflect the current number of supported operations (154) in the Excel MCP Server. |
||
|
Stefan Broenner
|
72c968c0ba |
feat: Add cross-workbook worksheet operations (copy-to-workbook, move-to-workbook) (#231)
Implements GitHub issue #187 - Enable copying and moving worksheets between different Excel workbooks. **Architecture Changes:** - Extended IExcelBatch to support multiple workbooks in single Excel.Application instance - Added Workbooks property (IReadOnlyDictionary<string, dynamic>) and GetWorkbook(string) method - Modified ExcelBatch constructor to accept string[] workbookPaths and open all in shared COM context - Updated ExcelSession.BeginBatch to accept params string[] filePaths **Core Implementation:** - Added CopyToWorkbook and MoveToWorkbook methods to ISheetCommands - Implemented using Excel COM Worksheet.Copy and Worksheet.Move APIs - Extended List() and Create() with optional filePath parameter for multi-workbook scenarios - Uses batch.GetWorkbook(filePath) to target specific workbook in multi-file batches **MCP Server:** - Updated ExcelWorksheetTool to create temporary multi-file batches for cross-workbook operations - Added comprehensive cross-workbook documentation to tool description - Updated excel_worksheet.md prompt with workflow examples and guidance **Tests:** - Converted 10 cross-workbook tests from error-handling to positive validation - Updated 18 test files for new ExcelBatch constructor signature (array parameter) - All 9 cross-workbook integration tests passing **Documentation:** - Updated README.md: 13→16 worksheet actions, added cross-workbook capability - Updated CLI README: Added copy-to-workbook/move-to-workbook examples - Updated GitHub Pages: 158 operations (fixed inconsistencies), comprehensive action tables - Updated vscode-extension README: Already correct (16 actions) **Key Benefits:** - Single Excel.Application for multiple workbooks = proper COM object sharing - No RCW isolation issues between batches - Clean multi-workbook API: ExcelSession.BeginBatch(file1, file2, file3) - LLMs now have clear guidance on when/how to use cross-workbook operations |
||
|
Copilot
|
ffbef07a2e |
Add tests and documentation for Connection Delete action (#228)
* Initial plan * Add comprehensive tests for Connection Delete action and update documentation Co-authored-by: sbroenne <3026464+sbroenne@users.noreply.github.com> * Add MCP Server integration tests for Connection Delete action Co-authored-by: sbroenne <3026464+sbroenne@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: sbroenne <3026464+sbroenne@users.noreply.github.com> |