mirror of
https://github.com/ruvnet/ruflo.git
synced 2026-09-14 14:01:28 +08:00
402b701a9d
* fix(security): ADR-165 Phase 1 — close all critical CVEs, refresh registry, add CI gate Closes ADR-165 Phase 1. Both workspaces pass `npm audit --audit-level=critical`. ## Before (2026-06-29) | Workspace | Critical | High | Moderate | Total | |-----------|----------|------|----------|-------| | Root | **1** | 6 | 31 | 38 | | v3 | **4** | 33 | 57 | 97 | ## After | Workspace | Critical | High | Moderate | Total | |-----------|----------|------|----------|-------| | Root | **0** | 0 | 31 | 31 | | v3 | **0** | 27 | 58 | 88 | All 5 critical advisories closed (vitest GHSA-5xrq, handlebars prototype-pollution, protobufjs constructor-pollution, plus 2 more in v3). 12 of 39 high advisories closed via overrides; the remaining 27 v3 highs are deeper transitive chains that would require breaking-change major bumps — flagged for ADR-165 Phase 2. ## Changes ### Root workspace overrides (package.json) - `vitest`: `^1.0.0` → `^3.2.6` (closes critical GHSA-5xrq CVSS 9.8) - `hono`: `>=4.11.4` → `>=4.12.25` (closes 6 hono advisories) - `undici`: `>=7.18.0` → `>=8.5.0` (closes 7 undici advisories — bumps the stale pin that ADR-165 flagged as still-in-vulnerable-range) - `vite`: `>=6.4.6` → `>=8.0.16` (closes 2 vite advisories) - NEW `@grpc/grpc-js`: `>=1.14.4` - NEW `form-data`: `>=4.0.6` - NEW `http-proxy-middleware`: `>=3.0.7` - `@hono/node-server`: `>=1.19.10` → `>=1.19.14` ### v3 workspace overrides (v3/package.json + pnpm.overrides) - `vitest`: `^4.0.16` → `^4.1.0` (and `@vitest/coverage-v8` matched) - Top-level + pnpm overrides: `handlebars: >=4.7.9`, `protobufjs: >=8.6.0` - 27 sub-package `package.json` updated to `vitest ^4.1.0` ### CVE registry refresh (v3/@claude-flow/security/src/CVE-REMEDIATION.ts) Rewritten from 5 stale Jan-2026 entries to 16 total: 15 fixed, 1 open (ADR165-OPEN-01 — PII pipeline wiring per ADR-164 §6.1 not yet on dispatch-layer). `SECURITY_SUMMARY` is now computed dynamically from the registry; `validateRemediation()` correctly returns `allFixed: false` with 1 issue. ADR-165 §5 flagged this as THE Phase 2 priority — now closed. ### New CI gate `.github/workflows/cve-audit.yml`: - `audit-root` — `npm audit --audit-level=critical` in root, blocking - `audit-v3` — same in v3, blocking - `audit-high-report` — warn-only summary on high-severity drift - Triggers: PR, push to main, daily cron ### ADR-165 §9 evidence ledger addendum Captures AFTER-remediation `npm audit --json` metadata for both workspaces. The diff between BEFORE (already in §9) and AFTER makes Phase 1 verifiable. Also CORRECTED one prior surprise in §9: the `validate-input.ts` in `mcp-tools/` is NOT a 9-line shim. It's 269 lines of real implementation. (That was an inaccurate findings note from the initial audit.) ### §7.3 research items resolved - `protobufjs` v3 chain confirmed gone after override pins - `handlebars` v3 chain confirmed not user-reachable on the workflow path (toolchain-only; override sufficient) - `validate-input.ts` confirmed real implementation, not a shim (registry entry corrected) - CORS surface check: no `cors()` / `app.use(cors` call sites — the hono CORS-wildcard advisory is not exploitable on the current server - ADR-164 §6.1 PII pipeline NOT wired in current agentbbs dispatch — recorded as ADR165-OPEN-01 (Phase 3 work) ## Gates (all PASS) - `npm audit --audit-level=critical` root: exit 0 (was non-zero) - `npm audit --audit-level=critical` v3: exit 0 (was non-zero) - vitest suites: 105/109 pass (4 skip-conditional — same as before) - ADR-112 audit: 352/352 tools with guidance - business-pods smoke: 11/11 PASS - agentbbs smoke: 8/8 PASS - agenticow smoke: 8/8 PASS - cli build: clean (tsc) ## Phase 2+ deferred The 27 v3 high-severity advisories that remain are transitive chains with no patched-in-range version. ADR-165 §6 Phase 2 picks these up after the `cve-watch.yml` automation in §6 lands (NEW PR — not in scope here). Co-Authored-By: RuFlo <ruv@ruv.net> Claude-Session: https://claude.ai/code/session_01WbBa4nccx5aGhXphoHxcni * chore(lock): regen v3/pnpm-lock.yaml after override updates (PR #2508 CI fix) PR #2508 added handlebars + protobufjs to v3 overrides + bumped vitest pin, but v3/pnpm-lock.yaml wasn't regenerated. CI surfaced ERR_PNPM_LOCKFILE_CONFIG_MISMATCH on every install step. Same pattern as the previous lockfile-drift fixes on PR #2500 and #2503. * fix(ci): cve-audit.yml jq-only + regen witness manifests for #1609 marker drift Two PR #2508 CI failures fixed: 1. Static-regression-guard tripped on cve-audit.yml line 52: the static YAML strict-parser sees `if high > 0:` inside the `run: |` block as a YAML block-mapping key indicator. Refactored all 3 inline-python blocks to use jq (preinstalled on ubuntu-latest) — no embedded `if x > 0:` lines, so the YAML guard passes. 2. Witness marker drift smoke flagged fix-marker #1609 — the Phase 1 vitest bump (4.0.16 → 4.1.0) drifted the cited marker string in v3/@claude-flow/aidefence/package.json. Updated `marker` field in all 3 platform manifests + `desc` to reference ADR-165 Phase 1, then re-signed via plugins/ruflo-core/scripts/witness/regen.mjs. Co-Authored-By: RuFlo <ruv@ruv.net>
115 lines
5.3 KiB
YAML
115 lines
5.3 KiB
YAML
name: CVE Audit Gate
|
|
|
|
on:
|
|
pull_request:
|
|
branches: [main]
|
|
push:
|
|
branches: [main]
|
|
schedule:
|
|
# Daily at 03:47 UTC (stagger from other crons)
|
|
- cron: '47 3 * * *'
|
|
workflow_dispatch:
|
|
|
|
concurrency:
|
|
group: cve-audit-${{ github.ref }}
|
|
cancel-in-progress: true
|
|
|
|
jobs:
|
|
# ───────────────────────────────────────────────────────────
|
|
# Job 1: Root workspace — BLOCKING on critical
|
|
# Phase 1 target: 0 criticals (ADR-165)
|
|
# ───────────────────────────────────────────────────────────
|
|
audit-root:
|
|
name: Audit root (critical-blocking)
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
|
|
- uses: actions/setup-node@v4
|
|
with:
|
|
node-version: '20'
|
|
cache: 'npm'
|
|
|
|
- name: Install root dependencies (lockfile only)
|
|
run: npm install --package-lock-only --ignore-scripts
|
|
|
|
- name: npm audit — critical gate (must be 0)
|
|
run: npm audit --audit-level=critical
|
|
# Exit 1 if any critical advisory is found.
|
|
# High/moderate/low are reported but do not block.
|
|
|
|
- name: npm audit — high summary (warn only)
|
|
run: |
|
|
# Use jq (preinstalled on ubuntu-latest) instead of embedded python
|
|
# so the static YAML guard doesn't mistake an `if x > 0:` for a
|
|
# YAML block-mapping key indicator.
|
|
summary=$(npm audit --json 2>/dev/null | jq -r '.metadata.vulnerabilities | "critical:\(.critical) high:\(.high) moderate:\(.moderate) total:\(.total)"' || echo "audit-failed")
|
|
echo "::notice::Root audit summary — $summary"
|
|
high=$(npm audit --json 2>/dev/null | jq -r '.metadata.vulnerabilities.high // 0' || echo 0)
|
|
if [ "$high" -gt 0 ]; then
|
|
echo "::warning::Root workspace has $high high-severity advisories (non-blocking — target Phase 5)"
|
|
fi
|
|
# Non-blocking: highs are surfaced as warnings in the Actions log
|
|
|
|
# ───────────────────────────────────────────────────────────
|
|
# Job 2: v3 workspace — BLOCKING on critical
|
|
# Phase 1 target: 0 criticals (ADR-165)
|
|
# ───────────────────────────────────────────────────────────
|
|
audit-v3:
|
|
name: Audit v3 (critical-blocking)
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
|
|
- uses: actions/setup-node@v4
|
|
with:
|
|
node-version: '20'
|
|
# v3 uses pnpm for runtime but npm for audit; no npm cache for v3
|
|
cache: 'npm'
|
|
|
|
- name: npm audit v3 — critical gate (must be 0)
|
|
working-directory: v3
|
|
run: npm audit --audit-level=critical
|
|
# Reads v3/package-lock.json generated by npm.
|
|
# v3/pnpm-lock.yaml is used by pnpm at runtime; this job validates the
|
|
# npm-readable lockfile kept in sync by the remediation workflow.
|
|
|
|
- name: npm audit v3 — high summary (warn only)
|
|
working-directory: v3
|
|
run: |
|
|
# jq, not python — avoids static YAML guard tripping on `if x > 0:`
|
|
summary=$(npm audit --json 2>/dev/null | jq -r '.metadata.vulnerabilities | "critical:\(.critical) high:\(.high) moderate:\(.moderate) total:\(.total)"' || echo "audit-failed")
|
|
echo "::notice::v3 audit summary — $summary"
|
|
high=$(npm audit --json 2>/dev/null | jq -r '.metadata.vulnerabilities.high // 0' || echo 0)
|
|
if [ "$high" -gt 0 ]; then
|
|
echo "::warning::v3 workspace has $high high-severity advisories (non-blocking — target Phase 5)"
|
|
fi
|
|
|
|
# ───────────────────────────────────────────────────────────
|
|
# Job 3: Combined high-severity report (warn only, never blocks)
|
|
# ───────────────────────────────────────────────────────────
|
|
audit-high-report:
|
|
name: High-severity report (warn only)
|
|
runs-on: ubuntu-latest
|
|
needs: [audit-root, audit-v3]
|
|
if: always()
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
|
|
- uses: actions/setup-node@v4
|
|
with:
|
|
node-version: '20'
|
|
cache: 'npm'
|
|
|
|
- name: Combined high/moderate summary
|
|
run: |
|
|
# jq instead of inline python so the static YAML guard doesn't
|
|
# trip on `if x > 0:`-style colons.
|
|
echo "=== Root workspace ==="
|
|
npm audit --json 2>/dev/null | jq -r '.metadata.vulnerabilities | " critical:\(.critical) high:\(.high) moderate:\(.moderate) total:\(.total)"' || true
|
|
echo ""
|
|
echo "=== v3 workspace ==="
|
|
(cd v3 && npm audit --json 2>/dev/null | jq -r '.metadata.vulnerabilities | " critical:\(.critical) high:\(.high) moderate:\(.moderate) total:\(.total)"') || true
|
|
# This job always runs and surfaces a combined summary.
|
|
# It never sets exit code > 0 so it cannot block merges.
|