mirror of
https://github.com/ruvnet/ruflo.git
synced 2026-09-14 14:01:28 +08:00
47a7825b0e
* docs(adr): ADR-129 — rvagent full integration (4 phases, post-3.7.0 baseline) Proposes a 4-phase integration of @ruvector/rvagent-wasm@0.1.0 to make WasmAgents first-class participants in the ruflo swarm. ## Gaps found in current code (verified by deep-researcher) - agent-wasm.ts:165-196 — echo-stub bypass (JsModelProvider never constructed; verified by `grep -rn 'new JsModelProvider'` returns 0 hits). WasmAgent.prompt() either echoes or hits a default — not routed through the v3 provider system from #2042. - agent-wasm.ts:420-429 — buildRvfFromTemplate silently drops template.mcp_tools, so wasm_gallery_create can't surface MCP tools to the agent. - 10 of 13 gallery methods unexposed (loadRvf, configure, getCategories, listByCategory, addCustom, removeCustom, importCustom, exportCustom, getActive, getConfig). - 6 agent introspection methods unexposed (get_state, get_todos, get_tools, turn_count, is_stopped, reset). - No bridge from any of the 35 ruflo plugins to the WASM agent runtime. ## 4 phases | Phase | What | Smoke | |---|---|---| | 1 | JsModelProvider → callAnthropicMessages bridge | smoke-wasm-provider-bridge.mjs | | 2 | wasm_agent_compose + addMcpTools bridge (314 tools) | smoke-wasm-rvf-compose.mjs | | 3 | 16 new MCP tools (gallery CRUD + introspection) | smoke-wasm-gallery-crud.mjs | | 4 | Plugin bridge contract | smoke-wasm-plugin-bridge.mjs | ## Top 3 risks 1. Billing expansion — Phase 1 turns wasm_agent_prompt into billable LLM calls (was echo). 2. addMcpTools over-permissioning — Phase 2 default must be explicit allowlist, not full dump (314 tools include destructive ones like memory_delete, federation_*). 3. importCustom prompt-injection — Phase 3 deserializes user JSON in the WASM runtime; AIDefence gate required. No phase needs a separate ADR. Anchored in #2042 (provider routing), ADR-115 (rvagent rename), ADR-127 (smoke pattern). Co-Authored-By: RuFlo <ruflo-bot@users.noreply.github.com> * feat(rvagent): #ADR-129 P1 — JsModelProvider routes WasmAgent through v3 provider system Wire set_model_provider() at agent-creation time so the WASM runtime's internal conversation loop dispatches through callAnthropicMessages (Anthropic / OpenRouter / Ollama, same routing as agent_execute #2042). Echo-stub fallback preserved for keyless environments. Smoke + CI job added: smoke-wasm-provider-bridge.mjs / wasm-provider-bridge-smoke. Co-Authored-By: RuFlo <ruv@ruv.net> * feat(rvagent): #ADR-129 P2 — wasm_agent_compose + addMcpTools bridge (314-tool unlock with allowlist gate) Fix silent drop of template.mcp_tools in buildRvfFromTemplate; extend buildRvfContainer to accept mcpTools param → builder.addMcpTools(). Add wasm_agent_compose MCP tool with explicit allowlist, destructive-tool gate (mcpToolsAllowDestructive required for *_delete/*_shutdown/federation_*), and includePlugins P4 wire. Smoke + CI job: smoke-wasm-rvf-compose.mjs. Co-Authored-By: RuFlo <ruv@ruv.net> * feat(rvagent): #ADR-129 P3 — 16 new MCP tools (10 gallery CRUD + 6 introspection) with AIDefence gate on import Add wasm_gallery_load_rvf, configure, categories, list_by_category, add_custom, remove_custom, import (HIGH_RISK + AIDefence gate), export, active, config. Add wasm_agent_state, todos, tools, turn_count, is_stopped, reset. Export 10 new functions from agent-wasm.ts. Smoke + CI job: smoke-wasm-gallery-crud.mjs. Co-Authored-By: RuFlo <ruv@ruv.net> * feat(rvagent): #ADR-129 P4 — plugin manifest "rvagent" field + includePlugins in compose Add loadPluginManifest() + extractPluginSkills() to wasm-agent-tools.ts. wasm_agent_compose gains includePlugins?: string[] — reads each plugin's .claude-plugin/plugin.json, parses rvagent.exposeSkillsAsTools, and adds matching skills to the RVF container. Unknown plugin name → warning, not error. Smoke + CI job: smoke-wasm-plugin-bridge.mjs. Co-Authored-By: RuFlo <ruv@ruv.net> * fix(ci): #2120 — memory smoke uses pnpm (workspace: protocol unsupported by npm) The memory-stats-legacy-db-smoke job hit `EUNSUPPORTEDPROTOCOL: Unsupported URL Type "workspace:"` in CI because `cd v3/@claude-flow/cli && npm install` ran against a package.json with workspace:* deps that only pnpm understands. Same pattern as the agent-execute smoke fix. Switch the job to pnpm/action-setup + `pnpm install` + `pnpm --filter @claude-flow/cli build`. The smoke logic is unchanged. Co-Authored-By: RuFlo <ruflo-bot@users.noreply.github.com> * fix(rvagent): #ADR-129 — pad 16 new wasm tool descriptions to ADR-112 spec (>=80 chars + Use-when guidance) Co-Authored-By: RuFlo <ruv@ruv.net> * feat(rvagent): #ADR-129 — benchmark suite (provider routing, compose, gallery CRUD, plugin enum) Co-Authored-By: RuFlo <ruv@ruv.net> * feat(witness): #ADR-103 — register ADR-129 P1-P4 fixes in witness manifest Co-Authored-By: RuFlo <ruv@ruv.net> * fix(ci): #2120 — pnpm install must run from v3/ (workspace root) My prior fix (2d2091fe7) ran `pnpm install` at repo root, but the pnpm-workspace.yaml lives in v3/, not at the root. Result: no node_modules under v3/@claude-flow/cli, tsc errored on missing @types/node, build never produced dist. Mirror the working pattern used elsewhere in this workflow: `working-directory: v3` + `pnpm install` + `pnpm --filter @claude-flow/cli build`. Keep the root `npm install` for sql.js which the smoke fixture imports from the repo root. Co-Authored-By: RuFlo <ruflo-bot@users.noreply.github.com> * fix(ci): #2120 — recursive build (CLI tsc depends on swarm dist) Previous fix (cec3cef48) installed correctly from v3/ but the CLI's tsc emits TS6305 because it has project references to @claude-flow/swarm and its dist hasn't been produced yet. `pnpm --filter @claude-flow/cli build` only builds that one package and skips deps. Switch to `pnpm --recursive --no-bail run build || true` — the proven pattern used elsewhere in this workflow — then assert the specific dist file the smoke imports (`dist/src/memory/memory-initializer.js`). Co-Authored-By: RuFlo <ruflo-bot@users.noreply.github.com> * fix(memory): #2120 — getBridge honors CLAUDE_FLOW_DISABLE_BRIDGE=1 The #2120 smoke sets `CLAUDE_FLOW_DISABLE_BRIDGE=1` to force the raw sql.js fallback path of `listEntries`, because the ensureSchemaColumns backfill (NULL status → 'active') only runs in that fallback — bridgeListEntries reads via a separate better-sqlite3 handle and skips the migration. `getBridge()` ignored that env var, so on CI Linux (where better-sqlite3 builds successfully) the bridge took over `listEntries`, the backfill never ran, and the smoke's step-4 verification (reading the file with plain sql.js) saw status=NULL on all rows and reported 0 active. The test passed on macOS only because the bridge happened to fail to initialize locally. Honor the env var: when set to "1", short-circuit getBridge() before any import attempt. Same value the smoke already sets — no other call site relies on this flag, so the change is non-breaking. Co-Authored-By: RuFlo <ruflo-bot@users.noreply.github.com> --------- Co-authored-by: RuFlo <ruflo-bot@users.noreply.github.com>
97 lines
2.0 KiB
JSON
97 lines
2.0 KiB
JSON
{
|
|
"tag": "baseline",
|
|
"trials": 5,
|
|
"node": "v22.22.1",
|
|
"platform": "darwin-arm64",
|
|
"capturedAt": "2026-05-24T17:53:40.839Z",
|
|
"adr": "ADR-129",
|
|
"phases": [
|
|
"P1-provider-routing",
|
|
"P2-compose-throughput",
|
|
"P3-gallery-crud",
|
|
"P4-plugin-enum"
|
|
],
|
|
"results": [
|
|
{
|
|
"name": "P1-echo-stub: createWasmAgent (keyless)",
|
|
"trials": 5,
|
|
"reps": 5,
|
|
"medianMs": 0.031,
|
|
"minMs": 0.015,
|
|
"maxMs": 0.063,
|
|
"variance": 1.558
|
|
},
|
|
{
|
|
"name": "P1-provider-path: createWasmAgent (fake key)",
|
|
"trials": 5,
|
|
"reps": 5,
|
|
"medianMs": 0.025,
|
|
"minMs": 0.02,
|
|
"maxMs": 0.036,
|
|
"variance": 0.657
|
|
},
|
|
{
|
|
"name": "P2-compose: 10 MCP tools",
|
|
"trials": 5,
|
|
"reps": 10,
|
|
"medianMs": 0.083,
|
|
"minMs": 0.045,
|
|
"maxMs": 0.176,
|
|
"variance": 1.579
|
|
},
|
|
{
|
|
"name": "P2-compose: 50 MCP tools",
|
|
"trials": 5,
|
|
"reps": 10,
|
|
"medianMs": 0.146,
|
|
"minMs": 0.133,
|
|
"maxMs": 0.249,
|
|
"variance": 0.797
|
|
},
|
|
{
|
|
"name": "P2-compose: 100 MCP tools",
|
|
"trials": 5,
|
|
"reps": 10,
|
|
"medianMs": 0.215,
|
|
"minMs": 0.136,
|
|
"maxMs": 0.229,
|
|
"variance": 0.434
|
|
},
|
|
{
|
|
"name": "P3-gallery-crud: add→list→import→export→remove",
|
|
"trials": 5,
|
|
"reps": 5,
|
|
"medianMs": 0.094,
|
|
"minMs": 0.06,
|
|
"maxMs": 0.212,
|
|
"variance": 1.618
|
|
},
|
|
{
|
|
"name": "P3-gallery-categories: getCategories",
|
|
"trials": 5,
|
|
"reps": 10,
|
|
"medianMs": 0.009,
|
|
"minMs": 0.009,
|
|
"maxMs": 0.018,
|
|
"variance": 0.987
|
|
},
|
|
{
|
|
"name": "P4-plugin-enum: compose WITHOUT includePlugins",
|
|
"trials": 5,
|
|
"reps": 10,
|
|
"medianMs": 0.018,
|
|
"minMs": 0.017,
|
|
"maxMs": 0.053,
|
|
"variance": 1.933
|
|
},
|
|
{
|
|
"name": "P4-plugin-enum: compose WITH includePlugins (absent plugins)",
|
|
"trials": 5,
|
|
"reps": 10,
|
|
"medianMs": 0.035,
|
|
"minMs": 0.035,
|
|
"maxMs": 0.042,
|
|
"variance": 0.198
|
|
}
|
|
]
|
|
} |