mirror of
https://github.com/ruvnet/ruflo.git
synced 2026-09-14 14:01:28 +08:00
495a451cf6
* feat(memory): typed provenance in AgentDB (ADR-323) Corrects and implements the 2026-07-28 dream-cycle research proposal (PR #2804, closed as superseded) for typed memory provenance in AgentDB, addressing MemIR/MemSyco-Bench's "provenance-role collapse" and memory-induced sycophancy findings. The dream-cycle PR's proposed schema change targeted the wrong table (`vector_indexes`, which is per-namespace HNSW index metadata, not per-entry) and its filename collided with the already-merged `ADR-322-metaharness-flywheel-integration.md` (#2817) — both corrected here as ADR-323 against `memory_entries`, the real per-record table. - memory-initializer.ts: `provenance_type` column (user_claim | agent_output | system_observation | tool_result | unknown, default unknown) on `memory_entries`, migrated for existing DBs via `ensureSchemaColumns()`. `storeEntry()`/`searchEntries()` accept and validate `provenanceType`/`provenanceFilter`. - memory-bridge.ts: same wiring for the native better-sqlite3 AgentDB v3 path (`bridgeStoreEntry`/`bridgeSearchEntries`). - commands/memory.ts: `memory store --provenance <type>`, `memory search --provenance-filter <types>` (comma-separated, OR semantics). - mcp-tools/memory-tools.ts + cli-core/mcp-tools/memory-defs.ts: `memory_store`'s `provenance_type` param, `memory_search`'s `provenance_filter` param (kept in sync across both tool-def sets). Found and fixed during implementation: an initial design skipped the RaBitQ/HNSW acceleration paths entirely whenever a provenance filter was requested (neither carries provenance_type on their candidates). This reproducibly crashed the CLI process on exit (a libuv assertion on Windows) after printing correct results. Fixed by never skipping those paths — RaBitQ now fetches provenance_type in its existing per-candidate query, HNSW does one batched (namespace, key) lookup afterward — eliminating the crash across repeated runs. See ADR-323's "Implementation note" for detail. 7 new end-to-end tests (adr-323-memory-provenance.test.ts), including a repeated-run regression guard for the crash. Full existing memory suite re-verified with no regressions (one pre-existing, environment- specific #2558 test failure confirmed identical against unmodified main — better-sqlite3's native bridge is unavailable in this dev environment, unrelated to this change). Closes the follow-up from dream-cycle PR #2804 (closed as superseded). Co-Authored-By: claude-flow <ruv@ruv.net> * fix(memory): enforce provenance across retrieval paths * feat: add agentic policy engine * fix: align Codex MCP integration * fix: keep MetaHarness dependencies optional * fix: declare MetaHarness as optional peers * fix: sync workspace lockfile * fix: document policy tool selection guidance * test: cover governed in-process flywheel * ci: make MetaHarness absence drill deterministic
64 lines
2.7 KiB
TypeScript
64 lines
2.7 KiB
TypeScript
import { afterEach, describe, expect, it } from 'vitest';
|
|
import { execFileSync } from 'node:child_process';
|
|
import { mkdtempSync, rmSync, writeFileSync } from 'node:fs';
|
|
import { join } from 'node:path';
|
|
import { tmpdir } from 'node:os';
|
|
import { CodexWorktreeCoordinator } from '../src/worktrees/index.js';
|
|
|
|
const roots: string[] = [];
|
|
|
|
function git(cwd: string, ...args: string[]): string {
|
|
return execFileSync('git', ['-C', cwd, ...args], { encoding: 'utf8' }).trim();
|
|
}
|
|
|
|
function repo(): string {
|
|
const parent = mkdtempSync(join(tmpdir(), 'ruflo-codex-worktrees-'));
|
|
roots.push(parent);
|
|
const root = join(parent, 'repo');
|
|
execFileSync('git', ['init', root]);
|
|
git(root, 'config', 'user.email', 'test@example.com');
|
|
git(root, 'config', 'user.name', 'Test');
|
|
writeFileSync(join(root, 'README.md'), 'seed\n');
|
|
git(root, 'add', 'README.md');
|
|
git(root, 'commit', '-m', 'seed');
|
|
return root;
|
|
}
|
|
|
|
afterEach(() => {
|
|
for (const root of roots.splice(0)) rmSync(root, { recursive: true, force: true });
|
|
});
|
|
|
|
describe('CodexWorktreeCoordinator', () => {
|
|
it('creates distinct owned worktrees and cleans only clean assignments', () => {
|
|
const root = repo();
|
|
const coordinator = new CodexWorktreeCoordinator(root);
|
|
const record = coordinator.prepare('run-1', [{ id: 'coder' }, { id: 'tester' }, { id: 'research', readOnly: true }]);
|
|
expect(new Set(record.assignments.map((item) => item.path)).size).toBe(3);
|
|
expect(coordinator.prepare('run-1', [{ id: 'ignored' }])).toEqual(record);
|
|
expect(coordinator.cleanup('run-1')).toEqual({
|
|
removed: ['coder', 'tester', 'research'],
|
|
retained: [],
|
|
});
|
|
});
|
|
|
|
it('refuses dirty coordinator state and unsafe identifiers', () => {
|
|
const root = repo();
|
|
writeFileSync(join(root, 'README.md'), 'dirty\n');
|
|
const coordinator = new CodexWorktreeCoordinator(root);
|
|
expect(() => coordinator.prepare('run-2', [{ id: 'coder' }])).toThrow(/dirty repository/);
|
|
expect(() => coordinator.prepare('../escape', [{ id: 'coder' }], { allowDirty: true })).toThrow(/invalid run id/);
|
|
});
|
|
|
|
it('retains dirty worker worktrees during cleanup', () => {
|
|
const root = repo();
|
|
const coordinator = new CodexWorktreeCoordinator(root);
|
|
const record = coordinator.prepare('run-3', [{ id: 'coder' }]);
|
|
writeFileSync(join(record.assignments[0]!.path, 'uncommitted.txt'), 'keep me\n');
|
|
expect(coordinator.cleanup('run-3')).toEqual({ removed: [], retained: ['coder'] });
|
|
expect(coordinator.status('run-3').assignments[0]!.agentId).toBe('coder');
|
|
git(record.assignments[0]!.path, 'add', 'uncommitted.txt');
|
|
git(record.assignments[0]!.path, 'commit', '-m', 'preserve');
|
|
expect(coordinator.cleanup('run-3')).toEqual({ removed: ['coder'], retained: [] });
|
|
});
|
|
});
|