CI's test ratchet flagged agentic-flow-agent.test.ts as an unexpected new
failure (run 32091740244, same commit fa13ee4a that passed the day before).
result.duration is Date.now()-delta over a ~1ms setTimeout; under coarse CI
clock resolution the two samples can land in the same millisecond, making
duration legitimately 0. Relax the two affected assertions from
toBeGreaterThan(0) to toBeGreaterThanOrEqual(0).
* fix(security): ADR-165 Phase 1 — close all critical CVEs, refresh registry, add CI gate
Closes ADR-165 Phase 1. Both workspaces pass `npm audit --audit-level=critical`.
## Before (2026-06-29)
| Workspace | Critical | High | Moderate | Total |
|-----------|----------|------|----------|-------|
| Root | **1** | 6 | 31 | 38 |
| v3 | **4** | 33 | 57 | 97 |
## After
| Workspace | Critical | High | Moderate | Total |
|-----------|----------|------|----------|-------|
| Root | **0** | 0 | 31 | 31 |
| v3 | **0** | 27 | 58 | 88 |
All 5 critical advisories closed (vitest GHSA-5xrq, handlebars prototype-pollution,
protobufjs constructor-pollution, plus 2 more in v3). 12 of 39 high advisories
closed via overrides; the remaining 27 v3 highs are deeper transitive chains
that would require breaking-change major bumps — flagged for ADR-165 Phase 2.
## Changes
### Root workspace overrides (package.json)
- `vitest`: `^1.0.0` → `^3.2.6` (closes critical GHSA-5xrq CVSS 9.8)
- `hono`: `>=4.11.4` → `>=4.12.25` (closes 6 hono advisories)
- `undici`: `>=7.18.0` → `>=8.5.0` (closes 7 undici advisories — bumps the
stale pin that ADR-165 flagged as still-in-vulnerable-range)
- `vite`: `>=6.4.6` → `>=8.0.16` (closes 2 vite advisories)
- NEW `@grpc/grpc-js`: `>=1.14.4`
- NEW `form-data`: `>=4.0.6`
- NEW `http-proxy-middleware`: `>=3.0.7`
- `@hono/node-server`: `>=1.19.10` → `>=1.19.14`
### v3 workspace overrides (v3/package.json + pnpm.overrides)
- `vitest`: `^4.0.16` → `^4.1.0` (and `@vitest/coverage-v8` matched)
- Top-level + pnpm overrides: `handlebars: >=4.7.9`, `protobufjs: >=8.6.0`
- 27 sub-package `package.json` updated to `vitest ^4.1.0`
### CVE registry refresh (v3/@claude-flow/security/src/CVE-REMEDIATION.ts)
Rewritten from 5 stale Jan-2026 entries to 16 total: 15 fixed, 1 open
(ADR165-OPEN-01 — PII pipeline wiring per ADR-164 §6.1 not yet on
dispatch-layer). `SECURITY_SUMMARY` is now computed dynamically from the
registry; `validateRemediation()` correctly returns `allFixed: false`
with 1 issue. ADR-165 §5 flagged this as THE Phase 2 priority — now closed.
### New CI gate
`.github/workflows/cve-audit.yml`:
- `audit-root` — `npm audit --audit-level=critical` in root, blocking
- `audit-v3` — same in v3, blocking
- `audit-high-report` — warn-only summary on high-severity drift
- Triggers: PR, push to main, daily cron
### ADR-165 §9 evidence ledger addendum
Captures AFTER-remediation `npm audit --json` metadata for both workspaces.
The diff between BEFORE (already in §9) and AFTER makes Phase 1 verifiable.
Also CORRECTED one prior surprise in §9: the `validate-input.ts` in
`mcp-tools/` is NOT a 9-line shim. It's 269 lines of real implementation.
(That was an inaccurate findings note from the initial audit.)
### §7.3 research items resolved
- `protobufjs` v3 chain confirmed gone after override pins
- `handlebars` v3 chain confirmed not user-reachable on the workflow path
(toolchain-only; override sufficient)
- `validate-input.ts` confirmed real implementation, not a shim (registry
entry corrected)
- CORS surface check: no `cors()` / `app.use(cors` call sites — the hono
CORS-wildcard advisory is not exploitable on the current server
- ADR-164 §6.1 PII pipeline NOT wired in current agentbbs dispatch —
recorded as ADR165-OPEN-01 (Phase 3 work)
## Gates (all PASS)
- `npm audit --audit-level=critical` root: exit 0 (was non-zero)
- `npm audit --audit-level=critical` v3: exit 0 (was non-zero)
- vitest suites: 105/109 pass (4 skip-conditional — same as before)
- ADR-112 audit: 352/352 tools with guidance
- business-pods smoke: 11/11 PASS
- agentbbs smoke: 8/8 PASS
- agenticow smoke: 8/8 PASS
- cli build: clean (tsc)
## Phase 2+ deferred
The 27 v3 high-severity advisories that remain are transitive chains with
no patched-in-range version. ADR-165 §6 Phase 2 picks these up after the
`cve-watch.yml` automation in §6 lands (NEW PR — not in scope here).
Co-Authored-By: RuFlo <ruv@ruv.net>
Claude-Session: https://claude.ai/code/session_01WbBa4nccx5aGhXphoHxcni
* chore(lock): regen v3/pnpm-lock.yaml after override updates (PR #2508 CI fix)
PR #2508 added handlebars + protobufjs to v3 overrides + bumped vitest pin,
but v3/pnpm-lock.yaml wasn't regenerated. CI surfaced
ERR_PNPM_LOCKFILE_CONFIG_MISMATCH on every install step.
Same pattern as the previous lockfile-drift fixes on PR #2500 and #2503.
* fix(ci): cve-audit.yml jq-only + regen witness manifests for #1609 marker drift
Two PR #2508 CI failures fixed:
1. Static-regression-guard tripped on cve-audit.yml line 52: the static
YAML strict-parser sees `if high > 0:` inside the `run: |` block as
a YAML block-mapping key indicator. Refactored all 3 inline-python
blocks to use jq (preinstalled on ubuntu-latest) — no embedded
`if x > 0:` lines, so the YAML guard passes.
2. Witness marker drift smoke flagged fix-marker #1609 — the Phase 1
vitest bump (4.0.16 → 4.1.0) drifted the cited marker string in
v3/@claude-flow/aidefence/package.json. Updated `marker` field in
all 3 platform manifests + `desc` to reference ADR-165 Phase 1, then
re-signed via plugins/ruflo-core/scripts/witness/regen.mjs.
Co-Authored-By: RuFlo <ruv@ruv.net>
The pnpm-without-postinstall layout in CI doesn't fetch prebuilt
binaries for sharp, onnxruntime-node, @ruvector/{sona,ruvllm,
ruvllm-wasm,rvagent-wasm}, etc. Tests that exercise these modules
fail with 'Cannot read properties of undefined' or ERR_DLOPEN_FAILED
in CI but pass locally where the binaries are available.
Per the 'get to 100% or remove tests that will never pass' policy,
each affected suite now resolves the dep via createRequire and
skips the whole describe block when it isn't present.
Files:
- ruvllm-wasm.test.ts (27 fails) — skipIf @ruvector/ruvllm-wasm absent
- agent-wasm.test.ts (22 fails) — skipIf @ruvector/rvagent-wasm absent
- memory-ruvector-deep.test.ts (14 fails) — skipIf @ruvector/sona absent
(only the SONA Optimizer block)
- ruvllm-integration.test.ts (3 fails) — skipIf @ruvector/ruvllm absent
- sdk-client + seed-client-raw (24 fails) — skipIf SEED_PAIRING_TOKEN +
SEED_ENDPOINT not set
- token-optimizer.test.ts (1 fail) — match assertion to actual
agentic-flow loadability
Also, vitest.config.ts gains a poolMatchGlobs entry routing
router-bandit.test.ts to the 'forks' pool (worker threads forbid
process.chdir, which the test legitimately needs for tmpdir
isolation; 6 tests fixed).
Total: ~91 of 152 failing tests addressed; remainder (timeouts in
guidance-provider/reasoningbank, tool-honesty assertion drift,
p1-commands, *integration tests, integration-docker) need separate
investigation for real-vs-environment classification.
Co-Authored-By: RuFlo <ruv@ruv.net>
Remove Math.random() metrics from 6 locations:
- agent_health: CPU/memory/latency were random — now null with notes
- system_health: all checks were hardcoded "healthy" — now real fs checks
- coordination_metrics: latency/throughput were random — now null with real sync data
- github-tools: all 5 tools fabricated — now return _stub:true, local CRUD only
- process monitor: all metrics random — now real os.loadavg/memoryUsage
- hook-handler route: random latency, hardcoded matches — removed
Fix 6 bugs:
- task-tools path mismatch: agents.json → agents/store.json
- token-optimizer double-increment of editsOptimized
- config get: now reads real configManager instead of hardcoded map
- config providers: now reads/writes real config, mutation flags work
- session restore: now syncs to sql.js database after legacy JSON write
- claims rebalance: now executes moves when dryRun=false
Mark stubs honestly (_stub:true):
- neural compress/optimize
- performance bottleneck/profile/optimize
- hooks metrics/pretrain/intelligence-reset (reset now actually deletes files)
- workflow execute/resume (steps stay pending, not auto-completed)
- hooks session-end summary: reads real counts from stores
- hooks explain: reads real success rate from routing-outcomes.json
- hooks transfer: returns failure instead of demo data when source empty
- status.ts: performance claims → 'not measured'
Co-Authored-By: claude-flow <ruv@ruv.net>
- #1514: Remove fabricated token savings (hardcoded +=100 per cache hit,
baseline=1000). getOptimalConfig() now scales with agentCount.
neural_train stores real embedding patterns via generateEmbedding().
neural_predict uses cosine similarity against stored patterns (no
hardcoded labels). Returns empty array when no patterns exist.
verifySignature() confirmed already real (HMAC + timingSafeEqual).
- #1516: All embedding model defaults prefixed with Xenova/ so
@xenova/transformers resolves correctly. ControllerRegistry now
passes embeddingModel to AgentDB constructor.
- #1521: @claude-flow/memory bumped to 3.0.0-alpha.13, better-sqlite3
moved from optionalDependencies to dependencies.
- #1526: hook-handler normalizes snake_case tool_input/tool_name from
Claude Code. intelligence.cjs scoped to current project only
(was scanning all 51+ project dirs).
- ADR-073: Documents stub tool honesty policy and real predictions.
Closes#1514, #1516, #1521, #1526
Co-authored-by: Reuven <cohen@ruv-mac-mini.local>
Automatic checkpoint created by Claude Code
- Branch: v3
- Timestamp: 2026-01-12T20:00:12Z
- Changes: 4 file(s)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Automatic checkpoint created by Claude Code
- Branch: v3
- Timestamp: 2026-01-12T19:32:49Z
- Changes: 1 file(s)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Automatic checkpoint created by Claude Code
- Branch: v3
- Timestamp: 2026-01-12T19:19:44Z
- Changes: 3 file(s)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Automatic checkpoint created by Claude Code
- Branch: v3
- Timestamp: 2026-01-12T19:16:57Z
- Changes: 1 file(s)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Automatic checkpoint created by Claude Code
- Branch: v3
- Timestamp: 2026-01-12T19:16:34Z
- Changes: 1 file(s)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Automatic checkpoint created by Claude Code
- Branch: v3
- Timestamp: 2026-01-12T19:16:21Z
- Changes: 1 file(s)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Automatic checkpoint created by Claude Code
- Branch: v3
- Timestamp: 2026-01-12T19:08:26Z
- Changes: 1 file(s)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Automatic checkpoint created by Claude Code
- Branch: v3
- Timestamp: 2026-01-12T19:06:04Z
- Changes: 1 file(s)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Automatic checkpoint created by Claude Code
- Branch: v3
- Timestamp: 2026-01-07T19:04:42Z
- Changes: 19 file(s)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Updated standard-checkpoint-hooks.sh to accept both JSON and plain paths
- Fixed pre-edit and post-edit functions to detect input format
- Fixed v3 CLI hook flags (-f -> --file, -c -> --command, etc.)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
rUv