mirror of
https://github.com/rtk-ai/rtk.git
synced 2026-09-19 07:33:17 +08:00
kylehgc
9e7e01d7dd
Review response for upstream #3199 (KuSh round 2), plus preclear findings.
- Root-lane claims disarm on any fall-through line again (pre-d602a3b
behavior restored; tagged lanes keep the keyed-only rule). Fixes the
plain-mvn frame leak on the repo's own fixtures -- filter_compile output
is byte-identical to base ba7a9ce on mvn_test_fail_slice_raw.txt and
mvn_test_multifail_slice_raw.txt, pinned by fixture-backed tests. Full
base A/B: 56/56 outputs identical across all four entry points.
- Failures-summary tails are attributed per lane: dropped moves onto
SurefireLane, each lane's '+N more failures' tail flushes at that lane's
own aggregate (or at end-of-stream for truncated input), while the
reactor-wide entry budget stays shared. A module's tail can no longer be
collected under another module's header.
- is_lane_opener's [ERROR] arm narrowed to genuine compiler diagnostics
(FILE_COORD), so [tag] [ERROR] app logs no longer escape a buffered
block or get re-ordered ahead of it; they route by ownership rules.
- The [ERROR] arm sites only rewrite keep_continuation on the lane's own
keyed lines, matching every sibling arm/disarm site; interloper sweeps
now cover both [WARNING] and [ERROR] spellings on all three filters.
- insta removed (first dev-dependency, and .claude/rules/cli-testing.md
prescribes plain assert_eq! with include_str! fixtures): the four
snapshots are now expected-output fixtures under tests/fixtures/,
Cargo.lock drops insta/console/encode_unicode/similar.
- split_lane's no-trailing-space tagged blank pinned by tests.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
31 lines
2.1 KiB
Plaintext
31 lines
2.1 KiB
Plaintext
[INFO] Scanning for projects...
|
|
[multi-module-fail-skeleton] [INFO] -------------< com.example.rtk:multi-module-fail-skeleton >-------------
|
|
[multi-module-fail-skeleton] [INFO] Building multi-module-fail-skeleton 1.0.0-SNAPSHOT [1/3]
|
|
[child-b] [INFO] ----------------------< com.example.rtk:child-b >-----------------------
|
|
[child-b] [INFO] Building child-b 1.0.0-SNAPSHOT [2/3]
|
|
[child-a] [INFO] ----------------------< com.example.rtk:child-a >-----------------------
|
|
[child-a] [INFO] Building child-a 1.0.0-SNAPSHOT [3/3]
|
|
[child-a] [INFO] Running com.example.rtk.ParallelFailTest
|
|
[child-a] [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.153 s <<< FAILURE! -- in com.example.rtk.ParallelFailTest
|
|
[child-a] [ERROR] com.example.rtk.ParallelFailTest.reactorDiagnostic -- Time elapsed: 0.098 s <<< FAILURE!
|
|
org.opentest4j.AssertionFailedError: parallel reactor diagnostic ==> expected: <1> but was: <2>
|
|
at com.example.rtk.ParallelFailTest.reactorDiagnostic(ParallelFailTest.java:10)
|
|
[child-a] [INFO] Results:
|
|
[child-b] [INFO] Results:
|
|
[child-a] [ERROR] Failures:
|
|
[child-b] [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0
|
|
[child-a] [ERROR] ParallelFailTest.reactorDiagnostic:10 parallel reactor diagnostic ==> expected: <1> but was: <2>
|
|
[child-a] [ERROR] Tests run: 3, Failures: 1, Errors: 0, Skipped: 0
|
|
[INFO] Reactor Summary for multi-module-fail-skeleton 1.0.0-SNAPSHOT:
|
|
[INFO]
|
|
[INFO] multi-module-fail-skeleton ......................... SUCCESS [ 0.030 s]
|
|
[INFO] child-a ............................................ FAILURE [ 3.230 s]
|
|
[INFO] child-b ............................................ SUCCESS [ 3.230 s]
|
|
[INFO] ------------------------------------------------------------------------
|
|
[INFO] BUILD FAILURE
|
|
[INFO] Total time: 3.363 s (Wall Clock)
|
|
[INFO] Finished at: 2026-08-13T09:18:03-04:00
|
|
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.5.5:test (default-test) on project child-a: There are test failures.
|
|
[ERROR] After correcting the problems, you can resume the build with the command
|
|
[ERROR] mvn <args> -r
|